67674 2011-09-06 14:55:36 -0700 Some cookie related tests fail on Lion 2011-09-08 10:17:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap beidson jberlin jochen webkit.review.bot oldest_to_newest 462879 0 ap 2011-09-06 14:55:36 -0700 http/tests/security/cookies/third-party-cookie-blocking-user-action.html and http/tests/security/cookies/third-party-cookie-blocking.html fail on Lion, because of a CFNetwork bug. The issue is that even when NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain policy is used for cookies, CFNetwork allows sites that already have cookies for this domain to set more. The theory is that when a site already has a cookie for you, it can already track you, so letting it set more is OK. This policy tweak was needed for compatibility with some important site. Unfortunately, even expired cookies are taken into account in that check, so set-a-cookie.php code that makes test cookie expired is insufficient: document.cookie = "test_cookie=0; path=/; expires=Thu, 01-Jan-1970 00:00:01 GMT"; This is tracked as a CFNetwork bug <rdar://problem/10080130>, but we should add a workaround, or skip tests. I think that I have a workaround. 462886 1 106495 ap 2011-09-06 15:02:50 -0700 Created attachment 106495 proposed fix 462889 2 jochen 2011-09-06 15:06:24 -0700 the work around looks good to me 463408 3 106495 jberlin 2011-09-07 10:06:33 -0700 Comment on attachment 106495 proposed fix unofficial r=me! 464108 4 106495 webkit.review.bot 2011-09-08 09:55:28 -0700 Comment on attachment 106495 proposed fix Rejecting attachment 106495 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: name: third_party/ots url: From('chromium_deps', 'src/third_party/ots') should_process: True requirements: set(['third_party', 'chromium_deps', './']) name: third_party/snappy/src url: From('chromium_deps', 'src/third_party/snappy/src') should_process: True requirements: set(['third_party', 'chromium_deps', './']) Died at Tools/Scripts/update-webkit-chromium line 80. No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 1929. Full output: http://queues.webkit.org/results/9622245 464125 5 ap 2011-09-08 10:17:45 -0700 Manually committed <http://trac.webkit.org/changeset/94765>. 106495 2011-09-06 15:02:50 -0700 2011-09-08 09:55:28 -0700 proposed fix ExpiredCookie.txt text/plain 3660 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk0NjAwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMDYgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBjb29raWUgcmVsYXRlZCB0ZXN0cyBm YWlsIG9uIExpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY3Njc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVXNlIHByaXZhdGUgYnJvd3NpbmcgbW9kZSB0byB3b3JrIGFyb3VuZCBhIENGTmV0d29yayBp c3N1ZSB3aGVyZSB0aGVzZSB0ZXN0cyBjYW4gYWZmZWN0IGVhY2gKKyAgICAgICAgb3RoZXIncyBy ZXN1bHRzLiBUaGlzIHNob3VsZCBub3QgYWZmZWN0IHRoZWlyIGJlaGF2aW9yIGluIGFueSBvdGhl ciB3YXkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nvb2tpZXMvdGhpcmQtcGFy dHktY29va2llLWJsb2NraW5nLW1haW4tZnJhbWUuaHRtbDoKKyAgICAgICAgKiBodHRwL3Rlc3Rz L3NlY3VyaXR5L2Nvb2tpZXMvdGhpcmQtcGFydHktY29va2llLWJsb2NraW5nLXVzZXItYWN0aW9u Lmh0bWw6CisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9jb29raWVzL3RoaXJkLXBhcnR5 LWNvb2tpZS1ibG9ja2luZy5odG1sOgorCiAyMDExLTA5LTA2ICBEYXZpZCBIeWF0dCAgPGh5YXR0 QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njc2NzIKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29va2ll cy90aGlyZC1wYXJ0eS1jb29raWUtYmxvY2tpbmctbWFpbi1mcmFtZS5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29va2llcy90aGlyZC1wYXJ0eS1j b29raWUtYmxvY2tpbmctbWFpbi1mcmFtZS5odG1sCShyZXZpc2lvbiA5NDU3NikKKysrIExheW91 dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29va2llcy90aGlyZC1wYXJ0eS1jb29raWUtYmxv Y2tpbmctbWFpbi1mcmFtZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC02LDYgKzYsMTIgQEAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgIGxheW91dFRlc3RDb250cm9sbGVy LndhaXRVbnRpbERvbmUoKTsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcENoaWxkRnJhbWVzQXNUZXh0KCk7CisKKyAg ICAvLyBTdGFydCB3aXRoIGEgY2xlYW4gc3RhdGUsIGFzIG90aGVyd2lzZSBhbiBleHBpcmVkIGNv b2tpZSBmb3IgdGhpcyBkb21haW4gY291bGQgYWZmZWN0IGJlaGF2aW9yIHdpdGggQ0ZOZXR3b3Jr LgorICAgIC8vIENhbiBiZSByZW1vdmVkIG9uY2UgPHJkYXI6Ly9wcm9ibGVtLzEwMDgwMTMwPiBp cyBmaXhlZC4KKyAgICBpZiAobGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0UHJpdmF0ZUJyb3dzaW5n RW5hYmxlZCkKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0UHJpdmF0ZUJyb3dzaW5n RW5hYmxlZCh0cnVlKTsKKwogICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldEFsd2F5c0FjY2Vw dENvb2tpZXMoZmFsc2UpOwogfQogCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3Vy aXR5L2Nvb2tpZXMvdGhpcmQtcGFydHktY29va2llLWJsb2NraW5nLXVzZXItYWN0aW9uLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb29raWVzL3Ro aXJkLXBhcnR5LWNvb2tpZS1ibG9ja2luZy11c2VyLWFjdGlvbi5odG1sCShyZXZpc2lvbiA5NDU3 NikKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29va2llcy90aGlyZC1wYXJ0 eS1jb29raWUtYmxvY2tpbmctdXNlci1hY3Rpb24uaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNiw2 ICs2LDEyIEBAIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu ZHVtcEFzVGV4dCgpOwogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBDaGlsZEZyYW1lc0Fz VGV4dCgpOworCisgICAgLy8gU3RhcnQgd2l0aCBhIGNsZWFuIHN0YXRlLCBhcyBvdGhlcndpc2Ug YW4gZXhwaXJlZCBjb29raWUgZm9yIHRoaXMgZG9tYWluIGNvdWxkIGFmZmVjdCBiZWhhdmlvciB3 aXRoIENGTmV0d29yay4KKyAgICAvLyBDYW4gYmUgcmVtb3ZlZCBvbmNlIDxyZGFyOi8vcHJvYmxl bS8xMDA4MDEzMD4gaXMgZml4ZWQuCisgICAgaWYgKGxheW91dFRlc3RDb250cm9sbGVyLnNldFBy aXZhdGVCcm93c2luZ0VuYWJsZWQpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldFBy aXZhdGVCcm93c2luZ0VuYWJsZWQodHJ1ZSk7CisKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5z ZXRBbHdheXNBY2NlcHRDb29raWVzKGZhbHNlKTsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9zZWN1cml0eS9jb29raWVzL3RoaXJkLXBhcnR5LWNvb2tpZS1ibG9ja2luZy5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29va2llcy90 aGlyZC1wYXJ0eS1jb29raWUtYmxvY2tpbmcuaHRtbAkocmV2aXNpb24gOTQ1NzYpCisrKyBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nvb2tpZXMvdGhpcmQtcGFydHktY29va2llLWJs b2NraW5nLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTYsNiArNiwxMiBAQCBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKSB7CiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGls RG9uZSgpOwogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQ2hpbGRGcmFtZXNBc1RleHQoKTsKKworICAgIC8vIFN0YXJ0 IHdpdGggYSBjbGVhbiBzdGF0ZSwgYXMgb3RoZXJ3aXNlIGFuIGV4cGlyZWQgY29va2llIGZvciB0 aGlzIGRvbWFpbiBjb3VsZCBhZmZlY3QgYmVoYXZpb3Igd2l0aCBDRk5ldHdvcmsuCisgICAgLy8g Q2FuIGJlIHJlbW92ZWQgb25jZSA8cmRhcjovL3Byb2JsZW0vMTAwODAxMzA+IGlzIGZpeGVkLgor ICAgIGlmIChsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKQor ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKHRy dWUpOworCiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0QWx3YXlzQWNjZXB0Q29va2llcyhm YWxzZSk7CiB9CiAK