<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67667</bug_id>
          
          <creation_ts>2011-09-06 13:15:14 -0700</creation_ts>
          <short_desc>LayoutTests does not include a test for DFG speculation recovery of additions</short_desc>
          <delta_ts>2011-09-06 13:37:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>462790</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-06 13:15:14 -0700</bug_when>
    <thetext>In https://bugs.webkit.org/show_bug.cgi?id=67551 we fixed a bug in speculation recovery of additions in JavaScriptCore.  There is currently no test that covers this regression and fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462792</commentid>
    <comment_count>1</comment_count>
      <attachid>106474</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-06 13:16:56 -0700</bug_when>
    <thetext>Created attachment 106474
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462793</commentid>
    <comment_count>2</comment_count>
      <attachid>106474</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-09-06 13:17:22 -0700</bug_when>
    <thetext>Comment on attachment 106474
the patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462813</commentid>
    <comment_count>3</comment_count>
      <attachid>106474</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-06 13:36:58 -0700</bug_when>
    <thetext>Comment on attachment 106474
the patch

Clearing flags on attachment: 106474

Committed r94594: &lt;http://trac.webkit.org/changeset/94594&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462814</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-06 13:37:02 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>106474</attachid>
            <date>2011-09-06 13:16:56 -0700</date>
            <delta_ts>2011-09-06 13:36:57 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>recoveraddtest_patch_1.diff</filename>
            <type>text/plain</type>
            <size>3244</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDk0NTkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMDYgIEZpbGlwIFBpemxvICA8ZnBp
emxvQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXRUZXN0cyBkb2VzIG5vdCBpbmNsdWRlIGEg
dGVzdCBmb3IgREZHIHNwZWN1bGF0aW9uIHJlY292ZXJ5IG9mIGFkZGl0aW9ucworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc2NjcKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvanMvYWRkLXJlY292
ZXJ5LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9hZGQtcmVjb3Zlcnku
aHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvYWRkLXJlY292ZXJ5
LmpzOiBBZGRlZC4KKyAgICAgICAgKGRlc3RydWN0aXZlQWRkRm9yQm94ZWRJbnRlZ2VyKToKKwog
MjAxMS0wOS0wNiAgTWlrZSBSZWVkICA8cmVlZEBnb29nbGUuY29tPgogCiAgICAgICAgIFtza2lh
XSBuZXZlciBkcmF3IHdpdGggR0RJLCBzbyB0aGF0IGFsbCB0ZXh0IGNhbiBiZSBncHUtYWNjZWxl
cmF0ZWQKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvYWRkLXJlY292ZXJ5LWV4cGVjdGVkLnR4
dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL2FkZC1yZWNvdmVyeS1leHBlY3Rl
ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2FkZC1yZWNvdmVyeS1l
eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTQgQEAKK1RoaXMgdGVzdHMgdGhh
dCBzcGVjdWxhdGlvbiByZWNvdmVyeSBvZiBkZXN0cnVjdGl2ZSBhZGRpdGlvbnMgb24gdW5ib3hl
ZCBpbnRlZ2VycyB3b3Jrcy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m
ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mg
ZGVzdHJ1Y3RpdmVBZGRGb3JCb3hlZEludGVnZXIoe3g6MX0sIDIsIDQpIGlzIDkKK1BBU1MgZGVz
dHJ1Y3RpdmVBZGRGb3JCb3hlZEludGVnZXIoe3g6MjE0NzQ4MzY0N30sIDIsIDQpIGlzIDIxNDc0
ODM2NTUKK1BBU1MgZGVzdHJ1Y3RpdmVBZGRGb3JCb3hlZEludGVnZXIoe3g6Mn0sIDIxNDc0ODM2
NDcsIDQpIGlzIDQyOTQ5NjczMDAKK1BBU1MgZGVzdHJ1Y3RpdmVBZGRGb3JCb3hlZEludGVnZXIo
e3g6MjE0NzQ4MzY0N30sIDIxNDc0ODM2NDcsIDQpIGlzIDY0NDI0NTA5NDUKK1BBU1MgZGVzdHJ1
Y3RpdmVBZGRGb3JCb3hlZEludGVnZXIoe3g6MX0sIDIsIDIxNDc0ODM2NDcpIGlzIDIxNDc0ODM2
NTIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCklu
ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL2FkZC1yZWNvdmVyeS5odG1sCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IExheW91dFRlc3RzL2Zhc3QvanMvYWRkLXJlY292ZXJ5Lmh0bWwJKHJldmlzaW9uIDApCisrKyBM
YXlvdXRUZXN0cy9mYXN0L2pzL2FkZC1yZWNvdmVyeS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww
ICsxLDEzIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+
Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSJyZXNvdXJjZXMv
anMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9qcy10ZXN0LXByZS5q
cyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgor
PGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL2FkZC1y
ZWNvdmVyeS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcG9z
dC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0
L2pzL3NjcmlwdC10ZXN0cy9hZGQtcmVjb3ZlcnkuanMKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz
dHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvYWRkLXJlY292ZXJ5LmpzCShyZXZpc2lvbiAwKQorKysg
TGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvYWRkLXJlY292ZXJ5LmpzCShyZXZpc2lv
biAwKQpAQCAtMCwwICsxLDIyIEBACitkZXNjcmlwdGlvbigKKyJUaGlzIHRlc3RzIHRoYXQgc3Bl
Y3VsYXRpb24gcmVjb3Zlcnkgb2YgZGVzdHJ1Y3RpdmUgYWRkaXRpb25zIG9uIHVuYm94ZWQgaW50
ZWdlcnMgd29ya3MuIgorKTsKKworZnVuY3Rpb24gZGVzdHJ1Y3RpdmVBZGRGb3JCb3hlZEludGVn
ZXIoYSxiLGMpIHsKKyAgICB2YXIgYV8gPSBhLng7CisgICAgdmFyIGQgPSBhXyArIGI7CisgICAg
cmV0dXJuIGMgKyBkICsgYjsKK30KKworLy8gd2FybS11cCBmb28gdG8gYmUgaW50ZWdlcgorZm9y
ICh2YXIgaSA9IDA7IGkgPCAxMDA7ICsraSkgeworICAgIGRlc3RydWN0aXZlQWRkRm9yQm94ZWRJ
bnRlZ2VyKHt4OjF9LCAyLCAzKTsKK30KKworc2hvdWxkQmUoImRlc3RydWN0aXZlQWRkRm9yQm94
ZWRJbnRlZ2VyKHt4OjF9LCAyLCA0KSIsICI5Iik7CitzaG91bGRCZSgiZGVzdHJ1Y3RpdmVBZGRG
b3JCb3hlZEludGVnZXIoe3g6MjE0NzQ4MzY0N30sIDIsIDQpIiwgIjIxNDc0ODM2NTUiKTsKK3No
b3VsZEJlKCJkZXN0cnVjdGl2ZUFkZEZvckJveGVkSW50ZWdlcih7eDoyfSwgMjE0NzQ4MzY0Nywg
NCkiLCAiNDI5NDk2NzMwMCIpOworc2hvdWxkQmUoImRlc3RydWN0aXZlQWRkRm9yQm94ZWRJbnRl
Z2VyKHt4OjIxNDc0ODM2NDd9LCAyMTQ3NDgzNjQ3LCA0KSIsICI2NDQyNDUwOTQ1Iik7CitzaG91
bGRCZSgiZGVzdHJ1Y3RpdmVBZGRGb3JCb3hlZEludGVnZXIoe3g6MX0sIDIsIDIxNDc0ODM2NDcp
IiwgIjIxNDc0ODM2NTIiKTsKKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>