67646 2011-09-06 07:58:06 -0700 REGRESSION(r94288) build-webkit doesn't work on Windows 2011-09-07 05:29:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 67703 38054 1 ossy webkit-unassigned kkristof ossy webkit.review.bot oldest_to_newest 462515 0 ossy 2011-09-06 07:58:06 -0700 After r94288 we get the following error: Undefined subroutine &File::Path::remove_tree called at D:/t/qt-symbian-release/build/Tools/Scripts/webkitdirs.pm line 1698. On Windows we need this: "use File::Path qw(remove_tree);" Kristof, could you prepare a patch to fix it? 463228 1 106554 kkristof 2011-09-07 01:22:11 -0700 Created attachment 106554 proposed fix 463240 2 106554 webkit.review.bot 2011-09-07 01:59:57 -0700 Comment on attachment 106554 proposed fix Rejecting attachment 106554 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/9607256 463248 3 106554 ossy 2011-09-07 02:27:34 -0700 Comment on attachment 106554 proposed fix Clearing flags on attachment: 106554 Committed r94655: <http://trac.webkit.org/changeset/94655> 463249 4 ossy 2011-09-07 02:27:42 -0700 All reviewed patches have been landed. Closing bug. 463267 5 ossy 2011-09-07 03:23:27 -0700 We have to roll it out, because it broke Leopard debug bot, and Qt ARM tester: "remove_tree" is not exported by the File::Path module Can't continue after import errors at /home/buildbot/cute1/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/Tools/Scripts/webkitdirs.pm line 36 BEGIN failed--compilation aborted at /home/buildbot/cute1/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/Tools/Scripts/webkitdirs.pm line 36. 463274 6 ossy 2011-09-07 03:29:52 -0700 It was rolled out by http://trac.webkit.org/changeset/94660 463289 7 ossy 2011-09-07 04:47:05 -0700 We got similar problem on the Symbian bot: "remove_tree" is not exported by the File::Path module 463307 8 ossy 2011-09-07 05:19:14 -0700 Zoltan said that we should use rmtree instead of remove_tree. http://perldoc.perl.org/File/Path.html 463309 9 ossy 2011-09-07 05:29:19 -0700 Fix landed in http://trac.webkit.org/changeset/94663. I hope it will work. :) 106554 2011-09-07 01:22:11 -0700 2011-09-07 02:27:34 -0700 proposed fix 7.patch text/plain 873 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZmUx MmVmLi4zZGZlNDBkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMDcgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJFR1JFU1NJT04ocjk0Mjg4KSBi dWlsZC13ZWJraXQgZG9lc24ndCB3b3JrIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NjQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisKIDIw MTEtMDktMDYgIEVyaWMgQm9yZW4gIDxib3JlbmV0QGdtYWlsLmNvbT4KIAogICAgICAgICBbQ2hy b21pdW1dIE1vZGlmeSBXZWJUb3VjaEV2ZW50IHN0cnVjdHVyZSB0byBtYXRjaCBXZWJDb3JlOjpU b3VjaEV2ZW50CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggYjFhMjRjYi4uYmUxZjk5ZSAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQpAQCAtMzMsNyArMzMsNyBAQCB1c2Ugd2FybmluZ3M7CiB1c2UgQ29uZmlnOwogdXNl IEZpbmRCaW47CiB1c2UgRmlsZTo6QmFzZW5hbWU7Ci11c2UgRmlsZTo6UGF0aDsKK3VzZSBGaWxl OjpQYXRoIHF3KG1rcGF0aCByZW1vdmVfdHJlZSk7CiB1c2UgRmlsZTo6U3BlYzsKIHVzZSBQT1NJ WDsKIHVzZSBWQ1NVdGlsczsK