67621 2011-09-05 18:00:33 -0700 [chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path 2011-09-06 12:02:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr nduca enne fishd jamesr nduca vangelis webkit.review.bot oldest_to_newest 462293 0 jamesr 2011-09-05 18:00:33 -0700 See http://webstuff.nfshost.com/anim-timing/raftime.html. When compositing is enabled, requestAnimationFrame is uncapped. Regression range is 94351 - 94379. Will bisect. 462331 1 jamesr 2011-09-05 20:34:16 -0700 Locally confirmed that it's http://trac.webkit.org/changeset/94353. I'm not really sure how... 462361 2 nduca 2011-09-05 22:18:51 -0700 Oy! Well I guess we know what I'm doing on Tuesday then. :) 462696 3 106452 nduca 2011-09-06 11:34:24 -0700 Created attachment 106452 Patch 462701 4 106452 jamesr 2011-09-06 11:42:48 -0700 Comment on attachment 106452 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106452&action=review > Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:91 > + commitIfNeeded(false); actually we don't want to do layout here either. it's the responsibility of the caller to WebWidget::paint() to call animateAndLayout() before calling this function > Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:237 > + if (!alreadyCalledLayout) > + m_layerTreeHost->animateAndLayout(frameBeginTime); i think you can just delete this completely 462710 5 nduca 2011-09-06 11:55:08 -0700 > i think you can just delete this completely I did this because we're going to have to eventually invert that. But, I'll do as you wish. 462712 6 jamesr 2011-09-06 11:56:54 -0700 Eventually we'll need it, but not for compositeAndReadback(). That path will not. 462713 7 106456 nduca 2011-09-06 11:57:05 -0700 Created attachment 106456 Okay 462719 8 nduca 2011-09-06 12:02:41 -0700 Committed r94587: <http://trac.webkit.org/changeset/94587> 106452 2011-09-06 11:34:24 -0700 2011-09-06 11:57:01 -0700 Patch bug-67621-20110906113423.patch text/plain 3121 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ1NjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxYzkxMWNiNWFiMTMwOTA3 YTJjMmVhM2U2OWE0ODhiYzA1N2Q4NmIzLi43YjA4NjNlZDFkZjA0ODZiYTFjNjAzYjI3NTNiM2Qw MmE5NmVhN2M4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMDYgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUkVHUkVTU0lP Tig5NDM1Myk6IHJlcXVlc3RBbmltYXRpb25GcmFtZSBub3QgdGhyb3R0bGVkIGluIGNvbXBvc2l0 aW5nIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY3NjIxCisKKyAgICAgICAgQ0NTaW5nbGVUaHJlYWRQcm94eSBzaG91bGQgbm90IHBlcmZvcm0g bGF5b3V0IHdoZW4gY2FsbGVkCisgICAgICAgIHZpYSB0aGUgY29tcG9zaXRlSW1tZWRpYXRlbHkg cGF0aC4gRG9pbmcgc28gbWFrZXMgaXQgbG9vaworICAgICAgICBsaWtlIGZyYW1lIHJhdGUgaXMg dW5ib3VuZGVkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1NpbmdsZVRocmVhZFByb3h5Ojpjb21wb3NpdGVBbmRS ZWFkYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpDQ1NpbmdsZVRocmVhZFByb3h5Ojpjb21wb3Np dGVJbW1lZGlhdGVseSk6CisgICAgICAgIChXZWJDb3JlOjpDQ1NpbmdsZVRocmVhZFByb3h5Ojpj b21taXRJZk5lZWRlZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NTaW5nbGVUaHJlYWRQcm94eS5oOgorCiAyMDExLTA5LTA1ICBQYXZlbCBQb2Rpdmlsb3YgIDxw b2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlLWltcGxl bWVudCBSYXdTb3VyY2VDb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1NpbmdsZVRocmVhZFByb3h5LmNw cAppbmRleCA2MGJlNzU2MTE5YmRjYTFkZDhjYjAxZTRkODczNzI3YWJjZTM0OTdhLi4xYTY3NzI3 YjNmMTRhZjUzNWFhZDViMjNkNDc3OTA0M2IwZjAzYWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1NpbmdsZVRocmVhZFByb3h5LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Np bmdsZVRocmVhZFByb3h5LmNwcApAQCAtODgsNyArODgsNyBAQCBib29sIENDU2luZ2xlVGhyZWFk UHJveHk6OmNvbXBvc2l0ZUFuZFJlYWRiYWNrKHZvaWQgKnBpeGVscywgY29uc3QgSW50UmVjdCYg cmVjdAogICAgIGlmICghcmVjcmVhdGVDb250ZXh0SWZOZWVkZWQoKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCi0gICAgY29tbWl0SWZOZWVkZWQoKTsKKyAgICBjb21taXRJZk5lZWRlZChmYWxz ZSk7CiAKIAogICAgIGlmICghZG9Db21wb3NpdGUoKSkKQEAgLTE4OCw3ICsxODgsNyBAQCB2b2lk IENDU2luZ2xlVGhyZWFkUHJveHk6OmNvbXBvc2l0ZUltbWVkaWF0ZWx5KCkKICAgICBpZiAoIXJl Y3JlYXRlQ29udGV4dElmTmVlZGVkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGNvbW1pdElm TmVlZGVkKCk7CisgICAgY29tbWl0SWZOZWVkZWQodHJ1ZSk7CiAKICAgICBpZiAoZG9Db21wb3Np dGUoKSkKICAgICAgICAgbV9sYXllclRyZWVIb3N0SW1wbC0+cHJlc2VudCgpOwpAQCAtMjI5LDEx ICsyMjksMTIgQEAgYm9vbCBDQ1NpbmdsZVRocmVhZFByb3h5OjpyZWNyZWF0ZUNvbnRleHRJZk5l ZWRlZCgpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lkIENDU2luZ2xlVGhyZWFkUHJveHk6 OmNvbW1pdElmTmVlZGVkKCkKK3ZvaWQgQ0NTaW5nbGVUaHJlYWRQcm94eTo6Y29tbWl0SWZOZWVk ZWQoYm9vbCBhbHJlYWR5Q2FsbGVkTGF5b3V0KQogewogICAgIC8vIFVwZGF0ZQogICAgIGRvdWJs ZSBmcmFtZUJlZ2luVGltZSA9IGN1cnJlbnRUaW1lKCk7Ci0gICAgbV9sYXllclRyZWVIb3N0LT5h bmltYXRlQW5kTGF5b3V0KGZyYW1lQmVnaW5UaW1lKTsKKyAgICBpZiAoIWFscmVhZHlDYWxsZWRM YXlvdXQpCisgICAgICAgIG1fbGF5ZXJUcmVlSG9zdC0+YW5pbWF0ZUFuZExheW91dChmcmFtZUJl Z2luVGltZSk7CiAgICAgbV9sYXllclRyZWVIb3N0LT51cGRhdGVMYXllcnMoKTsKIAogICAgIC8v IENvbW1pdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5oCmluZGV4IDc2NWI4NTlm OTUxNTAyNmU5ZDc4NzUyMWQ0OTlkNTFhOTgwZjhmOTcuLmM1MjgwYzA2MThlNThiNmM3MWEwODIz MzU1M2JhOWQwYTY5NWRiNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDU2luZ2xlVGhyZWFkUHJveHkuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1NpbmdsZVRocmVhZFByb3h5LmgK QEAgLTYzLDcgKzYzLDcgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBleHBsaWNpdCBDQ1Npbmds ZVRocmVhZFByb3h5KENDTGF5ZXJUcmVlSG9zdCopOwogICAgIGJvb2wgcmVjcmVhdGVDb250ZXh0 SWZOZWVkZWQoKTsKLSAgICB2b2lkIGNvbW1pdElmTmVlZGVkKCk7CisgICAgdm9pZCBjb21taXRJ Zk5lZWRlZChib29sIGFscmVhZHlDYWxsZWRMYXlvdXQpOwogICAgIGJvb2wgZG9Db21wb3NpdGUo KTsKIAogICAgIC8vIEFjY2Vzc2VkIG9uIG1haW4gdGhyZWFkIG9ubHkuCg== 106456 2011-09-06 11:57:05 -0700 2011-09-06 11:57:34 -0700 Okay bug-67621-20110906115704.patch text/plain 1969 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ1NjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxYzkxMWNiNWFiMTMwOTA3 YTJjMmVhM2U2OWE0ODhiYzA1N2Q4NmIzLi43YjA4NjNlZDFkZjA0ODZiYTFjNjAzYjI3NTNiM2Qw MmE5NmVhN2M4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMDYgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUkVHUkVTU0lP Tig5NDM1Myk6IHJlcXVlc3RBbmltYXRpb25GcmFtZSBub3QgdGhyb3R0bGVkIGluIGNvbXBvc2l0 aW5nIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY3NjIxCisKKyAgICAgICAgQ0NTaW5nbGVUaHJlYWRQcm94eSBzaG91bGQgbm90IHBlcmZvcm0g bGF5b3V0IHdoZW4gY2FsbGVkCisgICAgICAgIHZpYSB0aGUgY29tcG9zaXRlSW1tZWRpYXRlbHkg cGF0aC4gRG9pbmcgc28gbWFrZXMgaXQgbG9vaworICAgICAgICBsaWtlIGZyYW1lIHJhdGUgaXMg dW5ib3VuZGVkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1NpbmdsZVRocmVhZFByb3h5Ojpjb21wb3NpdGVBbmRS ZWFkYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpDQ1NpbmdsZVRocmVhZFByb3h5Ojpjb21wb3Np dGVJbW1lZGlhdGVseSk6CisgICAgICAgIChXZWJDb3JlOjpDQ1NpbmdsZVRocmVhZFByb3h5Ojpj b21taXRJZk5lZWRlZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NTaW5nbGVUaHJlYWRQcm94eS5oOgorCiAyMDExLTA5LTA1ICBQYXZlbCBQb2Rpdmlsb3YgIDxw b2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlLWltcGxl bWVudCBSYXdTb3VyY2VDb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1NpbmdsZVRocmVhZFByb3h5LmNw cAppbmRleCA2MGJlNzU2MTE5YmRjYTFkZDhjYjAxZTRkODczNzI3YWJjZTM0OTdhLi4wYWYzMzBk YmQ4ZjQ2N2ZkYWZkN2RhNDAzNmYwNGJjODQ1MTYzZGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1NpbmdsZVRocmVhZFByb3h5LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Np bmdsZVRocmVhZFByb3h5LmNwcApAQCAtOTAsNyArOTAsNiBAQCBib29sIENDU2luZ2xlVGhyZWFk UHJveHk6OmNvbXBvc2l0ZUFuZFJlYWRiYWNrKHZvaWQgKnBpeGVscywgY29uc3QgSW50UmVjdCYg cmVjdAogCiAgICAgY29tbWl0SWZOZWVkZWQoKTsKIAotCiAgICAgaWYgKCFkb0NvbXBvc2l0ZSgp KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTIzMiw4ICsyMzEsNiBAQCBib29sIENDU2lu Z2xlVGhyZWFkUHJveHk6OnJlY3JlYXRlQ29udGV4dElmTmVlZGVkKCkKIHZvaWQgQ0NTaW5nbGVU aHJlYWRQcm94eTo6Y29tbWl0SWZOZWVkZWQoKQogewogICAgIC8vIFVwZGF0ZQotICAgIGRvdWJs ZSBmcmFtZUJlZ2luVGltZSA9IGN1cnJlbnRUaW1lKCk7Ci0gICAgbV9sYXllclRyZWVIb3N0LT5h bmltYXRlQW5kTGF5b3V0KGZyYW1lQmVnaW5UaW1lKTsKICAgICBtX2xheWVyVHJlZUhvc3QtPnVw ZGF0ZUxheWVycygpOwogCiAgICAgLy8gQ29tbWl0Cg==