67593 2011-09-05 03:25:39 -0700 [GTK] Use soup_session_add_feature_by_type uniformly in WebKit2 2011-09-06 11:25:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 mdwajahatali.siddiqui webkit-unassigned mrobinson svillar webkit.review.bot oldest_to_newest 462093 0 mdwajahatali.siddiqui 2011-09-05 03:25:39 -0700 Using soup_session_add_feature_by_type for adding all soup features instead of GRefPtr This will cut down redundant lines of code in doing GRefPtr as suggested in https://bugs.webkit.org/show_bug.cgi?id=65319 462097 1 106320 mdwajahatali.siddiqui 2011-09-05 03:35:24 -0700 Created attachment 106320 using soup_session_add_feature_by_type fix soup_session_add_feature_by_type fix 462098 2 mdwajahatali.siddiqui 2011-09-05 03:36:05 -0700 adding reviewers 462689 3 106320 webkit.review.bot 2011-09-06 11:25:32 -0700 Comment on attachment 106320 using soup_session_add_feature_by_type fix Clearing flags on attachment: 106320 Committed r94583: <http://trac.webkit.org/changeset/94583> 462690 4 webkit.review.bot 2011-09-06 11:25:36 -0700 All reviewed patches have been landed. Closing bug. 106320 2011-09-05 03:35:24 -0700 2011-09-06 11:25:32 -0700 using soup_session_add_feature_by_type fix proposed.patch text/plain 1872 mdwajahatali.siddiqui SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvZ3RrL1dlYlByb2Nlc3NNYWluR3RrLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2d0ay9XZWJQcm9jZXNz TWFpbkd0ay5jcHAJKHJldmlzaW9uIDk0NTE5KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9ndGsvV2ViUHJvY2Vzc01haW5HdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCwxNCArNTgs MTAgQEAKICAgICBSdW5Mb29wOjppbml0aWFsaXplTWFpblJ1bkxvb3AoKTsKICAgICBTb3VwU2Vz c2lvbiogc2Vzc2lvbiA9IFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpkZWZhdWx0U2Vzc2lvbigp OwogCi0gICAgR1JlZlB0cjxTb3VwU2Vzc2lvbkZlYXR1cmU+IHNuaWZmZXIgPSBhZG9wdEdSZWYo c3RhdGljX2Nhc3Q8U291cFNlc3Npb25GZWF0dXJlKj4oZ19vYmplY3RfbmV3KFNPVVBfVFlQRV9D T05URU5UX1NOSUZGRVIsIE5VTEwpKSk7Ci0gICAgc291cF9zZXNzaW9uX2FkZF9mZWF0dXJlKHNl c3Npb24sIHNuaWZmZXIuZ2V0KCkpOwotCisgICAgc291cF9zZXNzaW9uX2FkZF9mZWF0dXJlX2J5 X3R5cGUoc2Vzc2lvbiwgU09VUF9UWVBFX0NPTlRFTlRfU05JRkZFUik7CiAgICAgc291cF9zZXNz aW9uX2FkZF9mZWF0dXJlX2J5X3R5cGUoc2Vzc2lvbiwgU09VUF9UWVBFX0NPTlRFTlRfREVDT0RF Uik7CisgICAgc291cF9zZXNzaW9uX2FkZF9mZWF0dXJlX2J5X3R5cGUoc2Vzc2lvbiwgV0VCX1RZ UEVfQVVUSF9ESUFMT0cpOwogCi0gICAgR1JlZlB0cjxTb3VwU2Vzc2lvbkZlYXR1cmU+IGF1dGhE aWFsb2cgPSBhZG9wdEdSZWYoc3RhdGljX2Nhc3Q8U291cFNlc3Npb25GZWF0dXJlKj4oZ19vYmpl Y3RfbmV3KFdFQl9UWVBFX0FVVEhfRElBTE9HLCBOVUxMKSkpOwotICAgIHNvdXBfc2Vzc2lvbl9h ZGRfZmVhdHVyZShzZXNzaW9uLCBhdXRoRGlhbG9nLmdldCgpKTsKLQogICAgIGludCBzb2NrZXQg PSBhdG9pKGFyZ3ZbMV0pOwogICAgIFdlYlByb2Nlc3M6OnNoYXJlZCgpLmluaXRpYWxpemUoc29j a2V0LCBSdW5Mb29wOjptYWluKCkpOwogICAgIFJ1bkxvb3A6OnJ1bigpOwpJbmRleDogU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwkocmV2aXNpb24gOTQ1MjApCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wOS0wNSAgV2FqYWhhdCBTaWRkaXF1aSAgPG1k d2FqYWhhdGFsaS5zaWRkaXF1aUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW0dUS10gVXNlIHNv dXBfc2Vzc2lvbl9hZGRfZmVhdHVyZV9ieV90eXBlIHVuaWZvcm1seSBpbiBXZWJLaXQyLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc1OTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2luZyBzb3VwX3Nl c3Npb25fYWRkX2ZlYXR1cmVfYnlfdHlwZSBmb3IgYWRkaW5nIGFsbCBzb3VwIGZlYXR1cmVzIAor ICAgICAgICBpbnN0ZWFkIG9mIGFkZGluZyB1c2luZyBHUmVmUHRyLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9ndGsvV2ViUHJvY2Vzc01haW5HdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ cm9jZXNzTWFpbkd0ayk6CisKIDIwMTEtMDktMDUgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNz aUBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XVtXSzJdIEZpeCB0aGUgYnVpbGQK