67576 2011-09-04 03:27:22 -0700 [Chromium] Add multiple selection to WebPopupMenuInfo for Android 2011-09-04 14:25:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth dbates fishd peter webkit.review.bot oldest_to_newest 461941 0 abarth 2011-09-04 03:27:22 -0700 [Chromium] Add mutliple to WebPopupMenuInfo for Android 461942 1 106284 abarth 2011-09-04 03:29:17 -0700 Created attachment 106284 Patch 461944 2 abarth 2011-09-04 03:30:13 -0700 +fishd for WebKit API review. 461950 3 106284 fishd 2011-09-04 08:56:38 -0700 Comment on attachment 106284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106284&action=review R=me, but consider renaming suggestion > Source/WebKit/chromium/public/WebPopupMenuInfo.h:46 > + bool multiple; maybe "multiple" is a little too vague here? maybe call it "allowMultipleSelection" or "selectMultiple"? for example, we prefix "index" with "selected" for selectedIndex. 461973 4 106293 abarth 2011-09-04 13:23:45 -0700 Created attachment 106293 Patch for landing 461984 5 106293 webkit.review.bot 2011-09-04 14:23:29 -0700 Comment on attachment 106293 Patch for landing Clearing flags on attachment: 106293 Committed r94507: <http://trac.webkit.org/changeset/94507> 461985 6 webkit.review.bot 2011-09-04 14:23:33 -0700 All reviewed patches have been landed. Closing bug. 106284 2011-09-04 03:29:17 -0700 2011-09-04 13:23:42 -0700 Patch bug-67576-20110904032915.patch text/plain 3147 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ0OTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZWFmM2ZhNGNjNDliNmEyNGY3MmM2MzE2NzRkYjBjOWQ5YTk2NWIzYi4uMmFmNjU4ZmM5ZTQyYjQx NzkxYmU0ODg4OTE0MjQ3OWI4ZjhhZGY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsNSArMSwxOSBAQAogMjAxMS0wOS0wNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCisgICAgICAgIFtDaHJvbWl1bV0gQWRkIG11dGxpcGxlIHRvIFdlYlBvcHVwTWVudUluZm8g Zm9yIEFuZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY3NTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBmbGFnIHJlcXVlc3RzIHRoYXQgdGhlIGVtYmVkZGVyIGFsbG93IG11bHRpcGxlIHNl bGVjdGlvbiBmb3IgdGhlCisgICAgICAgIHBvcHVwIG1lbnUuICAoU2VlIGFsc28gaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NTc0LikKKworICAgICAgICAqIHB1Ymxp Yy9XZWJQb3B1cE1lbnVJbmZvLmg6CisgICAgICAgICogc3JjL0V4dGVybmFsUG9wdXBNZW51LmNw cDoKKyAgICAgICAgKFdlYktpdDo6RXh0ZXJuYWxQb3B1cE1lbnU6OmdldFBvcHVwTWVudUluZm8p OgorCisyMDExLTA5LTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAg ICAgW0Nocm9taXVtXSBBZGQgbWVtb3J5IHRocmVzaG9sZCB2YWx1ZXMgdG8gV2ViS2l0UGxhdGZv cm1TdXBwb3J0LmgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY3NTc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YlBvcHVwTWVudUluZm8uaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBvcHVw TWVudUluZm8uaAppbmRleCA4ODI0ODQ2NTIxMjk3MGM3OThiNmU3ZTkyZDZiOGFjMTFiOTUwMDMy Li45ZmI1NDZmZmY0M2YzYTkyMzRlYTM5YzFjZjhkMWE1NzliOGQ1YmRlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQb3B1cE1lbnVJbmZvLmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUG9wdXBNZW51SW5mby5oCkBAIC00Myw2ICs0 Myw3IEBAIHN0cnVjdCBXZWJQb3B1cE1lbnVJbmZvIHsKICAgICBpbnQgc2VsZWN0ZWRJbmRleDsK ICAgICBXZWJWZWN0b3I8V2ViTWVudUl0ZW1JbmZvPiBpdGVtczsKICAgICBib29sIHJpZ2h0QWxp Z25lZDsKKyAgICBib29sIG11bHRpcGxlOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FeHRlcm5hbFBvcHVwTWVudS5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FeHRlcm5hbFBvcHVwTWVudS5jcHAKaW5k ZXggYTFjMThlNzZjMDVlZmFkY2UyOGNlNzY0MjVhYThhYjZhYWZiZDZjNC4uYzczOTIwZTc5YjA4 MGFlNjIwNmU1NDBlYTg2NGUwMWVjZjU5NjdkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvRXh0ZXJuYWxQb3B1cE1lbnUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL0V4dGVybmFsUG9wdXBNZW51LmNwcApAQCAtMTYxLDggKzE2MSw3IEBAIHZvaWQg RXh0ZXJuYWxQb3B1cE1lbnU6OmRpZENhbmNlbCgpCiB2b2lkIEV4dGVybmFsUG9wdXBNZW51Ojpn ZXRQb3B1cE1lbnVJbmZvKFdlYlBvcHVwTWVudUluZm8qIGluZm8pCiB7CiAgICAgaW50IGl0ZW1D b3VudCA9IG1fcG9wdXBNZW51Q2xpZW50LT5saXN0U2l6ZSgpOwotICAgIFdlYlZlY3RvcjxXZWJN ZW51SXRlbUluZm8+IGl0ZW1zKAotICAgICAgICBzdGF0aWNfY2FzdDxzaXplX3Q+KGl0ZW1Db3Vu dCkpOworICAgIFdlYlZlY3RvcjxXZWJNZW51SXRlbUluZm8+IGl0ZW1zKHN0YXRpY19jYXN0PHNp emVfdD4oaXRlbUNvdW50KSk7CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBpdGVtQ291bnQ7ICsr aSkgewogICAgICAgICBXZWJNZW51SXRlbUluZm8mIHBvcHVwSXRlbSA9IGl0ZW1zW2ldOwogICAg ICAgICBwb3B1cEl0ZW0ubGFiZWwgPSBtX3BvcHVwTWVudUNsaWVudC0+aXRlbVRleHQoaSk7CkBA IC0xODMsMTEgKzE4MiwxNCBAQCB2b2lkIEV4dGVybmFsUG9wdXBNZW51OjpnZXRQb3B1cE1lbnVJ bmZvKFdlYlBvcHVwTWVudUluZm8qIGluZm8pCiAgICAgfQogCiAgICAgaW5mby0+aXRlbUhlaWdo dCA9IG1fcG9wdXBNZW51Q2xpZW50LT5tZW51U3R5bGUoKS5mb250KCkuZm9udE1ldHJpY3MoKS5o ZWlnaHQoKTsKLSAgICBpbmZvLT5pdGVtRm9udFNpemUgPQotICAgICAgICBzdGF0aWNfY2FzdDxp bnQ+KG1fcG9wdXBNZW51Q2xpZW50LT5tZW51U3R5bGUoKS5mb250KCkuc2l6ZSgpKTsKKyAgICBp bmZvLT5pdGVtRm9udFNpemUgPSBzdGF0aWNfY2FzdDxpbnQ+KG1fcG9wdXBNZW51Q2xpZW50LT5t ZW51U3R5bGUoKS5mb250KCkuc2l6ZSgpKTsKICAgICBpbmZvLT5zZWxlY3RlZEluZGV4ID0gbV9w b3B1cE1lbnVDbGllbnQtPnNlbGVjdGVkSW5kZXgoKTsKLSAgICBpbmZvLT5yaWdodEFsaWduZWQg PQotICAgICAgICBtX3BvcHVwTWVudUNsaWVudC0+bWVudVN0eWxlKCkudGV4dERpcmVjdGlvbigp ID09IFdlYkNvcmU6OlJUTDsKKyAgICBpbmZvLT5yaWdodEFsaWduZWQgPSBtX3BvcHVwTWVudUNs aWVudC0+bWVudVN0eWxlKCkudGV4dERpcmVjdGlvbigpID09IFdlYkNvcmU6OlJUTDsKKyNpZiBF TkFCTEUoTk9fTElTVEJPWF9SRU5ERVJJTkcpCisgICAgLy8gRklYTUU6IFdoeSBpcyB0aGlzIGNh c3Qgc2FmZT8KKyAgICBMaXN0UG9wdXBNZW51Q2xpZW50KiBjbGllbnQgPSBzdGF0aWNfY2FzdDxM aXN0UG9wdXBNZW51Q2xpZW50Kj4obV9wb3B1cE1lbnVDbGllbnQpOworICAgIGluZm8tPm11bHRp cGxlID0gY2xpZW50LT5tdWx0aXBsZSgpOworI2VuZGlmCiAgICAgaW5mby0+aXRlbXMuc3dhcChp dGVtcyk7CiB9CiAK 106293 2011-09-04 13:23:45 -0700 2011-09-04 14:23:28 -0700 Patch for landing bug-67576-20110904132344.patch text/plain 3212 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ1MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NTQ1MjQ3YjhhZmUyZTVkOTA3YmQxYjQ5YzVjMWM1ZmJlZmEyMWE5NS4uNzNkM2VjM2RiYzA3ZWE1 NTIyMDVhZjM0MDE2MWI1ZWE5NGE4NTVlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsNSArMSwxOSBAQAogMjAxMS0wOS0wNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCisgICAgICAgIFtDaHJvbWl1bV0gQWRkIG11dGxpcGxlIHRvIFdlYlBvcHVwTWVudUluZm8g Zm9yIEFuZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY3NTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgorCisgICAgICAg IFRoaXMgZmxhZyByZXF1ZXN0cyB0aGF0IHRoZSBlbWJlZGRlciBhbGxvdyBtdWx0aXBsZSBzZWxl Y3Rpb24gZm9yIHRoZQorICAgICAgICBwb3B1cCBtZW51LiAgKFNlZSBhbHNvIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzU3NC4pCisKKyAgICAgICAgKiBwdWJsaWMv V2ViUG9wdXBNZW51SW5mby5oOgorICAgICAgICAqIHNyYy9FeHRlcm5hbFBvcHVwTWVudS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OkV4dGVybmFsUG9wdXBNZW51OjpnZXRQb3B1cE1lbnVJbmZvKToK KworMjAxMS0wOS0wNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCiAgICAgICAg IFtDaHJvbWl1bV0gQWRkIG1lbW9yeSB0aHJlc2hvbGQgdmFsdWVzIHRvIFdlYktpdFBsYXRmb3Jt U3VwcG9ydC5oCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NzU3NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQ b3B1cE1lbnVJbmZvLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQb3B1cE1l bnVJbmZvLmgKaW5kZXggODgyNDg0NjUyMTI5NzBjNzk4YjZlN2U5MmQ2YjhhYzExYjk1MDAzMi4u YWZmZTVmOWQxZGM2YWViYjc2NGEzMTAxODdkZGQ5MWYxZWM4NzQ1NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUG9wdXBNZW51SW5mby5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBvcHVwTWVudUluZm8uaApAQCAtNDMsOCArNDMs OSBAQCBzdHJ1Y3QgV2ViUG9wdXBNZW51SW5mbyB7CiAgICAgaW50IHNlbGVjdGVkSW5kZXg7CiAg ICAgV2ViVmVjdG9yPFdlYk1lbnVJdGVtSW5mbz4gaXRlbXM7CiAgICAgYm9vbCByaWdodEFsaWdu ZWQ7CisgICAgYm9vbCBhbGxvd011bHRpcGxlU2VsZWN0aW9uOwogfTsKIAotfSAvLyBuYW1lc3Bh Y2UgV2ViS2l0Cit9CiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvRXh0ZXJuYWxQb3B1cE1lbnUuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv RXh0ZXJuYWxQb3B1cE1lbnUuY3BwCmluZGV4IDg2NTFkMzUwZTZhNjM1ODQwZGM0M2M0NGM3NDk5 MzlmNWEwZWFjOWQuLmFiMWE5MTRhOTFkYzliNGZlMTEyMDkzNWU4NzQ3NmU1YzYzNTc4NzcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0V4dGVybmFsUG9wdXBNZW51LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FeHRlcm5hbFBvcHVwTWVudS5jcHAK QEAgLTEyOCw4ICsxMjgsNyBAQCB2b2lkIEV4dGVybmFsUG9wdXBNZW51OjpkaWRDYW5jZWwoKQog dm9pZCBFeHRlcm5hbFBvcHVwTWVudTo6Z2V0UG9wdXBNZW51SW5mbyhXZWJQb3B1cE1lbnVJbmZv KiBpbmZvKQogewogICAgIGludCBpdGVtQ291bnQgPSBtX3BvcHVwTWVudUNsaWVudC0+bGlzdFNp emUoKTsKLSAgICBXZWJWZWN0b3I8V2ViTWVudUl0ZW1JbmZvPiBpdGVtcygKLSAgICAgICAgc3Rh dGljX2Nhc3Q8c2l6ZV90PihpdGVtQ291bnQpKTsKKyAgICBXZWJWZWN0b3I8V2ViTWVudUl0ZW1J bmZvPiBpdGVtcyhzdGF0aWNfY2FzdDxzaXplX3Q+KGl0ZW1Db3VudCkpOwogICAgIGZvciAoaW50 IGkgPSAwOyBpIDwgaXRlbUNvdW50OyArK2kpIHsKICAgICAgICAgV2ViTWVudUl0ZW1JbmZvJiBw b3B1cEl0ZW0gPSBpdGVtc1tpXTsKICAgICAgICAgcG9wdXBJdGVtLmxhYmVsID0gbV9wb3B1cE1l bnVDbGllbnQtPml0ZW1UZXh0KGkpOwpAQCAtMTUwLDEyICsxNDksMTUgQEAgdm9pZCBFeHRlcm5h bFBvcHVwTWVudTo6Z2V0UG9wdXBNZW51SW5mbyhXZWJQb3B1cE1lbnVJbmZvKiBpbmZvKQogICAg IH0KIAogICAgIGluZm8tPml0ZW1IZWlnaHQgPSBtX3BvcHVwTWVudUNsaWVudC0+bWVudVN0eWxl KCkuZm9udCgpLmZvbnRNZXRyaWNzKCkuaGVpZ2h0KCk7Ci0gICAgaW5mby0+aXRlbUZvbnRTaXpl ID0KLSAgICAgICAgc3RhdGljX2Nhc3Q8aW50PihtX3BvcHVwTWVudUNsaWVudC0+bWVudVN0eWxl KCkuZm9udCgpLnNpemUoKSk7CisgICAgaW5mby0+aXRlbUZvbnRTaXplID0gc3RhdGljX2Nhc3Q8 aW50PihtX3BvcHVwTWVudUNsaWVudC0+bWVudVN0eWxlKCkuZm9udCgpLnNpemUoKSk7CiAgICAg aW5mby0+c2VsZWN0ZWRJbmRleCA9IG1fcG9wdXBNZW51Q2xpZW50LT5zZWxlY3RlZEluZGV4KCk7 Ci0gICAgaW5mby0+cmlnaHRBbGlnbmVkID0KLSAgICAgICAgbV9wb3B1cE1lbnVDbGllbnQtPm1l bnVTdHlsZSgpLnRleHREaXJlY3Rpb24oKSA9PSBXZWJDb3JlOjpSVEw7CisgICAgaW5mby0+cmln aHRBbGlnbmVkID0gbV9wb3B1cE1lbnVDbGllbnQtPm1lbnVTdHlsZSgpLnRleHREaXJlY3Rpb24o KSA9PSBXZWJDb3JlOjpSVEw7CisjaWYgRU5BQkxFKE5PX0xJU1RCT1hfUkVOREVSSU5HKQorICAg IC8vIEZJWE1FOiBXaHkgaXMgdGhpcyBjYXN0IHNhZmU/CisgICAgTGlzdFBvcHVwTWVudUNsaWVu dCogY2xpZW50ID0gc3RhdGljX2Nhc3Q8TGlzdFBvcHVwTWVudUNsaWVudCo+KG1fcG9wdXBNZW51 Q2xpZW50KTsKKyAgICBpbmZvLT5hbGxvd011bHRpcGxlU2VsZWN0aW9uID0gY2xpZW50LT5tdWx0 aXBsZSgpOworI2VuZGlmCiAgICAgaW5mby0+aXRlbXMuc3dhcChpdGVtcyk7CiB9CiAKLX0gLy8g bmFtZXNwYWNlIFdlYktpdAorfQo=