67570 2011-09-03 18:38:36 -0700 REGRESSION (r86268): Fix for qt_networkAccessAllowed() 2011-09-03 19:57:57 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, Regression P2 Normal --- 1 laszlo.gombos webkit-unassigned kenneth noam webkit.review.bot oldest_to_newest 461874 0 laszlo.gombos 2011-09-03 18:38:36 -0700 r86268 changed the USE(QT_BEARER) guard to ENABLE(QT_BEARER) - not consistently but only in one place. This seems an irrelevant change and made the guarded code never execute. QT_BEARER was introduced to manage BearerManager library dependency in Qt 4.6 however Qt 4.6 is no longer supported on trunk (see 81553), so this could be replaced by the existing QT_NO_BEARERMANAGEMENT QtNetwork guard. 461876 1 106270 laszlo.gombos 2011-09-03 18:46:05 -0700 Created attachment 106270 1st try 461878 2 106270 noam 2011-09-03 18:57:29 -0700 Comment on attachment 106270 1st try LGTM 461890 3 106270 webkit.review.bot 2011-09-03 19:57:53 -0700 Comment on attachment 106270 1st try Clearing flags on attachment: 106270 Committed r94499: <http://trac.webkit.org/changeset/94499> 461891 4 webkit.review.bot 2011-09-03 19:57:57 -0700 All reviewed patches have been landed. Closing bug. 106270 2011-09-03 18:46:05 -0700 2011-09-03 19:57:53 -0700 1st try 67570-1.patch text/plain 6735 laszlo.gombos ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3YTA5NTU3Li4zOTM5ODNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDktMDMgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHI4NjI2OCk6IEZpeCBmb3IgcXRfbmV0d29ya0FjY2Vz c0FsbG93ZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Njc1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBObyBuZXcgdGVzdHMgYXMgdGhpcyBjaGFuZ2Ugb25seSByZW1vdmVzIGRlYWQgY29kZS4KKyAg ICAgICAgU3VwcG9ydCBmb3IgUXQgNC42IGhhcyAgYmVlbiByZW1vdmVkIGEgd2hpbGUgYmFjay4K KworICAgICAgICAqIFdlYkNvcmUucHJpOgorICAgICAgICAqIFdlYkNvcmUucHJvOgorICAgICAg ICAqIGZlYXR1cmVzLnByaToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0 ZU5vdGlmaWVyLmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9OZXR3b3JrU3RhdGVO b3RpZmllclF0LmNwcDoKKwogMjAxMS0wOC0zMCAgUmFjaGVsIEJsdW0gIDxncm9ieUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgVGhlICJwb3J0IiBwcm9wZXJ0eSBvZiBhbiA8YT4gd2hvc2UgaHJl ZiBkb2VzIG5vdCBzcGVjaWZ5IGEgcG9ydCByZXR1cm5zIHRoZSB3cm9uZyB2YWx1ZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3Jl LnByaQppbmRleCAwZmY0NzYzLi5iNTc4NWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9X ZWJDb3JlLnByaQorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQpAQCAtMjQ1LDE1ICsy NDUsNiBAQCBjb250YWlucyhERUZJTkVTLCBXVEZfVVNFX1FUX01PQklMSVRZX1NZU1RFTUlORk89 MSkgewogICAgICBNT0JJTElUWSAqPSBzeXN0ZW1pbmZvCiB9CiAKLWNvbnRhaW5zKERFRklORVMs IFdURl9VU0VfUVRfQkVBUkVSPTEpIHsKLSAgICAjIEJlYXJlciBtYW5hZ2VtZW50IGlzIHBhcnQg b2YgUXQgNC43LCBzbyBkb24ndCBhY2NpZGVudGlhbGx5Ci0gICAgIyBwdWxsIGluIFF0IE1vYmls aXR5IHdoZW4gYnVpbGRpbmcgYWdhaW5zdCA+PSA0LjcKLSAgICAhZ3JlYXRlclRoYW4oUVRfTUlO T1JfVkVSU0lPTiwgNikgewotICAgICAgICBDT05GSUcgKj0gbW9iaWxpdHkKLSAgICAgICAgTU9C SUxJVFkgKj0gYmVhcmVyCi0gICAgfQotfQotCiBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfVklE RU89MSkgewogICAgIGNvbnRhaW5zKERFRklORVMsIFdURl9VU0VfUVRLSVQ9MSkgewogICAgICAg ICBJTkNMVURFUEFUSCArPSAkJFBXRC9wbGF0Zm9ybS9ncmFwaGljcy9tYWMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJvIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcm8K aW5kZXggMzAwZWNjNy4uMzBjMTM2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5wcm8KKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTIwNzksNiArMjA3OSw3 IEBAIEhFQURFUlMgKz0gXAogICAgIHBsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFz ZS5oIFwKICAgICBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmggXAogICAg IHBsYXRmb3JtL25ldHdvcmsvcXQvRG5zUHJlZmV0Y2hIZWxwZXIuaCBcCisgICAgcGxhdGZvcm0v bmV0d29yay9xdC9OZXR3b3JrU3RhdGVOb3RpZmllclByaXZhdGUuaCBcCiAgICAgcGxhdGZvcm0v UGxhdGZvcm1Ub3VjaEV2ZW50LmggXAogICAgIHBsYXRmb3JtL1BsYXRmb3JtVG91Y2hQb2ludC5o IFwKICAgICBwbGF0Zm9ybS9Qb3B1cE1lbnUuaCBcCkBAIC0yNTg0LDYgKzI1ODUsNyBAQCBTT1VS Q0VTICs9IFwKICAgICBwbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlSGFuZGxlUXQuY3BwIFwK ICAgICBwbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcCBcCiAgICAgcGxh dGZvcm0vbmV0d29yay9xdC9EbnNQcmVmZXRjaEhlbHBlci5jcHAgXAorICAgIHBsYXRmb3JtL25l dHdvcmsvcXQvTmV0d29ya1N0YXRlTm90aWZpZXJRdC5jcHAgXAogICAgIHBsYXRmb3JtL25ldHdv cmsvcXQvUHJveHlTZXJ2ZXJRdC5jcHAgXAogICAgIHBsYXRmb3JtL25ldHdvcmsvcXQvUXRNSU1F VHlwZVNuaWZmZXIuY3BwIFwKICAgICBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlI YW5kbGVyLmNwcCBcCkBAIC0zMjE1LDE0ICszMjE3LDYgQEAgY29udGFpbnMoREVGSU5FUywgRU5B QkxFX1hIVE1MTVA9MSkgewogICAgICAgICBodG1sL0hUTUxOb1NjcmlwdEVsZW1lbnQuY3BwCiB9 CiAKLWNvbnRhaW5zKERFRklORVMsIFdURl9VU0VfUVRfQkVBUkVSPTEpIHsKLSAgICBIRUFERVJT ICs9IFwKLSAgICAgICAgcGxhdGZvcm0vbmV0d29yay9xdC9OZXR3b3JrU3RhdGVOb3RpZmllclBy aXZhdGUuaAotCi0gICAgU09VUkNFUyArPSBcCi0gICAgICAgIHBsYXRmb3JtL25ldHdvcmsvcXQv TmV0d29ya1N0YXRlTm90aWZpZXJRdC5jcHAKLX0KLQogIyBRUmF3Rm9udCBmZWF0dXJlIGFkZGVk IGluIFF0IDQuOC4wCiAjIAogIyBJZiBhdmFpbGFibGUsIHRoaXMgaXMgdXNlZCB0byBpbXBsZW1l bnQgdGhlIGZhc3QgcGF0aCBmb3IgdGV4dCByZW5kZXJpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2ZlYXR1cmVzLnByaSBiL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLnByaQppbmRleCA1 MWJkODU1Li4wYWEwZDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5wcmkK KysrIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMucHJpCkBAIC0xNzEsMTggKzE3MSw2IEBAIHN5 bWJpYW58bWFlbW81fG1hZW1vNiB7CiAgICAgfQogfQogCi0jIEJlYXJlciBtYW5hZ2VtZW50IGlz IHBhcnQgb2YgUXQgNC43Ci0jIGZvciBvbGRlciB2ZXJzaW9uLCBjaGVjayBmb3IgbW9iaWxpdHkg d2l0aCBiZWFyZXIKLSFjb250YWlucyhERUZJTkVTLCBXVEZfVVNFX1FUX0JFQVJFUj0uKSB7Ci0g ICAgICFsZXNzVGhhbihRVF9NSU5PUl9WRVJTSU9OLCA3KSB7Ci0gICAgICAgIERFRklORVMgKz0g V1RGX1VTRV9RVF9CRUFSRVI9MQotICAgICB9IGVsc2UgewotICAgICAgICBjb250YWlucyhNT0JJ TElUWV9DT05GSUcsIGJlYXJlcikgewotICAgICAgICAgICAgREVGSU5FUyArPSBXVEZfVVNFX1FU X0JFQVJFUj0xCi0gICAgICAgIH0KLSAgICB9Ci19Ci0KICFjb250YWlucyhERUZJTkVTLCBFTkFC TEVfVE9VQ0hfRVZFTlRTPS4pOiBERUZJTkVTICs9IEVOQUJMRV9UT1VDSF9FVkVOVFM9MQogCiAj IEhUTUw1IE1lZGlhIFN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuaAppbmRleCBhMTI1NjFkLi44MTFlYjhlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5v dGlmaWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3Rh dGVOb3RpZmllci5oCkBAIC00NSwxNiArNDUsMTEgQEAgdHlwZWRlZiBjb25zdCBzdHJ1Y3QgX19T Q0R5bmFtaWNTdG9yZSAqIFNDRHluYW1pY1N0b3JlUmVmOwogCiAjaW5jbHVkZSA8UXRDb3JlL3Fn bG9iYWwuaD4KIAotI2lmZGVmIFFUX05PX0JFQVJFUk1BTkFHRU1FTlQKLSN1bmRlZiBXVEZfVVNF X1FUX0JFQVJFUgotI2RlZmluZSBXVEZfVVNFX1FUX0JFQVJFUiAwCi0jZW5kaWYKLQogI2VuZGlm CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotI2lmIChQTEFURk9STShRVCkgJiYgVVNFKFFUX0JF QVJFUikpCisjaWYgKFBMQVRGT1JNKFFUKSAmJiAhZGVmaW5lZChRVF9OT19CRUFSRVJNQU5BR0VN RU5UKSkKIGNsYXNzIE5ldHdvcmtTdGF0ZU5vdGlmaWVyUHJpdmF0ZTsKICNlbmRpZgogCkBAIC02 Niw3ICs2MSw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgb25MaW5lKCkgY29uc3QgeyByZXR1cm4g bV9pc09uTGluZTsgfQogCi0jaWYgKFBMQVRGT1JNKFFUKSAmJiBVU0UoUVRfQkVBUkVSKSkKKyNp ZiAoUExBVEZPUk0oUVQpICYmICFkZWZpbmVkKFFUX05PX0JFQVJFUk1BTkFHRU1FTlQpKQogICAg IHZvaWQgc2V0TmV0d29ya0FjY2Vzc0FsbG93ZWQoYm9vbCk7CiAjZWxpZiBQTEFURk9STShDSFJP TUlVTSkgfHwgUExBVEZPUk0oRUZMKQogICAgIHZvaWQgc2V0T25MaW5lKGJvb2wpOwpAQCAtOTUs MTMgKzkwLDEzIEBAIHByaXZhdGU6CiAgICAgSEFORExFIG1fd2FpdEhhbmRsZTsKICAgICBPVkVS TEFQUEVEIG1fb3ZlcmxhcHBlZDsKIAotI2VsaWYgUExBVEZPUk0oUVQpICYmIFVTRShRVF9CRUFS RVIpCisjZWxpZiAoUExBVEZPUk0oUVQpICYmICFkZWZpbmVkKFFUX05PX0JFQVJFUk1BTkFHRU1F TlQpKQogICAgIGZyaWVuZCBjbGFzcyBOZXR3b3JrU3RhdGVOb3RpZmllclByaXZhdGU7CiAgICAg TmV0d29ya1N0YXRlTm90aWZpZXJQcml2YXRlKiBwOwogI2VuZGlmCiB9OwogCi0jaWYgIVBMQVRG T1JNKE1BQykgJiYgIVBMQVRGT1JNKFdJTikgJiYgIShQTEFURk9STShRVCkgJiYgVVNFKFFUX0JF QVJFUikpCisjaWYgIVBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JNKFdJTikgJiYgIShQTEFURk9S TShRVCkgJiYgIWRlZmluZWQoUVRfTk9fQkVBUkVSTUFOQUdFTUVOVCkpCiAKIGlubGluZSBOZXR3 b3JrU3RhdGVOb3RpZmllcjo6TmV0d29ya1N0YXRlTm90aWZpZXIoKQogICAgIDogbV9pc09uTGlu ZSh0cnVlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9O ZXR3b3JrU3RhdGVOb3RpZmllclF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvcXQvTmV0d29ya1N0YXRlTm90aWZpZXJRdC5jcHAKaW5kZXggZWE5ZDg1Ni4uYTM1NmI3MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9OZXR3b3JrU3Rh dGVOb3RpZmllclF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0 L05ldHdvcmtTdGF0ZU5vdGlmaWVyUXQuY3BwCkBAIC0yMCw3ICsyMCw3IEBACiAjaW5jbHVkZSAi Y29uZmlnLmgiCiAjaW5jbHVkZSAiTmV0d29ya1N0YXRlTm90aWZpZXIuaCIKIAotI2lmIFBMQVRG T1JNKFFUKSAmJiBVU0UoUVRfQkVBUkVSKQorI2lmIChQTEFURk9STShRVCkgJiYgIWRlZmluZWQo UVRfTk9fQkVBUkVSTUFOQUdFTUVOVCkpCiAKICNpbmNsdWRlICJOZXR3b3JrU3RhdGVOb3RpZmll clByaXZhdGUuaCIKICNpbmNsdWRlICJxbmV0d29ya2NvbmZpZ21hbmFnZXIuaCIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0 L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCmluZGV4IGZhMTYyYzEuLjM2NzZmMDMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dl YktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcApAQCAtNTcsNyArNTcsNyBAQAogCiB2b2lkIFFX RUJLSVRfRVhQT1JUIHF0X25ldHdvcmtBY2Nlc3NBbGxvd2VkKGJvb2wgaXNBbGxvd2VkKQogewot I2lmIEVOQUJMRShRVF9CRUFSRVIpCisjaWZuZGVmIFFUX05PX0JFQVJFUk1BTkFHRU1FTlQKICAg ICBXZWJDb3JlOjpuZXR3b3JrU3RhdGVOb3RpZmllcigpLnNldE5ldHdvcmtBY2Nlc3NBbGxvd2Vk KGlzQWxsb3dlZCk7CiAjZW5kaWYKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggZDMyYzQyZS4uOTc4YjU3 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wOS0wMyAgTGFzemxvIEdv bWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjg2MjY4KTogRml4IGZvciBxdF9uZXR3b3JrQWNjZXNzQWxsb3dlZCgpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzU3MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgdGhlIEVOQUJMRShRVF9C RUFSRVIpIGd1YXJkIHdpdGgKKyAgICAgICAgIWRlZmluZWQoUVRfTk9fQkVBUkVSTUFOQUdFTUVO VCkgd2hpY2ggaXMgdHJ1ZSBieQorICAgICAgICBkZWZhdWx0IGluIFF0IDQuNyBvciBsYXRlciB2 ZXJzaW9ucy4KKworICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAocXRf bmV0d29ya0FjY2Vzc0FsbG93ZWQpOgorCiAyMDExLTA4LTMwICBDYWlvIE1hcmNlbG8gZGUgT2xp dmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgRW1p dCBsYXN0IHByb2dyZXNzIG5vdGlmaWNhdGlvbiBiZWZvcmUgY2FsbGluZyBkaXNwYXRjaERpZEZp bmlzaExvYWQK