67549 2011-09-02 19:07:25 -0700 [chromium] Check in 'build' for compiled binaries first 2011-09-06 13:31:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony dpranke webkit.review.bot oldest_to_newest 461691 0 tony 2011-09-02 19:07:25 -0700 [chromium] Check in 'build' for compiled binaries first 461692 1 106237 tony 2011-09-02 19:08:27 -0700 Created attachment 106237 Patch 461693 2 tony 2011-09-02 19:08:50 -0700 Suggestions on how to test this would be welcome. 461701 3 106237 dpranke 2011-09-02 19:27:07 -0700 Comment on attachment 106237 Patch The change looks fine to me so I'm R+'ing it. I'm on the fence as to whether writing tests for this is particularly valuable, but if you did want to, the way I'd do it would be to add some tests to chromium_win_unittest that created a port, overrode the port._filesystem field to a dummy object that implemented exists() for various paths, and then called port.build_path to exercise various branches. 462641 4 106441 tony 2011-09-06 10:43:16 -0700 Created attachment 106441 Patch 462722 5 tony 2011-09-06 12:06:16 -0700 Test added. Can you take another look? 462806 6 106441 webkit.review.bot 2011-09-06 13:31:45 -0700 Comment on attachment 106441 Patch Clearing flags on attachment: 106441 Committed r94592: <http://trac.webkit.org/changeset/94592> 462807 7 webkit.review.bot 2011-09-06 13:31:50 -0700 All reviewed patches have been landed. Closing bug. 106237 2011-09-02 19:08:27 -0700 2011-09-06 10:43:13 -0700 Patch bug-67549-20110902190722.patch text/plain 2054 tony U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ0MjEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiZDE4MWNmYjE5NzUyMDYwODBjNDAzNWRjZDg2NTBjMDkz NTM0MWJhLi4wYzAwZTg3NWZhODYyNmY4NmFkZTRlMjg4ODgyZDc2MmQ5ZjA2OWRmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDktMDIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAg ICBbY2hyb21pdW1dIENoZWNrIGluICdidWlsZCcgZm9yIGNvbXBpbGVkIGJpbmFyaWVzIGZpcnN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzU0OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEknbSB3b3Jr aW5nIG9uIG1vdmluZyB0aGUgd2luZG93cyBidWlsZCBvdXRwdXQgdG8gYSBjb21tb24gbG9jYXRp b24KKyAgICAgICAgcmF0aGVyIHRoYW4gcmVsYXRpdmUgdG8gdGhlIHNsbiBmaWxlLiAgQmVjYXVz ZSBvZiB0aGF0LCB3ZSBuZWVkIHRvCisgICAgICAgIGNoZWNrIHRob3NlIGJ1aWxkIGxvY2F0aW9u cyBmaXJzdCBmb3IgRHVtcFJlbmRlclRyZWUuZXhlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHk6CisKIDIwMTEtMDktMDIgIENz YWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIEJ1aWxk IGRlcGVuZGVuY3kgcHJvYmxlbXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKaW5kZXggZjNmMzQzMTAzMTY5Y2Vl ZDMxZGNhYzhiOWQxYjM1ODM5MTRkYWVhOC4uZDZmZTUwYjY5NWJkMTFkZmNmODFmYjcyMTI3Mjdk YjM4YjdlYjQ0MyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKQEAgLTE1NiwxMiArMTU2LDE4IEBAIGNsYXNz IENocm9taXVtV2luUG9ydChjaHJvbWl1bS5DaHJvbWl1bVBvcnQpOgogICAgICAgICBpZiBzZWxm LmdldF9vcHRpb24oJ2J1aWxkX2RpcmVjdG9yeScpOgogICAgICAgICAgICAgcmV0dXJuIHNlbGYu X2ZpbGVzeXN0ZW0uam9pbihzZWxmLmdldF9vcHRpb24oJ2J1aWxkX2RpcmVjdG9yeScpLCAqY29t cHMpCiAKKyAgICAgICAgcCA9IHNlbGYucGF0aF9mcm9tX2Nocm9taXVtX2Jhc2UoJ2J1aWxkJywg KmNvbXBzKQorICAgICAgICBpZiBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhwKToKKyAgICAgICAg ICAgIHJldHVybiBwCiAgICAgICAgIHAgPSBzZWxmLnBhdGhfZnJvbV9jaHJvbWl1bV9iYXNlKCd3 ZWJraXQnLCAqY29tcHMpCiAgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKHApOgog ICAgICAgICAgICAgcmV0dXJuIHAKICAgICAgICAgcCA9IHNlbGYucGF0aF9mcm9tX2Nocm9taXVt X2Jhc2UoJ2Nocm9tZScsICpjb21wcykKICAgICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5leGlz dHMocCk6CiAgICAgICAgICAgICByZXR1cm4gcAorICAgICAgICBwID0gc2VsZi5fZmlsZXN5c3Rl bS5qb2luKHNlbGYucGF0aF9mcm9tX3dlYmtpdF9iYXNlKCksICdTb3VyY2UnLCAnV2ViS2l0Jywg J2Nocm9taXVtJywgJ2J1aWxkJywgKmNvbXBzKQorICAgICAgICBpZiBzZWxmLl9maWxlc3lzdGVt LmV4aXN0cyhwKToKKyAgICAgICAgICAgIHJldHVybiBwCiAgICAgICAgIHJldHVybiBzZWxmLl9m aWxlc3lzdGVtLmpvaW4oc2VsZi5wYXRoX2Zyb21fd2Via2l0X2Jhc2UoKSwgJ1NvdXJjZScsICdX ZWJLaXQnLCAnY2hyb21pdW0nLCAqY29tcHMpCiAKICAgICBkZWYgX3VzZXNfYXBhY2hlKHNlbGYp Ogo= 106441 2011-09-06 10:43:16 -0700 2011-09-06 13:31:45 -0700 Patch bug-67549-20110906104209.patch text/plain 3535 tony U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ1NzYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlYTBlOTk2NzkzMTQwOWE5NzhjYjVmZWY2NjRkMTRhZGU2 NTdhNzI2Li5iNjI4ZjhjNWUxMTY4ODlhYTUyM2NjNDE3ZTM2NzMzMmVhOTQ3YWNlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDktMDYgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAg ICBbY2hyb21pdW1dIENoZWNrIGluICdidWlsZCcgZm9yIGNvbXBpbGVkIGJpbmFyaWVzIGZpcnN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzU0OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEknbSB3b3Jr aW5nIG9uIG1vdmluZyB0aGUgd2luZG93cyBidWlsZCBvdXRwdXQgdG8gYSBjb21tb24gbG9jYXRp b24KKyAgICAgICAgcmF0aGVyIHRoYW4gcmVsYXRpdmUgdG8gdGhlIHNsbiBmaWxlLiAgQmVjYXVz ZSBvZiB0aGF0LCB3ZSBuZWVkIHRvCisgICAgICAgIGNoZWNrIHRob3NlIGJ1aWxkIGxvY2F0aW9u cyBmaXJzdCBmb3IgRHVtcFJlbmRlclRyZWUuZXhlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHk6CisKIDIwMTEtMDktMDUgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgYSB0YWIgdG8gZ2Fy ZGVuLW8tbWF0aWMgZm9yIHZpZXdpbmcgZXhwZWN0ZWQgZmFpbHVyZXMKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkK aW5kZXggZjNmMzQzMTAzMTY5Y2VlZDMxZGNhYzhiOWQxYjM1ODM5MTRkYWVhOC4uZDZmZTUwYjY5 NWJkMTFkZmNmODFmYjcyMTI3MjdkYjM4YjdlYjQ0MyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKQEAgLTE1 NiwxMiArMTU2LDE4IEBAIGNsYXNzIENocm9taXVtV2luUG9ydChjaHJvbWl1bS5DaHJvbWl1bVBv cnQpOgogICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ2J1aWxkX2RpcmVjdG9yeScpOgogICAg ICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihzZWxmLmdldF9vcHRpb24oJ2J1 aWxkX2RpcmVjdG9yeScpLCAqY29tcHMpCiAKKyAgICAgICAgcCA9IHNlbGYucGF0aF9mcm9tX2No cm9taXVtX2Jhc2UoJ2J1aWxkJywgKmNvbXBzKQorICAgICAgICBpZiBzZWxmLl9maWxlc3lzdGVt LmV4aXN0cyhwKToKKyAgICAgICAgICAgIHJldHVybiBwCiAgICAgICAgIHAgPSBzZWxmLnBhdGhf ZnJvbV9jaHJvbWl1bV9iYXNlKCd3ZWJraXQnLCAqY29tcHMpCiAgICAgICAgIGlmIHNlbGYuX2Zp bGVzeXN0ZW0uZXhpc3RzKHApOgogICAgICAgICAgICAgcmV0dXJuIHAKICAgICAgICAgcCA9IHNl bGYucGF0aF9mcm9tX2Nocm9taXVtX2Jhc2UoJ2Nocm9tZScsICpjb21wcykKICAgICAgICAgaWYg c2VsZi5fZmlsZXN5c3RlbS5leGlzdHMocCk6CiAgICAgICAgICAgICByZXR1cm4gcAorICAgICAg ICBwID0gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYucGF0aF9mcm9tX3dlYmtpdF9iYXNlKCks ICdTb3VyY2UnLCAnV2ViS2l0JywgJ2Nocm9taXVtJywgJ2J1aWxkJywgKmNvbXBzKQorICAgICAg ICBpZiBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhwKToKKyAgICAgICAgICAgIHJldHVybiBwCiAg ICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5wYXRoX2Zyb21fd2Via2l0 X2Jhc2UoKSwgJ1NvdXJjZScsICdXZWJLaXQnLCAnY2hyb21pdW0nLCAqY29tcHMpCiAKICAgICBk ZWYgX3VzZXNfYXBhY2hlKHNlbGYpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW5fdW5pdHRlc3QucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbl91bml0dGVzdC5weQpp bmRleCA5OWQwNGNlNDZlOWEzYTI3NGM3MmJmMzExZTU5OTlmYzc1NmUyMzA2Li43YjE5MjRhMzBi OTc4MTBjNDQxZjY4ZmYxN2U4ZjJhMGM2ODVjNTQ3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbl91bml0dGVzdC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbl91 bml0dGVzdC5weQpAQCAtMzEsNiArMzEsNyBAQCBpbXBvcnQgc3lzCiBpbXBvcnQgdW5pdHRlc3QK IAogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtIGltcG9ydCBvdXRwdXRjYXB0dXJlCitmcm9t IHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZmlsZXN5c3RlbV9tb2NrIGltcG9ydCBNb2NrRmlsZVN5 c3RlbQogZnJvbSB3ZWJraXRweS50b29sIGltcG9ydCBtb2NrdG9vbAogCiBmcm9tIHdlYmtpdHB5 LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBjaHJvbWl1bV93aW4KQEAgLTEzNCw2ICsxMzUsMTcg QEAgY2xhc3MgQ2hyb21pdW1XaW5UZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToKICAg ICAgICAgcG9ydCA9IGNocm9taXVtX3dpbi5DaHJvbWl1bVdpblBvcnQocG9ydF9uYW1lPSdjaHJv bWl1bS13aW4td2luNycpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuYmFzZWxpbmVf cGF0aCgpLCBwb3J0Ll93ZWJraXRfYmFzZWxpbmVfcGF0aCgnY2hyb21pdW0td2luJykpCiAKKyAg ICBkZWYgdGVzdF9idWlsZF9wYXRoKHNlbGYpOgorICAgICAgICBtb2NrID0gTW9ja0ZpbGVTeXN0 ZW0oZmlsZXM9eworICAgICAgICAgICAgJy9tb2NrLWNoZWNrb3V0L1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vYnVpbGQvUmVsZWFzZS9EdW1wUmVuZGVyVHJlZS5leGUnOiAnZXhlJ30pCisKKyAgICAg ICAgcG9ydCA9IGNocm9taXVtX3dpbi5DaHJvbWl1bVdpblBvcnQoZmlsZXN5c3RlbT1tb2NrKQor ICAgICAgICBzZWxmLmFzc2VydEVxdWFscygKKyAgICAgICAgICAgICcvbW9jay1jaGVja291dC9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL2J1aWxkL1JlbGVhc2UvRHVtcFJlbmRlclRyZWUuZXhlJywK KyAgICAgICAgICAgIHBvcnQuX3BhdGhfdG9fZHJpdmVyKCdSZWxlYXNlJykpCisgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWxzKAorICAgICAgICAgICAgJy9tb2NrLWNoZWNrb3V0L1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vRGVidWcvRHVtcFJlbmRlclRyZWUuZXhlJywKKyAgICAgICAgICAgIHBvcnQu X3BhdGhfdG9fZHJpdmVyKCdEZWJ1ZycpKQogCiAKIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6 Cg==