67538 2011-09-02 16:32:46 -0700 Layout Test http/tests/security/xssAuditor/dom-write-innerHTML.html is flaky 2012-02-06 01:22:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED XSSAuditor P2 Normal --- 1 jamesr abarth abarth ap dbates eric haraken webkit.review.bot oldest_to_newest 461620 0 jamesr 2011-09-02 16:32:46 -0700 The following layout test is flaky on all platforms in debug http/tests/security/xssAuditor/dom-write-innerHTML.html Probable cause: I think the setTimeout() is failing the race against the img onerror handler, although I haven't looked too closely. Example failure diff: ALERT: /XSS/ 461734 1 ap 2011-09-02 22:06:12 -0700 This test is pretty old, was it always flaky? Seems unlikely that notifyDone() can trigger a failure alert, could be an actual bug. 549730 2 125571 abarth 2012-02-05 22:09:53 -0800 Created attachment 125571 Patch 549736 3 125571 haraken 2012-02-05 22:20:01 -0800 Comment on attachment 125571 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125571&action=review > LayoutTests/http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:9 > -</html> > \ No newline at end of file > +</html> What is the change for? 549737 4 125571 abarth 2012-02-05 22:21:27 -0800 Comment on attachment 125571 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125571&action=review >> LayoutTests/http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:9 >> +</html> > > What is the change for? vi just adds newlines at the end of the file. It's not needed to fix the bug. I can remove the newline again if you'd prefer. 549740 5 125571 haraken 2012-02-05 22:26:28 -0800 Comment on attachment 125571 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125571&action=review >>> LayoutTests/http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:9 >>> +</html> >> >> What is the change for? > > vi just adds newlines at the end of the file. It's not needed to fix the bug. I can remove the newline again if you'd prefer. Then, maybe we can remove the "\ No newline at end of file" line (because now the comment has no meaning). 549744 6 abarth 2012-02-05 22:33:57 -0800 > Then, maybe we can remove the "\ No newline at end of file" line (because now the comment has no meaning). Oh, that's just added by the diff tool. It's not something that ends up in the repository. 549745 7 haraken 2012-02-05 22:35:25 -0800 (In reply to comment #6) > > Then, maybe we can remove the "\ No newline at end of file" line (because now the comment has no meaning). > > Oh, that's just added by the diff tool. It's not something that ends up in the repository. Ah, I got it:-) 549824 8 125571 webkit.review.bot 2012-02-06 01:22:44 -0800 Comment on attachment 125571 Patch Clearing flags on attachment: 125571 Committed r106785: <http://trac.webkit.org/changeset/106785> 549825 9 webkit.review.bot 2012-02-06 01:22:49 -0800 All reviewed patches have been landed. Closing bug. 125571 2012-02-05 22:09:53 -0800 2012-02-06 01:22:44 -0800 Patch bug-67538-20120205220951.patch text/plain 3873 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwNjc3NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTA1ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC90ZXN0cy9zZWN1cml0 eS94c3NBdWRpdG9yL2RvbS13cml0ZS1pbm5lckhUTUwuaHRtbCBpcyBmbGFreQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc1MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcnkgdG8gZml4IHRoZSBmbGFr aW5lc3MgaW4gdGhpcyB0ZXN0IGJ5IGtpY2tpbmcgb2ZmIHRoZSA8aW1nPiBsb2FkCisgICAgICAg IGJlZm9yZSB0aGUgbG9hZCBldmVudCBoYXMgZmlyZWQgZm9yIHRoZSBpbm5lciBmcmFtZS4gIFRo YXQgd2F5LCB0aGUKKyAgICAgICAgbG9hZCBldmVudCBmb3IgdGhlIG1haW4gZnJhbWUgd2lsbCBi ZSBkZWxheWVkIHVudGlsIHRoZSBpbWFnZSBmaW5pc2hlcworICAgICAgICBsb2FkaW5nIChhbmQg aXRzIGVycm9yIGhhbmRsZXIgaGFzIGZpcmVkKSwgcmVtb3ZpbmcgdGhlIG5lZWQgZm9yIHRoZQor ICAgICAgICBzZXRUaW1lb3V0LgorCisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS94c3NB dWRpdG9yL2RvbS13cml0ZS1pbm5lckhUTUwuaHRtbDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3Nl Y3VyaXR5L3hzc0F1ZGl0b3IvcmVzb3VyY2VzL2VjaG8tZG9tLXdyaXRlLWlubmVySFRNTC5odG1s OgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwog MjAxMi0wMi0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIHhz cy1ERU5JRUQtZnJvbS1kYXRhLXVybC1pbi1mb3JlaWduLWRvbWFpbi1zdWJmcmFtZS5odG1sIGlz IGZsYWt5CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1ZGl0b3Iv ZG9tLXdyaXRlLWlubmVySFRNTC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAv dGVzdHMvc2VjdXJpdHkveHNzQXVkaXRvci9kb20td3JpdGUtaW5uZXJIVE1MLmh0bWwJKHJldmlz aW9uIDEwNjc2MSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkveHNzQXVkaXRv ci9kb20td3JpdGUtaW5uZXJIVE1MLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTksOSArOSw5IEBA IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKIH0KIAogd2luZG93Lm9ubG9hZCA9 IGZ1bmN0aW9uKCkgewotICAgIC8vIEdpdmUgdGhlIGltZyBvbmVycm9yIGhhbmRsZXIgYSBjaGFu Y2UgdG8gZmlyZS4KLSAgICBzZXRUaW1lb3V0KCJsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlE b25lKCkiLCAxMDApOwotfQorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK307CiA8L3NjcmlwdD4K IDwvaGVhZD4KIDxib2R5PgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS94 c3NBdWRpdG9yL3Jlc291cmNlcy9lY2hvLWRvbS13cml0ZS1pbm5lckhUTUwuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1ZGl0b3IvcmVzb3Vy Y2VzL2VjaG8tZG9tLXdyaXRlLWlubmVySFRNTC5odG1sCShyZXZpc2lvbiAxMDY3NjEpCisrKyBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1ZGl0b3IvcmVzb3VyY2VzL2VjaG8t ZG9tLXdyaXRlLWlubmVySFRNTC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDggKzEsOCBAQAog PCFET0NUWVBFIGh0bWw+CiA8aHRtbD4KLTxoZWFkPgotPHNjcmlwdD53aW5kb3cub25sb2FkID0g ZnVuY3Rpb24gKCkge2RvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gdW5lc2NhcGUod2luZG93Lmxv Y2F0aW9uKTt9PC9zY3JpcHQ+Ci08L2hlYWQ+CiA8Ym9keT4KKzxzY3JpcHQ+Citkb2N1bWVudC5i b2R5LmlubmVySFRNTCA9IHVuZXNjYXBlKHdpbmRvdy5sb2NhdGlvbik7Cis8L3NjcmlwdD4KIDwv Ym9keT4KLTwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCis8L2h0bWw+CkluZGV4 OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0CShyZXZpc2lvbiAxMDY3NzQpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTc3OCwxNCArNzc4LDE0 IEBAIEJVR0NSMjAzNDUgOiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWYKIEJVR0NSNDIwNDQg V0lOIDogaHR0cC90ZXN0cy9zZWN1cml0eS94c3MtREVOSUVELW1pbWUtdHlwZS1leGVjdXRlLWFz LWh0bWwuaHRtbCA9IFBBU1MgVElNRU9VVAogQlVHV0s0Mjc2OSA6IGh0dHAvdGVzdHMvc2VjdXJp dHkvNDAxLWxvZ291dC80MDEtbG9nb3V0LnBocCA9IFRJTUVPVVQKIEJVR0RQUkFOS0UgV0lOIDog aHR0cC90ZXN0cy9zZWN1cml0eS9jcmVkZW50aWFscy1pbi1yZWZlcmVyLmh0bWwgPSBQQVNTIFRJ TUVPVVQKLUJVR0NSNTQzNDggTElOVVggUkVMRUFTRSA6IGh0dHAvdGVzdHMvc2VjdXJpdHkveHNz QXVkaXRvci9kb20td3JpdGUtaW5uZXJIVE1MLmh0bWwgPSBQQVNTIFRFWFQKLUJVR1dLNjc1Mzgg REVCVUcgOiBodHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1ZGl0b3IvZG9tLXdyaXRlLWlubmVySFRN TC5odG1sID0gUEFTUyBURVhUCiBCVUdfTEVWSU4gREVCVUcgOiBodHRwL3Rlc3RzL3NlY3VyaXR5 L21peGVkQ29udGVudC9pbnNlY3VyZS1pbWFnZS1pbi1tYWluLWZyYW1lLmh0bWwgPSBQQVNTIFRF WFQKIEJVR1dLNzAyOTggOiBodHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1ZGl0b3IvY29va2llLWlu amVjdGlvbi5odG1sID0gVEVYVCBQQVNTCiBCVUdDUjI0MTgyIFdJTiBSRUxFQVNFIDogaHR0cC90 ZXN0cy9zZWN1cml0eS9jcm9zcy1vcmlnaW4tY3NzLmh0bWwgPSBQQVNTIFRJTUVPVVQKIAogLy8g SG9wZWZ1bGx5IGZpeGVkIGZsYWtpbmVzcyAobmVlZCB0byB2ZXJpZnkgd2l0aCBkYXNoYm9hcmQp LgogQlVHQ1I5Nzk4IFJFTEVBU0UgOiBodHRwL3Rlc3RzL3NlY3VyaXR5L2RhdGFVUkwveHNzLURF TklFRC1mcm9tLWRhdGEtdXJsLWluLWZvcmVpZ24tZG9tYWluLXN1YmZyYW1lLmh0bWwgPSBQQVNT IFRJTUVPVVQKK0JVR0NSNTQzNDggTElOVVggUkVMRUFTRSA6IGh0dHAvdGVzdHMvc2VjdXJpdHkv eHNzQXVkaXRvci9kb20td3JpdGUtaW5uZXJIVE1MLmh0bWwgPSBQQVNTIFRFWFQKK0JVR1dLNjc1 MzggREVCVUcgOiBodHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1ZGl0b3IvZG9tLXdyaXRlLWlubmVy SFRNTC5odG1sID0gUEFTUyBURVhUCiAKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAvLyBQbHVnaW4gdGVzdHMK