67530 2011-09-02 15:13:03 -0700 Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately 2011-09-12 13:05:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67557 56729 1 eric eric abarth rniwa webkit.review.bot oldest_to_newest 461563 0 eric 2011-09-02 15:13:03 -0700 Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately 461565 1 106205 eric 2011-09-02 15:15:24 -0700 Created attachment 106205 Patch 461566 2 eric 2011-09-02 15:19:23 -0700 Committed r94453: <http://trac.webkit.org/changeset/94453> 461763 3 rniwa 2011-09-02 23:56:23 -0700 This patch appears to have broken various bots http://build.webkit.org/builders/Qt%20Linux%20Release/builds/37102 http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/32807 http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/25701 461765 4 rniwa 2011-09-03 00:02:11 -0700 I have confirmed that this patch is causing the failures. Since these failures are preventing the rest of tests to run, I'm going to rollout the patch for now unless either one of you can fix it in the next 10 minutes or so. 461773 5 rniwa 2011-09-03 00:29:04 -0700 Rolled the patch out in http://trac.webkit.org/changeset/94481. 461774 6 106205 webkit.review.bot 2011-09-03 00:32:13 -0700 Comment on attachment 106205 Patch Rejecting attachment 106205 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/layout_tests/port/webkit.py Hunk #1 FAILED at 509. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitpy/layout_tests/port/webkit.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9587229 461783 7 rniwa 2011-09-03 00:44:49 -0700 Also rolled out the unreviewed followup in http://trac.webkit.org/changeset/94483. 461788 8 eric 2011-09-03 01:17:41 -0700 Thanks Ryosuke. 464948 9 eric 2011-09-09 11:43:11 -0700 I guess I'll try this again. :) 465748 10 eric 2011-09-12 12:59:51 -0700 I found the bug in the original patch, fixed. I also realize now that this is subtly changing behavior. Before we were not correctly respecting the deadline. This should make our timeouts much more accurate, as we're re-computing when the timeout is every time we read a line, instead of computing up front that we should wait 30 seconds, and then making every read wait 30 seconds. The old code would wait forever for a test which slowly produced output. 465754 11 eric 2011-09-12 13:05:45 -0700 Committed r94973: <http://trac.webkit.org/changeset/94973> 106205 2011-09-02 15:15:24 -0700 2011-09-03 00:32:13 -0700 Patch bug-67530-20110902151523.patch text/plain 4248 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ0NDgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1M2ZmNTY3M2E4YzI4NTk3NTdjMWM3YTg1MDhmYzUxZmM4 M2Q4NDMxLi5kN2RkYWNiMjJhMThmMjA4NmNjMzhkMmRjOGI2OTMzOThiMGZlZWQ4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDktMDIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJlc2h1ZmZsZSBzb21lIGNvZGUgaW4gV2ViS2l0RHJpdmVyLl9yZWFkX2Jsb2NrIGluIHByZXBh cmF0aW9uIGZvciByZWFkaW5nIHN0ZGVyci9zdGRvdXQgc2VwYXJhdGVseQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc1MzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBmdW5jdGlvbmFsIGNoYW5nZSwg anVzdCByZXNodWZmbGluZyBjb2RlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHk6CisKIDIwMTEtMDktMDIgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGVkIFN1YnZlcnNpb24gaWdub3JlIGZvciAucHlj IGdlbmVyYXRlZCBmaWxlcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXggYTg0YzY5OGJkN2JhNDJhZWY0ZWJhNmI4NGVkYTM4 MGE0MzhkMzliNy4uODYwYjAxYTUxMzQxMmQ0MGNlM2RhMzc5NGFlZjMzNDM3ZGZkMzhjNyAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQu cHkKQEAgLTUwOSw0NCArNTA5LDQ2IEBAIGNsYXNzIFdlYktpdERyaXZlcihEcml2ZXIpOgogICAg ICAgICAgICAgY3Jhc2g9c2VsZi5kZXRlY3RlZF9jcmFzaCgpLCB0ZXN0X3RpbWU9dGltZS50aW1l KCkgLSBzdGFydF90aW1lLAogICAgICAgICAgICAgdGltZW91dD1zZWxmLl9zZXJ2ZXJfcHJvY2Vz cy50aW1lZF9vdXQsIGVycm9yPWVycm9yKQogCisgICAgTEVOR1RIX0hFQURFUiA9ICdDb250ZW50 LUxlbmd0aDogJworICAgIEhBU0hfSEVBREVSID0gJ0FjdHVhbEhhc2g6ICcKKyAgICBUWVBFX0hF QURFUiA9ICdDb250ZW50LVR5cGU6ICcKKyAgICBFTkNPRElOR19IRUFERVIgPSAnQ29udGVudC1U cmFuc2Zlci1FbmNvZGluZzogJworCisgICAgZGVmIF9yZWFkX2xpbmVfdW50aWwoc2VsZiwgZGVh ZGxpbmUpOgorICAgICAgICByZXR1cm4gc2VsZi5fc2VydmVyX3Byb2Nlc3MucmVhZF9saW5lKGRl YWRsaW5lIC0gdGltZS50aW1lKCkpCisKICAgICBkZWYgX3JlYWRfYmxvY2soc2VsZiwgZGVhZGxp bmUpOgotICAgICAgICBMRU5HVEhfSEVBREVSID0gJ0NvbnRlbnQtTGVuZ3RoOiAnCi0gICAgICAg IEhBU0hfSEVBREVSID0gJ0FjdHVhbEhhc2g6ICcKLSAgICAgICAgVFlQRV9IRUFERVIgPSAnQ29u dGVudC1UeXBlOiAnCi0gICAgICAgIEVOQ09ESU5HX0hFQURFUiA9ICdDb250ZW50LVRyYW5zZmVy LUVuY29kaW5nOiAnCiAgICAgICAgIGNvbnRlbnRfdHlwZSA9IE5vbmUKICAgICAgICAgZW5jb2Rp bmcgPSBOb25lCiAgICAgICAgIGNvbnRlbnRfaGFzaCA9IE5vbmUKICAgICAgICAgY29udGVudF9s ZW5ndGggPSBOb25lCiAKICAgICAgICAgIyBDb250ZW50IGlzIHRyZWF0ZWQgYXMgYmluYXJ5IGRh dGEgZXZlbiB0aG91Z2ggdGhlIHRleHQgb3V0cHV0IGlzIHVzdWFsbHkgVVRGLTguCi0gICAgICAg IGNvbnRlbnQgPSAnJwotICAgICAgICB0aW1lb3V0ID0gZGVhZGxpbmUgLSB0aW1lLnRpbWUoKQot ICAgICAgICBsaW5lID0gc2VsZi5fc2VydmVyX3Byb2Nlc3MucmVhZF9saW5lKHRpbWVvdXQpCisg ICAgICAgIGNvbnRlbnQgPSBzdHIoKSAgIyBGSVhNRTogU2hvdWxkIGJlIGJ5dGVhcnJheSgpIG9u Y2Ugd2UgcmVxdWlyZSBQeXRob24gMi42LgorICAgICAgICBsaW5lID0gc2VsZi5fcmVhZF9saW5l X3VudGlsKGRlYWRsaW5lIC0gdGltZS50aW1lKCkpCiAgICAgICAgIGVvZiA9IEZhbHNlCiAgICAg ICAgIHdoaWxlIChub3Qgc2VsZi5fc2VydmVyX3Byb2Nlc3MudGltZWRfb3V0IGFuZCBub3Qgc2Vs Zi5kZXRlY3RlZF9jcmFzaCgpIGFuZCBub3QgZW9mKToKLSAgICAgICAgICAgIGNob21wZWRfbGlu ZSA9IGxpbmUucnN0cmlwKCkKKyAgICAgICAgICAgIGNob21wZWRfbGluZSA9IGxpbmUucnN0cmlw KCkgICMgRklYTUU6IFRoaXMgd2lsbCByZW1vdmUgdHJhaWxpbmcgbGluZXMgZnJvbSB0ZXN0IG91 dHB1dC4gIElzIHRoYXQgcmlnaHQ/CiAgICAgICAgICAgICBpZiBjaG9tcGVkX2xpbmUuZW5kc3dp dGgoIiNFT0YiKToKICAgICAgICAgICAgICAgICBlb2YgPSBUcnVlCiAgICAgICAgICAgICAgICAg bGluZSA9IGNob21wZWRfbGluZVs6LTRdCiAKICAgICAgICAgICAgIGlmIGxpbmUuc3RhcnRzd2l0 aChUWVBFX0hFQURFUikgYW5kIGNvbnRlbnRfdHlwZSBpcyBOb25lOgogICAgICAgICAgICAgICAg IGNvbnRlbnRfdHlwZSA9IGxpbmUuc3BsaXQoKVsxXQotICAgICAgICAgICAgZWxpZiBsaW5lLnN0 YXJ0c3dpdGgoRU5DT0RJTkdfSEVBREVSKSBhbmQgZW5jb2RpbmcgaXMgTm9uZToKKyAgICAgICAg ICAgIGVsaWYgbGluZS5zdGFydHN3aXRoKHNlbGYuRU5DT0RJTkdfSEVBREVSKSBhbmQgZW5jb2Rp bmcgaXMgTm9uZToKICAgICAgICAgICAgICAgICBlbmNvZGluZyA9IGxpbmUuc3BsaXQoKVsxXQot ICAgICAgICAgICAgZWxpZiBsaW5lLnN0YXJ0c3dpdGgoTEVOR1RIX0hFQURFUikgYW5kIGNvbnRl bnRfbGVuZ3RoIGlzIE5vbmU6Ci0gICAgICAgICAgICAgICAgdGltZW91dCA9IGRlYWRsaW5lIC0g dGltZS50aW1lKCkKLSAgICAgICAgICAgICAgICBjb250ZW50X2xlbmd0aCA9IGludChsaW5lW2xl bihMRU5HVEhfSEVBREVSKTpdKQotICAgICAgICAgICAgICAgICMgRklYTUU6IFRlY2huaWNhbGx5 IHRoZXJlIHNob3VsZCBwcm9iYWJseSBiZSBhbm90aGVyIGJsYW5rCi0gICAgICAgICAgICAgICAg IyBsaW5lIGhlcmUsIGJ1dCBEUlQgZG9lc24ndCB3cml0ZSBvbmUuCi0gICAgICAgICAgICAgICAg Y29udGVudCA9IHNlbGYuX3NlcnZlcl9wcm9jZXNzLnJlYWQodGltZW91dCwgY29udGVudF9sZW5n dGgpCi0gICAgICAgICAgICBlbGlmIGxpbmUuc3RhcnRzd2l0aChIQVNIX0hFQURFUik6CisgICAg ICAgICAgICBlbGlmIGxpbmUuc3RhcnRzd2l0aChzZWxmLkxFTkdUSF9IRUFERVIpIGFuZCBjb250 ZW50X2xlbmd0aCBpcyBOb25lOgorICAgICAgICAgICAgICAgIGNvbnRlbnRfbGVuZ3RoID0gaW50 KGxpbmVbbGVuKHNlbGYuTEVOR1RIX0hFQURFUik6XSkKKyAgICAgICAgICAgICAgICAjIEZJWE1F OiBJbiByZWFsIEhUVFAgdGhlcmUgc2hvdWxkIHByb2JhYmx5IGJlIGEgYmxhbmsgbGluZQorICAg ICAgICAgICAgICAgICMgYWZ0ZXIgaGVhZGVycyBiZWZvcmUgY29udGVudCwgYnV0IERSVCBkb2Vz bid0IHdyaXRlIG9uZS4KKyAgICAgICAgICAgICAgICBjb250ZW50ID0gc2VsZi5fc2VydmVyX3By b2Nlc3MucmVhZChkZWFkbGluZSAtIHRpbWUudGltZSgpLCBjb250ZW50X2xlbmd0aCkKKyAgICAg ICAgICAgIGVsaWYgbGluZS5zdGFydHN3aXRoKHNlbGYuSEFTSF9IRUFERVIpOgogICAgICAgICAg ICAgICAgIGNvbnRlbnRfaGFzaCA9IGxpbmUuc3BsaXQoKVsxXQogICAgICAgICAgICAgZWxpZiBs aW5lOgogICAgICAgICAgICAgICAgIGNvbnRlbnQgKz0gbGluZQotICAgICAgICAgICAgaWYgbm90 IGVvZjoKLSAgICAgICAgICAgICAgICBsaW5lID0gc2VsZi5fc2VydmVyX3Byb2Nlc3MucmVhZF9s aW5lKHRpbWVvdXQpCi0gICAgICAgICAgICAgICAgdGltZW91dCA9IGRlYWRsaW5lIC0gdGltZS50 aW1lKCkKKyAgICAgICAgICAgIGlmIGVvZjoKKyAgICAgICAgICAgICAgICBicmVhaworICAgICAg ICAgICAgbGluZSA9IHNlbGYuX3JlYWRfbGluZV91bnRpbChkZWFkbGluZSkKICAgICAgICAgcmV0 dXJuIENvbnRlbnRCbG9jayhjb250ZW50X3R5cGUsIGVuY29kaW5nLCBjb250ZW50X2hhc2gsIGNv bnRlbnQpCiAKICAgICBkZWYgc3RvcChzZWxmKToK