67526 2011-09-02 14:56:45 -0700 Add WKContext API to garbage collect JavaScript objects 2011-09-02 20:06:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67546 1 adachan adachan andersca jchaffraix sam slewis oldest_to_newest 461551 0 adachan 2011-09-02 14:56:45 -0700 Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in JavaScript in the WebProcess. 461557 1 106204 adachan 2011-09-02 15:05:35 -0700 Created attachment 106204 Patch 461569 2 adachan 2011-09-02 15:20:51 -0700 Committed: http://trac.webkit.org/changeset/94454 461661 3 jchaffraix 2011-09-02 17:35:55 -0700 This patch broke Windows: 5>..\WebProcess\WebProcess.cpp(939) : error C2228: left of '.garbageCollectNow' must have class/struct/union 5> type is ''unknown-type'' 5>..\WebProcess\WebProcess.cpp(939) : error C3861: 'gcController': identifier not found (http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/20560/steps/compile-webkit/logs/stdio) Do you have any plans to fix that soon or should we roll the patch out? 461712 4 jchaffraix 2011-09-02 20:06:41 -0700 FYI the patch got rolled out just after Michael Saboff fixed the release builds. The patch was rolled back in shortly after. 106204 2011-09-02 15:05:35 -0700 2011-09-02 15:15:10 -0700 Patch 67526.patch.txt text/plain 4916 adachan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0NDUwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDktMDIgIEFkYSBDaGFu ICA8YWRhY2hhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIFdLQ29udGV4dEdhcmJhZ2VDb2xs ZWN0SmF2YVNjcmlwdE9iamVjdHMoKSB3aGljaCBkb2VzIGEgZ2FyYmFnZSBjb2xsZWN0aW9uIGlu IHRoZSBXZWJQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NzUyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHA6CisgICAgICAgIChXS0NvbnRl eHRHYXJiYWdlQ29sbGVjdEphdmFTY3JpcHRPYmplY3RzKToKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0MvV0tDb250ZXh0Lmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0OjpnYXJiYWdlQ29sbGVjdEphdmFTY3JpcHRPYmpl Y3RzKTogU2VuZCBhIG1lc3NhZ2UgdG8gV2ViUHJvY2VzcyB0byBnYXJiYWdlIGNvbGxlY3QgSlMg b2JqZWN0cy4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5oOgorICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6Omdh cmJhZ2VDb2xsZWN0SmF2YVNjcmlwdE9iamVjdHMpOiBDYWxsIEdDQ29udHJvbGxlcjo6Z2FyYmFn ZUNvbGxlY3ROb3coKS4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuaDoKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MubWVzc2FnZXMuaW46IEFkZCBHYXJiYWdlQ29sbGVj dEphdmFTY3JpcHRPYmplY3RzIG1lc3NhZ2UuCisKIDIwMTEtMDktMDIgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgcGx1Zy1pbiBwYXRocyBm cm9tIHdlYiBwcm9jZXNzIHNhbmRib3gKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi Q29udGV4dC5jcHAJKHJldmlzaW9uIDk0MzY5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYkNvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MjksNCArODI5LDkgQEAgdm9pZCBX ZWJDb250ZXh0OjpkaWRHZXRXZWJDb3JlU3RhdGlzdGljcwogICAgIGNhbGxiYWNrLT5wZXJmb3Jt Q2FsbGJhY2tXaXRoUmV0dXJuVmFsdWUoc3RhdGlzdGljcy5nZXQoKSk7CiB9CiAgICAgCit2b2lk IFdlYkNvbnRleHQ6OmdhcmJhZ2VDb2xsZWN0SmF2YVNjcmlwdE9iamVjdHMoKQoreworICAgIHBy b2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2ViUHJvY2Vzczo6R2FyYmFnZUNvbGxlY3RKYXZhU2Ny aXB0T2JqZWN0cygpLCAwKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgJKHJldmlzaW9uIDk0MzY5KQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAkod29ya2luZyBjb3B5KQpAQCAtMTgxLDYg KzE4MSw3IEBAIHB1YmxpYzoKICAgICBib29sIGh0dHBQaXBlbGluaW5nRW5hYmxlZCgpOwogICAg IAogICAgIHZvaWQgZ2V0V2ViQ29yZVN0YXRpc3RpY3MoUGFzc1JlZlB0cjxEaWN0aW9uYXJ5Q2Fs bGJhY2s+KTsKKyAgICB2b2lkIGdhcmJhZ2VDb2xsZWN0SmF2YVNjcmlwdE9iamVjdHMoKTsKIAog cHJpdmF0ZToKICAgICBXZWJDb250ZXh0KFByb2Nlc3NNb2RlbCwgY29uc3QgU3RyaW5nJiBpbmpl Y3RlZEJ1bmRsZVBhdGgpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dL Q29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D L1dLQ29udGV4dC5jcHAJKHJldmlzaW9uIDk0MzY5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzNywzICsyMzcsOCBA QCB2b2lkIFdLQ29udGV4dEdldFN0YXRpc3RpY3MoV0tDb250ZXh0UmVmCiAgICAgdG9JbXBsKGNv bnRleHRSZWYpLT5nZXRXZWJDb3JlU3RhdGlzdGljcyhEaWN0aW9uYXJ5Q2FsbGJhY2s6OmNyZWF0 ZShjb250ZXh0LCBjYWxsYmFjaykpOyAgICAKIH0KIAordm9pZCBXS0NvbnRleHRHYXJiYWdlQ29s bGVjdEphdmFTY3JpcHRPYmplY3RzKFdLQ29udGV4dFJlZiBjb250ZXh0UmVmKQoreworICAgIHRv SW1wbChjb250ZXh0UmVmKS0+Z2FyYmFnZUNvbGxlY3RKYXZhU2NyaXB0T2JqZWN0cygpOworfQor CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5oCShyZXZp c2lvbiA5NDM2OSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQu aAkod29ya2luZyBjb3B5KQpAQCAtMTQwLDYgKzE0MCw4IEBAIFdLX0VYUE9SVCBXS1Jlc291cmNl Q2FjaGVNYW5hZ2VyUmVmIFdLQ28KICAgICAKIHR5cGVkZWYgdm9pZCAoKldLQ29udGV4dEdldFN0 YXRpc3RpY3NGdW5jdGlvbikoV0tEaWN0aW9uYXJ5UmVmIHN0YXRpc3RpY3MsIFdLRXJyb3JSZWYg ZXJyb3IsIHZvaWQqIGZ1bmN0aW9uQ29udGV4dCk7CiBXS19FWFBPUlQgdm9pZCBXS0NvbnRleHRH ZXRTdGF0aXN0aWNzKFdLQ29udGV4dFJlZiBjb250ZXh0LCB2b2lkKiBmdW5jdGlvbkNvbnRleHQs IFdLQ29udGV4dEdldFN0YXRpc3RpY3NGdW5jdGlvbiBmdW5jdGlvbik7CisgICAgCitXS19FWFBP UlQgdm9pZCBXS0NvbnRleHRHYXJiYWdlQ29sbGVjdEphdmFTY3JpcHRPYmplY3RzKFdLQ29udGV4 dFJlZiBjb250ZXh0KTsKIAogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHJldmlzaW9uIDk0MzcxKQorKysgU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTMy LDYgKzkzMiwxMSBAQCB2b2lkIFdlYlByb2Nlc3M6OmdldFdlYkNvcmVTdGF0aXN0aWNzKHVpCiAg ICAgbV9jb25uZWN0aW9uLT5zZW5kKE1lc3NhZ2VzOjpXZWJDb250ZXh0OjpEaWRHZXRXZWJDb3Jl U3RhdGlzdGljcyhkYXRhLCBjYWxsYmFja0lEKSwgMCk7CiB9CiAKK3ZvaWQgV2ViUHJvY2Vzczo6 Z2FyYmFnZUNvbGxlY3RKYXZhU2NyaXB0T2JqZWN0cygpCit7CisgICAgZ2NDb250cm9sbGVyKCku Z2FyYmFnZUNvbGxlY3ROb3coKTsKK30KKwogI2lmIEVOQUJMRShQTFVHSU5fUFJPQ0VTUykKIHZv aWQgV2ViUHJvY2Vzczo6cGx1Z2luUHJvY2Vzc0NyYXNoZWQoY29uc3QgU3RyaW5nJiBwbHVnaW5Q YXRoKQogewpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgJKHJldmlz aW9uIDk0MzY5KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgJKHdv cmtpbmcgY29weSkKQEAgLTE3OCw2ICsxNzgsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgc2V0VGV4 dENoZWNrZXJTdGF0ZShjb25zdCBUZXh0Q2hlY2tlclN0YXRlJik7CiAgICAgCiAgICAgdm9pZCBn ZXRXZWJDb3JlU3RhdGlzdGljcyh1aW50NjRfdCBjYWxsYmFja0lEKTsKKyAgICB2b2lkIGdhcmJh Z2VDb2xsZWN0SmF2YVNjcmlwdE9iamVjdHMoKTsKIAogICAgIC8vIENoaWxkUHJvY2VzcwogICAg IHZpcnR1YWwgYm9vbCBzaG91bGRUZXJtaW5hdGUoKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUHJvY2Vzcy5tZXNzYWdlcy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MubWVzc2FnZXMuaW4JKHJldmlzaW9uIDk0MzY5KQor KysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLm1lc3NhZ2VzLmluCSh3b3Jr aW5nIGNvcHkpCkBAIC02OSw0ICs2OSw1IEBAIG1lc3NhZ2VzIC0+IFdlYlByb2Nlc3MgewogICAg IFNldEVuaGFuY2VkQWNjZXNzaWJpbGl0eShib29sIGZsYWcpCiAKICAgICBHZXRXZWJDb3JlU3Rh dGlzdGljcyh1aW50NjRfdCBjYWxsYmFja0lEKQorICAgIEdhcmJhZ2VDb2xsZWN0SmF2YVNjcmlw dE9iamVjdHMoKQogfQo=