67522 2011-09-02 14:09:23 -0700 REGRESSION: Moving up doesn't work in some cases 2011-09-12 16:32:03 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://plexode.com/eval3/#ht=%3Cdiv%20contenteditable%3Dtrue%3E%0A%3Cdiv%3Efoo%20bar%20foo%20bar%20skldjf%20klasdfj%20klasjdf%20kljas%20dklfja%20skdfj%20aksldjf%20kljsd%20fkljasd%20fkljas%20dfklj%20asdklfj%20klsdjfkljsd%20fkljsdfklj%20askldfj%20klasdjf%20laksdj%20sjhdfklasjdfkl%20ajsdklfj%20asdj%20flksjd%20klja%20sdfklj%20asdkljf%20lkadf%20lkj%20sdfjasdj%20flj%20asdfj%20a%20sdkfj%20j%20sdfjal%3Bdskfj%20%3Bj%20s%3Bdlfja%3Bsf%26nbsp%3B%3C%2Fdiv%3E%3Cdiv%3E%3Cbr%3E%3C%2Fdiv%3E%0A%3C%2Fdiv%3E&ohh=1&ohj=1&jt=&ojh=1&ojj=1&ms=100&oth=0&otj=0&cex=1 P1 Normal --- 1 rniwa rniwa ap cshu enrica eric sullivan tony wcarss oldest_to_newest 461511 0 rniwa 2011-09-02 14:09:23 -0700 In the attached url, the caret should appear on the second line, NOT on the first line. i.e. when moving upwards, WebKit not skips lines that are soft-wrapped. 465815 1 107089 rniwa 2011-09-12 15:02:13 -0700 Created attachment 107089 fixes the bug 465816 2 107089 eric 2011-09-12 15:04:17 -0700 Comment on attachment 107089 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=107089&action=review > Source/WebCore/editing/visible_units.cpp:536 > + Position pos = n->hasTagName(brTag) ? positionBeforeNode(n) : createLegacyEditingPosition(n, caretMaxOffset(n)); Should this be a helper inline? Is this concept needed elsewhere? 465819 3 107089 rniwa 2011-09-12 15:07:33 -0700 Comment on attachment 107089 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=107089&action=review >> Source/WebCore/editing/visible_units.cpp:536 >> + Position pos = n->hasTagName(brTag) ? positionBeforeNode(n) : createLegacyEditingPosition(n, caretMaxOffset(n)); > > Should this be a helper inline? Is this concept needed elsewhere? Maybe. I think I need to clean up as a part of getting rid of createLegacyEditingPosition. This is a problem whenever we create positions using caretMinOffset/caretMaxOffset. There's a very interesting interactions between TextIterator and other iteration classes, visible_units, and VisiblePosition and caretMinOffset/caretMaxOffset so I've been postponing it for now. 465934 4 rniwa 2011-09-12 16:31:03 -0700 Committed r94988: <http://trac.webkit.org/changeset/94988> 465935 5 rniwa 2011-09-12 16:32:03 -0700 Thanks for the review! landing it now. 107089 2011-09-12 15:02:13 -0700 2011-09-12 15:07:33 -0700 fixes the bug bug-67522-20110912150212.patch text/plain 4136 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0OTgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDktMTIgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTjogTW92aW5nIHVw IGRvZXNuJ3Qgd29yayBpbiBzb21lIGNhc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzUyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBidWcgd2FzIGNhdXNlZCBieSBwcmV2aW91c0xpbmVQb3Np dGlvbidzIGF0dGVtcHRpbmcgdG8gb2J0YWluIHRoZSBsYXN0IHJvb3QgbGluZSBib3ggdXNpbmcK KyAgICAgICAgYSBwb3NpdGlvbiBhdCBtaW5DYXJldE9mZnNldCAod2hpY2ggaXMsIGluIHByYWN0 aWNlLCBsb2NhdGVkIGF0IHRoZSBiZWdpbm5pbmcgb2Ygd3JhcHBlZCBsaW5lcykuCisKKyAgICAg ICAgRml4IHRoZSBidWcgYnkgY2FsbGluZyBtYXhDYXJldE9mZnNldCBpbnN0ZWFkLiBCZWNhdXNl IGlzQ2FuZGlkYXRlIHJldHVybnMgZmFsc2UgYXQgKGJyLCAxKSwKKyAgICAgICAgdXNlIHRoZSBw b3NpdGlvbkJlZm9yZU5vZGUgZm9yIGJyIGVsZW1lbnRzLgorCisgICAgICAgIFRlc3Q6IGVkaXRp bmcvc2VsZWN0aW9uL21vdmUtdXAtaW50by13cmFwcGVkLWxpbmUuaHRtbAorCisgICAgICAgICog ZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnByZXZpb3VzTGlu ZVBvc2l0aW9uKToKKwogMjAxMS0wOS0xMiAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3ODk4 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAJKHJldmlzaW9u IDk0OTYxKQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNTMzLDcgKzUzMyw3IEBAIFZpc2libGVQb3NpdGlvbiBwcmV2aW91c0xp bmVQb3NpdGlvbihjb24KICAgICAgICAgd2hpbGUgKG4pIHsKICAgICAgICAgICAgIGlmIChoaWdo ZXN0RWRpdGFibGVSb290KGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShuKSkgIT0gaGlnaGVz dFJvb3QpCiAgICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICBQb3NpdGlvbiBwb3Mg PSBjcmVhdGVMZWdhY3lFZGl0aW5nUG9zaXRpb24obiwgY2FyZXRNaW5PZmZzZXQobikpOworICAg ICAgICAgICAgUG9zaXRpb24gcG9zID0gbi0+aGFzVGFnTmFtZShiclRhZykgPyBwb3NpdGlvbkJl Zm9yZU5vZGUobikgOiBjcmVhdGVMZWdhY3lFZGl0aW5nUG9zaXRpb24obiwgY2FyZXRNYXhPZmZz ZXQobikpOwogICAgICAgICAgICAgaWYgKHBvcy5pc0NhbmRpZGF0ZSgpKSB7CiAgICAgICAgICAg ICAgICAgcG9zLmdldElubGluZUJveEFuZE9mZnNldChET1dOU1RSRUFNLCBib3gsIGlnbm9yZWRD YXJldE9mZnNldCk7CiAgICAgICAgICAgICAgICAgaWYgKGJveCkgewpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gOTQ5ODApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxOCBAQAorMjAxMS0wOS0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K KworICAgICAgICBSRUdSRVNTSU9OOiBNb3ZpbmcgdXAgZG9lc24ndCB3b3JrIGluIHNvbWUgY2Fz ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NTIy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEg dGVzdCB0byBtb3ZlIGNhcmV0IHVwd2FyZHMgZnJvbSBhbiBlbXB0eSBsaW5lIGJlbG93IHdyYXBw ZWQgbGluZXMuCisKKyAgICAgICAgV2ViS2l0IHVzZWQgdG8gc2tpcCB3cmFwcGVkIGxpbmVzIGFu ZCBwbGFjZWQgY2FyZXQgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgZmlyc3Qgb2YgdGhvc2Ugd3Jh cHBlZCBsaW5lcworICAgICAgICBpbnN0ZWFkIG9mIGJlZm9yZSB0aGUgbGFzdC4KKworICAgICAg ICAqIGVkaXRpbmcvc2VsZWN0aW9uL21vdmUtdXAtaW50by13cmFwcGVkLWxpbmUtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXVwLWludG8td3Jh cHBlZC1saW5lLmh0bWw6IEFkZGVkLgorCiAyMDExLTA5LTEyICBCZXRoIERha2luICA8YmRha2lu QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njc4OTgKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtdXAt aW50by13cmFwcGVkLWxpbmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtdXAtaW50by13cmFwcGVkLWxpbmUtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS11cC1p bnRvLXdyYXBwZWQtbGluZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAg QEAKK1RoaXMgdGVzdCBtb3ZlcyB1cCBjYXJldCBpbnRvIGEgd3JhcHBlZCBsaW5lLiAKK2kuZS4g dGhlIGNhcmV0IGlzIG1vdmVkIGZyb20gdGhlIGVtcHR5IGxpbmUgYmVsb3cgImhlbGxvIHdvcmxk IiB0byBiZWZvcmUgIndvcmxkIi4KK3wgIgorIgorfCA8ZGl2PgorfCAgICJoZWxsbyA8I3NlbGVj dGlvbi1jYXJldD53b3JsZCIKK3wgPGRpdj4KK3wgICA8YnI+Cit8ICIKKyIKSW5kZXg6IExheW91 dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtdXAtaW50by13cmFwcGVkLWxpbmUuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXVwLWludG8t d3JhcHBlZC1saW5lLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3Nl bGVjdGlvbi9tb3ZlLXVwLWludG8td3JhcHBlZC1saW5lLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMjIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxkaXYgc3R5bGU9 IndpZHRoOiA2ZXg7IiBjb250ZW50ZWRpdGFibGU9dHJ1ZT4KKzxkaXY+aGVsbG8gd29ybGQ8L2Rp dj48ZGl2Pjxicj48L2Rpdj4KKzwvZGl2PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9k dW1wLWFzLW1hcmt1cC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitNYXJrdXAuZGVzY3JpcHRp b24oJ1RoaXMgdGVzdCBtb3ZlcyB1cCBjYXJldCBpbnRvIGEgd3JhcHBlZCBsaW5lLiBcbicKKyAr ICdpLmUuIHRoZSBjYXJldCBpcyBtb3ZlZCBmcm9tIHRoZSBlbXB0eSBsaW5lIGJlbG93ICJoZWxs byB3b3JsZCIgdG8gYmVmb3JlICJ3b3JsZCIuJyk7CisKK3ZhciBkaXYgPSBkb2N1bWVudC5nZXRF bGVtZW50c0J5VGFnTmFtZSgnZGl2JylbMF07CitkaXYuZm9jdXMoKTsKK2dldFNlbGVjdGlvbigp LnNldFBvc2l0aW9uKGRpdiwgZGl2LmNoaWxkTm9kZXMubGVuZ3RoKTsKK2dldFNlbGVjdGlvbigp Lm1vZGlmeSgnbW92ZScsICdiYWNrd2FyZCcsICdsaW5lJyk7CisKK01hcmt1cC5kdW1wKGRpdik7 CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=