67504 2011-09-02 10:48:57 -0700 Web Inspector: rename RawSourceCode.reload to contentEdited. 2011-09-05 08:34:31 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 461320 0 podivilov 2011-09-02 10:48:57 -0700 Web Inspector: rename RawSourceCode.reload to contentEdited. And remove RawSourceCode.content getter and setter. 461329 1 106155 podivilov 2011-09-02 10:58:23 -0700 Created attachment 106155 Patch 462077 2 106155 yurys 2011-09-05 02:13:27 -0700 Comment on attachment 106155 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106155&action=review > Source/WebCore/ChangeLog:5 > + Please put a description of the change here. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:201 > + if (!error) { Prefer early return. 462167 3 podivilov 2011-09-05 08:34:31 -0700 Committed r94532: <http://trac.webkit.org/changeset/94532> 106155 2011-09-02 10:58:23 -0700 2011-09-05 02:13:27 -0700 Patch bug-67504-20110902215820.patch text/plain 6433 podivilov U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyOTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNDczNjY0NGYzOTNlMTQw ZDAyMGNmOTdkZWNmYTFmZmE5OWVlZWNjLi4wNWVlNjJhYzMzNDliOGQ0NDdjZTNhM2EzOTk1MDcy MzMzMmRlMmJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDktMDIgIFBhdmVs IFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogcmVuYW1lIFJhd1NvdXJjZUNvZGUucmVsb2FkIHRvIGNvbnRlbnRFZGl0ZWQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzUwNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwucHJvdG90eXBlLnNldFNjcmlwdFNvdXJjZS5k aWRFZGl0U2NyaXB0U291cmNlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNl bnRhdGlvbk1vZGVsLnByb3RvdHlwZS5zZXRTY3JpcHRTb3VyY2UpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWxSZXNvdXJjZUJpbmRpbmcucHJvdG90eXBl LmNhblNldENvbnRlbnQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0 aW9uTW9kZWxSZXNvdXJjZUJpbmRpbmcucHJvdG90eXBlLnNldENvbnRlbnQpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWxSZXNvdXJjZUJpbmRpbmcucHJv dG90eXBlLl9zZXRDb250ZW50V2l0aEluaXRpYWxDb250ZW50KToKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1NvdXJjZUZpbGUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmF3U291 cmNlQ29kZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmF3U291cmNlQ29kZS5wcm90b3R5cGUu Y29udGVudEVkaXRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmF3U291cmNlQ29kZS5wcm90 b3R5cGUuZm9yY2VMb2FkQ29udGVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmF3U291cmNl Q29kZS5wcm90b3R5cGUuX3JlbG9hZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmF3U291cmNl Q29kZS5wcm90b3R5cGUuX2RpZFJlcXVlc3RDb250ZW50KToKKwogMjAxMS0wOC0zMSAgU3RldmUg QmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgYWxsIG1l bnRpb25zIG9mIEFuZHJvaWQgaW4gY29tbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5q cwppbmRleCAyODI0OTQwZGI2NmI1MDc4Y2IwN2MzNTJkZWJjYjRlZjY5ODZmODQzLi5mYWYzYzNi OGM4MWNkOTc3YThjZWZiYTY2ZTIxZTFjNjU2N2RjNWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlv bk1vZGVsLmpzCkBAIC0xOTYsMTUgKzE5NiwxNSBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVz ZW50YXRpb25Nb2RlbC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgZnVuY3Rpb24gZGlkRWRpdFNj cmlwdFNvdXJjZShlcnJvcikKICAgICAgICAgewotICAgICAgICAgICAgaWYgKCFlcnJvcikgewot ICAgICAgICAgICAgICAgIHJhd1NvdXJjZUNvZGUuY29udGVudCA9IG5ld1NvdXJjZTsKKyAgICAg ICAgICAgIGNhbGxiYWNrKGVycm9yKTsKIAorICAgICAgICAgICAgaWYgKCFlcnJvcikgewogICAg ICAgICAgICAgICAgIHZhciByZXNvdXJjZSA9IFdlYkluc3BlY3Rvci5yZXNvdXJjZUZvclVSTChy YXdTb3VyY2VDb2RlLnVybCk7CiAgICAgICAgICAgICAgICAgaWYgKHJlc291cmNlKQogICAgICAg ICAgICAgICAgICAgICByZXNvdXJjZS5hZGRSZXZpc2lvbihuZXdTb3VyY2UpOwotICAgICAgICAg ICAgfQogCi0gICAgICAgICAgICBjYWxsYmFjayhlcnJvcik7CisgICAgICAgICAgICAgICAgcmF3 U291cmNlQ29kZS5jb250ZW50RWRpdGVkKCk7CisgICAgICAgICAgICB9CiAKICAgICAgICAgICAg IGlmICghZXJyb3IgJiYgV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTW9kZWwuY2FsbEZyYW1lcykKICAg ICAgICAgICAgICAgICB0aGlzLl9kZWJ1Z2dlclBhdXNlZCgpOwpAQCAtNTgxLDcgKzU4MSw3IEBA IFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsUmVzb3VyY2VCaW5kaW5nLnBy b3RvdHlwZSA9IHsKICAgICAgICAgdmFyIHJhd1NvdXJjZUNvZGUgPSB0aGlzLl9wcmVzZW50YXRp b25Nb2RlbC5fcmF3U291cmNlQ29kZUZvclNjcmlwdChyZXNvdXJjZS51cmwpCiAgICAgICAgIGlm ICghcmF3U291cmNlQ29kZSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgcmV0 dXJuIHRoaXMuX3ByZXNlbnRhdGlvbk1vZGVsLmNhbkVkaXRTY3JpcHRTb3VyY2UocmF3U291cmNl Q29kZS5pZCk7CisgICAgICAgIHJldHVybiB0aGlzLl9wcmVzZW50YXRpb25Nb2RlbC5jYW5FZGl0 U2NyaXB0U291cmNlKHJhd1NvdXJjZUNvZGUudWlTb3VyY2VDb2RlKTsKICAgICB9LAogCiAgICAg c2V0Q29udGVudDogZnVuY3Rpb24ocmVzb3VyY2UsIGNvbnRlbnQsIG1ham9yQ2hhbmdlLCB1c2Vy Q2FsbGJhY2spCkBAIC01OTUsMjEgKzU5NSwxOSBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVz ZW50YXRpb25Nb2RlbFJlc291cmNlQmluZGluZy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICByZXNvdXJjZS5yZXF1ZXN0Q29udGVudCh0aGlz Ll9zZXRDb250ZW50V2l0aEluaXRpYWxDb250ZW50LmJpbmQodGhpcywgcmF3U291cmNlQ29kZSwg Y29udGVudCwgdXNlckNhbGxiYWNrKSk7CisgICAgICAgIHJlc291cmNlLnJlcXVlc3RDb250ZW50 KHRoaXMuX3NldENvbnRlbnRXaXRoSW5pdGlhbENvbnRlbnQuYmluZCh0aGlzLCByYXdTb3VyY2VD b2RlLnVpU291cmNlQ29kZSwgY29udGVudCwgdXNlckNhbGxiYWNrKSk7CiAgICAgfSwKIAotICAg IF9zZXRDb250ZW50V2l0aEluaXRpYWxDb250ZW50OiBmdW5jdGlvbihyYXdTb3VyY2VDb2RlLCBj b250ZW50LCB1c2VyQ2FsbGJhY2ssIG9sZENvbnRlbnQpCisgICAgX3NldENvbnRlbnRXaXRoSW5p dGlhbENvbnRlbnQ6IGZ1bmN0aW9uKHVpU291cmNlQ29kZSwgY29udGVudCwgdXNlckNhbGxiYWNr LCBvbGRDb250ZW50KQogICAgIHsKICAgICAgICAgZnVuY3Rpb24gY2FsbGJhY2soZXJyb3IpCiAg ICAgICAgIHsKICAgICAgICAgICAgIGlmICh1c2VyQ2FsbGJhY2spCiAgICAgICAgICAgICAgICAg dXNlckNhbGxiYWNrKGVycm9yKTsKLSAgICAgICAgICAgIGlmICghZXJyb3IpIHsKLSAgICAgICAg ICAgICAgICB0aGlzLl9wcmVzZW50YXRpb25Nb2RlbC5fdXBkYXRlQnJlYWtwb2ludHNBZnRlckxp dmVFZGl0KHJhd1NvdXJjZUNvZGUuaWQsIG9sZENvbnRlbnQsIGNvbnRlbnQpOwotICAgICAgICAg ICAgICAgIHJhd1NvdXJjZUNvZGUucmVsb2FkKCk7Ci0gICAgICAgICAgICB9CisgICAgICAgICAg ICBpZiAoIWVycm9yKQorICAgICAgICAgICAgICAgIHRoaXMuX3ByZXNlbnRhdGlvbk1vZGVsLl91 cGRhdGVCcmVha3BvaW50c0FmdGVyTGl2ZUVkaXQodWlTb3VyY2VDb2RlLCBvbGRDb250ZW50LCBj b250ZW50KTsKICAgICAgICAgfQotICAgICAgICB0aGlzLl9wcmVzZW50YXRpb25Nb2RlbC5zZXRT Y3JpcHRTb3VyY2UocmF3U291cmNlQ29kZS5pZCwgY29udGVudCwgY2FsbGJhY2suYmluZCh0aGlz KSk7CisgICAgICAgIHRoaXMuX3ByZXNlbnRhdGlvbk1vZGVsLnNldFNjcmlwdFNvdXJjZSh1aVNv dXJjZUNvZGUsIGNvbnRlbnQsIGNhbGxiYWNrLmJpbmQodGhpcykpOwogICAgIH0KIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGaWxlLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGaWxlLmpzCmluZGV4 IDdjOTE4YTJhMmZhZWU4ZDc3NDcxNmI4MDkzNDc4YjZmZDMyZTUzMDIuLjBiZmRhYzgwZGNhNDhh NGVkY2Q4NTBiMTlkMGZlYjE1NjBlZTFiOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvU291cmNlRmlsZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZpbGUuanMKQEAgLTUxLDcgKzUxLDcgQEAgV2ViSW5zcGVj dG9yLlJhd1NvdXJjZUNvZGUgPSBmdW5jdGlvbihpZCwgc2NyaXB0LCBmb3JtYXR0ZXIsIGZvcm1h dHRlZCkKICAgICB0aGlzLm1lc3NhZ2VzID0gW107CiAKICAgICBpZiAodGhpcy5faGFzUGVuZGlu Z1Jlc291cmNlKCkpCi0gICAgICAgIHRoaXMuX3Jlc291cmNlLmFkZEV2ZW50TGlzdGVuZXIoImZp bmlzaGVkIiwgdGhpcy5yZWxvYWQuYmluZCh0aGlzKSk7CisgICAgICAgIHRoaXMuX3Jlc291cmNl LmFkZEV2ZW50TGlzdGVuZXIoImZpbmlzaGVkIiwgdGhpcy5fcmVsb2FkLmJpbmQodGhpcykpOwog fQogCiBXZWJJbnNwZWN0b3IuUmF3U291cmNlQ29kZS5FdmVudHMgPSB7CkBAIC03Niw2ICs3Niwx MSBAQCBXZWJJbnNwZWN0b3IuUmF3U291cmNlQ29kZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJl dHVybiB0aGlzOwogICAgIH0sCiAKKyAgICBjb250ZW50RWRpdGVkOiBmdW5jdGlvbigpCisgICAg eworICAgICAgICB0aGlzLl9yZWxvYWQoKTsKKyAgICB9LAorCiAgICAgcmF3TG9jYXRpb25Ub1VJ TG9jYXRpb246IGZ1bmN0aW9uKHJhd0xvY2F0aW9uKQogICAgIHsKICAgICAgICAgdmFyIGxvY2F0 aW9uID0gdGhpcy5fbWFwcGluZyA/IHRoaXMuX21hcHBpbmcub3JpZ2luYWxUb0Zvcm1hdHRlZChy YXdMb2NhdGlvbikgOiByYXdMb2NhdGlvbjsKQEAgLTExNiwxNyArMTIxLDYgQEAgV2ViSW5zcGVj dG9yLlJhd1NvdXJjZUNvZGUucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9yZXF1ZXN0Q29u dGVudCgpOwogICAgIH0sCiAKLSAgICBnZXQgY29udGVudCgpCi0gICAgewotICAgICAgICByZXR1 cm4gdGhpcy5fY29udGVudDsKLSAgICB9LAotCi0gICAgc2V0IGNvbnRlbnQoY29udGVudCkKLSAg ICB7Ci0gICAgICAgIC8vIEZJWE1FOiBtb3ZlIGxpdmUgZWRpdCBpbXBsZW1lbnRhdGlvbiB0byBT b3VyY2VGaWxlIGFuZCByZW1vdmUgdGhpcyBzZXR0ZXIuCi0gICAgICAgIHRoaXMuX2NvbnRlbnQg PSBjb250ZW50OwotICAgIH0sCi0KICAgICBjcmVhdGVTb3VyY2VNYXBwaW5nSWZOZWVkZWQ6IGZ1 bmN0aW9uKGNhbGxiYWNrKQogICAgIHsKICAgICAgICAgaWYgKCF0aGlzLl9mb3JtYXR0ZWQpIHsK QEAgLTE2Miw3ICsxNTYsNyBAQCBXZWJJbnNwZWN0b3IuUmF3U291cmNlQ29kZS5wcm90b3R5cGUg PSB7CiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5fc2NyaXB0cy5sZW5ndGg7ICsr aSkKICAgICAgICAgICAgIHRoaXMuX2NvbmNhdGVuYXRlZFNjcmlwdHNbdGhpcy5fc2NyaXB0c1tp XS5zY3JpcHRJZF0gPSB0cnVlOwogCi0gICAgICAgIHRoaXMucmVsb2FkKCk7CisgICAgICAgIHRo aXMuX3JlbG9hZCgpOwogCiAgICAgICAgIGlmICghdGhpcy5fY29udGVudFJlcXVlc3RlZCkgewog ICAgICAgICAgICAgdGhpcy5fY29udGVudFJlcXVlc3RlZCA9IHRydWU7CkBAIC0xNzAsNyArMTY0 LDcgQEAgV2ViSW5zcGVjdG9yLlJhd1NvdXJjZUNvZGUucHJvdG90eXBlID0gewogICAgICAgICB9 CiAgICAgfSwKIAotICAgIHJlbG9hZDogZnVuY3Rpb24oKQorICAgIF9yZWxvYWQ6IGZ1bmN0aW9u KCkKICAgICB7CiAgICAgICAgIGlmICh0aGlzLl9jb250ZW50TG9hZGVkKSB7CiAgICAgICAgICAg ICB0aGlzLl9jb250ZW50TG9hZGVkID0gZmFsc2U7CkBAIC0yMzIsNyArMjI2LDcgQEAgV2ViSW5z cGVjdG9yLlJhd1NvdXJjZUNvZGUucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9yZXF1ZXN0 Q29udGVudENhbGxiYWNrcyA9IFtdOwogCiAgICAgICAgIGlmICh0aGlzLl9yZWxvYWRDb250ZW50 KQotICAgICAgICAgICAgdGhpcy5yZWxvYWQoKTsKKyAgICAgICAgICAgIHRoaXMuX3JlbG9hZCgp OwogICAgIH0sCiAKICAgICBfaGFzUGVuZGluZ1Jlc291cmNlOiBmdW5jdGlvbigpCg==