67492 2011-09-02 09:47:28 -0700 Remove two unused functions from Element. 2011-09-03 11:18:16 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling webkit.review.bot oldest_to_newest 461266 0 kling 2011-09-02 09:47:28 -0700 openTagStartToString() and setCStringAttribute() are not used. 461267 1 106143 kling 2011-09-02 09:48:01 -0700 Created attachment 106143 Proposed patch 461275 2 106143 benjamin 2011-09-02 09:53:33 -0700 Comment on attachment 106143 Proposed patch Sure, if it's not used. 461332 3 106143 webkit.review.bot 2011-09-02 11:02:09 -0700 Comment on attachment 106143 Proposed patch Rejecting attachment 106143 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: 00c2b69be37d95955dbb2b6fb2e7f49a30f07c95 r94433 = b811ff943f4eac8d6087047d8086e37041ef2dde Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9579824 461834 4 kling 2011-09-03 11:18:16 -0700 Committed r94491: <http://trac.webkit.org/changeset/94491> 106143 2011-09-02 09:48:01 -0700 2011-09-02 11:02:08 -0700 Proposed patch bug-67492.diff text/plain 3088 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwNzdlZGIwLi5kNDQxZWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMDktMDIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFJlbW92ZSB0d28gdW51c2VkIGZ1bmN0aW9ucyBmcm9tIEVsZW1lbnQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzQ5MgorCisgICAgICAgIFJl bW92ZWQgb3BlblRhZ1N0YXJ0VG9TdHJpbmcoKSBhbmQgc2V0Q1N0cmluZ0F0dHJpYnV0ZSgpIGFz IHRoZXkgYXJlCisgICAgICAgIG5vdCBjYWxsZWQgZnJvbSBhbnl3aGVyZS4KKworICAgICAgICAq IGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorCisyMDExLTA5LTAy ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKwogICAgICAgICBVc2UgZmFzdEdl dEF0dHJpYnV0ZSgpIGFuZCBmYXN0SGFzQXR0cmlidXRlKCkgd2hlcmUgYXBwcm9wcmlhdGUuCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzM5NAogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAKaW5kZXggZmYyZmUwYi4uOGFjNTM3OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50LmNwcApAQCAtMjM1LDEyICsyMzUsNiBAQCB2b2lkIEVsZW1lbnQ6OnNldEF0dHJpYnV0ZShj b25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKQogICAg IEV4Y2VwdGlvbkNvZGUgZWM7CiAgICAgc2V0QXR0cmlidXRlKG5hbWUsIHZhbHVlLCBlYyk7CiB9 Ci0gICAgCi12b2lkIEVsZW1lbnQ6OnNldENTdHJpbmdBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVk TmFtZSYgbmFtZSwgY29uc3QgY2hhciogY1N0cmluZ1ZhbHVlKQotewotICAgIEV4Y2VwdGlvbkNv ZGUgZWM7Ci0gICAgc2V0QXR0cmlidXRlKG5hbWUsIEF0b21pY1N0cmluZyhjU3RyaW5nVmFsdWUp LCBlYyk7Ci19CiAKIHZvaWQgRWxlbWVudDo6c2V0Qm9vbGVhbkF0dHJpYnV0ZShjb25zdCBRdWFs aWZpZWROYW1lJiBuYW1lLCBib29sIGIpCiB7CkBAIC0xNDYwLDMxICsxNDU0LDYgQEAgdm9pZCBF bGVtZW50OjpkaXNwYXRjaEF0dHJBZGRpdGlvbkV2ZW50KEF0dHJpYnV0ZSopCiAjZW5kaWYKIH0K IAotU3RyaW5nIEVsZW1lbnQ6Om9wZW5UYWdTdGFydFRvU3RyaW5nKCkgY29uc3QKLXsKLSAgICBT dHJpbmcgcmVzdWx0ID0gIjwiICsgbm9kZU5hbWUoKTsKLQotICAgIE5hbWVkTm9kZU1hcCogYXR0 ck1hcCA9IGF0dHJpYnV0ZXModHJ1ZSk7Ci0KLSAgICBpZiAoYXR0ck1hcCkgewotICAgICAgICB1 bnNpZ25lZCBudW1BdHRycyA9IGF0dHJNYXAtPmxlbmd0aCgpOwotICAgICAgICBmb3IgKHVuc2ln bmVkIGkgPSAwOyBpIDwgbnVtQXR0cnM7IGkrKykgewotICAgICAgICAgICAgcmVzdWx0ICs9ICIg IjsKLQotICAgICAgICAgICAgQXR0cmlidXRlICphdHRyaWJ1dGUgPSBhdHRyTWFwLT5hdHRyaWJ1 dGVJdGVtKGkpOwotICAgICAgICAgICAgcmVzdWx0ICs9IGF0dHJpYnV0ZS0+bmFtZSgpLnRvU3Ry aW5nKCk7Ci0gICAgICAgICAgICBpZiAoIWF0dHJpYnV0ZS0+dmFsdWUoKS5pc051bGwoKSkgewot ICAgICAgICAgICAgICAgIHJlc3VsdCArPSAiPVwiIjsKLSAgICAgICAgICAgICAgICAvLyBGSVhN RTogc3Vic3RpdHV0ZSBlbnRpdGllcyBmb3IgYW55IGluc3RhbmNlcyBvZiAiIG9yICcKLSAgICAg ICAgICAgICAgICByZXN1bHQgKz0gYXR0cmlidXRlLT52YWx1ZSgpOwotICAgICAgICAgICAgICAg IHJlc3VsdCArPSAiXCIiOwotICAgICAgICAgICAgfQotICAgICAgICB9Ci0gICAgfQotCi0gICAg cmV0dXJuIHJlc3VsdDsKLX0KLQogI2lmbmRlZiBOREVCVUcKIHZvaWQgRWxlbWVudDo6Zm9ybWF0 Rm9yRGVidWdnZXIoY2hhciogYnVmZmVyLCB1bnNpZ25lZCBsZW5ndGgpIGNvbnN0CiB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9t L0VsZW1lbnQuaAppbmRleCBiMDcwYzYyLi42YWMzMTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKQEAg LTIxMiw5ICsyMTIsNiBAQCBwdWJsaWM6CiAgICAgLy8gY29udmVuaWVuY2UgbWV0aG9kcyB3aGlj aCBpZ25vcmUgZXhjZXB0aW9ucwogICAgIHZvaWQgc2V0QXR0cmlidXRlKGNvbnN0IFF1YWxpZmll ZE5hbWUmLCBjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKTsKICAgICB2b2lkIHNldEJvb2xlYW5B dHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgYm9vbCk7Ci0gICAgLy8gUGxlYXNl IGRvbid0IHVzZSBzZXRDU3RyaW5nQXR0cmlidXRlIGluIHBlcmZvcm1hbmNlLXNlbnNpdGl2ZSBj b2RlOwotICAgIC8vIHVzZSBhIHN0YXRpYyBBdG9taWNTdHJpbmcgdmFsdWUgaW5zdGVhZCB0byBh dm9pZCB0aGUgY29udmVyc2lvbiBvdmVyaGVhZC4KLSAgICB2b2lkIHNldENTdHJpbmdBdHRyaWJ1 dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYsIGNvbnN0IGNoYXIqIGNTdHJpbmdWYWx1ZSk7CiAKICAg ICBOYW1lZE5vZGVNYXAqIGF0dHJpYnV0ZXMoYm9vbCByZWFkb25seSA9IGZhbHNlKSBjb25zdDsK IApAQCAtMjY4LDggKzI2NSw2IEBAIHB1YmxpYzoKICAKICAgICB2aXJ0dWFsIFN0cmluZyB0aXRs ZSgpIGNvbnN0OwogCi0gICAgU3RyaW5nIG9wZW5UYWdTdGFydFRvU3RyaW5nKCkgY29uc3Q7Ci0K ICAgICB2b2lkIHVwZGF0ZUlkKGNvbnN0IEF0b21pY1N0cmluZyYgb2xkSWQsIGNvbnN0IEF0b21p Y1N0cmluZyYgbmV3SWQpOwogCiAgICAgTGF5b3V0U2l6ZSBtaW5pbXVtU2l6ZUZvclJlc2l6aW5n KCkgY29uc3Q7Cg==