<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67485</bug_id>
          
          <creation_ts>2011-09-02 06:50:32 -0700</creation_ts>
          <short_desc>[Qt][WK2] 4 tests are failing, skip them</short_desc>
          <delta_ts>2012-02-02 11:00:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>LayoutTestFailure, Qt, Regression</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kristóf Kosztyó">kkristof</reporter>
          <assigned_to name="Csaba Osztrogonác">ossy</assigned_to>
          <cc>feherzs</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>ossy</cc>
    
    <cc>zoltan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>461202</commentid>
    <comment_count>0</comment_count>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-09-02 06:50:32 -0700</bug_when>
    <thetext>fast/dom/Window/window-properties.html = TEXT
fast/text/complex-preferred-logical-widths.html = TEXT
http/tests/loading/empty-urls.html = TEXT
http/tests/loading/progress-finished-callback.html = TEXT</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461441</commentid>
    <comment_count>1</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-09-02 12:49:24 -0700</bug_when>
    <thetext>It would be useful to record the differences between the expected and actual results for bugs such as this one. It would also be useful to record (approximately) which commit caused the regression. Lastly, it seems that this (and similar) bug needs the following Keyword - Qt, Regression, LayoutTestFailure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461813</commentid>
    <comment_count>2</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2011-09-03 05:39:13 -0700</bug_when>
    <thetext>The skip change has been committed in: http://trac.webkit.org/changeset/94416

(In reply to comment #0)

&gt; fast/dom/Window/window-properties.html = TEXT
This test was added in r94147, it was still failing.

&gt; http/tests/loading/empty-urls.html = TEXT
This test was added in r94213, it was still failing.

&gt; fast/text/complex-preferred-logical-widths.html = TEXT
&gt; http/tests/loading/progress-finished-callback.html = TEXT

These tests were started to fail before r94137 (the bot stores only 200 revisions).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462056</commentid>
    <comment_count>3</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-05 00:04:21 -0700</bug_when>
    <thetext>I really don&apos;t understand why did you disable a general test, fast/dom/Window/window-properties.html which only needs to be updated.

I made the update for qt platform, qt-wk2 needs similar update.
http://trac.webkit.org/changeset/94170/trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt

I think skipping new failing tests without any attempt to fix isn&apos;t a good idea. I agree with Laszlo, at least you should add revision numbers and diffs to the bug report.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462066</commentid>
    <comment_count>4</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2011-09-05 01:09:47 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; I really don&apos;t understand why did you disable a general test, fast/dom/Window/window-properties.html which only needs to be updated.

The answer is easy, maybe you will understand as well:  we had&apos;t got enough time to investigate the tests, so we did what a gardener should do. ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487348</commentid>
    <comment_count>5</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-19 23:28:06 -0700</bug_when>
    <thetext>*** Bug 67405 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>547986</commentid>
    <comment_count>6</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-02-02 11:00:10 -0800</bug_when>
    <thetext>Here is what should have a gardener done instead of headless skipping tests:
http://trac.webkit.org/changeset/106571</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>