67482 2011-09-02 06:12:40 -0700 [CMake] Detect the operating system in a more generic way. 2011-09-26 13:08:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco abarth leandro paroga tonikitoo webkit.review.bot oldest_to_newest 461185 0 rakuco 2011-09-02 06:12:40 -0700 [CMake] Detect the operating system in a more generic way. 461186 1 106122 rakuco 2011-09-02 06:13:26 -0700 Created attachment 106122 Patch 461190 2 106122 paroga 2011-09-02 06:28:32 -0700 Comment on attachment 106122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106122&action=review > Source/CMakeLists.txt:76 > +IF (UNIX) ok > Source/CMakeLists.txt:82 > +ELSEIF (WIN32) WIN32 isn't defined for Windows CE! 461193 3 rakuco 2011-09-02 06:34:10 -0700 (In reply to comment #2) > > Source/CMakeLists.txt:82 > > +ELSEIF (WIN32) > > WIN32 isn't defined for Windows CE! Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)? 461194 4 106125 rakuco 2011-09-02 06:36:31 -0700 Created attachment 106125 Patch 461196 5 106125 paroga 2011-09-02 06:37:18 -0700 Comment on attachment 106125 Patch LGTM 461205 6 paroga 2011-09-02 07:02:12 -0700 (In reply to comment #3) > (In reply to comment #2) > > > Source/CMakeLists.txt:82 > > > +ELSEIF (WIN32) > > > > WIN32 isn't defined for Windows CE! > > Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)? Not sure, but since there is no offical WinCE support at the moment, it's hard to say what's correct/wrog. If it's ok for you i'd like to keep the windows part as it for now. 461210 7 rakuco 2011-09-02 07:12:48 -0700 (In reply to comment #6) > (In reply to comment #3) > > Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)? > > Not sure, but since there is no offical WinCE support at the moment, it's hard to say what's correct/wrog. Do you mean there's no official WinCE support in CMake itself? > If it's ok for you i'd like to keep the windows part as it for now. No problem. 472905 8 rakuco 2011-09-25 13:15:02 -0700 CC'ing reviewers. 473328 9 106125 webkit.review.bot 2011-09-26 13:08:05 -0700 Comment on attachment 106125 Patch Clearing flags on attachment: 106125 Committed r95986: <http://trac.webkit.org/changeset/95986> 473330 10 webkit.review.bot 2011-09-26 13:08:11 -0700 All reviewed patches have been landed. Closing bug. 106122 2011-09-02 06:13:26 -0700 2011-09-02 06:36:25 -0700 Patch bug-67482-20110902101701.patch text/plain 1721 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ0MTAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCAyODBkOWE3MTFkZjcxNTA5NTUyOTAwYjViZDA5MzlhYzIyZjBlNGM5Li4xYzQw ZTc1MGJmYjkyNjJhOTRmMGIzNmFlMDY5OWUwYTY0MTBkZTFiIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMDIgIFJhcGhhZWwg S3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0NNYWtlXSBE ZXRlY3QgdGhlIG9wZXJhdGluZyBzeXN0ZW0gaW4gYSBtb3JlIGdlbmVyaWMgd2F5LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc0ODIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTbyBmYXIgdGhlIGJ1aWxk c3lzdGVtIG9ubHkgY29uc2lkZXJlZCBXaW5kb3dzLCBMaW51eCBhbmQgTWFjIE9TIFggYXMKKyAg ICAgICAgdmFsaWQgb3BlcmF0aW5nIHN5c3RlbXMsIGJ1dCBhbnkgVW5peCAob3IgYXQgbGVhc3Qg dGhlIEJTRHMpIHNob3VsZCBhbHNvCisgICAgICAgIHdvcmsgZmluZS4KKworICAgICAgICBCeSB1 c2luZyB0aGUgT1MgdmFsdWVzIENNYWtlIGl0c2VsZiBkZWZpbmVzIHdlIGNhbiBjaGVjayBmb3Ig VW5peAorICAgICAgICBzeXN0ZW1zIGluIGEgbW9yZSBnZW5lcmljIGZhc2hpb24uIFRoZSBXaW5k b3dzIGNoZWNrIHdhcyBhbHNvIGNoYW5nZWQgdG8KKyAgICAgICAga2VlcCB0aGluZ3MgY29uc2lz dGVudC4KKworICAgICAgICAqIFNvdXJjZS9DTWFrZUxpc3RzLnR4dDoKKwogMjAxMS0wOC0zMCAg QWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgTWVk aWFTb3VyY2UgQVBJIHRvIEhUTUxNZWRpYUVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9DTWFr ZUxpc3RzLnR4dCBiL1NvdXJjZS9DTWFrZUxpc3RzLnR4dAppbmRleCAyNjQ3N2Q5NzBiOTk2M2Zh MjQ4MjJjOTliMjY5NTA5ODlhYThlYjQ5Li5hNzk2NGVmZWM4YTU1OTViNjNhNWNjNzc2ZGZjMjc2 NjQ4ZjBjNTJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNl L0NNYWtlTGlzdHMudHh0CkBAIC03MywxMyArNzMsMTMgQEAgRU5ESUYgKCkKICMgLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KICMgRGV0ZXJtaW5lIHRoZSBvcGVyYXRpbmcgc3lzdGVtCiAjIC0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCi1JRiAoQ01BS0VfU1lTVEVNX05BTUUgTUFUQ0hFUyAiTGludXgiKQotICAg IFNFVChXVEZfT1NfVU5JWCAxKQotCitJRiAoVU5JWCkKICAgICBJRiAoQVBQTEUpCiAgICAgICAg IFNFVChXVEZfT1NfTUFDX09TX1ggMSkKKyAgICBFTFNFICgpCisgICAgICAgIFNFVChXVEZfT1Nf VU5JWCAxKQogICAgIEVORElGICgpCi1FTFNFSUYgKENNQUtFX1NZU1RFTV9OQU1FIE1BVENIRVMg IldpbmRvd3MiKQorRUxTRUlGIChXSU4zMikKICAgICBTRVQoV1RGX09TX1dJTkRPV1MgMSkKIEVM U0UgKCkKICAgICBNRVNTQUdFKEZBVEFMX0VSUk9SICJVbmtub3duIE9TICcke0NNQUtFX1NZU1RF TV9OQU1FfSciKQo= 106125 2011-09-02 06:36:31 -0700 2011-09-26 13:08:05 -0700 Patch bug-67482-20110902104006.patch text/plain 1563 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ0MTAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCAyODBkOWE3MTFkZjcxNTA5NTUyOTAwYjViZDA5MzlhYzIyZjBlNGM5Li43OTRm N2Y5NGNmNzg5YWI3NDYyOTI4MjNmZWFkMDVkNzNiNmVhNzYxIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDktMDIgIFJhcGhhZWwg S3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0NNYWtlXSBE ZXRlY3QgdGhlIG9wZXJhdGluZyBzeXN0ZW0gaW4gYSBtb3JlIGdlbmVyaWMgd2F5LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc0ODIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTbyBmYXIgdGhlIGJ1aWxk c3lzdGVtIG9ubHkgY29uc2lkZXJlZCBXaW5kb3dzLCBMaW51eCBhbmQgTWFjIE9TIFggYXMKKyAg ICAgICAgdmFsaWQgb3BlcmF0aW5nIHN5c3RlbXMsIGJ1dCBhbnkgVW5peCAob3IgYXQgbGVhc3Qg dGhlIEJTRHMpIHNob3VsZCBhbHNvCisgICAgICAgIHdvcmsgZmluZS4KKworICAgICAgICBCeSB1 c2luZyB0aGUgT1MgdmFsdWVzIENNYWtlIGl0c2VsZiBkZWZpbmVzIHdlIGNhbiBjaGVjayBmb3Ig VW5peAorICAgICAgICBzeXN0ZW1zIGluIGEgbW9yZSBnZW5lcmljIGZhc2hpb24uCisKKyAgICAg ICAgKiBTb3VyY2UvQ01ha2VMaXN0cy50eHQ6CisKIDIwMTEtMDgtMzAgIEFhcm9uIENvbHdlbGwg IDxhY29sd2VsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIE1lZGlhU291cmNlIEFQSSB0 byBIVE1MTWVkaWFFbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvQ01ha2VMaXN0cy50eHQgYi9T b3VyY2UvQ01ha2VMaXN0cy50eHQKaW5kZXggMjY0NzdkOTcwYjk5NjNmYTI0ODIyYzk5YjI2OTUw OTg5YWE4ZWI0OS4uYjYyOWY2MjhhZGE4YzZjZmVmNDg1OTY4MTUzN2QwMjRkNmE3YWU0ZSAxMDA2 NDQKLS0tIGEvU291cmNlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9DTWFrZUxpc3RzLnR4 dApAQCAtNzMsMTEgKzczLDExIEBAIEVORElGICgpCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAj IERldGVybWluZSB0aGUgb3BlcmF0aW5nIHN5c3RlbQogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQot SUYgKENNQUtFX1NZU1RFTV9OQU1FIE1BVENIRVMgIkxpbnV4IikKLSAgICBTRVQoV1RGX09TX1VO SVggMSkKLQorSUYgKFVOSVgpCiAgICAgSUYgKEFQUExFKQogICAgICAgICBTRVQoV1RGX09TX01B Q19PU19YIDEpCisgICAgRUxTRSAoKQorICAgICAgICBTRVQoV1RGX09TX1VOSVggMSkKICAgICBF TkRJRiAoKQogRUxTRUlGIChDTUFLRV9TWVNURU1fTkFNRSBNQVRDSEVTICJXaW5kb3dzIikKICAg ICBTRVQoV1RGX09TX1dJTkRPV1MgMSkK