67457 2011-09-01 17:08:32 -0700 [Chromium] Fix a crashing bug due to raciness around SQL database shutdown. 2011-09-01 19:26:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michaeln michaeln levin webkit.review.bot oldest_to_newest 460937 0 michaeln 2011-09-01 17:08:32 -0700 See http://code.google.com/p/chromium/issues/detail?id=71551 for more details. 460949 1 106068 michaeln 2011-09-01 17:30:21 -0700 Created attachment 106068 crash fix 460952 2 michaeln 2011-09-01 17:31:10 -0700 ptal 460970 3 michaeln 2011-09-01 17:56:46 -0700 storage layout tests are happy with this change on my system 460972 4 106068 webkit.review.bot 2011-09-01 18:04:28 -0700 Comment on attachment 106068 crash fix Rejecting attachment 106068 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: wer', u'David Levin', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file source/webcore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file source/webcore/storage/chromium/DatabaseTrackerChromium.cpp Hunk #1 FAILED at 129. 1 out of 1 hunk FAILED -- saving rejects to file source/webcore/storage/chromium/DatabaseTrackerChromium.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9580451 460999 5 michaeln 2011-09-01 18:41:56 -0700 thnx david! i'll land by hand 461015 6 michaeln 2011-09-01 19:26:58 -0700 Committed r94383: <http://trac.webkit.org/changeset/94383> 106068 2011-09-01 17:30:21 -0700 2011-09-01 18:04:28 -0700 crash fix dbfix.txt text/plain 1901 michaeln SW5kZXg6IHNvdXJjZS93ZWJjb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzb3VyY2Uvd2Vi Y29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MzY2KQorKysgc291cmNlL3dlYmNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMDEgIE1pY2hhZWwg Tm9yZG1hbiAgPG1pY2hhZWxuQGdvb2dsZS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXSBGaXgg YSBjcmFzaGluZyBidWcgZHVlIHRvIHJhY2luZXNzIGFyb3VuZCBTUUwgZGF0YWJhc2Ugc2h1dGRv d24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzQ1 NworCisgICAgICAgIFRoZSByZW1vdmVPcGVuRGF0YWJhc2UoKSBtZXRob2QgY2FuIGdldCBjYWxs ZWQgbXVsdGlwbGUgdGltZXMuCisgICAgICAgIFN1YnNlcXVlbnQgY2FsbHMgdG8gaXQgc2hvdWxk IGJlIGhhcm1lbGVzcyBpbnN0ZWFkIG9mIGNhdXNlIGEgY3Jhc2guCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdG9yYWdlL2Nocm9taXVtL0RhdGFi YXNlVHJhY2tlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlVHJhY2tl cjo6cmVtb3ZlT3BlbkRhdGFiYXNlKToKKwogMjAxMS0wOS0wMSAgTWFyayBSb3dlICA8bXJvd2VA YXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDA2MzQxMT4gV2ViU2NyaXB0 T2JqZWN0LmggZGVjbGFyZXMgYW4gT2JqZWN0aXZlLUMgbWV0aG9kIHdpdGhvdXQgYSByZXR1cm4g dHlwZS4KSW5kZXg6IHNvdXJjZS93ZWJjb3JlL3N0b3JhZ2UvY2hyb21pdW0vRGF0YWJhc2VUcmFj a2VyQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNvdXJjZS93ZWJjb3JlL3N0b3JhZ2UvY2hy b21pdW0vRGF0YWJhc2VUcmFja2VyQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA5NDM0OSkKKysrIHNv dXJjZS93ZWJjb3JlL3N0b3JhZ2UvY2hyb21pdW0vRGF0YWJhc2VUcmFja2VyQ2hyb21pdW0uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xMjksMTIgKzEyOSwxOSBAQCB2b2lkIERhdGFiYXNlVHJhY2tl cjo6cmVtb3ZlT3BlbkRhdGFiYXNlCiAgICAgTXV0ZXhMb2NrZXIgb3BlbkRhdGFiYXNlTWFwTG9j ayhtX29wZW5EYXRhYmFzZU1hcEd1YXJkKTsKICAgICBBU1NFUlQobV9vcGVuRGF0YWJhc2VNYXAp OwogICAgIERhdGFiYXNlTmFtZU1hcCogbmFtZU1hcCA9IG1fb3BlbkRhdGFiYXNlTWFwLT5nZXQo b3JpZ2luSWRlbnRpZmllcik7Ci0gICAgQVNTRVJUKG5hbWVNYXApOworICAgIGlmICghbmFtZU1h cCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgU3RyaW5nIG5hbWUoZGF0YWJhc2UtPnN0cmluZ0lk ZW50aWZpZXIoKSk7CiAgICAgRGF0YWJhc2VTZXQqIGRhdGFiYXNlU2V0ID0gbmFtZU1hcC0+Z2V0 KG5hbWUpOwotICAgIEFTU0VSVChkYXRhYmFzZVNldCk7Ci0gICAgZGF0YWJhc2VTZXQtPnJlbW92 ZShkYXRhYmFzZSk7CisgICAgaWYgKCFkYXRhYmFzZVNldCkKKyAgICAgICAgcmV0dXJuOworCisg ICAgRGF0YWJhc2VTZXQ6Oml0ZXJhdG9yIGZvdW5kID0gZGF0YWJhc2VTZXQtPmZpbmQoZGF0YWJh c2UpOworICAgIGlmIChmb3VuZCA9PSBkYXRhYmFzZVNldC0+ZW5kKCkpCisgICAgICAgIHJldHVy bjsKIAorICAgIGRhdGFiYXNlU2V0LT5yZW1vdmUoZm91bmQpOwogICAgIGlmIChkYXRhYmFzZVNl dC0+aXNFbXB0eSgpKSB7CiAgICAgICAgIG5hbWVNYXAtPnJlbW92ZShuYW1lKTsKICAgICAgICAg ZGVsZXRlIGRhdGFiYXNlU2V0Owo=