67425 2011-09-01 12:32:08 -0700 Assertion failures in checkEncodedString when running WebKit2 tests 2012-03-15 14:08:02 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r94298%20(402)/results.html InRadar, LayoutTestFailure, MakingBotsRed P2 Normal --- 1 simon.fraser ap andersca ap beidson jberlin simon.fraser webkit-bug-importer oldest_to_newest 460693 0 simon.fraser 2011-09-01 12:32:08 -0700 The following tests started failing on Lion Intel Debug (WebKit2 Tests) between r94297 and r94298 (inclusive): fast/loader/reload-zero-byte-plugin.html fast/loader/opaque-base-url.html http://trac.webkit.org/log/trunk?rev=94298&stop_rev=94297&limit=3 http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r94296%20(401)/results.html passed http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r94298%20(402)/results.html failed 460694 1 simon.fraser 2011-09-01 12:32:46 -0700 ASSERTION FAILED: !url.length() || isSchemeFirstChar(url[0]) /Volumes/SSData/Development/OSX/webkit/OpenSource/Source/WebCore/platform/KURL.cpp(300) : void WebCore::checkEncodedString(const WTF::String &) 1 _ZN7WebCoreL18checkEncodedStringERKN3WTF6StringE 2 WebCore::KURL::parse(WTF::String const&) 3 WebCore::KURL::KURL(WebCore::ParsedURLStringTag, WTF::String const&) 4 WebCore::KURL::KURL(WebCore::ParsedURLStringTag, WTF::String const&) 5 WebCore::ResourceError::nsError() const 6 CoreIPC::ArgumentCoder<WebCore::ResourceError>::encode(CoreIPC::ArgumentEncoder*, WebCore::ResourceError const&) 7 void CoreIPC::ArgumentEncoder::encode<WebCore::ResourceError>(WebCore::ResourceError const&) 8 CoreIPC::Arguments2<unsigned long long, WebCore::ResourceError const&>::encode(CoreIPC::ArgumentEncoder*) const 9 CoreIPC::Arguments3<unsigned long long, WebCore::ResourceError const&, WebKit::InjectedBundleUserMessageEncoder const&>::encode(CoreIPC::ArgumentEncoder*) const 10 CoreIPC::ArgumentCoder<Messages::WebPageProxy::DidFailProvisionalLoadForFrame>::encode(CoreIPC::ArgumentEncoder*, Messages::WebPageProxy::DidFailProvisionalLoadForFrame const&) 11 void CoreIPC::ArgumentEncoder::encode<Messages::WebPageProxy::DidFailProvisionalLoadForFrame>(Messages::WebPageProxy::DidFailProvisionalLoadForFrame const&) 12 bool CoreIPC::MessageSender<WebKit::WebPage>::send<Messages::WebPageProxy::DidFailProvisionalLoadForFrame>(Messages::WebPageProxy::DidFailProvisionalLoadForFrame const&, unsigned long long) 13 bool CoreIPC::MessageSender<WebKit::WebPage>::send<Messages::WebPageProxy::DidFailProvisionalLoadForFrame>(Messages::WebPageProxy::DidFailProvisionalLoadForFrame const&) 14 WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad(WebCore::ResourceError const&) 15 WebCore::FrameLoader::checkLoadCompleteForThisFrame() 16 WebCore::FrameLoader::checkLoadComplete() 17 WebCore::FrameLoader::checkCompleted() 18 WebCore::FrameLoader::completed() 19 WebCore::FrameLoader::checkCompleted() 20 WebCore::FrameLoader::completed() 21 WebCore::FrameLoader::checkCompleted() 22 WebCore::FrameLoader::mainReceivedCompleteError(WebCore::DocumentLoader*, WebCore::ResourceError const&) 23 WebCore::DocumentLoader::mainReceivedError(WebCore::ResourceError const&, bool) 24 WebCore::FrameLoader::receivedMainResourceError(WebCore::ResourceError const&, bool) 25 WebCore::MainResourceLoader::receivedError(WebCore::ResourceError const&) 26 WebCore::MainResourceLoader::didFail(WebCore::ResourceError const&) 27 WebCore::ResourceLoader::cannotShowURL(WebCore::ResourceHandle*) 28 WebCore::ResourceHandle::fireFailure(WebCore::Timer<WebCore::ResourceHandle>*) 29 WebCore::Timer<WebCore::ResourceHandle>::fired() 30 WebCore::ThreadTimers::sharedTimerFiredInternal() 31 WebCore::ThreadTimers::sharedTimerFired() 461582 2 ap 2011-09-02 15:30:41 -0700 r94298 is the only code change in this range, but I don't see how it could possibly cause this. 578051 3 jberlin 2012-03-13 17:39:13 -0700 This is still affecting the bots: http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r110638%20(4870)/http/tests/media/video-play-progress-crash-log.txt And I can reliably reproduce it on Lion with the following command: run-webkit-tests -2 LayoutTests/editing/input/reveal-* 578052 4 webkit-bug-importer 2012-03-13 17:39:30 -0700 <rdar://problem/11043492> 579644 5 ap 2012-03-15 12:38:06 -0700 I suspect that this always failed in WebKitTestRunner. r94296-r94298 in particular certainly couldn't have caused this. The reason why this doesn't happen in Safari or DumpRenderTree is that policy delegate says to ignore an invalid URL "<p>FAILURE</p>". But WebKitTestRunner lets any URL load, so WebKit tries to, and has to make an error callback with this URL. 579650 6 132106 ap 2012-03-15 12:47:15 -0700 Created attachment 132106 proposed fix 579662 7 132106 buildbot 2012-03-15 12:59:07 -0700 Comment on attachment 132106 proposed fix Attachment 132106 did not pass win-ews (win): Output: http://queues.webkit.org/results/11951860 579721 8 ap 2012-03-15 14:07:49 -0700 Committed <http://trac.webkit.org/changeset/110882>. 132106 2012-03-15 12:47:15 -0700 2012-03-15 12:59:07 -0700 proposed fix ResourceErrorInvalidURL.txt text/plain 2839 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDg3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTE1ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEFzc2VydGlvbiBmYWlsdXJl cyBpbiBjaGVja0VuY29kZWRTdHJpbmcgd2hlbiBydW5uaW5nIFdlYktpdDIgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NDI1CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xMTA0MzQ5Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VFcnJvckNG LmNwcDogKFdlYkNvcmU6OlJlc291cmNlRXJyb3I6OmNmRXJyb3IpOgorICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvbWFjL1Jlc291cmNlRXJyb3JNYWMubW06IChXZWJDb3JlOjpSZXNvdXJjZUVy cm9yOjpuc0Vycm9yKToKKyAgICAgICAgVGhlIGZhaWxpbmcgVVJMIGlzIGNlcnRhaW5seSBub3Qg Z3VhcmFudGVlZCB0byBiZSB2YWxpZCwgc28gaXQncyBub3QgY29ycmVjdCB0byBwdXQgaXQgYmFj aworICAgICAgICBpbnRvIGEgVVJMIGFzIGlmIGl0J3MgYmVlbiBub3JtYWxpemVkIGJ5IEtVUkwu CisKIDIwMTItMDMtMTUgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBub3JtYWxpemUgdmVydGljYWwgb3ZlcnZpZXcgYmFycyBi eSBsb25nZXN0IGJhciwgbm90IGJ5IGxvbmdlc3QgZnJhbWUKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VFcnJvckNGLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlRXJyb3JDRi5jcHAJKHJl dmlzaW9uIDExMDg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVz b3VyY2VFcnJvckNGLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ4LDcgKzE0OCw3IEBAIENGRXJy b3JSZWYgUmVzb3VyY2VFcnJvcjo6Y2ZFcnJvcigpIGNvbnMKICAgICAgICAgaWYgKCFtX2ZhaWxp bmdVUkwuaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGZh aWxpbmdVUkxTdHJpbmcoQWRvcHRDRiwgbV9mYWlsaW5nVVJMLmNyZWF0ZUNGU3RyaW5nKCkpOwog ICAgICAgICAgICAgQ0ZEaWN0aW9uYXJ5U2V0VmFsdWUodXNlckluZm8uZ2V0KCksIGZhaWxpbmdV UkxTdHJpbmdLZXksIGZhaWxpbmdVUkxTdHJpbmcuZ2V0KCkpOwotICAgICAgICAgICAgUmV0YWlu UHRyPENGVVJMUmVmPiB1cmwoQWRvcHRDRiwgS1VSTChQYXJzZWRVUkxTdHJpbmcsIG1fZmFpbGlu Z1VSTCkuY3JlYXRlQ0ZVUkwoKSk7CisgICAgICAgICAgICBSZXRhaW5QdHI8Q0ZVUkxSZWY+IHVy bChBZG9wdENGLCBDRlVSTENyZWF0ZVdpdGhTdHJpbmcoMCwgZmFpbGluZ1VSTFN0cmluZy5nZXQo KSwgMCk7CiAgICAgICAgICAgICBDRkRpY3Rpb25hcnlTZXRWYWx1ZSh1c2VySW5mby5nZXQoKSwg ZmFpbGluZ1VSTEtleSwgdXJsLmdldCgpKTsKICAgICAgICAgfQogCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUVycm9yTWFjLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlRXJyb3JNYWMu bW0JKHJldmlzaW9uIDExMDg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv bWFjL1Jlc291cmNlRXJyb3JNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEyMSw5ICsxMjEsOSBA QCBOU0Vycm9yICpSZXNvdXJjZUVycm9yOjpuc0Vycm9yKCkgY29uc3QKICAgICAgICAgICAgIFt1 c2VySW5mby5nZXQoKSBzZXRWYWx1ZTptX2xvY2FsaXplZERlc2NyaXB0aW9uIGZvcktleTpOU0xv Y2FsaXplZERlc2NyaXB0aW9uS2V5XTsKIAogICAgICAgICBpZiAoIW1fZmFpbGluZ1VSTC5pc0Vt cHR5KCkpIHsKLSAgICAgICAgICAgIE5TVVJMICpjb2NvYVVSTCA9IEtVUkwoUGFyc2VkVVJMU3Ry aW5nLCBtX2ZhaWxpbmdVUkwpOworICAgICAgICAgICAgUmV0YWluUHRyPE5TVVJMPiBjb2NvYVVS TCA9IGFkb3B0TlMoW1tOU1VSTCBhbGxvY10gaW5pdFdpdGhTdHJpbmc6bV9mYWlsaW5nVVJMXSk7 CiAgICAgICAgICAgICBbdXNlckluZm8uZ2V0KCkgc2V0VmFsdWU6bV9mYWlsaW5nVVJMIGZvcktl eTpAIk5TRXJyb3JGYWlsaW5nVVJMU3RyaW5nS2V5Il07Ci0gICAgICAgICAgICBbdXNlckluZm8u Z2V0KCkgc2V0VmFsdWU6Y29jb2FVUkwgZm9yS2V5OkAiTlNFcnJvckZhaWxpbmdVUkxLZXkiXTsK KyAgICAgICAgICAgIFt1c2VySW5mby5nZXQoKSBzZXRWYWx1ZTpjb2NvYVVSTC5nZXQoKSBmb3JL ZXk6QCJOU0Vycm9yRmFpbGluZ1VSTEtleSJdOwogICAgICAgICB9CiAKICAgICAgICAgbV9wbGF0 Zm9ybUVycm9yLmFkb3B0TlMoW1tOU0Vycm9yIGFsbG9jXSBpbml0V2l0aERvbWFpbjptX2RvbWFp biBjb2RlOm1fZXJyb3JDb2RlIHVzZXJJbmZvOnVzZXJJbmZvLmdldCgpXSk7Cg==