67421 2011-09-01 11:44:47 -0700 HTMLMediaElement should use fastHasAttribute instead of hasAttribute 2011-09-01 14:21:57 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson webkit-bug-importer oldest_to_newest 460647 0 eric.carlson 2011-09-01 11:44:47 -0700 As noted in the review of https://bugs.webkit.org/show_bug.cgi?id=58369, when HTMLMediaElement checks attribute values style attributes and SVG animated attributes are not involved so it would be faster to use fastHasAttribute instead of hasAttribute. 460651 1 webkit-bug-importer 2011-09-01 11:45:49 -0700 <rdar://problem/10061390> 460657 2 105999 eric.carlson 2011-09-01 11:52:35 -0700 Created attachment 105999 Proposed patch 460770 3 105999 simon.fraser 2011-09-01 14:08:46 -0700 Comment on attachment 105999 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=105999&action=review > Source/WebCore/ChangeLog:8 > + No new tests required, this is just an optimization. It would be nice if your change log explained why it's better, for those of us following along. 460780 4 eric.carlson 2011-09-01 14:21:57 -0700 http://trac.webkit.org/changeset/94344 105999 2011-09-01 11:52:35 -0700 2011-09-01 14:08:46 -0700 Proposed patch patch_1.txt text/plain 3914 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MzI0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDktMDEgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgSFRNTE1lZGlhRWxlbWVu dCBzaG91bGQgdXNlIGZhc3RIYXNBdHRyaWJ1dGUgaW5zdGVhZCBvZiBoYXNBdHRyaWJ1dGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NDIxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IHJlcXVpcmVkLCB0aGlzIGlzIGp1c3QgYW4gb3B0aW1pemF0aW9uLgorCisgICAgICAgICogaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1l bnQ6OnNlbGVjdE1lZGlhUmVzb3VyY2UpOiBoYXNBdHRyaWJ1dGUgLT4gZmFzdEhhc0F0dHJpYnV0 ZS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZSk6IERp dHRvLgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6YXV0b3BsYXkpOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6Omxvb3ApOiBEaXR0by4KKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNvbnRyb2xzKTogRGl0dG8uCisgICAg ICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZWxlY3ROZXh0U291cmNlQ2hpbGQpOiBE aXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnNvdXJjZVdhc0FkZGVk KTogRGl0dG8uCisKIDIwMTEtMDktMDEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjk0MjU5KTogVHdvIHRlc3RzIGRvaW5nIGhp dCB0ZXN0aW5nIHdlcmUgYnJva2VuIGJ5IHRoaXMgY2hhbmdlLgpJbmRleDogU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiA5NDMxOCkKKysrIFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzOCw3 ICs2MzgsNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNlbGVjdE1lZGlhUmVzb3VyCiAgICAg TW9kZSBtb2RlID0gYXR0cmlidXRlOwogCiAgICAgLy8gMyAtIC4uLiB0aGUgbWVkaWEgZWxlbWVu dCBoYXMgbmVpdGhlciBhIHNyYyBhdHRyaWJ1dGUgLi4uCi0gICAgaWYgKCFoYXNBdHRyaWJ1dGUo c3JjQXR0cikpIHsKKyAgICBpZiAoIWZhc3RIYXNBdHRyaWJ1dGUoc3JjQXR0cikpIHsKICAgICAg ICAgLy8gLi4uIG5vciBhIHNvdXJjZSBlbGVtZW50IGNoaWxkOiAuLi4KICAgICAgICAgTm9kZSog bm9kZTsKICAgICAgICAgZm9yIChub2RlID0gZmlyc3RDaGlsZCgpOyBub2RlOyBub2RlID0gbm9k ZS0+bmV4dFNpYmxpbmcoKSkgewpAQCAtODA5LDcgKzgwOSw3IEBAIHZvaWQgSFRNTE1lZGlhRWxl bWVudDo6bG9hZFJlc291cmNlKGNvbnMKICAgICAgICAgbV9wbGF5ZXItPnNldFByZWxvYWQobV9w cmVsb2FkKTsKICAgICBtX3BsYXllci0+c2V0UHJlc2VydmVzUGl0Y2gobV93ZWJraXRQcmVzZXJ2 ZXNQaXRjaCk7CiAKLSAgICBpZiAoaGFzQXR0cmlidXRlKG11dGVkQXR0cikpCisgICAgaWYgKGZh c3RIYXNBdHRyaWJ1dGUobXV0ZWRBdHRyKSkKICAgICAgICAgbV9tdXRlZCA9IHRydWU7CiAgICAg dXBkYXRlVm9sdW1lKCk7CiAKQEAgLTE1MzMsNyArMTUzMyw3IEBAIGJvb2wgSFRNTE1lZGlhRWxl bWVudDo6ZW5kZWQoKSBjb25zdAogCiBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OmF1dG9wbGF5KCkg Y29uc3QKIHsKLSAgICByZXR1cm4gaGFzQXR0cmlidXRlKGF1dG9wbGF5QXR0cik7CisgICAgcmV0 dXJuIGZhc3RIYXNBdHRyaWJ1dGUoYXV0b3BsYXlBdHRyKTsKIH0KIAogdm9pZCBIVE1MTWVkaWFF bGVtZW50OjpzZXRBdXRvcGxheShib29sIGIpCkBAIC0xNzE4LDcgKzE3MTgsNyBAQCB2b2lkIEhU TUxNZWRpYUVsZW1lbnQ6OnNldFNvdXJjZVN0YXRlKFNvCiAKIGJvb2wgSFRNTE1lZGlhRWxlbWVu dDo6bG9vcCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIGhhc0F0dHJpYnV0ZShsb29wQXR0cik7Cisg ICAgcmV0dXJuIGZhc3RIYXNBdHRyaWJ1dGUobG9vcEF0dHIpOwogfQogCiB2b2lkIEhUTUxNZWRp YUVsZW1lbnQ6OnNldExvb3AoYm9vbCBiKQpAQCAtMTc0Myw3ICsxNzQzLDcgQEAgYm9vbCBIVE1M TWVkaWFFbGVtZW50Ojpjb250cm9scygpIGNvbnN0CiAgICAgaWYgKGlzRnVsbHNjcmVlbigpKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIHJldHVybiBoYXNBdHRyaWJ1dGUoY29udHJvbHNB dHRyKTsKKyAgICByZXR1cm4gZmFzdEhhc0F0dHJpYnV0ZShjb250cm9sc0F0dHIpOwogfQogCiB2 b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldENvbnRyb2xzKGJvb2wgYikKQEAgLTE5NjUsNyArMTk2 NSw3IEBAIEtVUkwgSFRNTE1lZGlhRWxlbWVudDo6c2VsZWN0TmV4dFNvdXJjZUMKICAgICAgICAg aWYgKG1lZGlhVVJMLmlzRW1wdHkoKSkKICAgICAgICAgICAgIGdvdG8gY2hlY2tfYWdhaW47CiAg ICAgICAgIAotICAgICAgICBpZiAoc291cmNlLT5oYXNBdHRyaWJ1dGUobWVkaWFBdHRyKSkgewor ICAgICAgICBpZiAoc291cmNlLT5mYXN0SGFzQXR0cmlidXRlKG1lZGlhQXR0cikpIHsKICAgICAg ICAgICAgIE1lZGlhUXVlcnlFdmFsdWF0b3Igc2NyZWVuRXZhbCgic2NyZWVuIiwgZG9jdW1lbnQo KS0+ZnJhbWUoKSwgcmVuZGVyZXIoKSA/IHJlbmRlcmVyKCktPnN0eWxlKCkgOiAwKTsKICAgICAg ICAgICAgIFJlZlB0cjxNZWRpYUxpc3Q+IG1lZGlhID0gTWVkaWFMaXN0OjpjcmVhdGVBbGxvd2lu Z0Rlc2NyaXB0aW9uU3ludGF4KHNvdXJjZS0+bWVkaWEoKSk7CiAjaWYgIUxPR19ESVNBQkxFRApA QCAtMTk3Niw3ICsxOTc2LDcgQEAgS1VSTCBIVE1MTWVkaWFFbGVtZW50OjpzZWxlY3ROZXh0U291 cmNlQwogICAgICAgICAgICAgICAgIGdvdG8gY2hlY2tfYWdhaW47CiAgICAgICAgIH0KIAotICAg ICAgICBpZiAoc291cmNlLT5oYXNBdHRyaWJ1dGUodHlwZUF0dHIpKSB7CisgICAgICAgIGlmIChz b3VyY2UtPmZhc3RIYXNBdHRyaWJ1dGUodHlwZUF0dHIpKSB7CiAjaWYgIUxPR19ESVNBQkxFRAog ICAgICAgICAgICAgaWYgKHNob3VsZExvZykKICAgICAgICAgICAgICAgICBMT0coTWVkaWEsICJI VE1MTWVkaWFFbGVtZW50OjpzZWxlY3ROZXh0U291cmNlQ2hpbGQgLSAndHlwZScgaXMgJXMiLCBz b3VyY2UtPnR5cGUoKS51dGY4KCkuZGF0YSgpKTsKQEAgLTIwMjgsNyArMjAyOCw3IEBAIHZvaWQg SFRNTE1lZGlhRWxlbWVudDo6c291cmNlV2FzQWRkZWQoSFQKICNlbmRpZgogICAgIAogICAgIC8v IFdlIHNob3VsZCBvbmx5IGNvbnNpZGVyIGEgPHNvdXJjZT4gZWxlbWVudCB3aGVuIHRoZXJlIGlz IG5vdCBzcmMgYXR0cmlidXRlIGF0IGFsbC4KLSAgICBpZiAoaGFzQXR0cmlidXRlKHNyY0F0dHIp KQorICAgIGlmIChmYXN0SGFzQXR0cmlidXRlKHNyY0F0dHIpKQogICAgICAgICByZXR1cm47CiAK ICAgICAvLyA0LjguOCAtIElmIGEgc291cmNlIGVsZW1lbnQgaXMgaW5zZXJ0ZWQgYXMgYSBjaGls ZCBvZiBhIG1lZGlhIGVsZW1lbnQgdGhhdCBoYXMgbm8gc3JjIAo=