67413 2011-09-01 09:37:02 -0700 [Chromium]Web Inspector: inspected page with dedicated worker crashes on refresh 2011-09-07 00:49:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys dslomov apavlov bweinstein dimich dslomov keishi levin loislo pfeldman pmuellr rik webkit.review.bot yurys oldest_to_newest 460520 0 yurys 2011-09-01 09:37:02 -0700 1. Open a page with dedicated worker 2. Inspect the worker 3. Try to reload the page Result: Page crashes. Stack trace: (gdb) bt #0 0x00007fffea5bda75 in raise (sig=<value optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 #1 0x00007fffea5c15c0 in abort () at abort.c:92 #2 0x00007ffff312e09f in v8::internal::OS::Abort () at v8/src/platform-linux.cc:421 #3 0x00007ffff2e329ce in V8_Fatal (file=0x7ffff5dc6bc4 "v8/src/isolate.h", line=444, format=0x7ffff5dc6890 "CHECK(%s) failed") at v8/src/checks.cc:58 #4 0x00007ffff2de95a8 in CheckHelper (file=0x7ffff5dc6bc4 "v8/src/isolate.h", line=444, source=0x7ffff5dc6bb2 "isolate != __null", condition=false) at v8/src/checks.h:60 #5 0x00007ffff2e06ab2 in v8::internal::Isolate::Current () at v8/src/isolate.h:444 #6 0x00007ffff2e329c1 in V8_Fatal (file=0x7ffff5dc6bc4 "v8/src/isolate.h", line=444, format=0x7ffff5dc6890 "CHECK(%s) failed") at v8/src/checks.cc:55 #7 0x00007ffff2de95a8 in CheckHelper (file=0x7ffff5dc6bc4 "v8/src/isolate.h", line=444, source=0x7ffff5dc6bb2 "isolate != __null", condition=false) at v8/src/checks.h:60 #8 0x00007ffff2e06ab2 in v8::internal::Isolate::Current () at v8/src/isolate.h:444 #9 0x00007ffff2e329c1 in V8_Fatal (file=0x7ffff5dc6bc4 "v8/src/isolate.h", line=444, format=0x7ffff5dc6890 "CHECK(%s) failed") at v8/src/checks.cc:55 #10 0x00007ffff2de95a8 in CheckHelper (file=0x7ffff5dc6bc4 "v8/src/isolate.h", line=444, source=0x7ffff5dc6bb2 "isolate != __null", condition=false) at v8/src/checks.h:60 #11 0x00007ffff2e06ab2 in v8::internal::Isolate::Current () at v8/src/isolate.h:444 #12 0x00007ffff2deaa9b in v8::V8::IsGlobalWeak (obj=0x7fffd35702a0) at v8/src/api.cc:622 #13 0x00007ffff393efa5 in v8::Persistent<v8::Object>::IsWeak (this=0x7fffd612e580) at v8/include/v8.h:3865 #14 0x00007ffff393e95a in WebCore::OwnHandle<v8::Object>::clear (this=0x7fffd612e580) at third_party/WebKit/Source/WebCore/bindings/v8/OwnHandle.h:53 #15 0x00007ffff393e5a4 in WebCore::OwnHandle<v8::Object>::~OwnHandle (this=0x7fffd612e580, __in_chrg=<value optimized out>) at third_party/WebKit/Source/WebCore/bindings/v8/OwnHandle.h:43 #16 0x00007ffff393e3d0 in WebCore::ScriptDebugServer::~ScriptDebugServer (this=0x7fffd612e570, __in_chrg=<value optimized out>) at third_party/WebKit/Source/WebCore/bindings/v8/ScriptDebugServer.h:92 #17 0x00007ffff3dd044a in WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer (this=0x7fffd612e570, __in_chrg=<value optimized out>) at third_party/WebKit/Source/WebCore/bindings/v8/WorkerScriptDebugServer.h:46 #18 0x00007ffff3dd0326 in WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent (this=0x7fffd612e480, __in_chrg=<value optimized out>) at third_party/WebKit/Source/WebCore/inspector/WorkerDebuggerAgent.cpp:53 #19 0x00007ffff3af9a5c in WTF::deleteOwnedPtr<WebCore::InspectorDebuggerAgent> (ptr=0x7fffd612e480) at third_party/WebKit/Source/JavaScriptCore/wtf/OwnPtrCommon.h:65 #20 0x00007ffff3af8765 in WTF::OwnPtr<WebCore::InspectorDebuggerAgent>::~OwnPtr (this=0x7fffd356c070, __in_chrg=<value optimized out>) at third_party/WebKit/Source/JavaScriptCore/wtf/OwnPtr.h:54 #21 0x00007ffff3b5586e in WebCore::WorkerInspectorController::~WorkerInspectorController (this=0x7fffd356c050, __in_chrg=<value optimized out>) at third_party/WebKit/Source/WebCore/inspector/WorkerInspectorController.cpp:119 #22 0x00007ffff3cc8a43 in WTF::deleteOwnedPtr<WebCore::WorkerInspectorController> (ptr=0x7fffd356c050) at third_party/WebKit/Source/JavaScriptCore/wtf/OwnPtrCommon.h:65 #23 0x00007ffff3cc7d05 in WTF::OwnPtr<WebCore::WorkerInspectorController>::~OwnPtr (this=0x7fffd542e6b0, __in_chrg=<value optimized out>) at third_party/WebKit/Source/JavaScriptCore/wtf/OwnPtr.h:54 #24 0x00007ffff3cc4ee4 in WebCore::WorkerContext::~WorkerContext (this=0x7fffd542e400, __in_chrg=<value optimized out>) at third_party/WebKit/Source/WebCore/workers/WorkerContext.cpp:131 #25 0x00007ffff3e25a0c in WebCore::DedicatedWorkerContext::~DedicatedWorkerContext (this=0x7fffd542e400, __in_chrg=<value optimized out>) at third_party/WebKit/Source/WebCore/workers/DedicatedWorkerContext.h:43 #26 0x00007ffff3cc3bcf in WTF::RefCounted<WebCore::WorkerContext>::deref (this=0x7fffd542e5f0) at third_party/WebKit/Source/JavaScriptCore/wtf/RefCounted.h:184 #27 0x00007ffff3cd3d76 in WTF::derefIfNotNull<WebCore::WorkerContext> (ptr=0x7fffd542e400) at third_party/WebKit/Source/JavaScriptCore/wtf/PassRefPtr.h:59 #28 0x00007ffff3cd3b8e in WTF::RefPtr<WebCore::WorkerContext>::operator= (this=0x7fffd611ec20, optr=0x0) at third_party/WebKit/Source/JavaScriptCore/wtf/RefPtr.h:135 #29 0x00007ffff3cd334c in WebCore::WorkerThread::workerThread (this=0x7fffd611eb40) at third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:149 #30 0x00007ffff3cd30ea in WebCore::WorkerThread::workerThreadStart (thread=0x7fffd611eb40) at third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:118 #31 0x00007ffff4f0c6e1 in WTF::threadEntryPoint (contextData=0x7fffd33d2c00) at third_party/WebKit/Source/JavaScriptCore/wtf/Threading.cpp:67 #32 0x00007fffed0a49ca in start_thread (arg=<value optimized out>) at pthread_create.c:300 #33 0x00007fffea67070d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112 #34 0x0000000000000000 in ?? () 460549 1 yurys 2011-09-01 10:07:26 -0700 The problem is that the worker isolate is destroyed before the ScriptDebugServer which holds OwnHandle on an object from the isolate. Dmitry, could you take a look at this? (gdb) bt #0 v8::Isolate::Dispose (this=0x7fffd35da000) at v8/src/api.cc:5052 #1 0x00007ffff397eb59 in WebCore::WorkerScriptController::~WorkerScriptController (this=0x7fffd35d9a00, __in_chrg=<value optimized out>) at third_party/WebKit/Source/WebCore/bindings/v8/WorkerScriptController.cpp:70 #2 0x00007ffff3cc76e1 in WTF::deleteOwnedPtr<WebCore::WorkerScriptController> (ptr=0x7fffd35d9a00) at third_party/WebKit/Source/JavaScriptCore/wtf/OwnPtrCommon.h:65 #3 0x00007ffff3cd29a0 in WTF::OwnPtr<WebCore::WorkerScriptController>::clear (this=0x7fffd9a2b290) at third_party/WebKit/Source/JavaScriptCore/wtf/OwnPtr.h:99 #4 0x00007ffff3cd2528 in WebCore::WorkerContext::clearScript (this=0x7fffd9a2b000) at third_party/WebKit/Source/WebCore/workers/WorkerContext.h:81 #5 0x00007ffff3cd26dc in WebCore::WorkerThreadShutdownFinishTask::performTask (this=0x7fffd37cef10, context=0x7fffd9a2b000) at third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:178 #6 0x00007ffff3cce7e0 in WebCore::WorkerRunLoop::Task::performTask (this=0x7fffd353a540, context=0x7fffd9a2b000) at third_party/WebKit/Source/WebCore/workers/WorkerRunLoop.cpp:200 #7 0x00007ffff3cce598 in WebCore::WorkerRunLoop::runInMode (this=0x7fffdf367a30, context=0x7fffd9a2b000, predicate=...) at third_party/WebKit/Source/WebCore/workers/WorkerRunLoop.cpp:164 #8 0x00007ffff3cce32d in WebCore::WorkerRunLoop::run (this=0x7fffdf367a30, context=0x7fffd9a2b000) at third_party/WebKit/Source/WebCore/workers/WorkerRunLoop.cpp:135 #9 0x00007ffff3cd23eb in WebCore::WorkerThread::runEventLoop (this=0x7fffdf367a00) at third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:163 #10 0x00007ffff3cc2b29 in WebCore::DedicatedWorkerThread::runEventLoop (this=0x7fffdf367a00) at third_party/WebKit/Source/WebCore/workers/DedicatedWorkerThread.cpp:66 #11 0x00007ffff3cd2309 in WebCore::WorkerThread::workerThread (this=0x7fffdf367a00) at third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:141 #12 0x00007ffff3cd212e in WebCore::WorkerThread::workerThreadStart (thread=0x7fffdf367a00) at third_party/WebKit/Source/WebCore/workers/WorkerThread.cpp:118 #13 0x00007ffff4f0b721 in WTF::threadEntryPoint (contextData=0x7fffe004d8c0) at third_party/WebKit/Source/JavaScriptCore/wtf/Threading.cpp:67 #14 0x00007fffed0a39ca in start_thread (arg=<value optimized out>) at pthread_create.c:300 #15 0x00007fffea66f70d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112 #16 0x0000000000000000 in ?? () 463013 2 106524 dslomov 2011-09-06 17:34:30 -0700 Created attachment 106524 This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController. 463118 3 106524 dslomov 2011-09-06 20:57:12 -0700 Comment on attachment 106524 This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController. chromium trybots are happy 463212 4 106524 webkit.review.bot 2011-09-07 00:49:31 -0700 Comment on attachment 106524 This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController. Clearing flags on attachment: 106524 Committed r94647: <http://trac.webkit.org/changeset/94647> 463213 5 webkit.review.bot 2011-09-07 00:49:37 -0700 All reviewed patches have been landed. Closing bug. 106524 2011-09-06 17:34:30 -0700 2011-09-07 00:49:31 -0700 This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController. 67413.patch text/plain 2690 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZWNkNDMzLi4yMDc2Y2QzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDktMDYgIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc0MTMgCisgICAg ICAgIFtDaHJvbWl1bV1XZWIgSW5zcGVjdG9yOiBpbnNwZWN0ZWQgcGFnZSB3aXRoIGRlZGljYXRl ZCB3b3JrZXIgY3Jhc2hlcyBvbiByZWZyZXNoLgorICAgICAgICBUaGlzIHBhdGNoIGVuZm9yY2Vz IGxpZmV0aW1lIG9yZGVyaW5nIGJldHdlZW4gV29ya2VySW5zcGVjdG9yQ29udHJvbGxlciBhbmQg V29ya2VyU2NyaXB0Q29udHJvbGxlci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHdvcmtlcnMvV29ya2VyQ29udGV4dC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpXb3JrZXJDb250ZXh0OjpjbGVhckluc3BlY3Rvcik6CisgICAgICAgICogd29ya2Vy cy9Xb3JrZXJDb250ZXh0Lmg6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJUaHJlYWQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6V29ya2VyVGhyZWFkU2h1dGRvd25GaW5pc2hUYXNrOjpwZXJmb3Jt VGFzayk6CisKIDIwMTEtMDktMDYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzY1NwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5jcHAKaW5kZXggOTMwYzM2MC4uMzkyNTlj OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwCkBAIC0yMTksNiAr MjE5LDEzIEBAIHZvaWQgV29ya2VyQ29udGV4dDo6Y2xlYXJUaW1lb3V0KGludCB0aW1lb3V0SWQp CiAgICAgRE9NVGltZXI6OnJlbW92ZUJ5SWQoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCB0aW1l b3V0SWQpOwogfQogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKK3ZvaWQgV29ya2VyQ29udGV4dDo6 Y2xlYXJJbnNwZWN0b3IoKQoreworICAgIG1fd29ya2VySW5zcGVjdG9yQ29udHJvbGxlci5jbGVh cigpOworfQorI2VuZGlmCisKIGludCBXb3JrZXJDb250ZXh0OjpzZXRJbnRlcnZhbChQYXNzT3du UHRyPFNjaGVkdWxlZEFjdGlvbj4gYWN0aW9uLCBpbnQgdGltZW91dCkKIHsKICAgICByZXR1cm4g RE9NVGltZXI6Omluc3RhbGwoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCBhY3Rpb24sIHRpbWVv dXQsIGZhbHNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29u dGV4dC5oIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmgKaW5kZXggMDcz NzY3OTIuLmRlYmM2YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2Vy Q29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5oCkBA IC03OSw2ICs3OSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICBXb3JrZXJTY3Jp cHRDb250cm9sbGVyKiBzY3JpcHQoKSB7IHJldHVybiBtX3NjcmlwdC5nZXQoKTsgfQogICAgICAg ICB2b2lkIGNsZWFyU2NyaXB0KCkgeyBtX3NjcmlwdC5jbGVhcigpOyB9CisjaWYgRU5BQkxFKElO U1BFQ1RPUikKKyAgICAgICAgdm9pZCBjbGVhckluc3BlY3RvcigpOworI2VuZGlmCiAKICAgICAg ICAgV29ya2VyVGhyZWFkKiB0aHJlYWQoKSBjb25zdCB7IHJldHVybiBtX3RocmVhZDsgfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlclRocmVhZC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlclRocmVhZC5jcHAKaW5kZXggNDFkNDAzYi4uNWRlMDNk YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJUaHJlYWQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhyZWFkLmNwcApAQCAtMTc0LDYgKzE3 NCw5IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIEFTU0VSVChjb250ZXh0LT5pc1dvcmtlckNv bnRleHQoKSk7CiAgICAgICAgIFdvcmtlckNvbnRleHQqIHdvcmtlckNvbnRleHQgPSBzdGF0aWNf Y2FzdDxXb3JrZXJDb250ZXh0Kj4oY29udGV4dCk7CisjaWYgRU5BQkxFKElOU1BFQ1RPUikKKyAg ICAgICAgd29ya2VyQ29udGV4dC0+Y2xlYXJJbnNwZWN0b3IoKTsKKyNlbmRpZgogICAgICAgICAv LyBJdCdzIG5vdCBzYWZlIHRvIGNhbGwgY2xlYXJTY3JpcHQgdW50aWwgYWxsIHRoZSBjbGVhbnVw IHRhc2tzIHBvc3RlZCBieSBmdW5jdGlvbnMgaW5pdGlhdGVkIGJ5IFdvcmtlclRocmVhZFNodXRk b3duU3RhcnRUYXNrIGhhdmUgY29tcGxldGVkLgogICAgICAgICB3b3JrZXJDb250ZXh0LT5jbGVh clNjcmlwdCgpOwogICAgICAgICB3b3JrZXJDb250ZXh0LT50aHJlYWQoKS0+cnVuTG9vcCgpLnRl cm1pbmF0ZSgpOwo=