<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67404</bug_id>
          
          <creation_ts>2011-09-01 07:54:10 -0700</creation_ts>
          <short_desc>[cairo] GraphicsContextCairo::FillRect with a solid colour does not respect operator</short_desc>
          <delta_ts>2012-04-25 08:37:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>84848</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Rob Bradford">rob</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>d-r</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>460460</commentid>
    <comment_count>0</comment_count>
    <who name="Rob Bradford">rob</who>
    <bug_when>2011-09-01 07:54:10 -0700</bug_when>
    <thetext>In the GraphicsContext function:

void GraphicsContext::fillRect(const FloatRect&amp; rect, const Color&amp; color, ColorSpace styleColorSpace, CompositeOperator op)

(which is not overridden in the GraphicsContextCairo)

It sets the operator and then proceeds to call the fillRect(const FloatRect&amp; rect, const Color&amp; color, ColorSpace styleColorSpace) (i.e. the version without the operator)

The problem is that the fillRectWithColor in GraphicsContextCairo.cpp always uses the OVER operator.

Without respecting the operator I think we would see incorrect results from code that triggers

&quot;
        if (baseColor.alpha()) {
            if (bgColor.alpha())
                baseColor = baseColor.blend(bgColor);

            context-&gt;fillRect(backgroundRect, baseColor, style()-&gt;colorSpace(), CompositeCopy);
        } else if (bgColor.alpha()) {
            CompositeOperator operation = shouldClearBackground ? CompositeCopy : context-&gt;compositeOperation();
            context-&gt;fillRect(backgroundRect, bgColor, style()-&gt;colorSpace(), operation);
        } else if (shouldClearBackground)
            context-&gt;clearRect(backgroundRect);

&quot; from RenderBoxModelObject::paintFillLayerExtended</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>460477</commentid>
    <comment_count>1</comment_count>
      <attachid>105968</attachid>
    <who name="Rob Bradford">rob</who>
    <bug_when>2011-09-01 08:20:39 -0700</bug_when>
    <thetext>Created attachment 105968
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>460480</commentid>
    <comment_count>2</comment_count>
      <attachid>105969</attachid>
    <who name="Rob Bradford">rob</who>
    <bug_when>2011-09-01 08:28:20 -0700</bug_when>
    <thetext>Created attachment 105969
Fix gramatical errors in the ChangeLog entry on the original patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>460542</commentid>
    <comment_count>3</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-09-01 10:01:11 -0700</bug_when>
    <thetext>Do you have a test case where this fails? In what cases would this lead to degraded performance?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>460588</commentid>
    <comment_count>4</comment_count>
    <who name="Rob Bradford">rob</who>
    <bug_when>2011-09-01 10:40:57 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Do you have a test case where this fails? In what cases would this lead to degraded performance?

I observed this bug by observation of the code. I will try and figure out a test case that triggers a visual issue because of this bug.

In terms of performance painting with OVER is more costly than SOURCE since SOURCE can be optimised to a blit by Cairo in many situations (since it doesn&apos;t depend on the value that is currently in the destination.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465030</commentid>
    <comment_count>5</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-09-09 14:40:29 -0700</bug_when>
    <thetext>(In reply to comment #4)

&gt; In terms of performance painting with OVER is more costly than SOURCE since SOURCE can be optimised to a blit by Cairo in many situations (since it doesn&apos;t depend on the value that is currently in the destination.)

Thanks. This is very likely a bug!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>524165</commentid>
    <comment_count>6</comment_count>
      <attachid>105969</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-12-19 13:53:00 -0800</bug_when>
    <thetext>Comment on attachment 105969
Fix gramatical errors in the ChangeLog entry on the original patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105969&amp;action=review

How do we test this?

&gt; Source/WebCore/ChangeLog:5
&gt; +

Please don&apos;t remove the REviewed by line, otherwise the tools can&apos;t fill it in fo ryou.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>609791</commentid>
    <comment_count>7</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-04-25 08:32:37 -0700</bug_when>
    <thetext>*** Bug 84848 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>609798</commentid>
    <comment_count>8</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-04-25 08:37:48 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 84848 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>105968</attachid>
            <date>2011-09-01 08:20:39 -0700</date>
            <delta_ts>2011-09-01 08:28:20 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>0001-Cairo-GraphicsContext-fillRect-ignores-operator-that.patch</filename>
            <type>text/plain</type>
            <size>3459</size>
            <attacher name="Rob Bradford">rob</attacher>
            
              <data encoding="base64">RnJvbSBjOTc5NThkNDM1YTlkMGQ1MTc2NGFhOTgzMjgxOGUzYTI5YzBlNmJhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgQnJhZGZvcmQgPHJvYkBsaW51eC5pbnRlbC5jb20+CkRh
dGU6IFRodSwgMSBTZXAgMjAxMSAxNjoxODo0NyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFtDYWly
b10gR3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdCBpZ25vcmVzIG9wZXJhdG9yIHRoYXQgd2FzCiBz
ZXQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NDA0CgpUaGUgaGVs
cGVyIGZ1bmN0aW9uIHdhcyBhbHdheXMgc2V0dGluZyB0aGUgY2Fpcm8gb3BlcmF0b3IgdG8gT1ZF
UiBldmVuCmlmIHRoZSB0aGUgb3BlcmF0b3Igd2FzIHNldCB0byBzb21ldGhpbmcgZWxzZS4gVGhp
cyBjb3VsZCByZXN1bHQgaW4KaW5jb3JyZWN0IHJlbmRlcmluZyBvciBwZXJmb3JtYW5jZSBkZWNs
aW5lIHdoZW4gdGhlIG1vcmUgY29tcGxleApvcGVyYXRvciBpcyB1c2VkIG92ZXIgdGhlIHNpbXBs
ZXIgb25lLgoKKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5j
cHA6CihXZWJDb3JlOjpmaWxsUmVjdFdpdGhDb2xvcik6CkRvbid0IHNldCB0aGUgb3BlcmF0b3Ig
b24gdGhlIGNhaXJvIGNvbnRleHQgaW4gdGhlIGhlbHBlciBmdW5jdGlvbgooV2ViQ29yZTo6R3Jh
cGhpY3NDb250ZXh0OjpkcmF3UmVjdCk6CihXZWJDb3JlOjpkcmF3TGluZU9uQ2Fpcm9Db250ZXh0
KToKU2V0IG9wZXJhdG9ycyBvbiB0aGUgY2Fpcm8gY29udGV4dCB0byBlbnN1cmUgc2FtZSBiZWhh
dmlvdXIuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg
ICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp
Y3NDb250ZXh0Q2Fpcm8uY3BwICAgICAgICB8ICAgIDQgKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAy
MCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOGRjM2M0Li5i
YTY5OGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl
L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMDEgIFJvYiBCcmFk
Zm9yZCAgPHJvYkBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0NhaXJvXSBHcmFwaGljc0Nv
bnRleHQ6OmZpbGxSZWN0IGlnbm9yZXMgb3BlcmF0b3IgdGhhdCB3YXMgc2V0CisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzQwNAorCisgICAgICAgIFRo
ZSBoZWxwZXIgZnVuY3Rpb24gd2FzIGFsd2F5cyBzZXR0aW5nIHRoZSBjYWlybyBvcGVyYXRvciB0
byBPVkVSIGV2ZW4KKyAgICAgICAgaWYgdGhlIHRoZSBvcGVyYXRvciB3YXMgc2V0IHRvIHNvbWV0
aGluZyBlbHNlLiBUaGlzIGNvdWxkIHJlc3VsdCBpbgorICAgICAgICBpbmNvcnJlY3QgcmVuZGVy
aW5nIG9yIHBlcmZvcm1hbmNlIGRlY2xpbmUgd2hlbiB0aGUgbW9yZSBjb21wbGV4CisgICAgICAg
IG9wZXJhdG9yIGlzIHVzZWQgb3ZlciB0aGUgc2ltcGxlciBvbmUuCisKKyAgICAgICAgKiBwbGF0
Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpmaWxsUmVjdFdpdGhDb2xvcik6CisgICAgICAgIERvbid0IHNldCB0aGUgb3BlcmF0
b3Igb24gdGhlIGNhaXJvIGNvbnRleHQgaW4gdGhlIGhlbHBlciBmdW5jdGlvbgorICAgICAgICAo
V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3UmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpk
cmF3TGluZU9uQ2Fpcm9Db250ZXh0KToKKyAgICAgICAgU2V0IG9wZXJhdG9ycyBvbiB0aGUgY2Fp
cm8gY29udGV4dCB0byBlbnN1cmUgc2FtZSBiZWhhdmlvdXIuCisKIDIwMTEtMDgtMzAgIFZzZXZv
bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv
cjogSW5zcGVjdGVkIHBhZ2Ugc29tZXRpbWVzIGNyYXNoZXMgaW4gSW5zcGVjdG9yUmVzb3VyY2VB
Z2VudDo6ZGlkRmFpbExvYWRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAppbmRleCBh
ODU5Zjg3Li4wOGUzYjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCkBAIC03Nyw3
ICs3Nyw2IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBmaWxsUmVjdFdpdGhDb2xvcihjYWlyb190KiBj
ciwgY29uc3QgRmxvYXRSZWN0JiByZWN0LCBjb25zdCBDCiAgICAgICAgIHJldHVybjsKICAgICBz
ZXRTb3VyY2VSR0JBRnJvbUNvbG9yKGNyLCBjb2xvcik7CiAgICAgY2Fpcm9fcmVjdGFuZ2xlKGNy
LCByZWN0LngoKSwgcmVjdC55KCksIHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSk7Ci0gICAg
Y2Fpcm9fc2V0X29wZXJhdG9yKGNyLCBDQUlST19PUEVSQVRPUl9PVkVSKTsKICAgICBjYWlyb19m
aWxsKGNyKTsKIH0KIApAQCAtMjMzLDYgKzIzMiw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0Ojpk
cmF3UmVjdChjb25zdCBJbnRSZWN0JiByZWN0KQogICAgIGNhaXJvX3QqIGNyID0gcGxhdGZvcm1D
b250ZXh0KCktPmNyKCk7CiAgICAgY2Fpcm9fc2F2ZShjcik7CiAKKyAgICBjYWlyb19zZXRfb3Bl
cmF0b3IoY3IsIENBSVJPX09QRVJBVE9SX09WRVIpOwogICAgIGZpbGxSZWN0V2l0aENvbG9yKGNy
LCByZWN0LCBmaWxsQ29sb3IoKSk7CiAKICAgICBpZiAoc3Ryb2tlU3R5bGUoKSAhPSBOb1N0cm9r
ZSkgewpAQCAtMzA5LDYgKzMwOSw4IEBAIHN0YXRpYyB2b2lkIGRyYXdMaW5lT25DYWlyb0NvbnRl
eHQoR3JhcGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGNhaXJvX3QqIGNvCiAgICAgICAg
ICAgICBmaXJzdFJlY3QubW92ZSgtc3Ryb2tlVGhpY2tuZXNzLCAtc3Ryb2tlVGhpY2tuZXNzIC8g
Mik7CiAgICAgICAgICAgICBzZWNvbmRSZWN0Lm1vdmUoMCwgLXN0cm9rZVRoaWNrbmVzcyAvIDIp
OwogICAgICAgICB9CisKKyAgICAgICAgY2Fpcm9fc2V0X29wZXJhdG9yKGNvbnRleHQsIENBSVJP
X09QRVJBVE9SX09WRVIpOwogICAgICAgICBmaWxsUmVjdFdpdGhDb2xvcihjb250ZXh0LCBmaXJz
dFJlY3QsIHN0cm9rZUNvbG9yKTsKICAgICAgICAgZmlsbFJlY3RXaXRoQ29sb3IoY29udGV4dCwg
c2Vjb25kUmVjdCwgc3Ryb2tlQ29sb3IpOwogCi0tIAoxLjcuNgoK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>105969</attachid>
            <date>2011-09-01 08:28:20 -0700</date>
            <delta_ts>2011-12-19 13:53:00 -0800</delta_ts>
            <desc>Fix gramatical errors in the ChangeLog entry on the original patch</desc>
            <filename>0001-Cairo-GraphicsContext-fillRect-ignores-operator-that.patch</filename>
            <type>text/plain</type>
            <size>3453</size>
            <attacher name="Rob Bradford">rob</attacher>
            
              <data encoding="base64">RnJvbSA1NjNmYmUzZDJkNzg5M2E1MTgzNzgyMWZkNmRkMjM4Zjc2NTkwNTE5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgQnJhZGZvcmQgPHJvYkBsaW51eC5pbnRlbC5jb20+CkRh
dGU6IFRodSwgMSBTZXAgMjAxMSAxNjoxODo0NyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFtDYWly
b10gR3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdCBpZ25vcmVzIG9wZXJhdG9yIHRoYXQgd2FzCiBz
ZXQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NDA0CgpUaGUgaGVs
cGVyIGZ1bmN0aW9uIHdhcyBhbHdheXMgc2V0dGluZyB0aGUgY2Fpcm8gb3BlcmF0b3IgdG8gT1ZF
UiBldmVuCmlmIHRoZSB0aGUgb3BlcmF0b3Igd2FzIHNldCB0byBzb21ldGhpbmcgZWxzZS4gVGhp
cyBjb3VsZCByZXN1bHQgaW4KaW5jb3JyZWN0IHJlbmRlcmluZyBvciBwZXJmb3JtYW5jZSBkZWNs
aW5lIHdoZW4gdGhlIG1vcmUgY29tcGxleApvcGVyYXRvciBpcyB1c2VkIG92ZXIgdGhlIHNpbXBs
ZXIgb25lLgoKKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5j
cHA6CihXZWJDb3JlOjpmaWxsUmVjdFdpdGhDb2xvcik6CkRvbid0IHNldCB0aGUgb3BlcmF0b3Ig
b24gdGhlIGNhaXJvIGNvbnRleHQgaW4gdGhlIGhlbHBlciBmdW5jdGlvbgooV2ViQ29yZTo6R3Jh
cGhpY3NDb250ZXh0OjpkcmF3UmVjdCk6CihXZWJDb3JlOjpkcmF3TGluZU9uQ2Fpcm9Db250ZXh0
KToKU2V0IG9wZXJhdG9ycyBvbiB0aGUgY2Fpcm8gY29udGV4dCB0byBlbnN1cmUgc2FtZSBiZWhh
dmlvdXIuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg
ICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp
Y3NDb250ZXh0Q2Fpcm8uY3BwICAgICAgICB8ICAgIDQgKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAy
MCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOGRjM2M0Li5k
ZDhiOWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl
L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMDEgIFJvYiBCcmFk
Zm9yZCAgPHJvYkBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0NhaXJvXSBHcmFwaGljc0Nv
bnRleHQ6OmZpbGxSZWN0IGlnbm9yZXMgb3BlcmF0b3IgdGhhdCB3YXMgc2V0CisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzQwNAorCisgICAgICAgIFRo
ZSBoZWxwZXIgZnVuY3Rpb24gd2FzIGFsd2F5cyBzZXR0aW5nIHRoZSBjYWlybyBvcGVyYXRvciB0
byBPVkVSIGV2ZW4KKyAgICAgICAgaWYgdGhlIG9wZXJhdG9yIHdhcyBzZXQgdG8gc29tZXRoaW5n
IGVsc2UuIFRoaXMgY291bGQgcmVzdWx0IGluCisgICAgICAgIGluY29ycmVjdCByZW5kZXJpbmcg
b3IgcGVyZm9ybWFuY2UgZGVjbGluZSB3aGVuIGEgbW9yZSBjb21wbGV4CisgICAgICAgIG9wZXJh
dG9yIGlzIHVzZWQgb3ZlciB0aGUgc2ltcGxlciBvbmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n
cmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3Jl
OjpmaWxsUmVjdFdpdGhDb2xvcik6CisgICAgICAgIERvbid0IHNldCB0aGUgb3BlcmF0b3Igb24g
dGhlIGNhaXJvIGNvbnRleHQgaW4gdGhlIGhlbHBlciBmdW5jdGlvbgorICAgICAgICAoV2ViQ29y
ZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3UmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpkcmF3TGlu
ZU9uQ2Fpcm9Db250ZXh0KToKKyAgICAgICAgU2V0IG9wZXJhdG9ycyBvbiB0aGUgY2Fpcm8gY29u
dGV4dCB0byBlbnN1cmUgc2FtZSBiZWhhdmlvdXIuCisKIDIwMTEtMDgtMzAgIFZzZXZvbG9kIFZs
YXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5z
cGVjdGVkIHBhZ2Ugc29tZXRpbWVzIGNyYXNoZXMgaW4gSW5zcGVjdG9yUmVzb3VyY2VBZ2VudDo6
ZGlkRmFpbExvYWRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAppbmRleCBhODU5Zjg3
Li4wOGUzYjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j
YWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCkBAIC03Nyw3ICs3Nyw2
IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBmaWxsUmVjdFdpdGhDb2xvcihjYWlyb190KiBjciwgY29u
c3QgRmxvYXRSZWN0JiByZWN0LCBjb25zdCBDCiAgICAgICAgIHJldHVybjsKICAgICBzZXRTb3Vy
Y2VSR0JBRnJvbUNvbG9yKGNyLCBjb2xvcik7CiAgICAgY2Fpcm9fcmVjdGFuZ2xlKGNyLCByZWN0
LngoKSwgcmVjdC55KCksIHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSk7Ci0gICAgY2Fpcm9f
c2V0X29wZXJhdG9yKGNyLCBDQUlST19PUEVSQVRPUl9PVkVSKTsKICAgICBjYWlyb19maWxsKGNy
KTsKIH0KIApAQCAtMjMzLDYgKzIzMiw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3UmVj
dChjb25zdCBJbnRSZWN0JiByZWN0KQogICAgIGNhaXJvX3QqIGNyID0gcGxhdGZvcm1Db250ZXh0
KCktPmNyKCk7CiAgICAgY2Fpcm9fc2F2ZShjcik7CiAKKyAgICBjYWlyb19zZXRfb3BlcmF0b3Io
Y3IsIENBSVJPX09QRVJBVE9SX09WRVIpOwogICAgIGZpbGxSZWN0V2l0aENvbG9yKGNyLCByZWN0
LCBmaWxsQ29sb3IoKSk7CiAKICAgICBpZiAoc3Ryb2tlU3R5bGUoKSAhPSBOb1N0cm9rZSkgewpA
QCAtMzA5LDYgKzMwOSw4IEBAIHN0YXRpYyB2b2lkIGRyYXdMaW5lT25DYWlyb0NvbnRleHQoR3Jh
cGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGNhaXJvX3QqIGNvCiAgICAgICAgICAgICBm
aXJzdFJlY3QubW92ZSgtc3Ryb2tlVGhpY2tuZXNzLCAtc3Ryb2tlVGhpY2tuZXNzIC8gMik7CiAg
ICAgICAgICAgICBzZWNvbmRSZWN0Lm1vdmUoMCwgLXN0cm9rZVRoaWNrbmVzcyAvIDIpOwogICAg
ICAgICB9CisKKyAgICAgICAgY2Fpcm9fc2V0X29wZXJhdG9yKGNvbnRleHQsIENBSVJPX09QRVJB
VE9SX09WRVIpOwogICAgICAgICBmaWxsUmVjdFdpdGhDb2xvcihjb250ZXh0LCBmaXJzdFJlY3Qs
IHN0cm9rZUNvbG9yKTsKICAgICAgICAgZmlsbFJlY3RXaXRoQ29sb3IoY29udGV4dCwgc2Vjb25k
UmVjdCwgc3Ryb2tlQ29sb3IpOwogCi0tIAoxLjcuNgoK
</data>
<flag name="review"
          id="102289"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>