67396 2011-09-01 07:13:59 -0700 Web Inspector: Make it more clear when requests are loaded from cache on network panel. 2011-09-02 04:49:53 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 460427 0 vsevik 2011-09-01 07:13:59 -0700 Make it more clear when requests are loaded from cache on network panel. After recent changes in status column it is not always clear if the resource was loaded from cache or from network. Graying status code out for cached resources should make it better. 460428 1 105955 vsevik 2011-09-01 07:18:07 -0700 Created attachment 105955 Patch 460552 2 105955 pfeldman 2011-09-01 10:10:32 -0700 Comment on attachment 105955 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105955&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1967 > + this._statusCell.addStyleClass("network-dim-cell"); Maybe we should dim entire row instead? 461160 3 vsevik 2011-09-02 04:49:53 -0700 Committed r94410: <http://trac.webkit.org/changeset/94410> 105955 2011-09-01 07:18:07 -0700 2011-09-01 10:10:32 -0700 Patch bug-67396-20110901181804.patch text/plain 4048 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyOTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNDczNjY0NGYzOTNlMTQw ZDAyMGNmOTdkZWNmYTFmZmE5OWVlZWNjLi40NzZhYzU2MjRkNDQ2OTQ1NGFmYWEwZTJhZGVmYTEx YTE1N2JmNGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMDEgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogTWFrZSBpdCBtb3JlIGNsZWFyIHdoZW4gcmVxdWVzdHMgYXJlIGxvYWRlZCBmcm9tIGNhY2hl IG9uIG5ldHdvcmsgcGFuZWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NzM5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuTmV0d29ya0RhdGFHcmlkTm9kZS5wcm90b3R5cGUuX3JlZnJlc2hTdGF0 dXNDZWxsKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlSGVhZGVyc1Zp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VIZWFkZXJzVmlldy5wcm90b3R5 cGUuX3JlZnJlc2hIVFRQSW5mb3JtYXRpb24pOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvbmV0d29ya1BhbmVsLmNzczoKKyAgICAgICAgKC5yZXNvdXJjZS1oZWFkZXJzLXZpZXcgLm91 dGxpbmUtZGlzY2xvc3VyZSBsaSAuc3RhdHVzLWZyb20tY2FjaGUpOgorCiAyMDExLTA4LTMxICBT dGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCBh bGwgbWVudGlvbnMgb2YgQW5kcm9pZCBpbiBjb21tZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qcwppbmRleCAwODlkNTM3YzFlNzY5 N2VhNzFlOWVhOWI2NWVkN2Y1NDRkMTRiNTc2Li5mZGZhZGQzODViNjI0ZDYyODAxMDI3ODAxMzYy NGNlYzY1NTA4YmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL05ldHdvcmtQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL05ldHdvcmtQYW5lbC5qcwpAQCAtMTk1OSwxMSArMTk1OSwxMiBAQCBXZWJJbnNwZWN0b3Iu TmV0d29ya0RhdGFHcmlkTm9kZS5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgaWYgKHRoaXMuX3Jl c291cmNlLnN0YXR1c0NvZGUpIHsKICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwuYXBwZW5k Q2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUodGhpcy5fcmVzb3VyY2Uuc3RhdHVzQ29kZSkp OwotICAgICAgICAgICAgdGhpcy5fc3RhdHVzQ2VsbC5yZW1vdmVTdHlsZUNsYXNzKCJuZXR3b3Jr LWRpbS1jZWxsIik7CiAgICAgICAgICAgICB0aGlzLl9hcHBlbmRTdWJ0aXRsZSh0aGlzLl9zdGF0 dXNDZWxsLCB0aGlzLl9yZXNvdXJjZS5zdGF0dXNUZXh0KTsKICAgICAgICAgICAgIHRoaXMuX3N0 YXR1c0NlbGwudGl0bGUgPSB0aGlzLl9yZXNvdXJjZS5zdGF0dXNDb2RlICsgIiAiICsgdGhpcy5f cmVzb3VyY2Uuc3RhdHVzVGV4dDsKICAgICAgICAgICAgIGlmICh0aGlzLl9yZXNvdXJjZS5zdGF0 dXNDb2RlID49IDQwMCkKICAgICAgICAgICAgICAgICB0aGlzLmVsZW1lbnQuYWRkU3R5bGVDbGFz cygibmV0d29yay1lcnJvci1yb3ciKTsKKyAgICAgICAgICAgIGlmICh0aGlzLl9yZXNvdXJjZS5j YWNoZWQpCisgICAgICAgICAgICAgICAgdGhpcy5fc3RhdHVzQ2VsbC5hZGRTdHlsZUNsYXNzKCJu ZXR3b3JrLWRpbS1jZWxsIik7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBpZiAoIXRo aXMuX3Jlc291cmNlLmlzSHR0cEZhbWlseSgpICYmIHRoaXMuX3Jlc291cmNlLmZpbmlzaGVkKQog ICAgICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwuc2V0VGV4dEFuZFRpdGxlKFdlYkluc3Bl Y3Rvci5VSVN0cmluZygiU3VjY2VzcyIpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VIZWFkZXJzVmlldy5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VIZWFkZXJzVmlldy5qcwppbmRleCAwOTc5MGFk YWUzODQ3ODhjYjNkM2I5NDA2NmUyMmNhYjIxYThmNTllLi5jZWJkNTI0ZDUxMmE3Y2ZkYTRiYWRh YzBlMGU3NGFhMGY0OTk2YzlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1Jlc291cmNlSGVhZGVyc1ZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZUhlYWRlcnNWaWV3LmpzCkBAIC0yOTgsOCArMjk4LDEy IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZUhlYWRlcnNWaWV3LnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIHJlcXVlc3RNZXRob2RFbGVtZW50LnRpdGxlSFRNTCA9ICI8ZGl2IGNsYXNzPVwiaGVh ZGVyLW5hbWVcIj4iICsgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJSZXF1ZXN0IE1ldGhvZCIpICsg Ijo8L2Rpdj4iICsKICAgICAgICAgICAgICAgICAiPGRpdiBjbGFzcz1cImhlYWRlci12YWx1ZSBz b3VyY2UtY29kZVwiPiIgKyB0aGlzLl9yZXNvdXJjZS5yZXF1ZXN0TWV0aG9kICsgIjwvZGl2PiI7 CiAKKyAgICAgICAgICAgIHZhciBmcm9tQ2FjaGVTcGFuID0gIiI7CisgICAgICAgICAgICBpZiAo dGhpcy5fcmVzb3VyY2UuY2FjaGVkKQorICAgICAgICAgICAgICAgIGZyb21DYWNoZVNwYW4gPSAi ICIgKyAiPHNwYW4gY2xhc3M9XCJzdGF0dXMtZnJvbS1jYWNoZVwiPiIgKyBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIihmcm9tIGNhY2hlKSIpLmVzY2FwZUhUTUwoKSArICI8L3NwYW4+IjsKKwogICAg ICAgICAgICAgc3RhdHVzQ29kZUVsZW1lbnQudGl0bGVIVE1MID0gIjxkaXYgY2xhc3M9XCJoZWFk ZXItbmFtZVwiPiIgKyBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlN0YXR1cyBDb2RlIikgKyAiOjwv ZGl2PiIgKwotICAgICAgICAgICAgICAgIHN0YXR1c0NvZGVJbWFnZSArICI8ZGl2IGNsYXNzPVwi aGVhZGVyLXZhbHVlIHNvdXJjZS1jb2RlXCI+IiArIHN0YXR1c1RleHRFc2NhcGVkICsgIjwvZGl2 PiI7CisgICAgICAgICAgICAgICAgc3RhdHVzQ29kZUltYWdlICsgIjxkaXYgY2xhc3M9XCJoZWFk ZXItdmFsdWUgc291cmNlLWNvZGVcIj4iICsgc3RhdHVzVGV4dEVzY2FwZWQgKyBmcm9tQ2FjaGVT cGFuICsgIjwvZGl2PiI7CiAgICAgICAgIH0KICAgICB9LAogICAgIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9uZXR3b3JrUGFuZWwuY3NzIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9uZXR3b3JrUGFuZWwuY3NzCmluZGV4IDFjYTdk YWI1Y2YyNGQyOWEzNjM1ZTI0MDZkY2M2OGUwMzk0M2JiNDAuLjkwNTk0ODljNTRiYWZiNGMyMjYy MTYyMGE0NmZhNzgwODc1ZGRlZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvbmV0d29ya1BhbmVsLmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5jc3MKQEAgLTEzNSw2ICsxMzUsMTAgQEAKICAgICBk aXNwbGF5OiBub25lOwogfQogCisucmVzb3VyY2UtaGVhZGVycy12aWV3IC5vdXRsaW5lLWRpc2Ns b3N1cmUgbGkgLnN0YXR1cy1mcm9tLWNhY2hlIHsKKyAgICBjb2xvcjogZ3JheTsKK30KKwogLnJl c291cmNlLWhlYWRlcnMtdmlldyAub3V0bGluZS1kaXNjbG9zdXJlIGxpLmV4cGFuZGVkIC5oZWFk ZXItdG9nZ2xlIHsKICAgICBkaXNwbGF5OiBpbmxpbmU7CiAgICAgbWFyZ2luLWxlZnQ6IDMwcHg7 Cg==