67389 2011-09-01 05:26:23 -0700 [GTK] run-gtk-tests leaves a zombie Xvfb process 2011-09-06 09:28:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned gustavo oldest_to_newest 460388 0 pnormand 2011-09-01 05:26:23 -0700 Seems like calling exec() with shell like stderr/stdout redirections and "&" is wrong. 460389 1 105944 pnormand 2011-09-01 05:28:27 -0700 Created attachment 105944 proposed patch 460396 2 pnormand 2011-09-01 05:41:15 -0700 CC Gustavo as he wrote the original code 460401 3 pnormand 2011-09-01 05:58:56 -0700 The symptom being: run-gtk-tests let it run ps aux |grep Xvfb phil 21096 3.0 0.1 63968 11340 pts/0 S 14:57 0:00 Xvfb :31 -screen 0 800x600x24 -nolisten tcp The Xvfb process is not killed. Seems related to exec and file handles somehow, but I lack the perl-fu to debug this further. 461074 4 pnormand 2011-09-02 00:32:10 -0700 Committed r94388: <http://trac.webkit.org/changeset/94388> 462592 5 105944 mrobinson 2011-09-06 09:28:21 -0700 Comment on attachment 105944 proposed patch Clearing flag on committed patch. 105944 2011-09-01 05:28:27 -0700 2011-09-06 09:28:21 -0700 proposed patch proposed-patch.patch text/plain 1485 pnormand RnJvbSA5NzhjODJkM2ZiMjIzY2Q3OWI3YTczODYxMWU3ZjljMmUwY2VkYTkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDEgU2VwIDIwMTEgMTQ6Mjc6NTggKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgfCAgIDEwICsr KysrKysrKysKIFRvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyB8ICAgIDQgKysrLQogMiBmaWxl cyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjYTExMWQzLi5hOTliYmJj IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTEtMDktMDEgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIHJ1bi1ndGstdGVzdHMgbGVhdmVzIGEgem9tYmllIFh2 ZmIgcHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjczODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0czogUHJvcGVybHkgY2xvc2UgU1RESU4gYW5kIFNUREVS UiBvbiB0aGUKKyAgICAgICAgY2hpbGQgcHJvY2VzcyBpbnN0ZWFkIG9mIGRvaW5nIHNoZWxsIHJl ZGlyZWN0aW9uLgorCiAyMDExLTA5LTAxICBLcmlzdMOzZiBLb3N6dHnDsyAgPGtrcmlzdG9mQGlu Zi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdIEJ1aWxkIGRlcGVuZGVuY3kgcHJvYmxlbXMK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMv cnVuLWd0ay10ZXN0cwppbmRleCBhMmRkNWZjLi5kM2UwNTYwIDEwMDc1NQotLS0gYS9Ub29scy9T Y3JpcHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCkBA IC0zNSw3ICszNSw5IEBAIGlmICgkI3VuaXRUZXN0cyA8IDEpIHsKIAogbXkgJHBpZCA9IGZvcmso KTsKIGlmICgkcGlkID09IDApIHsKLSAgICBleGVjKCJYdmZiIDozMSAtc2NyZWVuIDAgODAweDYw MHgyNCAtbm9saXN0ZW4gdGNwID4gL2Rldi9udWxsIDI+JjEiKTsKKyAgICBjbG9zZShTVERPVVQp IG9yIGRpZSAiQ2FuJ3QgY2xvc2UgU1RET1VUOiAkIVxuIjsKKyAgICBjbG9zZShTVERFUlIpIG9y IGRpZSAiQ2FuJ3QgY2xvc2UgU1RERVJSOiAkIVxuIjsKKyAgICBleGVjKCJYdmZiIDozMSAtc2Ny ZWVuIDAgODAweDYwMHgyNCAtbm9saXN0ZW4gdGNwIik7CiAgICAgZXhpdCAxOwogfSBlbHNpZiAo JHBpZCA9PSAtMSkgewogICAgIHByaW50ICJGYWlsZWQgdG8gZm9yayBYdmZiLiI7Ci0tIAoxLjcu NS40