67387 2011-09-01 04:46:23 -0700 [Chromium] Webfonts display bold in Windows 2011-09-02 03:38:08 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://crbug.com/94903 P2 Normal --- 1 bashi bashi evan tony webkit.review.bot oldest_to_newest 460379 0 bashi 2011-09-01 04:46:23 -0700 Chromium bug entry: http://crbug.com/94903 Chromium win port uses CreateFontIndirect() to create FontCustomPlatformData object for webfonts. A webfont could be wider (or narrower) than expected when the font's weight class isn't normal(400) because CreateFontIndirect() adjusts font weight according to LOGFONT.lfWeight. For webfonts, we should set LOGFONT.lfWeight to FW_DONTCARE, which means using a default weight. 460380 1 105942 bashi 2011-09-01 04:55:38 -0700 Created attachment 105942 Patch 460383 2 bashi 2011-09-01 05:01:59 -0700 I didn't come up with how to test for this patch because testing this patch requires a non-local font whose weight class isn't normal.. 461106 3 105942 tkent 2011-09-02 02:35:27 -0700 Comment on attachment 105942 Patch ok 461107 4 105942 bashi 2011-09-02 02:36:40 -0700 Comment on attachment 105942 Patch Kent-san, Thank you for review! 461131 5 105942 webkit.review.bot 2011-09-02 03:38:04 -0700 Comment on attachment 105942 Patch Clearing flags on attachment: 105942 Committed r94400: <http://trac.webkit.org/changeset/94400> 461133 6 webkit.review.bot 2011-09-02 03:38:08 -0700 All reviewed patches have been landed. Closing bug. 105942 2011-09-01 04:55:38 -0700 2011-09-02 03:38:04 -0700 Patch bug-67387-20110901205536.patch text/plain 1763 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ZWY4MjA3OWQ5Yzc5NWFj MmM0OGJkMWJkZGY4ZjQxNzNjMDNiZjQ0Li5mNGJlNzUwMTg2NWFjMGFlY2Y4ODlmNGJjNDAxYjY2 ZGI2ZGYzNzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMDEgIEtlbmlj aGkgSXNoaWJhc2hpICA8YmFzaGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0g V2ViZm9udHMgZGlzcGxheSBib2xkIGluIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3Mzg3CisKKyAgICAgICAgVXNlcyBmb250J3MgZGVm YXVsdCB3ZWlnaHQgZm9yIHdlYmZvbnRzIGJ5IHNldHRpbmcgRldfRE9OVENBUkUuCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBX ZSBkb24ndCBoYXZlIGZvbnRzIHRvIHRlc3QgdGhpcyBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9za2lhL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGEuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Rm9udEN1c3RvbVBsYXRmb3JtRGF0YTo6Zm9udFBsYXRmb3JtRGF0YSk6IFNldHMg RldfRE9OVENBUkUgdG8gdXNlIGRlZmF1bHQgZm9udCB3ZWlnaHQuCisKIDIwMTEtMDktMDEgIFBh dHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVwbGFjZSBw cmVwcm9jZXNzb3Igc3RhdGVtZW50cyBpbiBET01XaW5kb3cuaWRsIHdpdGggQ29uZGl0aW9uYWwg YXR0cmlidXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9Gb250Q3VzdG9tUGxhdGZvcm1EYXRhLmNwcAppbmRleCA1YTA0OTFkZjlm YWU1M2JhMjQ1NjJlMzMwM2Q0MzMxZWFhZDkwMDdkLi5iNDIzMGQyOTgwZGY1YzZiZmZkZDQyMjkx NzExZjkwZGI3Nzc0NjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5jcHAKQEAgLTk3 LDcgKzk3LDcgQEAgRm9udFBsYXRmb3JtRGF0YSBGb250Q3VzdG9tUGxhdGZvcm1EYXRhOjpmb250 UGxhdGZvcm1EYXRhKGludCBzaXplLCBib29sIGJvbGQsIGIKICAgICAgICAgICAgICAgICAgICAg ICAgIERFRkFVTFRfUVVBTElUWTsgLy8gSG9ub3IgdXNlcidzIGRlc2t0b3Agc2V0dGluZ3MuCiAg ICAgbG9nRm9udC5sZlBpdGNoQW5kRmFtaWx5ID0gREVGQVVMVF9QSVRDSCB8IEZGX0RPTlRDQVJF OwogICAgIGxvZ0ZvbnQubGZJdGFsaWMgPSBpdGFsaWM7Ci0gICAgbG9nRm9udC5sZldlaWdodCA9 IGJvbGQgPyA3MDAgOiA0MDA7CisgICAgbG9nRm9udC5sZldlaWdodCA9IGJvbGQgPyBGV19CT0xE IDogRldfRE9OVENBUkU7CiAKICAgICBIRk9OVCBoZm9udCA9IENyZWF0ZUZvbnRJbmRpcmVjdCgm bG9nRm9udCk7CiAgICAgcmV0dXJuIEZvbnRQbGF0Zm9ybURhdGEoaGZvbnQsIHNpemUpOwo=