67380 2011-09-01 02:16:36 -0700 [GTK] Generate gobject bindings for Notification and NotificationCenter 2011-09-02 09:53:29 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 67490 1 paroga paroga mrobinson webkit.review.bot xan.lopez oldest_to_newest 460335 0 paroga 2011-09-01 02:16:36 -0700 [GTK] Generate gobject bindings for Notification and NotificationCenter 460336 1 105928 paroga 2011-09-01 02:19:34 -0700 Created attachment 105928 Patch 461115 2 105928 pnormand 2011-09-02 03:09:06 -0700 Comment on attachment 105928 Patch LGTM and GTK EWS didn't complain. Thanks! 461149 3 105928 webkit.review.bot 2011-09-02 04:09:56 -0700 Comment on attachment 105928 Patch Clearing flags on attachment: 105928 Committed r94404: <http://trac.webkit.org/changeset/94404> 461150 4 webkit.review.bot 2011-09-02 04:10:00 -0700 All reviewed patches have been landed. Closing bug. 461258 5 xan.lopez 2011-09-02 09:32:51 -0700 This patch is wrong in several ways. - It's not adding the headers to the Makefile, so the end result is broken. - You need to reviewers r+ to add new API. - We don't add new bindings API without a justification of why we would want to do so. - We are already working on this elsewhere, and this has some problems that we need to discuss without going ahead: https://bugs.webkit.org/show_bug.cgi?id=61140 I'm going to rollout for all those reasons. 461274 6 pnormand 2011-09-02 09:53:29 -0700 Oh, sorry :( It just seemed like an harmless change, I overlooked the API addition implied by this patch. 105928 2011-09-01 02:19:34 -0700 2011-09-02 04:09:56 -0700 Patch bug-67380.patch text/plain 1402 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYjM5NTUxLi41ZGZlNWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMDEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0dUS10gR2VuZXJhdGUgZ29iamVjdCBiaW5kaW5ncyBmb3IgTm90aWZpY2F0aW9u IGFuZCBOb3RpZmljYXRpb25DZW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY3MzgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9nb2JqZWN0L0dOVW1ha2VmaWxlLmFtOgorCiAyMDEx LTA5LTAxICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl bmFtZSBjb2xvclNlbGVjdGVkIHRvIGRpZENob29zZUNvbG9yCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvZ29iamVjdC9HTlVtYWtlZmlsZS5hbQppbmRleCA1ZTE2ZTc2Li4xZGEyZThhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L0dOVW1ha2VmaWxlLmFt CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvR05VbWFrZWZpbGUuYW0KQEAg LTIyMCw2ICsyMjAsMTAgQEAgd2Via2l0Z3RrX2dkb21fYnVpbHRfc291cmNlcyArPSBcCiAJRGVy aXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERPTU5vZGVMaXN0LmNwcCBcCiAJRGVyaXZlZFNvdXJj ZXMvd2Via2l0L1dlYktpdERPTU5vZGVMaXN0UHJpdmF0ZS5oIFwKIAlEZXJpdmVkU291cmNlcy93 ZWJraXQvV2ViS2l0RE9NTm9kZVByaXZhdGUuaCBcCisJRGVyaXZlZFNvdXJjZXMvd2Via2l0L1dl YktpdERPTU5vdGlmaWNhdGlvbi5jcHAgXAorCURlcml2ZWRTb3VyY2VzL3dlYmtpdC9XZWJLaXRE T01Ob3RpZmljYXRpb25Qcml2YXRlLmggXAorCURlcml2ZWRTb3VyY2VzL3dlYmtpdC9XZWJLaXRE T01Ob3RpZmljYXRpb25DZW50ZXIuY3BwIFwKKwlEZXJpdmVkU291cmNlcy93ZWJraXQvV2ViS2l0 RE9NTm90aWZpY2F0aW9uQ2VudGVyUHJpdmF0ZS5oIFwKIAlEZXJpdmVkU291cmNlcy93ZWJraXQv V2ViS2l0RE9NUHJvY2Vzc2luZ0luc3RydWN0aW9uLmNwcCBcCiAJRGVyaXZlZFNvdXJjZXMvd2Vi a2l0L1dlYktpdERPTVByb2Nlc3NpbmdJbnN0cnVjdGlvblByaXZhdGUuaCBcCiAJRGVyaXZlZFNv dXJjZXMvd2Via2l0L1dlYktpdERPTVJhbmdlLmNwcCBcCg==