67372 2011-09-01 00:52:25 -0700 [chromium] Move ImageBuffer::platformLayer() 2011-09-01 18:57:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon kbr senorblanco webkit.review.bot oldest_to_newest 460304 0 noel.gordon 2011-09-01 00:52:25 -0700 Have some toDataURL() related work upcoming and platformLayer() is sitting right in the middle of it :) Hope you don't mind my moving out of the way. 460314 1 105919 noel.gordon 2011-09-01 01:00:06 -0700 Created attachment 105919 Patch 460321 2 noel.gordon 2011-09-01 01:27:59 -0700 And curious, does this routine need a #if USE(ACCELERATED_COMPOSITING) guard? A cursory look at http://trac.webkit.org/changeset/93157/trunk/Source/WebCore/platform/graphics/ImageBuffer.h made me think so. 460650 3 105919 kbr 2011-09-01 11:45:46 -0700 Comment on attachment 105919 Patch This looks fine. 460652 4 kbr 2011-09-01 11:46:35 -0700 (In reply to comment #2) > And curious, does this routine need a #if USE(ACCELERATED_COMPOSITING) guard? A cursory look at > http://trac.webkit.org/changeset/93157/trunk/Source/WebCore/platform/graphics/ImageBuffer.h made > me think so. Not sure -- it's been a while since we compiled without that flag so there might be several compilation errors throughout the code base. 460702 5 105919 webkit.review.bot 2011-09-01 12:39:24 -0700 Comment on attachment 105919 Patch Clearing flags on attachment: 105919 Committed r94332: <http://trac.webkit.org/changeset/94332> 460703 6 webkit.review.bot 2011-09-01 12:39:28 -0700 All reviewed patches have been landed. Closing bug. 461003 7 noel.gordon 2011-09-01 18:57:46 -0700 (In reply to comment #4) > Not sure -- it's been a while since we compiled without that flag so there might be several compilation errors throughout the code base. OK thanks, so long as we know it. 105919 2011-09-01 01:00:06 -0700 2011-09-01 12:39:24 -0700 Patch platform-move.git.diff text/plain 1918 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZDc4NmQyLi4yZmY3ZDljNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDExLTA5LTAxICBOb2VsIEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKwor ICAgICAgICBbY2hyb21pdW1dIE1vdmUgSW1hZ2VCdWZmZXI6OnBsYXRmb3JtTGF5ZXIoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjczNzIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHM6 IHJlZmFjdG9yaW5nIG9ubHksIGNvdmVyZWQgYnkgZXhpc3R0aW5nIHRlc3RzLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnBsYXRmb3JtTGF5ZXIpOiAgTW92ZSBpdCBhd2F5IGZyb20g dGhlIHRvRGF0YVVSTCBjb2RlLgorCiAyMDExLTA4LTMxICBLZW50YXJvIEhhcmEgIDxoYXJha2Vu QGdvb2dsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IFdlYiBJREwgQ29uc3RydWN0b3IgZXh0 ZW5kZWQgYXR0cmlidXRlIGluIElETFBhcnNlci5wbSBhbmQgQ29kZUdlbmVyYXRvclY4LnBtLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1 ZmZlclNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFn ZUJ1ZmZlclNraWEuY3BwCmluZGV4IGIxMDQ5NjguLmI2MmQ1MGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5j cHAKQEAgLTEzNSw2ICsxMzUsMTEgQEAgUGFzc1JlZlB0cjxJbWFnZT4gSW1hZ2VCdWZmZXI6OmNv cHlJbWFnZShCYWNraW5nU3RvcmVDb3B5IGNvcHlCZWhhdmlvcikgY29uc3QKICAgICByZXR1cm4g Qml0bWFwSW1hZ2VTaW5nbGVGcmFtZVNraWE6OmNyZWF0ZSgqbV9kYXRhLm1fcGxhdGZvcm1Db250 ZXh0LmJpdG1hcCgpLCB0cnVlKTsKIH0KIAorUGxhdGZvcm1MYXllciogSW1hZ2VCdWZmZXI6OnBs YXRmb3JtTGF5ZXIoKSBjb25zdAoreworICAgIHJldHVybiBtX2RhdGEubV9wbGF0Zm9ybUxheWVy LmdldCgpOworfQorCiB2b2lkIEltYWdlQnVmZmVyOjpjbGlwKEdyYXBoaWNzQ29udGV4dCogY29u dGV4dCwgY29uc3QgRmxvYXRSZWN0JiByZWN0KSBjb25zdAogewogICAgIGNvbnRleHQtPnBsYXRm b3JtQ29udGV4dCgpLT5iZWdpbkxheWVyQ2xpcHBlZFRvSW1hZ2UocmVjdCwgdGhpcyk7CkBAIC0z OTcsMTEgKzQwMiw2IEBAIFN0cmluZyBJbWFnZUJ1ZmZlcjo6dG9EYXRhVVJMKGNvbnN0IFN0cmlu ZyYgbWltZVR5cGUsIGNvbnN0IGRvdWJsZSogcXVhbGl0eSkgY29uCiAgICAgcmV0dXJuIEltYWdl VG9EYXRhVVJMKGRldmljZS0+YWNjZXNzQml0bWFwKGZhbHNlKSwgbWltZVR5cGUsIHF1YWxpdHkp OwogfQogCi1QbGF0Zm9ybUxheWVyKiBJbWFnZUJ1ZmZlcjo6cGxhdGZvcm1MYXllcigpIGNvbnN0 Ci17Ci0gICAgcmV0dXJuIG1fZGF0YS5tX3BsYXRmb3JtTGF5ZXIuZ2V0KCk7Ci19Ci0KIFN0cmlu ZyBJbWFnZURhdGFUb0RhdGFVUkwoY29uc3QgSW1hZ2VEYXRhJiBzb3VyY2UsIGNvbnN0IFN0cmlu ZyYgbWltZVR5cGUsIGNvbnN0IGRvdWJsZSogcXVhbGl0eSkKIHsKICAgICByZXR1cm4gSW1hZ2VU b0RhdGFVUkwoc291cmNlLCBtaW1lVHlwZSwgcXVhbGl0eSk7Cg==