67362 2011-08-31 23:06:04 -0700 Define PTHREAD_KEYS_MAX to fix Android port build 2011-09-01 21:28:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 66689 0 zhenghao webkit-unassigned abarth andreip peter steveblock webkit.review.bot oldest_to_newest 460241 0 zhenghao 2011-08-31 23:06:04 -0700 PTHREAD_KEYS_MAX is not defined in bionic, so explicitly define it here. 460250 1 105897 zhenghao 2011-08-31 23:18:31 -0700 Created attachment 105897 Proposed patch. 460253 2 105897 abarth 2011-08-31 23:21:29 -0700 Comment on attachment 105897 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=105897&action=review > Source/JavaScriptCore/ChangeLog:8 > + Define PTHREAD_KEYS_MAX to fix Android port build. > + https://bugs.webkit.org/show_bug.cgi?id=67362 > + > + Reviewed by NOBODY (OOPS!). > + > + * wtf/ThreadIdentifierDataPthreads.cpp: It would be good to include the information from the bug about this being a missing feature of bionic in the ChangeLog. 460277 3 105906 zhenghao 2011-09-01 00:07:46 -0700 Created attachment 105906 Proposed patch 2. 460341 4 zhenghao 2011-09-01 02:31:31 -0700 Sorry, one correction: It's not for Android port, which no longer exists. It's for Chromium port for Android. And one clarification: it's not a build fix for the bot, but it's required when Chromium for Android starts using the code. 460344 5 105906 webkit.review.bot 2011-09-01 02:39:53 -0700 Comment on attachment 105906 Proposed patch 2. Clearing flags on attachment: 105906 Committed r94281: <http://trac.webkit.org/changeset/94281> 460345 6 webkit.review.bot 2011-09-01 02:39:58 -0700 All reviewed patches have been landed. Closing bug. 460562 7 105906 ap 2011-09-01 10:18:05 -0700 Comment on attachment 105906 Proposed patch 2. View in context: https://bugs.webkit.org/attachment.cgi?id=105906&action=review > Source/JavaScriptCore/wtf/ThreadIdentifierDataPthreads.cpp:40 > +// PTHREAD_KEYS_MAX is not defined in bionic, so explicitly define it here. Are you tracking this as a bug? It would help to have a link to that bug in a comment, so that we would know when it's safe to remove the workaround. 461036 8 zhenghao 2011-09-01 21:28:53 -0700 See android bug: http://code.google.com/p/android/issues/detail?id=19764 . 105897 2011-08-31 23:18:31 -0700 2011-09-01 00:07:46 -0700 Proposed patch. JavaScriptCore.patch text/plain 996 zhenghao SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTQyNzEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDgtMzEgIEhhbyBaaGVuZyAgPHpoZW5naGFvQGNocm9taXVtLm9yZz4KKworICAgICAg ICBEZWZpbmUgUFRIUkVBRF9LRVlTX01BWCB0byBmaXggQW5kcm9pZCBwb3J0IGJ1aWxkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjczNjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9UaHJlYWRJ ZGVudGlmaWVyRGF0YVB0aHJlYWRzLmNwcDoKKwogMjAxMS0wOC0zMSAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBidWlsZC4KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvVGhyZWFkSWRlbnRpZmllckRhdGFQdGhyZWFkcy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRJZGVudGlmaWVyRGF0YVB0aHJl YWRzLmNwcAkocmV2aXNpb24gOTQyNjQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1Ro cmVhZElkZW50aWZpZXJEYXRhUHRocmVhZHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICsz NiwxMSBAQAogCiAjaW5jbHVkZSAiVGhyZWFkaW5nLmgiCiAKKyNpZiBPUyhBTkRST0lEKQorI2Rl ZmluZSBQVEhSRUFEX0tFWVNfTUFYIDEwMjQKKyNlbHNlCiAjaW5jbHVkZSA8bGltaXRzLmg+Cisj ZW5kaWYKIAogbmFtZXNwYWNlIFdURiB7CiAK 105906 2011-09-01 00:07:46 -0700 2011-09-01 10:18:05 -0700 Proposed patch 2. JavaScriptCore.patch text/plain 1219 zhenghao SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkSWRlbnRpZmllckRhdGFQdGhy ZWFkcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRJ ZGVudGlmaWVyRGF0YVB0aHJlYWRzLmNwcAkocmV2aXNpb24gOTQyNjQpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL1RocmVhZElkZW50aWZpZXJEYXRhUHRocmVhZHMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zNiw3ICszNiwxMiBAQAogCiAjaW5jbHVkZSAiVGhyZWFkaW5nLmgiCiAKKyNp ZiBPUyhBTkRST0lEKQorLy8gUFRIUkVBRF9LRVlTX01BWCBpcyBub3QgZGVmaW5lZCBpbiBiaW9u aWMsIHNvIGV4cGxpY2l0bHkgZGVmaW5lIGl0IGhlcmUuCisjZGVmaW5lIFBUSFJFQURfS0VZU19N QVggMTAyNAorI2Vsc2UKICNpbmNsdWRlIDxsaW1pdHMuaD4KKyNlbmRpZgogCiBuYW1lc3BhY2Ug V1RGIHsKIApAQCAtODcsNCArOTIsMyBAQAogfSAvLyBuYW1lc3BhY2UgV1RGCiAKICNlbmRpZiAv LyBVU0UoUFRIUkVBRFMpCi0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24g OTQyNzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMzEgIEhhbyBaaGVuZyAgPHpoZW5naGFvQGNocm9t aXVtLm9yZz4KKworICAgICAgICBEZWZpbmUgUFRIUkVBRF9LRVlTX01BWCB0byBmaXggQW5kcm9p ZCBwb3J0IGJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjczNjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQVEhSRUFEX0tFWVNfTUFYIGlzIG5vdCBkZWZpbmVkIGluIGJpb25pYywgc28gZXhwbGlj aXRseSBkZWZpbmUgaXQuCisKKyAgICAgICAgKiB3dGYvVGhyZWFkSWRlbnRpZmllckRhdGFQdGhy ZWFkcy5jcHA6CisKIDIwMTEtMDgtMzEgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4K IAogICAgICAgICBGaXggYnVpbGQuCg==