67356 2011-08-31 21:13:04 -0700 REGRESSION (r94093): Private browsing doesn't start with a clean state on Snow Leopard 2011-09-02 12:38:54 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED Regression P1 Normal --- 1 khooyp ap ap jberlin khooyp webkit.review.bot oldest_to_newest 460204 0 khooyp 2011-08-31 21:13:04 -0700 There appears to have been a change in Safari's Private Browsing behavior between the r94061 and r94145 nightlies in the following scenario: 1) log in to some website (e.g., facebook.com or gmail.com); 2) turn on Private Browsing; 3) reload the website in step 1. In r94061, reloading in step 3 be logged out as if cookies were reset; whereas in r94145, reloading in step 3 would remain logged in. Looking at the SVN commit logs between these revisions, there doesn't seem to be any that explicitly calls out such a change, though r94093 appears to be related to cookies. Is this an expected change? I much rather prefer the old behavior as it is more thorough in ensuring privacy. 460567 1 ap 2011-09-01 10:20:32 -0700 Per your analysis, it seems likely that I broke something, will investigate ASAP. 460649 2 ap 2011-09-01 11:45:18 -0700 This only happens on Snow Leopard, not on Lion. Investigating... 460917 3 106062 ap 2011-09-01 16:43:55 -0700 Created attachment 106062 proposed fix 460946 4 106062 webkit.review.bot 2011-09-01 17:22:16 -0700 Comment on attachment 106062 proposed fix Rejecting attachment 106062 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: f0d9405ba69418331dcdfeb2b468b45aa2d1040f r94371 = 8b34cc661db8cceb5d89e4be6eecf8ad466a75fc Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9586217 461041 5 106062 ap 2011-09-01 21:48:52 -0700 Comment on attachment 106062 proposed fix What did that mean? 461054 6 106062 webkit.review.bot 2011-09-01 22:48:04 -0700 Comment on attachment 106062 proposed fix Rejecting attachment 106062 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: d546a50615913604e5f2b269d0f7ca6ccf93b070 r94386 = 5e8e385bd2e33d41d28bd86612dafef1390d00bd Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9581597 461061 7 ap 2011-09-01 23:25:56 -0700 Ah right, I accidentally removed reviewer line. Will fix and land manually. 461437 8 ap 2011-09-02 12:38:54 -0700 Committed <trac.webkit.org/r94426>. 106062 2011-09-01 16:43:55 -0700 2011-09-01 22:48:04 -0700 proposed fix SLPrivateBrowsing.txt text/plain 1962 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MzYyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMDEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjk0MDkz KTogUHJpdmF0ZSBicm93c2luZyBkb2Vzbid0IHN0YXJ0IHdpdGggYSBjbGVhbiBzdGF0ZSBvbiBT bm93IExlb3BhcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY3MzU2CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9Db29raWVTdG9yYWdl TWFjLm1tOiAoV2ViQ29yZTo6c2V0Q29va2llU3RvcmFnZVByaXZhdGVCcm93c2luZ0VuYWJsZWQp OgorICAgICAgICBEb24ndCBlbmFibGUgb2xkLXN0eWxlIHByaXZhdGUgYnJvd3Npbmcgd2hlbiB1 c2luZyBzZXNzaW9ucyAtIGl0IHdvdWxkIHRha2UgcHJlY2VkZW5jZSBvdmVyCisgICAgICAgIHNl c3Npb24gY29va2llIHN0b3JhZ2Ugb24gU25vdyBMZW9wYXJkLgorCiAyMDExLTA5LTAxICBQYXRy aWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIERvbid0IGluY2x1 ZGUgdW5uZWNlc3NhcnkgaGVhZGVycyBpbiBWOCBiaW5kaW5ncwpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9tYWMvQ29va2llU3RvcmFnZU1hYy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9Db29raWVTdG9yYWdlTWFjLm1t CShyZXZpc2lvbiA5NDI0NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFj L0Nvb2tpZVN0b3JhZ2VNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTI1LDYgKzI1LDcgQEAKIAog I2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNvb2tpZVN0b3JhZ2UuaCIKKyNpbmNsdWRl ICJDb29raWVTdG9yYWdlQ0ZOZXQuaCIKIAogI2ltcG9ydCAiUmVzb3VyY2VIYW5kbGUuaCIKIApA QCAtNzgsNiArNzksMTUgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2b2lkIHNldENvb2tpZVN0 b3JhZ2VQcml2YXRlQnJvd3NpbmdFbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKKyNpZiBCVUlMRElO R19PTl9TTk9XX0xFT1BBUkQgJiYgVVNFKENGVVJMU1RPUkFHRVNFU1NJT05TKQorICAgIC8vIERv bid0IGNhbGwgd2tTZXRDb29raWVTdG9yYWdlUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpIHdoZW4g Y29va2llIHN0b3JhZ2UgaXMgc2V0IHVwIHZpYSBzZXNzaW9ucy4KKyAgICAvLyBUaGF0IHdvdWxk IG1ha2UgTlNVUkxDb25uZWN0IHVzZSBnbG9iYWwgcHJpdmF0ZSBicm93c2luZyBjb29raWUgc3Rv cmFnZSByZWdhcmRsZXNzIG9mIHJlcXVlc3Qgc2Vzc2lvbi4KKyAgICAvLyBUaGUgZ2xvYmFsIHBy aXZhdGUgY29va2llIHN0b3JhZ2UgaGFzIGRpZmZlcmVudCBzZW1hbnRpY3MgLSBpdCBtYWtlcyBu ZXcgY29va2llcyBub24tcGVyc2lzdGVudCwKKyAgICAvLyBidXQgZG9lc24ndCBzdGFydCB3aXRo IGEgY2xlYW4gc3RhdGUuCisgICAgaWYgKGVuYWJsZWQgJiYgY3VycmVudENGSFRUUENvb2tpZVN0 b3JhZ2UoKSkKKyAgICAgICAgcmV0dXJuOworI2VuZGlmCisKICAgICAvLyBGSVhNRTogV2hlbiBQ cml2YXRlIEJyb3dzaW5nIGlzIGVuYWJsZWQsIHRoZSBQcml2YXRlIEJyb3dzaW5nIENvb2tpZSBT dG9yYWdlIHNob3VsZCBiZQogICAgIC8vIG9ic2VydmVkIGZvciBjaGFuZ2VzLCBub3QgdGhlIGRl ZmF1bHQgQ29va2llIFN0b3JhZ2UuCiAK