67332 2011-08-31 16:07:19 -0700 Fix compile issues when enabling HAVE(CFNETWORK_DATA_ARRAY_CALLBACK) 2011-08-31 17:25:54 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki ap psolanki oldest_to_newest 460021 0 psolanki 2011-08-31 16:07:19 -0700 Recent changes (r93811 and r94093) have broken compiles with HAVE(CFNETWORK_DATA_ARRAY_CALLBACK) enabled. 460044 1 105854 psolanki 2011-08-31 16:27:07 -0700 Created attachment 105854 Patch 460065 2 105854 ap 2011-08-31 16:41:53 -0700 Comment on attachment 105854 Patch r=me as a build fix, but I don't understand the second change. How can we use CFNETWORK_DATA_ARRAY_CALLBACK when we don't use CFNETWORK? Something seems wrong. 460105 3 psolanki 2011-08-31 17:20:22 -0700 (In reply to comment #2) > (From update of attachment 105854 [details]) > r=me as a build fix, but I don't understand the second change. How can we use CFNETWORK_DATA_ARRAY_CALLBACK when we don't use CFNETWORK? Something seems wrong. CFNETWORK_DATA_ARRAY_CALLBACK can be used by the Foundation based loader as well. We have code for it in ResourceHandleMac.mm as well. Maybe we should change the name of the define to make it less confusing? 460107 4 psolanki 2011-08-31 17:25:54 -0700 Committed r94255: <http://trac.webkit.org/changeset/94255> 105854 2011-08-31 16:27:07 -0700 2011-08-31 16:41:53 -0700 Patch bug-67332-20110831162706.patch text/plain 2406 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyMTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2YzA3OGQ2NjhiYzNkOGRh MzAwMmFhMzU2MGRiZDQxMmEwZTlmZjkyLi4wMzZjNDZkOWU5NmQwYzg2YjU4MDVlNGZkNWQ2ZmM0 NzBkNmYxYWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMzEgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBjb21waWxlIGlz c3VlcyB3aGVuIGVuYWJsaW5nIEhBVkUoQ0ZORVRXT1JLX0RBVEFfQVJSQVlfQ0FMTEJBQ0spCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzMzMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL21h Yy9SZXNvdXJjZUxvYWRlck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZGVy OjpkaWRSZWNlaXZlRGF0YUFycmF5KToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jl c291cmNlSGFuZGxlQ0ZOZXQuY3BwOgorCiAyMDExLTA4LTMxICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdpdGggLXdlYmtpdC1yYWRpYWwt Z3JhZGllbnQodG9wKSBncmFkaWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L21hYy9SZXNvdXJjZUxvYWRlck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9tYWMvUmVz b3VyY2VMb2FkZXJNYWMubW0KaW5kZXggMmQxNTc3NTMyMTczMWU0YzVhODI0MTVkNTgwMzU4OTk4 YzgyNDRlMS4uNDM4YzhmMDM0ZGEyZGEyY2QyMjAxNWFjZjI0OTM3OGIxODZkZDFmNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL21hYy9SZXNvdXJjZUxvYWRlck1hYy5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvbWFjL1Jlc291cmNlTG9hZGVyTWFjLm1tCkBAIC04MSw3 ICs4MSw3IEBAIHZvaWQgUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVEYXRhQXJyYXkoQ0ZBcnJh eVJlZiBkYXRhQXJyYXkpCiAgICAgICAgIENGRGF0YVJlZiBkYXRhID0gc3RhdGljX2Nhc3Q8Q0ZE YXRhUmVmPihDRkFycmF5R2V0VmFsdWVBdEluZGV4KGRhdGFBcnJheSwgaSkpOwogICAgICAgICBp bnQgZGF0YUxlbiA9IHN0YXRpY19jYXN0PGludD4oQ0ZEYXRhR2V0TGVuZ3RoKGRhdGEpKTsKIAot ICAgICAgICBpZiAobV9zaG91bGRCdWZmZXJEYXRhKSB7CisgICAgICAgIGlmIChtX29wdGlvbnMu c2hvdWxkQnVmZmVyRGF0YSA9PSBCdWZmZXJEYXRhKSB7CiAgICAgICAgICAgICBpZiAoIW1fcmVz b3VyY2VEYXRhKQogICAgICAgICAgICAgICAgIG1fcmVzb3VyY2VEYXRhID0gU2hhcmVkQnVmZmVy OjpjcmVhdGUoKTsKICAgICAgICAgICAgIG1fcmVzb3VyY2VEYXRhLT5hcHBlbmQoZGF0YSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlSGFu ZGxlQ0ZOZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJj ZUhhbmRsZUNGTmV0LmNwcAppbmRleCA1OWFlNjJlZWI4YWZlZDBhNzk1OGQ5ZTI1NzgwNzFiYjBm MTZhYjFhLi5mNTZiMmRjYzMyOTFjMjZiMzNjM2VjM2RjZmE0OWQwYmEyYjJkYjYxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlSGFuZGxlQ0ZO ZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VI YW5kbGVDRk5ldC5jcHAKQEAgLTg5NCw2ICs4OTQsOCBAQCBib29sIFdlYkNvcmVTeW5jaHJvbm91 c0xvYWRlckNsaWVudDo6Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZShSZXNv dQogfQogI2VuZGlmCiAKKyNlbmRpZiAvLyBVU0UoQ0ZORVRXT1JLKQorCiAjaWYgSEFWRShDRk5F VFdPUktfREFUQV9BUlJBWV9DQUxMQkFDSykKIHZvaWQgUmVzb3VyY2VIYW5kbGU6OmhhbmRsZURh dGFBcnJheShDRkFycmF5UmVmIGRhdGFBcnJheSkKIHsKQEAgLTkyNyw4ICs5MjksNiBAQCB2b2lk IFJlc291cmNlSGFuZGxlOjpoYW5kbGVEYXRhQXJyYXkoQ0ZBcnJheVJlZiBkYXRhQXJyYXkpCiB9 CiAjZW5kaWYKIAotI2VuZGlmIC8vIFVTRShDRk5FVFdPUkspCi0KICNpZiBVU0UoQ0ZVUkxTVE9S QUdFU0VTU0lPTlMpCiAKIFJldGFpblB0cjxDRlVSTFN0b3JhZ2VTZXNzaW9uUmVmPiBSZXNvdXJj ZUhhbmRsZTo6Y3JlYXRlUHJpdmF0ZUJyb3dzaW5nU3RvcmFnZVNlc3Npb24oQ0ZTdHJpbmdSZWYg aWRlbnRpZmllcikK