67330 2011-08-31 15:42:42 -0700 fix bug in flexbox test with offsetWidth/offsetLeft of 0 2011-08-31 16:53:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan tony oldest_to_newest 459994 0 ojan 2011-08-31 15:42:42 -0700 fix bug in flexbox test with offsetWidth/offsetLeft of 0 459995 1 105842 ojan 2011-08-31 15:43:20 -0700 Created attachment 105842 Patch 459996 2 ojan 2011-08-31 15:44:01 -0700 Also remove the '<br>'. That wasn't working because we insert a text node. Not worth refactoring to make it work. 460001 3 105842 tony 2011-08-31 15:48:57 -0700 Comment on attachment 105842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105842&action=review > LayoutTests/css3/flexbox/resources/flexbox.js:17 > + if (isDefined(node.offsetWidth) && expectedWidth) { I think we can just drop the node.offsetWidth check. This should still work if it's undefined. > LayoutTests/css3/flexbox/resources/flexbox.js:23 > + if (isDefined(node.offsetLeft) && expectedOffset) { ditto 460006 4 105846 ojan 2011-08-31 15:51:41 -0700 Created attachment 105846 Patch 460081 5 ojan 2011-08-31 16:53:36 -0700 Committed r94250: <http://trac.webkit.org/changeset/94250> 105842 2011-08-31 15:43:20 -0700 2011-08-31 15:51:37 -0700 Patch bug-67330-20110831154319.patch text/plain 2252 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyMzQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYzBkNjA5NjljYWM3MWFjMzJhMTVi ODhmYTBjMTM3MzcwYmMwMWRiLi44MTk5OTU0Yzc1ZjFkNTE2MDBjZTFjZmZiMWRkZDRhMWNmNzc2 YTM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMzEgIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KKworICAgICAgICBmaXggYnVnIGluIGZsZXhib3ggdGVzdCB3aXRoIG9m ZnNldFdpZHRoL29mZnNldExlZnQgb2YgMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjczMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGNzczMvZmxleGJveC9yZXNvdXJjZXMvZmxleGJveC5qczoKKwog MjAxMS0wOC0zMSAgQ2FyeSBDbGFyayAgPGNhcnljbGFya0Bnb29nbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQ7IG5ldyBiYXNlbGluZXMgKFNraWEgb24gTWFjLCBuZXh0IGNodW5rIG9mIDgw MCBmaWxlcykKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9yZXNvdXJjZXMv ZmxleGJveC5qcyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9yZXNvdXJjZXMvZmxleGJveC5q cwppbmRleCAyYjkxOWYxZmI2NWUxMzY3NmRiYmMxNWVkOTczMmRhNzdmNTBkNjRjLi4wZTA2NzY3 YjNjZWNiYzMwODcxZGZmOTY4ZjUxOGQwNmI5OTAxMTE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9jc3MzL2ZsZXhib3gvcmVzb3VyY2VzL2ZsZXhib3guanMKKysrIGIvTGF5b3V0VGVzdHMvY3Nz My9mbGV4Ym94L3Jlc291cmNlcy9mbGV4Ym94LmpzCkBAIC02LDE2ICs2LDIxIEBAIGZ1bmN0aW9u IGluc2VydEFmdGVyKG5vZGVUb0FkZCwgcmVmZXJlbmNlTm9kZSkKICAgICAgICAgcmVmZXJlbmNl Tm9kZS5wYXJlbnROb2RlLmFwcGVuZENoaWxkKG5vZGVUb0FkZCk7CiB9CiAKK2Z1bmN0aW9uIGlz RGVmaW5lZCh2YWx1ZSkKK3sKKyAgICByZXR1cm4gdmFsdWUgIT0gdW5kZWZpbmVkOworfQorCiBm dW5jdGlvbiBjaGVja0V4cGVjdGVkVmFsdWVzKG5vZGUsIGZhaWx1cmVzKQogewogICAgIHZhciBl eHBlY3RlZFdpZHRoID0gbm9kZS5nZXRBdHRyaWJ1dGUgJiYgbm9kZS5nZXRBdHRyaWJ1dGUoImRh dGEtZXhwZWN0ZWQtd2lkdGgiKTsKLSAgICBpZiAobm9kZS5vZmZzZXRXaWR0aCAmJiBleHBlY3Rl ZFdpZHRoKSB7CisgICAgaWYgKGlzRGVmaW5lZChub2RlLm9mZnNldFdpZHRoKSAmJiBleHBlY3Rl ZFdpZHRoKSB7CiAgICAgICAgIGlmIChub2RlLm9mZnNldFdpZHRoICE9IHBhcnNlSW50KGV4cGVj dGVkV2lkdGgpKQogICAgICAgICAgICAgZmFpbHVyZXMucHVzaCgiRXhwZWN0ZWQgIiArIGV4cGVj dGVkV2lkdGggKyAiIGZvciB3aWR0aCwgYnV0IGdvdCAiICsgbm9kZS5vZmZzZXRXaWR0aCArICIu ICIpOwogICAgIH0KIAogICAgIHZhciBleHBlY3RlZE9mZnNldCA9IG5vZGUuZ2V0QXR0cmlidXRl ICYmIG5vZGUuZ2V0QXR0cmlidXRlKCJkYXRhLW9mZnNldC14Iik7Ci0gICAgaWYgKG5vZGUub2Zm c2V0TGVmdCAmJiBleHBlY3RlZE9mZnNldCkgeworICAgIGlmIChpc0RlZmluZWQobm9kZS5vZmZz ZXRMZWZ0KSAmJiBleHBlY3RlZE9mZnNldCkgewogICAgICAgICBpZiAobm9kZS5vZmZzZXRMZWZ0 ICE9IHBhcnNlSW50KGV4cGVjdGVkT2Zmc2V0KSkKICAgICAgICAgICAgIGZhaWx1cmVzLnB1c2go IkV4cGVjdGVkICIgKyBleHBlY3RlZE9mZnNldCArICIgZm9yIG9mZnNldExlZnQsIGJ1dCBnb3Qg IiArIG5vZGUub2Zmc2V0TGVmdCArICIuICIpOwogICAgIH0KQEAgLTM1LDYgKzQwLDYgQEAgZnVu Y3Rpb24gY2hlY2tIb3Jpem9udGFsQm94ZW4oKQogICAgICAgfQogCiAgICAgICBpbnNlcnRBZnRl cihkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJwIiksIGZsZXhib3gpOwotICAgICAgaW5zZXJ0QWZ0 ZXIoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZmFpbHVyZXMubGVuZ3RoID8gZmFpbHVyZXMuam9p bignPGJyPicpIDogIlBBU1MiKSwgZmxleGJveCk7CisgICAgICBpbnNlcnRBZnRlcihkb2N1bWVu dC5jcmVhdGVUZXh0Tm9kZShmYWlsdXJlcy5sZW5ndGggPyBmYWlsdXJlcy5qb2luKCcnKSA6ICJQ QVNTIiksIGZsZXhib3gpOwogICAgIH0pOwogfQo= 105846 2011-08-31 15:51:41 -0700 2011-08-31 15:54:37 -0700 Patch bug-67330-20110831155139.patch text/plain 2061 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyMzQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYzBkNjA5NjljYWM3MWFjMzJhMTVi ODhmYTBjMTM3MzcwYmMwMWRiLi44MTk5OTU0Yzc1ZjFkNTE2MDBjZTFjZmZiMWRkZDRhMWNmNzc2 YTM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMzEgIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KKworICAgICAgICBmaXggYnVnIGluIGZsZXhib3ggdGVzdCB3aXRoIG9m ZnNldFdpZHRoL29mZnNldExlZnQgb2YgMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjczMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGNzczMvZmxleGJveC9yZXNvdXJjZXMvZmxleGJveC5qczoKKwog MjAxMS0wOC0zMSAgQ2FyeSBDbGFyayAgPGNhcnljbGFya0Bnb29nbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQ7IG5ldyBiYXNlbGluZXMgKFNraWEgb24gTWFjLCBuZXh0IGNodW5rIG9mIDgw MCBmaWxlcykKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9yZXNvdXJjZXMv ZmxleGJveC5qcyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9yZXNvdXJjZXMvZmxleGJveC5q cwppbmRleCAyYjkxOWYxZmI2NWUxMzY3NmRiYmMxNWVkOTczMmRhNzdmNTBkNjRjLi44ZGY5MTVj MGVjMDFhM2M5NzViYzVkNjA0YTE5MzcxYzRlYWQwOGM5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9jc3MzL2ZsZXhib3gvcmVzb3VyY2VzL2ZsZXhib3guanMKKysrIGIvTGF5b3V0VGVzdHMvY3Nz My9mbGV4Ym94L3Jlc291cmNlcy9mbGV4Ym94LmpzCkBAIC05LDEzICs5LDEzIEBAIGZ1bmN0aW9u IGluc2VydEFmdGVyKG5vZGVUb0FkZCwgcmVmZXJlbmNlTm9kZSkKIGZ1bmN0aW9uIGNoZWNrRXhw ZWN0ZWRWYWx1ZXMobm9kZSwgZmFpbHVyZXMpCiB7CiAgICAgdmFyIGV4cGVjdGVkV2lkdGggPSBu b2RlLmdldEF0dHJpYnV0ZSAmJiBub2RlLmdldEF0dHJpYnV0ZSgiZGF0YS1leHBlY3RlZC13aWR0 aCIpOwotICAgIGlmIChub2RlLm9mZnNldFdpZHRoICYmIGV4cGVjdGVkV2lkdGgpIHsKKyAgICBp ZiAoZXhwZWN0ZWRXaWR0aCkgewogICAgICAgICBpZiAobm9kZS5vZmZzZXRXaWR0aCAhPSBwYXJz ZUludChleHBlY3RlZFdpZHRoKSkKICAgICAgICAgICAgIGZhaWx1cmVzLnB1c2goIkV4cGVjdGVk ICIgKyBleHBlY3RlZFdpZHRoICsgIiBmb3Igd2lkdGgsIGJ1dCBnb3QgIiArIG5vZGUub2Zmc2V0 V2lkdGggKyAiLiAiKTsKICAgICB9CiAKICAgICB2YXIgZXhwZWN0ZWRPZmZzZXQgPSBub2RlLmdl dEF0dHJpYnV0ZSAmJiBub2RlLmdldEF0dHJpYnV0ZSgiZGF0YS1vZmZzZXQteCIpOwotICAgIGlm IChub2RlLm9mZnNldExlZnQgJiYgZXhwZWN0ZWRPZmZzZXQpIHsKKyAgICBpZiAoZXhwZWN0ZWRP ZmZzZXQpIHsKICAgICAgICAgaWYgKG5vZGUub2Zmc2V0TGVmdCAhPSBwYXJzZUludChleHBlY3Rl ZE9mZnNldCkpCiAgICAgICAgICAgICBmYWlsdXJlcy5wdXNoKCJFeHBlY3RlZCAiICsgZXhwZWN0 ZWRPZmZzZXQgKyAiIGZvciBvZmZzZXRMZWZ0LCBidXQgZ290ICIgKyBub2RlLm9mZnNldExlZnQg KyAiLiAiKTsKICAgICB9CkBAIC0zNSw2ICszNSw2IEBAIGZ1bmN0aW9uIGNoZWNrSG9yaXpvbnRh bEJveGVuKCkKICAgICAgIH0KIAogICAgICAgaW5zZXJ0QWZ0ZXIoZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgicCIpLCBmbGV4Ym94KTsKLSAgICAgIGluc2VydEFmdGVyKGRvY3VtZW50LmNyZWF0ZVRl eHROb2RlKGZhaWx1cmVzLmxlbmd0aCA/IGZhaWx1cmVzLmpvaW4oJzxicj4nKSA6ICJQQVNTIiks IGZsZXhib3gpOworICAgICAgaW5zZXJ0QWZ0ZXIoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZmFp bHVyZXMubGVuZ3RoID8gZmFpbHVyZXMuam9pbignJykgOiAiUEFTUyIpLCBmbGV4Ym94KTsKICAg ICB9KTsKIH0K