67316 2011-08-31 14:05:08 -0700 REGRESSION(92210): AVFoundation media engine is disabled on OS X 2011-08-31 16:53:57 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC All RESOLVED FIXED InRadar P1 Normal --- 66253 1 jeffm jeffm aroben eric.carlson jeffm oldest_to_newest 459899 0 jeffm 2011-08-31 14:05:08 -0700 When I moved the definition of WTF_USE_AVFOUNDATION on the Mac from JavaScriptCore/wtf/Platform.h to WebCore/config.h to fix bug 65552, this caused AVFoundation to be disabled on OS X, since WebKit2 doesn't have access to WebCore/config.h on the Mac (it does on Windows). 459900 1 jeffm 2011-08-31 14:05:27 -0700 <rdar://problem/10047199> 459919 2 jeffm 2011-08-31 14:20:06 -0700 Sam says that we shouldn't have moved the definition of WTF_USE_AVFOUNDATION out of JavaScriptCore/wtf/Platform.h in the first place. I'll use this bug to track fixing this for the Mac, and file a separate bug for Windows, since that's more involved. 460038 3 jeffm 2011-08-31 16:22:21 -0700 Fixing this on Windows is tracked by bug 67334. 460059 4 105857 jeffm 2011-08-31 16:36:17 -0700 Created attachment 105857 Patch 460083 5 jeffm 2011-08-31 16:53:57 -0700 Committed r94251: <http://trac.webkit.org/changeset/94251> 105857 2011-08-31 16:36:17 -0700 2011-08-31 16:41:28 -0700 Patch bug-67316-20110831163616.patch text/plain 2985 jeffm SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTQyNDYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDgtMzEgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04oOTIyMTApOiBBVkZvdW5kYXRpb24gbWVkaWEgZW5naW5lIGlzIGRpc2FibGVkIG9u IE9TIFgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3 MzE2CisKKyAgICAgICAgTW92ZSB0aGUgZGVmaW5pdGlvbiBvZiBXVEZfVVNFX0FWRk9VTkRBVElP TiBvbiB0aGUgTWFjIGJhY2sgdG8gSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgsCisgICAg ICAgIHNpbmNlIFdlYktpdDIgZG9lc24ndCBoYXZlIGFjY2VzcyB0byBXZWJDb3JlL2NvbmZpZy5o IG9uIHRoaXMgcGxhdGZvcm0uIFRoaXMgcmV2ZXJ0cyB0aGUKKyAgICAgICAgY2hhbmdlcyB0aGF0 IHdlcmUgbWFkZSBpbiByOTIyMTAuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogQWRkZWQgZGVmaW5pdGlvbiBvZiBXVEZf VVNFX0FWRk9VTkRBVElPTiBvbiB0aGUgTWFjLgorCiAyMDExLTA4LTMxICBQZXRlciBCZXZlcmxv byAgPHBldGVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgQW5kcm9pZCdzIHBsYXRmb3Jt IHNwZWNpZmljYXRpb24gYW5kIHRoZSByaWdodCBhdG9taWMgZnVuY3Rpb25zLgpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gOTQxOTQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTExNDEsNCAr MTE0MSw4IEBACiAjZW5kaWYKICNlbmRpZgogCisjaWYgUExBVEZPUk0oTUFDKSAmJiAhZGVmaW5l ZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9TTk9XX0xFT1BB UkQpCisjZGVmaW5lIFdURl9VU0VfQVZGT1VOREFUSU9OIDEKKyNlbmRpZgorCiAjZW5kaWYgLyog V1RGX1BsYXRmb3JtX2ggKi8KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MjQ2KQorKysgU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIw MTEtMDgtMzEgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JF U1NJT04oOTIyMTApOiBBVkZvdW5kYXRpb24gbWVkaWEgZW5naW5lIGlzIGRpc2FibGVkIG9uIE9T IFgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3MzE2 CisgICAgICAgIAorICAgICAgICBNb3ZlIHRoZSBkZWZpbml0aW9uIG9mIFdURl9VU0VfQVZGT1VO REFUSU9OIG9uIHRoZSBNYWMgYmFjayB0byBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaCwK KyAgICAgICAgc2luY2UgV2ViS2l0MiBkb2Vzbid0IGhhdmUgYWNjZXNzIHRvIFdlYkNvcmUvY29u ZmlnLmggb24gdGhpcyBwbGF0Zm9ybS4gVGhpcyByZXZlcnRzIHRoZQorICAgICAgICBjaGFuZ2Vz IHRoYXQgd2VyZSBtYWRlIGluIHI5MjIxMC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgbWVk aWEgdGVzdHMuCisKKyAgICAgICAgKiBjb25maWcuaDogUmVtb3ZlZCBkZWZpbml0aW9uIG9mIFdU Rl9VU0VfQVZGT1VOREFUSU9OIG9uIHRoZSBNYWMsIGFkZCBhIGNvbW1lbnQgYWJvdXQgZml4aW5n IHRoaXMgb24gV2luZG93cyBpbiB0aGUgZnV0dXJlLgorCiAyMDExLTA4LTMxICBTYWlsZXNoIEFn cmF3YWwgIDxzYWlsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFN3aXRjaGlu ZyBiZXR3ZWVuIG92ZXJsYXkgYW5kIG9wYXF1ZSBzY3JvbGxiYXJzIGNhdXNlcyBnbGl0Y2hlcwpJ bmRleDogU291cmNlL1dlYkNvcmUvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvY29uZmlnLmgJKHJldmlzaW9uIDk0MTk0KQorKysgU291cmNlL1dlYkNvcmUvY29uZmlnLmgJ KHdvcmtpbmcgY29weSkKQEAgLTIyMiwxMCArMjIyLDggQEAgdHlwZWRlZiBmbG9hdCBDR0Zsb2F0 OwogI2luY2x1ZGUgPGJyaWRnZS9ucHJ1bnRpbWVfaW50ZXJuYWwuaD4KICNlbmRpZgogCi0jaWYg UExBVEZPUk0oTUFDKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVmaW5l ZChCVUlMRElOR19PTl9TTk9XX0xFT1BBUkQpCi0jZGVmaW5lIFdURl9VU0VfQVZGT1VOREFUSU9O IDEKLSNlbmRpZgotCisvLyBGSVhNRTogTW92ZSB0aGlzIHRvIEphdmFTY3JpcHRDb3JlL3d0Zi9Q bGF0Zm9ybS5oLCB3aGljaCBpcyB3aGVyZSB3ZSBkZWZpbmUgV1RGX1VTRV9BVkZPVU5EQVRJT04g b24gdGhlIE1hYy4KKy8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NzMzNAogI2lmIFBMQVRGT1JNKFdJTikgJiYgSEFWRShBVkNGKQogI2RlZmluZSBXVEZfVVNFX0FW Rk9VTkRBVElPTiAxCiAjZW5kaWYK