67311 2011-08-31 13:29:26 -0700 Add EnabledAtRuntime support for constants. 2011-09-30 11:19:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 acolwell webkit-unassigned abarth webkit.review.bot oldest_to_newest 459854 0 acolwell 2011-08-31 13:29:26 -0700 Add EnabledAtRuntime support for constants. 459856 1 105821 acolwell 2011-08-31 13:29:59 -0700 Created attachment 105821 Patch 459860 2 acolwell 2011-08-31 13:33:54 -0700 Currently V8 code generation allows EnabledAtRuntime on methods and attributes, but not constants. This patch allows constants to be runtime enabled so experimental features that have constants, like MediaSource (https://bugs.webkit.org/show_bug.cgi?id=67306), can completely hide themselves in the DOM. Without this patch the attributes and methods would be hidden, but the constants would be visible. 465397 3 acolwell 2011-09-11 06:31:04 -0700 ping 476131 4 109302 acolwell 2011-09-30 09:51:34 -0700 Created attachment 109302 Patch 476133 5 acolwell 2011-09-30 09:54:16 -0700 Will you review this please. 476140 6 109302 abarth 2011-09-30 10:01:03 -0700 Comment on attachment 109302 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109302&action=review > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2113 > # FIXME: we need the static_cast here only because of one constant, NodeFilter.idl > # defines "const unsigned long SHOW_ALL = 0xFFFFFFFF". It would be better if we > # handled this here, and converted it to a -1 constant in the c++ output. Can you move this comment inside the else branch? That's really where it belongs. > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2253 > + static const BatchedConstant constData = {"${name}", static_cast<signed int>(${value})}; > + batchConfigureConstants(desc, proto, &constData, 1); Its too bad we don't get much of a batching savings here, but I don't see how to avoid that. Maybe if we grouped by condition? That doesn't seem worthwhile. 476151 7 109302 acolwell 2011-09-30 10:20:24 -0700 Comment on attachment 109302 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109302&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2113 >> # handled this here, and converted it to a -1 constant in the c++ output. > > Can you move this comment inside the else branch? That's really where it belongs. Done. >> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2253 >> + batchConfigureConstants(desc, proto, &constData, 1); > > Its too bad we don't get much of a batching savings here, but I don't see how to avoid that. Maybe if we grouped by condition? That doesn't seem worthwhile. Yeah I didn't like that either, but I figured grouping by condition was going to make this very difficult to read for not a whole lot of gain. 476152 8 109307 acolwell 2011-09-30 10:20:50 -0700 Created attachment 109307 Patch 476192 9 109307 webkit.review.bot 2011-09-30 11:19:28 -0700 Comment on attachment 109307 Patch Clearing flags on attachment: 109307 Committed r96409: <http://trac.webkit.org/changeset/96409> 476193 10 webkit.review.bot 2011-09-30 11:19:33 -0700 All reviewed patches have been landed. Closing bug. 105821 2011-08-31 13:29:59 -0700 2011-09-30 09:44:26 -0700 Patch bug-67311-20110831132958.patch text/plain 3257 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyMDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlOTQ2NTU2YzMyMzQzMjZj YmM3MDg3ZjNlZTEyYmMyMmYzNTk3NDQyLi4wODY2ZDcwZDdiNzRiN2EzMjhjMGUwNzU0NjA0Mjc2 ZDJjN2RhZWY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMzEgIEFhcm9u IENvbHdlbGwgIDxhY29sd2VsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIEVuYWJsZWRB dFJ1bnRpbWUgc3VwcG9ydCBmb3IgY29uc3RhbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjczMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAq IGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVJ bXBsZW1lbnRhdGlvbik6CisKIDIwMTEtMDgtMzAgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgY2hlY2tlZCBhcml0aG1ldGljCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmlu ZGV4IDNmY2I3MmQ4NGIzN2Q1MjkwNjIzMmRiOWZkOGZmNThjMGZmM2YyOGQuLmZjYWI1N2VjZjMz NjJmMmViMzQ4ZmFlYzkyZjVlNzY4NzczMDYwMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0yMDYzLDYgKzIwNjMsNyBA QCBFTkQKIAogICAgICMgU2V0dXAgY29uc3RhbnRzCiAgICAgbXkgJGhhc19jb25zdGFudHMgPSAw OworICAgIG15IEBjb25zdGFudHNFbmFibGVkQXRSdW50aW1lOwogICAgIGlmIChAeyRkYXRhTm9k ZS0+Y29uc3RhbnRzfSkgewogICAgICAgICAkaGFzX2NvbnN0YW50cyA9IDE7CiAgICAgICAgIHB1 c2goQGltcGxDb250ZW50LCAic3RhdGljIGNvbnN0IEJhdGNoZWRDb25zdGFudCAke2ludGVyZmFj ZU5hbWV9Q29uc3RzW10gPSB7XG4iKTsKQEAgLTIwNzAsMTIgKzIwNzEsMTcgQEAgRU5ECiAgICAg Zm9yZWFjaCBteSAkY29uc3RhbnQgKEB7JGRhdGFOb2RlLT5jb25zdGFudHN9KSB7CiAgICAgICAg IG15ICRuYW1lID0gJGNvbnN0YW50LT5uYW1lOwogICAgICAgICBteSAkdmFsdWUgPSAkY29uc3Rh bnQtPnZhbHVlOworICAgICAgICBteSAkYXR0ckV4dCA9ICRjb25zdGFudC0+ZXh0ZW5kZWRBdHRy aWJ1dGVzOwogICAgICAgICAjIEZJWE1FOiB3ZSBuZWVkIHRoZSBzdGF0aWNfY2FzdCBoZXJlIG9u bHkgYmVjYXVzZSBvZiBvbmUgY29uc3RhbnQsIE5vZGVGaWx0ZXIuaWRsCiAgICAgICAgICMgZGVm aW5lcyAiY29uc3QgdW5zaWduZWQgbG9uZyBTSE9XX0FMTCA9IDB4RkZGRkZGRkYiLiAgSXQgd291 bGQgYmUgYmV0dGVyIGlmIHdlCiAgICAgICAgICMgaGFuZGxlZCB0aGlzIGhlcmUsIGFuZCBjb252 ZXJ0ZWQgaXQgdG8gYSAtMSBjb25zdGFudCBpbiB0aGUgYysrIG91dHB1dC4KLSAgICAgICAgcHVz aChAaW1wbENvbnRlbnQsIDw8RU5EKTsKKyAgICAgICAgaWYgKCRhdHRyRXh0LT57IkVuYWJsZWRB dFJ1bnRpbWUifSkgeworICAgICAgICAgICAgcHVzaChAY29uc3RhbnRzRW5hYmxlZEF0UnVudGlt ZSwgJGNvbnN0YW50KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHB1c2goQGltcGxD b250ZW50LCA8PEVORCk7CiAgICAgeyIke25hbWV9Iiwgc3RhdGljX2Nhc3Q8c2lnbmVkIGludD4o JHZhbHVlKX0sCiBFTkQKKyAgICAgICAgfQogICAgIH0KICAgICBpZiAoJGhhc19jb25zdGFudHMp IHsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ9O1xuXG4iKTsKQEAgLTIxOTMsNiArMjE5 OSwyMiBAQCBFTkQKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJcbiNlbmRpZiAvLyAke2Nv bmRpdGlvbmFsU3RyaW5nfVxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5nOwogICAgIH0KIAorICAg ICMgU2V0dXAgdGhlIGVuYWJsZS1hdC1ydW50aW1lIGNvbnN0YW50cyBpZiB3ZSBoYXZlIHRoZW0K KyAgICBmb3JlYWNoIG15ICRydW50aW1lX2NvbnN0IChAY29uc3RhbnRzRW5hYmxlZEF0UnVudGlt ZSkgeworICAgICAgICBteSAkZW5hYmxlX2Z1bmN0aW9uID0gR2V0UnVudGltZUVuYWJsZUZ1bmN0 aW9uTmFtZSgkcnVudGltZV9jb25zdCk7CisgICAgICAgIG15ICRjb25kaXRpb25hbFN0cmluZyA9 IEdlbmVyYXRlQ29uZGl0aW9uYWxTdHJpbmcoJHJ1bnRpbWVfY29uc3QpOworICAgICAgICBteSAk bmFtZSA9ICRydW50aW1lX2NvbnN0LT5uYW1lOworICAgICAgICBteSAkdmFsdWUgPSAkcnVudGlt ZV9jb25zdC0+dmFsdWU7CisgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiXG4jaWYgJHtjb25k aXRpb25hbFN0cmluZ31cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKKyAgICAgICAgcHVzaChA aW1wbENvbnRlbnQsICIgICAgaWYgKCR7ZW5hYmxlX2Z1bmN0aW9ufSgpKSB7XG4iKTsKKyAgICAg ICAgcHVzaChAaW1wbENvbnRlbnQsIDw8RU5EKTsKKyAgICAgICAgc3RhdGljIGNvbnN0IEJhdGNo ZWRDb25zdGFudCBjb25zdERhdGEgPSB7IiR7bmFtZX0iLCBzdGF0aWNfY2FzdDxzaWduZWQgaW50 Pigke3ZhbHVlfSl9OworICAgICAgICBiYXRjaENvbmZpZ3VyZUNvbnN0YW50cyhkZXNjLCBwcm90 bywgJmNvbnN0RGF0YSwgMSk7CitFTkQKKyAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAg fVxuIik7CisgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiXG4jZW5kaWYgLy8gJHtjb25kaXRp b25hbFN0cmluZ31cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKKyAgICB9CisKICAgICBHZW5l cmF0ZUltcGxlbWVudGF0aW9uSW5kZXhlcigkZGF0YU5vZGUsICRpbmRleGVyKTsKICAgICBHZW5l cmF0ZUltcGxlbWVudGF0aW9uTmFtZWRQcm9wZXJ0eUdldHRlcigkZGF0YU5vZGUsICRuYW1lZFBy b3BlcnR5R2V0dGVyKTsKICAgICBHZW5lcmF0ZUltcGxlbWVudGF0aW9uQ3VzdG9tQ2FsbCgkZGF0 YU5vZGUpOwo= 109302 2011-09-30 09:51:34 -0700 2011-09-30 10:20:45 -0700 Patch bug-67311-20110930095133.patch text/plain 3271 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogOTY0MDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YjllYzliNjkxMmFjNzE1 NjVmNGM3ZDEyMDdlM2EwMDA2Y2Y3NWVmLi40YjQ5ODQ2NmQwZTFjZmE0MGQ4NTUwZDU0M2ZmMzk2 N2ZkYjdiMGMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMzAgIEFhcm9u IENvbHdlbGwgIDxhY29sd2VsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IEVuYWJsZWRB dFJ1bnRpbWUgc3VwcG9ydCBmb3IgY29uc3RhbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjczMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisKIDIwMTEtMDktMzAgIFBh dmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtjaHJvbWl1bV0gZXhwb3NlIGluc3BlY3RvciBwcm90b2NvbCB2ZXJzaW9uIHRvIHRoZSBl bWJlZGRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG0KaW5kZXggMWQwNzY4MjQxZjZjNmZlODZlODRkMGQ5MzZmMDE3NWY0NmMxYzk4 ZS4uYWM0M2RlZTgyZDcxMjAxMzM5ZDVjYWU1ODNjMzAyYzJlMTE4ZjIzNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTIw OTksNiArMjA5OSw3IEBAIEVORAogCiAgICAgIyBTZXR1cCBjb25zdGFudHMKICAgICBteSAkaGFz X2NvbnN0YW50cyA9IDA7CisgICAgbXkgQGNvbnN0YW50c0VuYWJsZWRBdFJ1bnRpbWU7CiAgICAg aWYgKEB7JGRhdGFOb2RlLT5jb25zdGFudHN9KSB7CiAgICAgICAgICRoYXNfY29uc3RhbnRzID0g MTsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJzdGF0aWMgY29uc3QgQmF0Y2hlZENvbnN0 YW50ICR7aW50ZXJmYWNlTmFtZX1Db25zdHNbXSA9IHtcbiIpOwpAQCAtMjEwNiwxMiArMjEwNywx NyBAQCBFTkQKICAgICBmb3JlYWNoIG15ICRjb25zdGFudCAoQHskZGF0YU5vZGUtPmNvbnN0YW50 c30pIHsKICAgICAgICAgbXkgJG5hbWUgPSAkY29uc3RhbnQtPm5hbWU7CiAgICAgICAgIG15ICR2 YWx1ZSA9ICRjb25zdGFudC0+dmFsdWU7CisgICAgICAgIG15ICRhdHRyRXh0ID0gJGNvbnN0YW50 LT5leHRlbmRlZEF0dHJpYnV0ZXM7CiAgICAgICAgICMgRklYTUU6IHdlIG5lZWQgdGhlIHN0YXRp Y19jYXN0IGhlcmUgb25seSBiZWNhdXNlIG9mIG9uZSBjb25zdGFudCwgTm9kZUZpbHRlci5pZGwK ICAgICAgICAgIyBkZWZpbmVzICJjb25zdCB1bnNpZ25lZCBsb25nIFNIT1dfQUxMID0gMHhGRkZG RkZGRiIuICBJdCB3b3VsZCBiZSBiZXR0ZXIgaWYgd2UKICAgICAgICAgIyBoYW5kbGVkIHRoaXMg aGVyZSwgYW5kIGNvbnZlcnRlZCBpdCB0byBhIC0xIGNvbnN0YW50IGluIHRoZSBjKysgb3V0cHV0 LgotICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOworICAgICAgICBpZiAoJGF0dHJF eHQtPnsiRW5hYmxlZEF0UnVudGltZSJ9KSB7CisgICAgICAgICAgICBwdXNoKEBjb25zdGFudHNF bmFibGVkQXRSdW50aW1lLCAkY29uc3RhbnQpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAg ICAgcHVzaChAaW1wbENvbnRlbnQsIDw8RU5EKTsKICAgICB7IiR7bmFtZX0iLCBzdGF0aWNfY2Fz dDxzaWduZWQgaW50PigkdmFsdWUpfSwKIEVORAorICAgICAgICB9CiAgICAgfQogICAgIGlmICgk aGFzX2NvbnN0YW50cykgewogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIn07XG5cbiIpOwpA QCAtMjIzNCw2ICsyMjQwLDIyIEBAIEVORAogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIlxu I2VuZGlmIC8vICR7Y29uZGl0aW9uYWxTdHJpbmd9XG4iKSBpZiAkY29uZGl0aW9uYWxTdHJpbmc7 CiAgICAgfQogCisgICAgIyBTZXR1cCB0aGUgZW5hYmxlLWF0LXJ1bnRpbWUgY29uc3RhbnRzIGlm IHdlIGhhdmUgdGhlbQorICAgIGZvcmVhY2ggbXkgJHJ1bnRpbWVfY29uc3QgKEBjb25zdGFudHNF bmFibGVkQXRSdW50aW1lKSB7CisgICAgICAgIG15ICRlbmFibGVfZnVuY3Rpb24gPSBHZXRSdW50 aW1lRW5hYmxlRnVuY3Rpb25OYW1lKCRydW50aW1lX2NvbnN0KTsKKyAgICAgICAgbXkgJGNvbmRp dGlvbmFsU3RyaW5nID0gR2VuZXJhdGVDb25kaXRpb25hbFN0cmluZygkcnVudGltZV9jb25zdCk7 CisgICAgICAgIG15ICRuYW1lID0gJHJ1bnRpbWVfY29uc3QtPm5hbWU7CisgICAgICAgIG15ICR2 YWx1ZSA9ICRydW50aW1lX2NvbnN0LT52YWx1ZTsKKyAgICAgICAgcHVzaChAaW1wbENvbnRlbnQs ICJcbiNpZiAke2NvbmRpdGlvbmFsU3RyaW5nfVxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5nOwor ICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICBpZiAoJHtlbmFibGVfZnVuY3Rpb259KCkp IHtcbiIpOworICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOworICAgICAgICBzdGF0 aWMgY29uc3QgQmF0Y2hlZENvbnN0YW50IGNvbnN0RGF0YSA9IHsiJHtuYW1lfSIsIHN0YXRpY19j YXN0PHNpZ25lZCBpbnQ+KCR7dmFsdWV9KX07CisgICAgICAgIGJhdGNoQ29uZmlndXJlQ29uc3Rh bnRzKGRlc2MsIHByb3RvLCAmY29uc3REYXRhLCAxKTsKK0VORAorICAgICAgICBwdXNoKEBpbXBs Q29udGVudCwgIiAgICB9XG4iKTsKKyAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJcbiNlbmRp ZiAvLyAke2NvbmRpdGlvbmFsU3RyaW5nfVxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5nOworICAg IH0KKwogICAgIEdlbmVyYXRlSW1wbGVtZW50YXRpb25JbmRleGVyKCRkYXRhTm9kZSwgJGluZGV4 ZXIpOwogICAgIEdlbmVyYXRlSW1wbGVtZW50YXRpb25OYW1lZFByb3BlcnR5R2V0dGVyKCRkYXRh Tm9kZSwgJG5hbWVkUHJvcGVydHlHZXR0ZXIpOwogICAgIEdlbmVyYXRlSW1wbGVtZW50YXRpb25D dXN0b21DYWxsKCRkYXRhTm9kZSk7Cg== 109307 2011-09-30 10:20:50 -0700 2011-09-30 11:19:28 -0700 Patch bug-67311-20110930102049.patch text/plain 3548 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogOTY0MDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YjllYzliNjkxMmFjNzE1 NjVmNGM3ZDEyMDdlM2EwMDA2Y2Y3NWVmLi40YjQ5ODQ2NmQwZTFjZmE0MGQ4NTUwZDU0M2ZmMzk2 N2ZkYjdiMGMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMzAgIEFhcm9u IENvbHdlbGwgIDxhY29sd2VsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IEVuYWJsZWRB dFJ1bnRpbWUgc3VwcG9ydCBmb3IgY29uc3RhbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjczMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisKIDIwMTEtMDktMzAgIFBh dmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtjaHJvbWl1bV0gZXhwb3NlIGluc3BlY3RvciBwcm90b2NvbCB2ZXJzaW9uIHRvIHRoZSBl bWJlZGRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG0KaW5kZXggMWQwNzY4MjQxZjZjNmZlODZlODRkMGQ5MzZmMDE3NWY0NmMxYzk4 ZS4uNDgyMjdjYzYxMWI0ODUzMjFkN2ZlMDgxYzZkYTY1OWU4YWE0NDlhMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTIw OTksNiArMjA5OSw3IEBAIEVORAogCiAgICAgIyBTZXR1cCBjb25zdGFudHMKICAgICBteSAkaGFz X2NvbnN0YW50cyA9IDA7CisgICAgbXkgQGNvbnN0YW50c0VuYWJsZWRBdFJ1bnRpbWU7CiAgICAg aWYgKEB7JGRhdGFOb2RlLT5jb25zdGFudHN9KSB7CiAgICAgICAgICRoYXNfY29uc3RhbnRzID0g MTsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJzdGF0aWMgY29uc3QgQmF0Y2hlZENvbnN0 YW50ICR7aW50ZXJmYWNlTmFtZX1Db25zdHNbXSA9IHtcbiIpOwpAQCAtMjEwNiwxMiArMjEwNywx NyBAQCBFTkQKICAgICBmb3JlYWNoIG15ICRjb25zdGFudCAoQHskZGF0YU5vZGUtPmNvbnN0YW50 c30pIHsKICAgICAgICAgbXkgJG5hbWUgPSAkY29uc3RhbnQtPm5hbWU7CiAgICAgICAgIG15ICR2 YWx1ZSA9ICRjb25zdGFudC0+dmFsdWU7Ci0gICAgICAgICMgRklYTUU6IHdlIG5lZWQgdGhlIHN0 YXRpY19jYXN0IGhlcmUgb25seSBiZWNhdXNlIG9mIG9uZSBjb25zdGFudCwgTm9kZUZpbHRlci5p ZGwKLSAgICAgICAgIyBkZWZpbmVzICJjb25zdCB1bnNpZ25lZCBsb25nIFNIT1dfQUxMID0gMHhG RkZGRkZGRiIuICBJdCB3b3VsZCBiZSBiZXR0ZXIgaWYgd2UKLSAgICAgICAgIyBoYW5kbGVkIHRo aXMgaGVyZSwgYW5kIGNvbnZlcnRlZCBpdCB0byBhIC0xIGNvbnN0YW50IGluIHRoZSBjKysgb3V0 cHV0LgotICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOworICAgICAgICBteSAkYXR0 ckV4dCA9ICRjb25zdGFudC0+ZXh0ZW5kZWRBdHRyaWJ1dGVzOworICAgICAgICBpZiAoJGF0dHJF eHQtPnsiRW5hYmxlZEF0UnVudGltZSJ9KSB7CisgICAgICAgICAgICBwdXNoKEBjb25zdGFudHNF bmFibGVkQXRSdW50aW1lLCAkY29uc3RhbnQpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAg ICAgIyBGSVhNRTogd2UgbmVlZCB0aGUgc3RhdGljX2Nhc3QgaGVyZSBvbmx5IGJlY2F1c2Ugb2Yg b25lIGNvbnN0YW50LCBOb2RlRmlsdGVyLmlkbAorICAgICAgICAgICAgIyBkZWZpbmVzICJjb25z dCB1bnNpZ25lZCBsb25nIFNIT1dfQUxMID0gMHhGRkZGRkZGRiIuICBJdCB3b3VsZCBiZSBiZXR0 ZXIgaWYgd2UKKyAgICAgICAgICAgICMgaGFuZGxlZCB0aGlzIGhlcmUsIGFuZCBjb252ZXJ0ZWQg aXQgdG8gYSAtMSBjb25zdGFudCBpbiB0aGUgYysrIG91dHB1dC4KKyAgICAgICAgICAgIHB1c2go QGltcGxDb250ZW50LCA8PEVORCk7CiAgICAgeyIke25hbWV9Iiwgc3RhdGljX2Nhc3Q8c2lnbmVk IGludD4oJHZhbHVlKX0sCiBFTkQKKyAgICAgICAgfQogICAgIH0KICAgICBpZiAoJGhhc19jb25z dGFudHMpIHsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ9O1xuXG4iKTsKQEAgLTIyMzQs NiArMjI0MCwyMiBAQCBFTkQKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJcbiNlbmRpZiAv LyAke2NvbmRpdGlvbmFsU3RyaW5nfVxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5nOwogICAgIH0K IAorICAgICMgU2V0dXAgdGhlIGVuYWJsZS1hdC1ydW50aW1lIGNvbnN0YW50cyBpZiB3ZSBoYXZl IHRoZW0KKyAgICBmb3JlYWNoIG15ICRydW50aW1lX2NvbnN0IChAY29uc3RhbnRzRW5hYmxlZEF0 UnVudGltZSkgeworICAgICAgICBteSAkZW5hYmxlX2Z1bmN0aW9uID0gR2V0UnVudGltZUVuYWJs ZUZ1bmN0aW9uTmFtZSgkcnVudGltZV9jb25zdCk7CisgICAgICAgIG15ICRjb25kaXRpb25hbFN0 cmluZyA9IEdlbmVyYXRlQ29uZGl0aW9uYWxTdHJpbmcoJHJ1bnRpbWVfY29uc3QpOworICAgICAg ICBteSAkbmFtZSA9ICRydW50aW1lX2NvbnN0LT5uYW1lOworICAgICAgICBteSAkdmFsdWUgPSAk cnVudGltZV9jb25zdC0+dmFsdWU7CisgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiXG4jaWYg JHtjb25kaXRpb25hbFN0cmluZ31cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKKyAgICAgICAg cHVzaChAaW1wbENvbnRlbnQsICIgICAgaWYgKCR7ZW5hYmxlX2Z1bmN0aW9ufSgpKSB7XG4iKTsK KyAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsIDw8RU5EKTsKKyAgICAgICAgc3RhdGljIGNvbnN0 IEJhdGNoZWRDb25zdGFudCBjb25zdERhdGEgPSB7IiR7bmFtZX0iLCBzdGF0aWNfY2FzdDxzaWdu ZWQgaW50Pigke3ZhbHVlfSl9OworICAgICAgICBiYXRjaENvbmZpZ3VyZUNvbnN0YW50cyhkZXNj LCBwcm90bywgJmNvbnN0RGF0YSwgMSk7CitFTkQKKyAgICAgICAgcHVzaChAaW1wbENvbnRlbnQs ICIgICAgfVxuIik7CisgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiXG4jZW5kaWYgLy8gJHtj b25kaXRpb25hbFN0cmluZ31cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKKyAgICB9CisKICAg ICBHZW5lcmF0ZUltcGxlbWVudGF0aW9uSW5kZXhlcigkZGF0YU5vZGUsICRpbmRleGVyKTsKICAg ICBHZW5lcmF0ZUltcGxlbWVudGF0aW9uTmFtZWRQcm9wZXJ0eUdldHRlcigkZGF0YU5vZGUsICRu YW1lZFByb3BlcnR5R2V0dGVyKTsKICAgICBHZW5lcmF0ZUltcGxlbWVudGF0aW9uQ3VzdG9tQ2Fs bCgkZGF0YU5vZGUpOwo=