<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67307</bug_id>
          
          <creation_ts>2011-08-31 11:39:51 -0700</creation_ts>
          <short_desc>[Qt][Symbian] REGRESSION(93235) Missing .def update</short_desc>
          <delta_ts>2011-09-05 06:31:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, Regression</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ademar Reis">ademar</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cshu</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>459780</commentid>
    <comment_count>0</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-08-31 11:39:51 -0700</bug_when>
    <thetext>r93235 introduces new methods to DumpRenderTreeSupportQt but the respective .def file was not updated, thus breaking the build on Symbian.

See error below:
&quot;&quot;&quot;
 compile    : Tools\DumpRenderTree\qt\ImageDiff.cpp  	[armv5_urel.rvct4_0]
 target     : epoc32\release\armv5\urel\DumpRenderTree.exe  	[armv5_urel.rvct4_0]
   Error: L6218E: Undefined symbol DumpRenderTreeSupportQt::resetInternalsObject(QWebFrame*) (referred from DumpRenderTreeQt.o).
   Error: L6218E: Undefined symbol DumpRenderTreeSupportQt::injectInternalsObject(QWebFrame*) (referred from DumpRenderTreeQt.o).
   Not enough information to list image symbols.
   Finished: 1 information, 0 warning and 2 error messages.
&quot;&quot;&quot;

An example of .def file udpate: http://trac.webkit.org/changeset/89621</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461586</commentid>
    <comment_count>1</comment_count>
      <attachid>106208</attachid>
    <who name="jade han">jade.han</who>
    <bug_when>2011-09-02 15:34:34 -0700</bug_when>
    <thetext>Created attachment 106208
fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461587</commentid>
    <comment_count>2</comment_count>
      <attachid>106208</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-09-02 15:38:36 -0700</bug_when>
    <thetext>Comment on attachment 106208
fix

Looks good to me. Thanks !</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461625</commentid>
    <comment_count>3</comment_count>
      <attachid>106208</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-02 16:38:21 -0700</bug_when>
    <thetext>Comment on attachment 106208
fix

Clearing flags on attachment: 106208

Committed r94462: &lt;http://trac.webkit.org/changeset/94462&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461626</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-02 16:38:25 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462142</commentid>
    <comment_count>5</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-09-05 06:31:43 -0700</bug_when>
    <thetext>Revision r94462 cherry-picked into qtwebkit-2.2 with commit 52abba5 &lt;http://gitorious.org/webkit/qtwebkit/commit/52abba5&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>106208</attachid>
            <date>2011-09-02 15:34:34 -0700</date>
            <delta_ts>2011-09-02 16:38:21 -0700</delta_ts>
            <desc>fix</desc>
            <filename>67307.patch</filename>
            <type>text/plain</type>
            <size>1138</size>
            <attacher name="jade han">jade.han</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NDQ1NikKKysrIFNvdXJjZS9XZWJLaXQvcXQv
Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMDIgIEph
ZGUgSGFuICA8amFkZS5oYW5Abm9raWEuY29tPgorCisgICAgICAgIFtRdF1bU3ltYmlhbl0gUkVH
UkVTU0lPTig5MzIzNSkgTWlzc2luZyAuZGVmIHVwZGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjczMDcKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN5bWJpYW4vZWFiaS9RdFdlYktpdHUuZGVmOgor
CiAyMDExLTA5LTAxICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZl
aXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW1F0XSBUcmFuc2Zvcm0gUXRGYWxsYmFja1dl
YlBvcHVwQ29tYm8gaW50byBRdFdlYkNvbWJvQm94CkluZGV4OiBTb3VyY2UvV2ViS2l0L3F0L3N5
bWJpYW4vZWFiaS9RdFdlYktpdHUuZGVmCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvcXQv
c3ltYmlhbi9lYWJpL1F0V2ViS2l0dS5kZWYJKHJldmlzaW9uIDk0NDU2KQorKysgU291cmNlL1dl
YktpdC9xdC9zeW1iaWFuL2VhYmkvUXRXZWJLaXR1LmRlZgkod29ya2luZyBjb3B5KQpAQCAtODc4
LDMgKzg3OCw1IEBAIEVYUE9SVFMNCiAJX1pOOFFEUlROb2RlRDFFdiBAIDg3NyBOT05BTUUNCiAJ
X1pOOFFEUlROb2RlRDJFdiBAIDg3OCBOT05BTUUNCiAJX1pOOFFEUlROb2RlYVNFUktTXyBAIDg3
OSBOT05BTUUNCisJX1pOMjNEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDIxaW5qZWN0SW50ZXJuYWxz
T2JqZWN0RVA5UVdlYkZyYW1lIEAgODgwIE5PTkFNRQ0KKwlfWk4yM0R1bXBSZW5kZXJUcmVlU3Vw
cG9ydFF0MjByZXNldEludGVybmFsc09iamVjdEVQOVFXZWJGcmFtZSBAIDg4MSBOT05BTUUNCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>