67304 2011-08-31 11:15:50 -0700 Web Inspector: [Chromium] Perform a more effective JS GC 2011-11-08 08:36:50 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 71821 1 mnaganov mnaganov abarth apavlov bweinstein japhet joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 459750 0 mnaganov 2011-08-31 11:15:50 -0700 We shouldn't require user to push the "GC" button several times. 459755 1 105799 mnaganov 2011-08-31 11:17:57 -0700 Created attachment 105799 Patch 460229 2 105799 pfeldman 2011-08-31 22:42:06 -0700 Comment on attachment 105799 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105799&action=review > Source/WebCore/bindings/v8/ScriptProfiler.cpp:65 > + while (!v8::V8::IdleNotification()) { should be { }. I'd like somebody from v8 team to bless this change before I rubber stamp it. 460378 3 105941 mnaganov 2011-09-01 04:39:27 -0700 Created attachment 105941 Comments addressed Fixed braces. I've found this code in Chromium's ChromeRenderProcessObserver::OnPurgeMemory. I've discussed it with Slava from the V8 team, and we have agreed that this approach is more effective because it actually does several rounds of GC, clears compilation caches and other stuff that will be left intact after a single MC GC round. 460639 4 mnaganov 2011-09-01 11:39:52 -0700 Manually committed http://trac.webkit.org/changeset/94322 2011-08-31 Mikhail Naganov <mnaganov@chromium.org> Web Inspector: [Chromium] Perform a more effective JS GC https://bugs.webkit.org/show_bug.cgi?id=67304 Reviewed by Pavel Feldman. * bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::collectGarbage): 498066 5 114070 ulan 2011-11-08 08:00:08 -0800 Created attachment 114070 LowMemoryNotification instead of IdleNotification The new GC fixes the LowMemoryNofication, so now there is no need to repeatedly call the IdleNotification. 498070 6 114070 pfeldman 2011-11-08 08:01:44 -0800 Comment on attachment 114070 LowMemoryNotification instead of IdleNotification Please file a separate bug for each patch. Use webkit.org/new-inspector-bug as a template. 498091 7 mnaganov 2011-11-08 08:26:53 -0800 I'd also wait for several days before committing this change to make sure that the new V8 version sticks in Chromium, as it has been already rolled out several times due to performance regressions on bots. 105799 2011-08-31 11:17:57 -0700 2011-09-01 04:39:27 -0700 Patch patch-67304 text/plain 1861 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MGFiZTNhLi4zMzUwZDE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDgtMzEgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIFBlcmZvcm0gYSBtb3JlIGVmZmVj dGl2ZSBKUyBHQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjczMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNj cmlwdFByb2ZpbGVyOjpjb2xsZWN0R2FyYmFnZSk6CisKIDIwMTEtMDgtMzEgIFl1dGEgS2l0YW11 cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU29ja2V0OiBMb2FkIEJsb2Ig aW4gV2ViU29ja2V0Q2hhbm5lbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2NyaXB0UHJvZmlsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 UHJvZmlsZXIuY3BwCmluZGV4IDcxODhjMzIuLmNlOWZmMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlci5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICog Q29weXJpZ2h0IChjKSAyMDEwLCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICog Q29weXJpZ2h0IChjKSAyMDExLCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoK ICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdp dGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRo YXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAtNTgsMTAgKzU4LDEyIEBAIFBhc3NS ZWZQdHI8U2NyaXB0UHJvZmlsZT4gU2NyaXB0UHJvZmlsZXI6OnN0b3AoU2NyaXB0U3RhdGUqIHN0 YXRlLCBjb25zdCBTdHJpbmcmCiAKIHZvaWQgU2NyaXB0UHJvZmlsZXI6OmNvbGxlY3RHYXJiYWdl KCkKIHsKLSAgICAvLyBOT1RFIDogVGhlcmUgaXMgY3VycmVudGx5IG5vIGRpcmVjdCB3YXkgdG8g Y29sbGVjdCBtZW1vcnkgZnJvbSB0aGUgdjggQysrIEFQSQotICAgIC8vIGJ1dCBub3RpZnlpbmcg bG93LW1lbW9yeSBmb3JjZXMgYSBtYXJrLWNvbXBhY3QsIHdoaWNoIGlzIGV4YWN0bHkgd2hhdCB3 ZSB3YW50Ci0gICAgLy8gaW4gdGhpcyBjYXNlLgotICAgIHY4OjpWODo6TG93TWVtb3J5Tm90aWZp Y2F0aW9uKCk7CisgICAgLy8gUmVwZWF0ZWRseSBjYWxsIHRoZSBWOCBpZGxlIG5vdGlmaWNhdGlv biB1bnRpbCBpdCByZXR1cm5zIHRydWUgKCJub3RoaW5nCisgICAgLy8gbW9yZSB0byBmcmVlIiku IE5vdGUgdGhhdCBpdCBtYWtlcyBtb3JlIHNlbnNlIHRvIGRvIHRoaXMgdGhhbiB0byBpbXBsZW1l bnQKKyAgICAvLyBhIG5ldyAiZGVsZXRlIGV2ZXJ5dGhpbmciIHBhc3MgYmVjYXVzZSBvYmplY3Qg cmVmZXJlbmNlcyBtYWtlIGl0IGRpZmZpY3VsdAorICAgIC8vIHRvIGZyZWUgZXZlcnl0aGluZyBw b3NzaWJsZSBpbiBqdXN0IG9uZSBwYXNzLgorICAgIHdoaWxlICghdjg6OlY4OjpJZGxlTm90aWZp Y2F0aW9uKCkpIHsKKyAgICB9CiB9CiAKIG5hbWVzcGFjZSB7Cg== 105941 2011-09-01 04:39:27 -0700 2011-09-01 10:07:09 -0700 Comments addressed patch-67304 text/plain 1856 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MGFiZTNhLi4zMzUwZDE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDgtMzEgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIFBlcmZvcm0gYSBtb3JlIGVmZmVj dGl2ZSBKUyBHQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjczMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNj cmlwdFByb2ZpbGVyOjpjb2xsZWN0R2FyYmFnZSk6CisKIDIwMTEtMDgtMzEgIFl1dGEgS2l0YW11 cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU29ja2V0OiBMb2FkIEJsb2Ig aW4gV2ViU29ja2V0Q2hhbm5lbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2NyaXB0UHJvZmlsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 UHJvZmlsZXIuY3BwCmluZGV4IDcxODhjMzIuLmZiNGU5NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlci5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICog Q29weXJpZ2h0IChjKSAyMDEwLCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICog Q29weXJpZ2h0IChjKSAyMDExLCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoK ICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdp dGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRo YXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAtNTgsMTAgKzU4LDExIEBAIFBhc3NS ZWZQdHI8U2NyaXB0UHJvZmlsZT4gU2NyaXB0UHJvZmlsZXI6OnN0b3AoU2NyaXB0U3RhdGUqIHN0 YXRlLCBjb25zdCBTdHJpbmcmCiAKIHZvaWQgU2NyaXB0UHJvZmlsZXI6OmNvbGxlY3RHYXJiYWdl KCkKIHsKLSAgICAvLyBOT1RFIDogVGhlcmUgaXMgY3VycmVudGx5IG5vIGRpcmVjdCB3YXkgdG8g Y29sbGVjdCBtZW1vcnkgZnJvbSB0aGUgdjggQysrIEFQSQotICAgIC8vIGJ1dCBub3RpZnlpbmcg bG93LW1lbW9yeSBmb3JjZXMgYSBtYXJrLWNvbXBhY3QsIHdoaWNoIGlzIGV4YWN0bHkgd2hhdCB3 ZSB3YW50Ci0gICAgLy8gaW4gdGhpcyBjYXNlLgotICAgIHY4OjpWODo6TG93TWVtb3J5Tm90aWZp Y2F0aW9uKCk7CisgICAgLy8gUmVwZWF0ZWRseSBjYWxsIHRoZSBWOCBpZGxlIG5vdGlmaWNhdGlv biB1bnRpbCBpdCByZXR1cm5zIHRydWUgKCJub3RoaW5nCisgICAgLy8gbW9yZSB0byBmcmVlIiku IE5vdGUgdGhhdCBpdCBtYWtlcyBtb3JlIHNlbnNlIHRvIGRvIHRoaXMgdGhhbiB0byBpbXBsZW1l bnQKKyAgICAvLyBhIG5ldyAiZGVsZXRlIGV2ZXJ5dGhpbmciIHBhc3MgYmVjYXVzZSBvYmplY3Qg cmVmZXJlbmNlcyBtYWtlIGl0IGRpZmZpY3VsdAorICAgIC8vIHRvIGZyZWUgZXZlcnl0aGluZyBw b3NzaWJsZSBpbiBqdXN0IG9uZSBwYXNzLgorICAgIHdoaWxlICghdjg6OlY4OjpJZGxlTm90aWZp Y2F0aW9uKCkpIHsgfQogfQogCiBuYW1lc3BhY2Ugewo= 114070 2011-11-08 08:00:08 -0800 2011-11-08 08:01:44 -0800 LowMemoryNotification instead of IdleNotification b67304 text/plain 870 ulan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlci5jcHAJ KHJldmlzaW9uIDk5NTUyKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJv ZmlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OSwxMSArNTksNyBAQCBQYXNzUmVmUHRyPFNj cmlwdFByb2ZpbGU+IFNjcmlwdFByb2ZpbGVyCiAKIHZvaWQgU2NyaXB0UHJvZmlsZXI6OmNvbGxl Y3RHYXJiYWdlKCkKIHsKLSAgICAvLyBSZXBlYXRlZGx5IGNhbGwgdGhlIFY4IGlkbGUgbm90aWZp Y2F0aW9uIHVudGlsIGl0IHJldHVybnMgdHJ1ZSAoIm5vdGhpbmcKLSAgICAvLyBtb3JlIHRvIGZy ZWUiKS4gTm90ZSB0aGF0IGl0IG1ha2VzIG1vcmUgc2Vuc2UgdG8gZG8gdGhpcyB0aGFuIHRvIGlt cGxlbWVudAotICAgIC8vIGEgbmV3ICJkZWxldGUgZXZlcnl0aGluZyIgcGFzcyBiZWNhdXNlIG9i amVjdCByZWZlcmVuY2VzIG1ha2UgaXQgZGlmZmljdWx0Ci0gICAgLy8gdG8gZnJlZSBldmVyeXRo aW5nIHBvc3NpYmxlIGluIGp1c3Qgb25lIHBhc3MuCi0gICAgd2hpbGUgKCF2ODo6Vjg6OklkbGVO b3RpZmljYXRpb24oKSkgeyB9CisgICAgdjg6OlY4OjpMb3dNZW1vcnlOb3RpZmljYXRpb24oKTsK IH0KIAogUGFzc1JlZlB0cjxJbnNwZWN0b3JWYWx1ZT4gU2NyaXB0UHJvZmlsZXI6Om9iamVjdEJ5 SGVhcE9iamVjdElkKHVuc2lnbmVkIGlkLCBJbmplY3RlZFNjcmlwdE1hbmFnZXIqIGluamVjdGVk U2NyaXB0TWFuYWdlcikK