67278 2011-08-31 04:36:14 -0700 Web Inspector: Having the "Metrics" pane open affects the node highlight display 2011-08-31 07:35:22 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 459551 0 apavlov 2011-08-31 04:36:14 -0700 1. Open Web Inspector, open the Elements pane. 2. Start iterating over nodes using keyboard (Up and Down arrows). Notice how the current node is highlighted. 3. Now expand the Metrics pane and try to do the same. The blue rectangle only blinks for a moment. It is expected that it should work the same regardless of the "Metrics" pane state. 459554 1 apavlov 2011-08-31 04:45:31 -0700 Upstreaming http://crbug.com/93751 459561 2 105769 apavlov 2011-08-31 05:09:17 -0700 Created attachment 105769 [PATCH] Suggested fix 459566 3 105769 yurys 2011-08-31 05:21:22 -0700 Comment on attachment 105769 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=105769&action=review > Source/WebCore/inspector/front-end/MetricsSidebarPane.js:265 > + boxElement.addEventListener("mouseover", this._highlightDOMNode.bind(this, true, name === "position" ? "" : name), false); Could you pass "all" instead of "" for clarity? 459567 4 apavlov 2011-08-31 05:24:10 -0700 (In reply to comment #3) > (From update of attachment 105769 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=105769&action=review > > > Source/WebCore/inspector/front-end/MetricsSidebarPane.js:265 > > + boxElement.addEventListener("mouseover", this._highlightDOMNode.bind(this, true, name === "position" ? "" : name), false); > > Could you pass "all" instead of "" for clarity? Will fix. 459580 5 apavlov 2011-08-31 05:52:27 -0700 Committed r94181: <http://trac.webkit.org/changeset/94181> 459618 6 apavlov 2011-08-31 07:35:22 -0700 *** Bug 66928 has been marked as a duplicate of this bug. *** 105769 2011-08-31 05:09:17 -0700 2011-08-31 05:21:22 -0700 [PATCH] Suggested fix metricshighlight.patch text/plain 2148 apavlov Y29tbWl0IGRiNjc1OTdiNmEwYzlhZWNmYzI4YjY0MjU2YWRjZGE1MGY1MDk2ZjYKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgQXVnIDMx IDE1OjU0OjMwIDIwMTEgKzA0MDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg5OTc3Ny4uZjQw ZGYxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDExLTA4LTMxICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog SGF2aW5nIHRoZSAiTWV0cmljcyIgcGFuZSBvcGVuIGFmZmVjdHMgdGhlIG5vZGUgaGlnaGxpZ2h0 IGRpc3BsYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY3Mjc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL01ldHJpY3NTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5NZXRyaWNzU2lkZWJhclBhbmUucHJvdG90eXBlLl91cGRhdGVNZXRyaWNzKToK KworMjAxMS0wOC0zMSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgor CiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdlZCBidWlsZCBmaXguIFJlc3RvcmUgZGVidWdn ZXJfc2NyaXB0X3NvdXJjZSB0YXJnZXQgZGVwZW5kZW5jeQogICAgICAgICBicm9rZW4gaW4gaHR0 cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvOTQwODIuCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTWV0cmljc1NpZGViYXJQYW5lLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9NZXRyaWNzU2lkZWJhclBhbmUuanMKaW5k ZXggYzJlMDI2Yy4uMTMwZWUwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9NZXRyaWNzU2lkZWJhclBhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9NZXRyaWNzU2lkZWJhclBhbmUuanMKQEAgLTI2Miw3ICsyNjIsNyBA QCBXZWJJbnNwZWN0b3IuTWV0cmljc1NpZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKIAogICAgICAg ICAgICAgdmFyIGJveEVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAg ICAgICAgICAgIGJveEVsZW1lbnQuY2xhc3NOYW1lID0gbmFtZTsKLSAgICAgICAgICAgIGJveEVs ZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdmVyIiwgdGhpcy5faGlnaGxpZ2h0RE9NTm9k ZS5iaW5kKHRoaXMsIHRydWUsIG5hbWUpLCBmYWxzZSk7CisgICAgICAgICAgICBib3hFbGVtZW50 LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlb3ZlciIsIHRoaXMuX2hpZ2hsaWdodERPTU5vZGUuYmlu ZCh0aGlzLCB0cnVlLCBuYW1lID09PSAicG9zaXRpb24iID8gIiIgOiBuYW1lKSwgZmFsc2UpOwog ICAgICAgICAgICAgYm94RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZW91dCIsIHRoaXMu X2hpZ2hsaWdodERPTU5vZGUuYmluZCh0aGlzLCBmYWxzZSwgIiIpLCBmYWxzZSk7CiAKICAgICAg ICAgICAgIGlmIChuYW1lID09PSAiY29udGVudCIpIHsKQEAgLTMwNSw4ICszMDUsNiBAQCBXZWJJ bnNwZWN0b3IuTWV0cmljc1NpZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgbWV0cmlj c0VsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdXQiLCB0aGlzLl9oaWdobGlnaHRET01O b2RlLmJpbmQodGhpcywgZmFsc2UsICIiKSwgZmFsc2UpOwogICAgICAgICB0aGlzLmJvZHlFbGVt ZW50LnJlbW92ZUNoaWxkcmVuKCk7CiAgICAgICAgIHRoaXMuYm9keUVsZW1lbnQuYXBwZW5kQ2hp bGQobWV0cmljc0VsZW1lbnQpOwotCi0gICAgICAgIFdlYkluc3BlY3Rvci5oaWdobGlnaHRET01O b2RlKDApOwogICAgIH0sCiAKICAgICBzdGFydEVkaXRpbmc6IGZ1bmN0aW9uKHRhcmdldEVsZW1l bnQsIGJveCwgc3R5bGVQcm9wZXJ0eSwgY29tcHV0ZWRTdHlsZSkK