67275 2011-08-31 03:19:25 -0700 Web Inspector: remove PresentationBreakpoint class. 2011-09-01 07:19:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 459536 0 podivilov 2011-08-31 03:19:25 -0700 Web Inspector: remove PresentationBreakpoint class. PresentationBreakpoint introduce unnecessary level of indirection with no added value. 459538 1 105764 podivilov 2011-08-31 03:20:40 -0700 Created attachment 105764 Patch 460431 2 podivilov 2011-09-01 07:19:18 -0700 Committed r94294: <http://trac.webkit.org/changeset/94294> 105764 2011-08-31 03:20:40 -0700 2011-08-31 04:10:11 -0700 Patch bug-67275-20110831142038.patch text/plain 5755 podivilov U3VidmVyc2lvbiBSZXZpc2lvbjogOTQxNjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhYWEwMDg0NDFhYjFmOWNi NTc2MTljZDkwZDZiMTc0Mzg5NWM1ZDY5Li4yOWI4N2IwMGJkMmUyNjM0OTVlYjBhNjliY2U2NDg1 ZDM5NjQwM2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMzEgIFBhdmVs IFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogcmVtb3ZlIFByZXNlbnRhdGlvbkJyZWFrcG9pbnQgY2xhc3MuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzI3NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9C cmVha3BvaW50c1NpZGViYXJQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkphdmFTY3Jp cHRCcmVha3BvaW50c1NpZGViYXJQYW5lLnByb3RvdHlwZS5hZGRCcmVha3BvaW50LmRpZFJlcXVl c3RDb250ZW50KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0QnJlYWtwb2ludHNT aWRlYmFyUGFuZS5wcm90b3R5cGUuYWRkQnJlYWtwb2ludCk6CisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwucHJvdG90eXBlLl9icmVha3BvaW50QWRk ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwucHJv dG90eXBlLl9icmVha3BvaW50UmVtb3ZlZCk6CisKIDIwMTEtMDgtMzAgIFBhdmVsIFBvZGl2aWxv diAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVu YW1lIHNvdXJjZUZpbGUgdG8gdWlTb3VyY2VDb2RlIGFuZCBnZXQgcmlkIG9mIHNvdXJjZUZpbGVJ ZCB3aGVyZSBwb3NzaWJsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvQnJlYWtwb2ludHNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludHNTaWRlYmFyUGFuZS5qcwppbmRleCAzZTdjZmNmM2Zm MTlmYTJhZGIxYWQwZjkxMzY4NzJhY2E4MDI2MGU1Li5kNWY4ZDQ2NWYxZWM5NzA4NTMxOWY5MTUw MzI0NzM1MzVhNGQ4Yzk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0JyZWFrcG9pbnRzU2lkZWJhclBhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50c1NpZGViYXJQYW5lLmpzCkBAIC01NywyMCArNTcs MjEgQEAgV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRCcmVha3BvaW50c1NpZGViYXJQYW5lLnByb3Rv dHlwZSA9IHsKICAgICAgICAgY2hlY2tib3guYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlz Ll9icmVha3BvaW50Q2hlY2tib3hDbGlja2VkLmJpbmQodGhpcywgYnJlYWtwb2ludCksIGZhbHNl KTsKICAgICAgICAgZWxlbWVudC5hcHBlbmRDaGlsZChjaGVja2JveCk7CiAKLSAgICAgICAgdmFy IGRpc3BsYXlOYW1lID0gYnJlYWtwb2ludC51cmwgPyBXZWJJbnNwZWN0b3IuZGlzcGxheU5hbWVG b3JVUkwoYnJlYWtwb2ludC51cmwpIDogV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIocHJvZ3JhbSki KTsKKyAgICAgICAgdmFyIHVybCA9IGJyZWFrcG9pbnQudWlTb3VyY2VDb2RlLnVybDsKKyAgICAg ICAgdmFyIGRpc3BsYXlOYW1lID0gdXJsID8gV2ViSW5zcGVjdG9yLmRpc3BsYXlOYW1lRm9yVVJM KHVybCkgOiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIihwcm9ncmFtKSIpOwogICAgICAgICB2YXIg bGFiZWxFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZGlzcGxheU5hbWUgKyAiOiIg KyAoYnJlYWtwb2ludC5saW5lTnVtYmVyICsgMSkpOwogICAgICAgICBlbGVtZW50LmFwcGVuZENo aWxkKGxhYmVsRWxlbWVudCk7CiAKICAgICAgICAgdmFyIHNuaXBwZXRFbGVtZW50ID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgICAgIHNuaXBwZXRFbGVtZW50LmNsYXNzTmFt ZSA9ICJzb3VyY2UtdGV4dCBtb25vc3BhY2UiOwogICAgICAgICBlbGVtZW50LmFwcGVuZENoaWxk KHNuaXBwZXRFbGVtZW50KTsKLSAgICAgICAgaWYgKGJyZWFrcG9pbnQubG9hZFNuaXBwZXQpIHsK LSAgICAgICAgICAgIGZ1bmN0aW9uIGRpZExvYWRTbmlwcGV0KHNuaXBwZXQpCi0gICAgICAgICAg ICB7Ci0gICAgICAgICAgICAgICAgc25pcHBldEVsZW1lbnQudGV4dENvbnRlbnQgPSBzbmlwcGV0 OwotICAgICAgICAgICAgfQotICAgICAgICAgICAgYnJlYWtwb2ludC5sb2FkU25pcHBldChkaWRM b2FkU25pcHBldCk7CisgICAgICAgIGZ1bmN0aW9uIGRpZFJlcXVlc3RDb250ZW50KG1pbWVUeXBl LCBjb250ZW50KQorICAgICAgICB7CisgICAgICAgICAgICB2YXIgbGluZUVuZGluZ3MgPSBjb250 ZW50LmxpbmVFbmRpbmdzKCk7CisgICAgICAgICAgICBpZiAoYnJlYWtwb2ludC5saW5lTnVtYmVy IDwgbGluZUVuZGluZ3MubGVuZ3RoKQorICAgICAgICAgICAgICAgIHNuaXBwZXRFbGVtZW50LnRl eHRDb250ZW50ID0gY29udGVudC5zdWJzdHJpbmcobGluZUVuZGluZ3NbYnJlYWtwb2ludC5saW5l TnVtYmVyIC0gMV0sIGxpbmVFbmRpbmdzW2JyZWFrcG9pbnQubGluZU51bWJlcl0pOwogICAgICAg ICB9CisgICAgICAgIGJyZWFrcG9pbnQudWlTb3VyY2VDb2RlLnJlcXVlc3RDb250ZW50KGRpZFJl cXVlc3RDb250ZW50LmJpbmQodGhpcykpOwogCiAgICAgICAgIGVsZW1lbnQuX2RhdGEgPSBicmVh a3BvaW50OwogICAgICAgICB2YXIgY3VycmVudEVsZW1lbnQgPSB0aGlzLmxpc3RFbGVtZW50LmZp cnN0Q2hpbGQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwuanMKaW5kZXggMjgyNDk0MGRiNjZi NTA3OGNiMDdjMzUyZGViY2I0ZWY2OTg2Zjg0My4uMjVhYmI3NjFkMTBiZGJjZGUxMjZkZTJmOGEw YmE3YTVkYWEzYTM5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5qcwpAQCAtMzU3LDE3 ICszNTcsMTQgQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwucHJvdG90 eXBlID0gewogCiAgICAgX2JyZWFrcG9pbnRBZGRlZDogZnVuY3Rpb24oYnJlYWtwb2ludCkKICAg ICB7Ci0gICAgICAgIGlmICghYnJlYWtwb2ludC51aVNvdXJjZUNvZGUpCi0gICAgICAgICAgICBy ZXR1cm47Ci0gICAgICAgIHZhciBwcmVzZW50YXRpb25CcmVha3BvaW50ID0gbmV3IFdlYkluc3Bl Y3Rvci5QcmVzZW50YXRpb25CcmVha3BvaW50KGJyZWFrcG9pbnQudWlTb3VyY2VDb2RlLCBicmVh a3BvaW50LmxpbmVOdW1iZXIsIGJyZWFrcG9pbnQuY29uZGl0aW9uLCBicmVha3BvaW50LmVuYWJs ZWQpOwotICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3Iu RGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5FdmVudHMuQnJlYWtwb2ludEFkZGVkLCBwcmVzZW50 YXRpb25CcmVha3BvaW50KTsKKyAgICAgICAgaWYgKGJyZWFrcG9pbnQudWlTb3VyY2VDb2RlKQor ICAgICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkRl YnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwuRXZlbnRzLkJyZWFrcG9pbnRBZGRlZCwgYnJlYWtwb2lu dCk7CiAgICAgfSwKIAogICAgIF9icmVha3BvaW50UmVtb3ZlZDogZnVuY3Rpb24oYnJlYWtwb2lu dCkKICAgICB7Ci0gICAgICAgIGlmICghYnJlYWtwb2ludC51aVNvdXJjZUNvZGUpCi0gICAgICAg ICAgICByZXR1cm47Ci0gICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYklu c3BlY3Rvci5EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLkV2ZW50cy5CcmVha3BvaW50UmVtb3Zl ZCwgeyB1aVNvdXJjZUNvZGU6IGJyZWFrcG9pbnQudWlTb3VyY2VDb2RlLCBsaW5lTnVtYmVyOiBi cmVha3BvaW50LmxpbmVOdW1iZXIgfSk7CisgICAgICAgIGlmIChicmVha3BvaW50LnVpU291cmNl Q29kZSkKKyAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3Bl Y3Rvci5EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLkV2ZW50cy5CcmVha3BvaW50UmVtb3ZlZCwg YnJlYWtwb2ludCk7CiAgICAgfSwKIAogICAgIF9kZWJ1Z2dlclBhdXNlZDogZnVuY3Rpb24oKQpA QCAtNDQ5LDQyICs0NDYsNiBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJQcmVzZW50YXRpb25Nb2Rl bC5wcm90b3R5cGUuX19wcm90b19fID0gV2ViSW5zcGVjdG9yLk9iamVjdAogLyoqCiAgKiBAY29u c3RydWN0b3IKICAqLwotV2ViSW5zcGVjdG9yLlByZXNlbnRhdGlvbkJyZWFrcG9pbnQgPSBmdW5j dGlvbih1aVNvdXJjZUNvZGUsIGxpbmVOdW1iZXIsIGNvbmRpdGlvbiwgZW5hYmxlZCkKLXsKLSAg ICB0aGlzLnVpU291cmNlQ29kZSA9IHVpU291cmNlQ29kZTsKLSAgICB0aGlzLmxpbmVOdW1iZXIg PSBsaW5lTnVtYmVyOwotICAgIHRoaXMuY29uZGl0aW9uID0gY29uZGl0aW9uOwotICAgIHRoaXMu ZW5hYmxlZCA9IGVuYWJsZWQ7Ci19Ci0KLVdlYkluc3BlY3Rvci5QcmVzZW50YXRpb25CcmVha3Bv aW50LnByb3RvdHlwZSA9IHsKLSAgICBnZXQgdXJsKCkKLSAgICB7Ci0gICAgICAgIHJldHVybiB0 aGlzLnVpU291cmNlQ29kZS51cmw7Ci0gICAgfSwKLQotICAgIGdldCByZXNvbHZlZCgpCi0gICAg ewotICAgICAgICByZXR1cm4gISF0aGlzLmxvY2F0aW9uOwotICAgIH0sCi0KLSAgICBsb2FkU25p cHBldDogZnVuY3Rpb24oY2FsbGJhY2spCi0gICAgewotICAgICAgICBmdW5jdGlvbiBkaWRSZXF1 ZXN0Q29udGVudChtaW1lVHlwZSwgY29udGVudCkKLSAgICAgICAgewotICAgICAgICAgICAgdmFy IGxpbmVFbmRpbmdzID0gY29udGVudC5saW5lRW5kaW5ncygpOwotICAgICAgICAgICAgdmFyIHNu aXBwZXQgPSAiIjsKLSAgICAgICAgICAgIGlmICh0aGlzLmxpbmVOdW1iZXIgPCBsaW5lRW5kaW5n cy5sZW5ndGgpCi0gICAgICAgICAgICAgICAgc25pcHBldCA9IGNvbnRlbnQuc3Vic3RyaW5nKGxp bmVFbmRpbmdzW3RoaXMubGluZU51bWJlciAtIDFdLCBsaW5lRW5kaW5nc1t0aGlzLmxpbmVOdW1i ZXJdKTsKLSAgICAgICAgICAgIGNhbGxiYWNrKHNuaXBwZXQpOwotICAgICAgICB9Ci0gICAgICAg IHRoaXMudWlTb3VyY2VDb2RlLnJlcXVlc3RDb250ZW50KGRpZFJlcXVlc3RDb250ZW50LmJpbmQo dGhpcykpOwotICAgIH0KLX0KLQotLyoqCi0gKiBAY29uc3RydWN0b3IKLSAqLwogV2ViSW5zcGVj dG9yLlByZXNlbmF0aW9uQ2FsbEZyYW1lID0gZnVuY3Rpb24oY2FsbEZyYW1lLCBpbmRleCwgbW9k ZWwsIHVpU291cmNlQ29kZSkKIHsKICAgICB0aGlzLl9jYWxsRnJhbWUgPSBjYWxsRnJhbWU7Cg==