67246 2011-08-30 16:58:12 -0700 [Qt] Add a convenience function to cast a QTransform to TransformationMatrix 2011-08-31 07:49:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 noam noam webkit.review.bot oldest_to_newest 459335 0 noam 2011-08-30 16:58:12 -0700 Have done this manually far too many times... 459339 1 105721 noam 2011-08-30 17:04:47 -0700 Created attachment 105721 Patch 459590 2 105721 kling 2011-08-31 06:20:47 -0700 Comment on attachment 105721 Patch Since you're not calling it anywhere, this is just dead code. r=me though, assuming that you start using it right away. 459601 3 105721 noam 2011-08-31 06:41:53 -0700 Comment on attachment 105721 Patch Yes, already using it in the branch where I'm working on AC for Qt5. 459626 4 105721 webkit.review.bot 2011-08-31 07:49:37 -0700 Comment on attachment 105721 Patch Clearing flags on attachment: 105721 Committed r94188: <http://trac.webkit.org/changeset/94188> 459627 5 webkit.review.bot 2011-08-31 07:49:41 -0700 All reviewed patches have been landed. Closing bug. 105721 2011-08-30 17:04:47 -0700 2011-08-31 07:49:37 -0700 Patch bug-67246-20110830170008.patch text/plain 2504 noam U3VidmVyc2lvbiBSZXZpc2lvbjogOTQxMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNWY5MDkyODM5MTMxY2Qw ZTdiYjBmNzYzY2NkZDkyYTZiOWUwNzIwLi5jZGJhZTIzYjU3NmY1NGYwYTVmNTUxMTZmMGRiMmNl OWJhOTgwMTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMzAgIE5vJ2Ft IFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIEFk ZCBhIGNvbnZlbmllbmNlIGZ1bmN0aW9uIHRvIGNhc3QgYSBRVHJhbnNmb3JtIHRvIFRyYW5zZm9y bWF0aW9uTWF0cml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NzI0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5IHNvIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3F0L1RyYW5zZm9ybWF0aW9uTWF0cml4UXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VHJhbnNmb3JtYXRpb25NYXRyaXg6OlRyYW5zZm9ybWF0aW9uTWF0cml4KToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4 Lmg6CisKIDIwMTEtMDgtMzAgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgdGhlIFhNTEh0dHBSZXF1ZXN0IG1ldGhvZC9oZWFkZXIg dmFsaWRhdGlvbiBsb2dpYyBhdmFpbGFibGUgYXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3F0L1RyYW5zZm9ybWF0aW9uTWF0cml4UXQuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvVHJhbnNmb3JtYXRpb25NYXRyaXhRdC5jcHAK aW5kZXggYTViYzNjM2NmMGZiOTM3ZjA3ZTZiMjFiNjVmZWE4MDdjZjUzMWJlMS4uNmE1NzM1YjNk Mjg3MTgxNDRiMjExNzI4ZDIwYTNhNzQyNzRhMTQ0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvVHJhbnNmb3JtYXRpb25NYXRyaXhRdC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvVHJhbnNmb3JtYXRpb25NYXRyaXhR dC5jcHAKQEAgLTQyLDYgKzQyLDE0IEBAIEFmZmluZVRyYW5zZm9ybTo6b3BlcmF0b3IgUVRyYW5z Zm9ybSgpIGNvbnN0CiAgICAgcmV0dXJuIFFUcmFuc2Zvcm0oYSgpLCBiKCksIGMoKSwgZCgpLCBl KCksIGYoKSk7CiB9CiAKK1RyYW5zZm9ybWF0aW9uTWF0cml4OjpUcmFuc2Zvcm1hdGlvbk1hdHJp eChjb25zdCBRVHJhbnNmb3JtJiB0cmFuc2Zvcm0pCit7CisgICAgc2V0TWF0cml4KHRyYW5zZm9y bS5tMTEoKSwgdHJhbnNmb3JtLm0xMigpLCAwLCB0cmFuc2Zvcm0ubTEzKCksCisgICAgICAgICAg ICAgIHRyYW5zZm9ybS5tMjEoKSwgdHJhbnNmb3JtLm0yMigpLCAwLCB0cmFuc2Zvcm0ubTIzKCks CisgICAgICAgICAgICAgIDAsIDAsIDEsIDAsCisgICAgICAgICAgICAgIHRyYW5zZm9ybS5tMzEo KSwgdHJhbnNmb3JtLm0zMigpLCAwLCB0cmFuc2Zvcm0ubTMzKCkpOworfQorCiB9CiAKIC8vIHZp bTogdHM9NCBzdz00IGV0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmgKaW5kZXgg ZWM4YWQxYTY4ZDVkZjBmY2EwZWNiOWMyMDIyY2E4Y2Y4OTk3MzdiOS4uMzc1YWJiNjEzMmIzY2Jm MjAyMTgwYjcyYjZjNWIwM2I5MzUwNmMyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25N YXRyaXguaApAQCAtODAsNiArODAsMTAgQEAgcHVibGljOgogICAgICAgICBzZXRNYXRyaXgobTEx LCBtMTIsIG0xMywgbTE0LCBtMjEsIG0yMiwgbTIzLCBtMjQsIG0zMSwgbTMyLCBtMzMsIG0zNCwg bTQxLCBtNDIsIG00MywgbTQ0KTsKICAgICB9CiAKKyNpZiBQTEFURk9STShRVCkKKyAgICBUcmFu c2Zvcm1hdGlvbk1hdHJpeChjb25zdCBRVHJhbnNmb3JtJik7CisjZW5kaWYKKwogICAgIHZvaWQg c2V0TWF0cml4KGRvdWJsZSBhLCBkb3VibGUgYiwgZG91YmxlIGMsIGRvdWJsZSBkLCBkb3VibGUg ZSwgZG91YmxlIGYpCiAgICAgewogICAgICAgICBtX21hdHJpeFswXVswXSA9IGE7IG1fbWF0cml4 WzBdWzFdID0gYjsgbV9tYXRyaXhbMF1bMl0gPSAwOyBtX21hdHJpeFswXVszXSA9IDA7IAo=