67244 2011-08-30 16:21:09 -0700 Add additional convertValue overloads to JSDictionary 2011-08-30 16:33:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam webkit.review.bot oldest_to_newest 459303 0 sam 2011-08-30 16:21:09 -0700 Add additional convertValue overloads to JSDictionary 459305 1 105716 sam 2011-08-30 16:23:58 -0700 Created attachment 105716 Patch 459309 2 webkit.review.bot 2011-08-30 16:26:07 -0700 Attachment 105716 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/js/JSDictionary.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/js/JSDictionary.cpp:98: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/bindings/js/JSDictionary.cpp:103: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/bindings/js/JSDictionary.cpp:108: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/bindings/js/JSDictionary.cpp:113: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/bindings/js/JSDictionary.h:70: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/bindings/js/JSDictionary.h:71: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/bindings/js/JSDictionary.h:72: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/bindings/js/JSDictionary.h:73: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 9 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 459322 3 sam 2011-08-30 16:33:38 -0700 Committed r94123: <http://trac.webkit.org/changeset/94123> 105716 2011-08-30 16:23:58 -0700 2011-08-30 16:25:46 -0700 Patch bug-67244-20110830162357.patch text/plain 5369 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MTIxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDgtMzAgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgYWRkaXRpb25hbCBjb252ZXJ0VmFs dWUgb3ZlcmxvYWRzIHRvIEpTRGljdGlvbmFyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcyNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgb3ZlcmxvYWRzIGZvciBjb252ZXJ0VmFsdWUgdGhhdCB3 aWxsIGJlIG5lZWRlZCBmb3IgRXZlbnQKKyAgICAgICAgY29uc3RydWN0b3JzLgorCisgICAgICAg ICogYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRGlj dGlvbmFyeTo6Y29udmVydFZhbHVlKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RpY3Rpb25h cnkuaDoKKyAgICAgICAgQWRkIG92ZXJsb2Fkcy4gIFJlbW92ZSAjaW5jbHVkZSBvZiA8cnVudGlt ZS9FcnJvci5oPiBhbmQganVzdCBpbmNsdWRlCisgICAgICAgIDxpbnRlcnByZXRlci9DYWxsRnJh bWUuaD4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRXZlbnRDb25zdHJ1Y3RvcnMuY3BwOgor ICAgICAgICBBZGQgbm93IG5lY2Vzc2FyeSAjaW5jbHVkZSBvZiA8cnVudGltZS9FcnJvci5oPi4K KwogMjAxMS0wOC0zMCAgQWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBBZGQgTWVkaWFTb3VyY2UgQVBJIHRvIEhUTUxNZWRpYUVsZW1lbnQKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGljdGlvbmFyeS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5LmNwcAkocmV2aXNpb24gOTQx MTkpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNyw2ICsyNywxMiBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1 ZGUgIkpTRGljdGlvbmFyeS5oIgogCisjaW5jbHVkZSAiSlNET01XaW5kb3cuaCIKKyNpbmNsdWRl ICJKU0V2ZW50VGFyZ2V0LmgiCisjaW5jbHVkZSAiSlNOb2RlLmgiCisjaW5jbHVkZSAiU2VyaWFs aXplZFNjcmlwdFZhbHVlLmgiCisjaW5jbHVkZSAiU2NyaXB0VmFsdWUuaCIKKwogdXNpbmcgbmFt ZXNwYWNlIEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNTQsOSArNjAsNTkgQEAgdm9p ZCBKU0RpY3Rpb25hcnk6OmNvbnZlcnRWYWx1ZShFeGVjU3RhdAogICAgIHJlc3VsdCA9IHZhbHVl LnRvQm9vbGVhbihleGVjKTsKIH0KIAordm9pZCBKU0RpY3Rpb25hcnk6OmNvbnZlcnRWYWx1ZShF eGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUsIGludCYgcmVzdWx0KQoreworICAgIHJlc3Vs dCA9IHZhbHVlLnRvSW50MzIoZXhlYyk7Cit9CisKK3ZvaWQgSlNEaWN0aW9uYXJ5Ojpjb252ZXJ0 VmFsdWUoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHZhbHVlLCB1bnNpZ25lZCYgcmVzdWx0KQor eworICAgIHJlc3VsdCA9IHZhbHVlLnRvVUludDMyKGV4ZWMpOworfQorCit2b2lkIEpTRGljdGlv bmFyeTo6Y29udmVydFZhbHVlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgdW5zaWdu ZWQgc2hvcnQmIHJlc3VsdCkKK3sKKyAgICByZXN1bHQgPSBzdGF0aWNfY2FzdDx1bnNpZ25lZCBz aG9ydD4odmFsdWUudG9VSW50MzIoZXhlYykpOworfQorCit2b2lkIEpTRGljdGlvbmFyeTo6Y29u dmVydFZhbHVlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgdW5zaWduZWQgbG9uZyBs b25nJiByZXN1bHQpCit7CisgICAgcmVzdWx0ID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgbG9uZyBs b25nPih2YWx1ZS50b0ludGVnZXIoZXhlYykpOworfQorCiB2b2lkIEpTRGljdGlvbmFyeTo6Y29u dmVydFZhbHVlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgZG91YmxlJiByZXN1bHQp CiB7CiAgICAgcmVzdWx0ID0gdmFsdWUudG9OdW1iZXIoZXhlYyk7CiB9CiAKK3ZvaWQgSlNEaWN0 aW9uYXJ5Ojpjb252ZXJ0VmFsdWUoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHZhbHVlLCBTdHJp bmcmIHJlc3VsdCkKK3sKKyAgICByZXN1bHQgPSB1c3RyaW5nVG9TdHJpbmcodmFsdWUudG9TdHJp bmcoZXhlYykpOworfQorCit2b2lkIEpTRGljdGlvbmFyeTo6Y29udmVydFZhbHVlKEV4ZWNTdGF0 ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgU2NyaXB0VmFsdWUmIHJlc3VsdCkKK3sKKyAgICByZXN1 bHQgPSBTY3JpcHRWYWx1ZShleGVjLT5nbG9iYWxEYXRhKCksIHZhbHVlKTsKK30KKwordm9pZCBK U0RpY3Rpb25hcnk6OmNvbnZlcnRWYWx1ZShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUs IFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+JiByZXN1bHQpCit7CisgICAgcmVzdWx0ID0g U2VyaWFsaXplZFNjcmlwdFZhbHVlOjpjcmVhdGUoZXhlYywgdmFsdWUpOworfQorCit2b2lkIEpT RGljdGlvbmFyeTo6Y29udmVydFZhbHVlKEV4ZWNTdGF0ZSosIEpTVmFsdWUgdmFsdWUsIFJlZlB0 cjxET01XaW5kb3c+JiByZXN1bHQpCit7CisgICAgcmVzdWx0ID0gdG9ET01XaW5kb3codmFsdWUp OworfQorCit2b2lkIEpTRGljdGlvbmFyeTo6Y29udmVydFZhbHVlKEV4ZWNTdGF0ZSosIEpTVmFs dWUgdmFsdWUsIFJlZlB0cjxFdmVudFRhcmdldD4mIHJlc3VsdCkKK3sKKyAgICByZXN1bHQgPSB0 b0V2ZW50VGFyZ2V0KHZhbHVlKTsKK30KKwordm9pZCBKU0RpY3Rpb25hcnk6OmNvbnZlcnRWYWx1 ZShFeGVjU3RhdGUqLCBKU1ZhbHVlIHZhbHVlLCBSZWZQdHI8Tm9kZT4mIHJlc3VsdCkKK3sKKyAg ICByZXN1bHQgPSB0b05vZGUodmFsdWUpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaAkocmV2aXNpb24g OTQxMTkpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaAkod29y a2luZyBjb3B5KQpAQCAtMjYsMTAgKzI2LDE3IEBACiAjaWZuZGVmIEpTRGljdGlvbmFyeV9oCiAj ZGVmaW5lIEpTRGljdGlvbmFyeV9oCiAKLSNpbmNsdWRlIDxydW50aW1lL0Vycm9yLmg+CisjaW5j bHVkZSA8aW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmg+CisjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4K IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBET01XaW5kb3c7CitjbGFzcyBFdmVudFRh cmdldDsKK2NsYXNzIE5vZGU7CitjbGFzcyBTY3JpcHRWYWx1ZTsKK2NsYXNzIFNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZTsKKwogY2xhc3MgSlNEaWN0aW9uYXJ5IHsKIHB1YmxpYzoKICAgICBKU0RpY3Rp b25hcnkoSlNDOjpFeGVjU3RhdGUqIGV4ZWMsIEpTQzo6SlNPYmplY3QqIGluaXRpYWxpemVyT2Jq ZWN0KQpAQCAtNTMsNyArNjAsMTcgQEAgcHJpdmF0ZToKICAgICBHZXRQcm9wZXJ0eVJlc3VsdCB0 cnlHZXRQcm9wZXJ0eShjb25zdCBjaGFyKiBwcm9wZXJ0eU5hbWUsIEpTQzo6SlNWYWx1ZSYpOwog CiAgICAgc3RhdGljIHZvaWQgY29udmVydFZhbHVlKEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU1Zh bHVlLCBib29sJiByZXN1bHQpOworICAgIHN0YXRpYyB2b2lkIGNvbnZlcnRWYWx1ZShKU0M6OkV4 ZWNTdGF0ZSosIEpTQzo6SlNWYWx1ZSwgaW50JiByZXN1bHQpOworICAgIHN0YXRpYyB2b2lkIGNv bnZlcnRWYWx1ZShKU0M6OkV4ZWNTdGF0ZSosIEpTQzo6SlNWYWx1ZSwgdW5zaWduZWQmIHJlc3Vs dCk7CisgICAgc3RhdGljIHZvaWQgY29udmVydFZhbHVlKEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpK U1ZhbHVlLCB1bnNpZ25lZCBzaG9ydCYgcmVzdWx0KTsKKyAgICBzdGF0aWMgdm9pZCBjb252ZXJ0 VmFsdWUoSlNDOjpFeGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUsIHVuc2lnbmVkIGxvbmcgbG9uZyYg cmVzdWx0KTsKICAgICBzdGF0aWMgdm9pZCBjb252ZXJ0VmFsdWUoSlNDOjpFeGVjU3RhdGUqLCBK U0M6OkpTVmFsdWUsIGRvdWJsZSYgcmVzdWx0KTsKKyAgICBzdGF0aWMgdm9pZCBjb252ZXJ0VmFs dWUoSlNDOjpFeGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUsIFN0cmluZyYgcmVzdWx0KTsKKyAgICBz dGF0aWMgdm9pZCBjb252ZXJ0VmFsdWUoSlNDOjpFeGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUsIFNj cmlwdFZhbHVlJiByZXN1bHQpOworICAgIHN0YXRpYyB2b2lkIGNvbnZlcnRWYWx1ZShKU0M6OkV4 ZWNTdGF0ZSosIEpTQzo6SlNWYWx1ZSwgUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4mIHJl c3VsdCk7CisgICAgc3RhdGljIHZvaWQgY29udmVydFZhbHVlKEpTQzo6RXhlY1N0YXRlKiwgSlND OjpKU1ZhbHVlLCBSZWZQdHI8RE9NV2luZG93PiYgcmVzdWx0KTsKKyAgICBzdGF0aWMgdm9pZCBj b252ZXJ0VmFsdWUoSlNDOjpFeGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUsIFJlZlB0cjxFdmVudFRh cmdldD4mIHJlc3VsdCk7CisgICAgc3RhdGljIHZvaWQgY29udmVydFZhbHVlKEpTQzo6RXhlY1N0 YXRlKiwgSlNDOjpKU1ZhbHVlLCBSZWZQdHI8Tm9kZT4mIHJlc3VsdCk7CiAKICAgICBKU0M6OkV4 ZWNTdGF0ZSogbV9leGVjOwogICAgIEpTQzo6SlNPYmplY3QqIG1faW5pdGlhbGl6ZXJPYmplY3Q7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50Q29uc3RydWN0b3JzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50Q29uc3Ry dWN0b3JzLmNwcAkocmV2aXNpb24gOTQxMTkpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0V2ZW50Q29uc3RydWN0b3JzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksNyBA QAogI2luY2x1ZGUgIkV2ZW50LmgiCiAjaW5jbHVkZSAiSlNEaWN0aW9uYXJ5LmgiCiAjaW5jbHVk ZSAiSlNFdmVudC5oIgorI2luY2x1ZGUgPHJ1bnRpbWUvRXJyb3IuaD4KIAogdXNpbmcgbmFtZXNw YWNlIEpTQzsKIAo=