67243 2011-08-30 16:00:42 -0700 add a test for border/padding/margin on the flexbox container 2011-08-30 17:28:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan tony webkit.review.bot oldest_to_newest 459288 0 ojan 2011-08-30 16:00:42 -0700 add a test for border/padding/margin on the flexbox container 459289 1 105714 ojan 2011-08-30 16:01:08 -0700 Created attachment 105714 Patch 459299 2 105714 tony 2011-08-30 16:16:03 -0700 Comment on attachment 105714 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105714&action=review I like more tests. > LayoutTests/css3/flexbox/001.html:146 > + <div data-expected-width="700" style="display: -webkit-flexbox; padding-left: 10px; padding-right: 20px; border-left: 30px solid; border-right: 40px solid; margin-left: 50px; margin-right:60px;" class="horizontal-box "> Can we drop the display: property? 459352 3 105714 webkit.review.bot 2011-08-30 17:28:52 -0700 Comment on attachment 105714 Patch Clearing flags on attachment: 105714 Committed r94137: <http://trac.webkit.org/changeset/94137> 459353 4 webkit.review.bot 2011-08-30 17:28:56 -0700 All reviewed patches have been landed. Closing bug. 105714 2011-08-30 16:01:08 -0700 2011-08-30 17:28:52 -0700 Patch bug-67243-20110830160107.patch text/plain 4657 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTQxMTcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiMTdhOTNkN2IyZWExYjU1YTg1ODQ5 NDA1ODA0OGRmYWZkZjI4YmU3Li40YTUxZTllMDUwYmNjMTI4YWUyNDFjZDYyNzU5ZDhlNWRkODA1 ZjM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMzAgIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KKworICAgICAgICBhZGQgYSB0ZXN0IGZvciBib3JkZXIvcGFkZGluZy9t YXJnaW4gb24gdGhlIGZsZXhib3ggY29udGFpbmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzI0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogY3NzMy9mbGV4Ym94LzAwMS1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogY3NzMy9mbGV4Ym94LzAwMS5odG1sOgorICAgICAgICAqIGNzczMvZmxleGJveC9y ZXNvdXJjZXMvZmxleGJveC5qczoKKwogMjAxMS0wOC0zMCAgVGltIEhvcnRvbiAgPHRpbW90aHlf aG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBnZXRCQm94KCkgb24gYSBTVkdQYXRoRWxlbWVu dCB3aXRoIGN1cnZlcyBpbmNvcnJlY3RseSBpbmNsdWRlcyBjb250cm9sIHBvaW50cwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94LzAwMS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9jc3MzL2ZsZXhib3gvMDAxLWV4cGVjdGVkLnR4dAppbmRleCBlMThhZGQxZTkzYTcwMTJm NTJiNTg1MWQ0ZTQ5NzhlOTAxMzRlNzc5Li5kODk1YWU4M2JhZTNmMTJjOTVjOTdhZmQ0MGFhMTRl MGM3NTk1NDk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvMDAxLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvMDAxLWV4cGVjdGVkLnR4dApA QCAtMTUsNCArMTUsNSBAQCBQQVNTCiBQQVNTCiBQQVNTCiBQQVNTCitQQVNTCiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2NzczMvZmxleGJveC8wMDEuaHRtbCBiL0xheW91dFRlc3RzL2NzczMv ZmxleGJveC8wMDEuaHRtbAppbmRleCA5OTU5MzQ2YmY5ZGQxNGIyMmNiNDc0NjVjM2MxYzc1YmQy ZWNiNGViLi4zOTZhY2NlNzUyYTE3OGEyODU1N2QxMWExOGJkYzI4MTkyM2I2ZGE3IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvMDAxLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv Y3NzMy9mbGV4Ym94LzAwMS5odG1sCkBAIC0xNDEsNSArMTQxLDE0IEBAIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCiAgIDxkaXYgZGF0YS1leHBlY3RlZC13aWR0aD0iMjAwIiBzdHls ZT0id2lkdGg6IC13ZWJraXQtZmxleCgxKSI+PC9kaXY+CiA8L2Rpdj4KIAorPCEtLSBUZXN0IGJv cmRlci9wYWRkaW5nL21hcmdpbiBvbiB0aGUgZmxleGJveCBpdHNlbGYuIC0tPgorPGRpdiBzdHls ZT0iYm9yZGVyOiAxMHB4IHNvbGlkOyBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7Ij4KKyAgICA8ZGl2 IGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjcwMCIgc3R5bGU9ImRpc3BsYXk6IC13ZWJraXQtZmxleGJv eDsgcGFkZGluZy1sZWZ0OiAxMHB4OyBwYWRkaW5nLXJpZ2h0OiAyMHB4OyBib3JkZXItbGVmdDog MzBweCBzb2xpZDsgYm9yZGVyLXJpZ2h0OiA0MHB4IHNvbGlkOyBtYXJnaW4tbGVmdDogNTBweDsg bWFyZ2luLXJpZ2h0OjYwcHg7IiBjbGFzcz0iaG9yaXpvbnRhbC1ib3ggIj4KKyAgICAgIDxkaXYg ZGF0YS1vZmZzZXQteD0iMTAwIiBkYXRhLWV4cGVjdGVkLXdpZHRoPSIyMDAiIHN0eWxlPSJ3aWR0 aDogLXdlYmtpdC1mbGV4KDEpIj48L2Rpdj4KKyAgICAgIDxkaXYgZGF0YS1vZmZzZXQteD0iMzAw IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSIyMDAiIHN0eWxlPSJ3aWR0aDogLXdlYmtpdC1mbGV4KDEp Ij48L2Rpdj4KKyAgICAgIDxkaXYgZGF0YS1vZmZzZXQteD0iNTAwIiBkYXRhLWV4cGVjdGVkLXdp ZHRoPSIyMDAiIHN0eWxlPSJ3aWR0aDogLXdlYmtpdC1mbGV4KDEpIj48L2Rpdj4KKyAgICA8L2Rp dj4KKzwvZGl2PgorCiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9j c3MzL2ZsZXhib3gvcmVzb3VyY2VzL2ZsZXhib3guanMgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhi b3gvcmVzb3VyY2VzL2ZsZXhib3guanMKaW5kZXggMzAyYWJiMjZkYmVkYmQ4NzNkN2RjMzY4MzYw NTg4ODhjMmQ0MGJlYy4uMmI5MTlmMWZiNjVlMTM2NzZkYmJjMTVlZDk3MzJkYTc3ZjUwZDY0YyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L3Jlc291cmNlcy9mbGV4Ym94Lmpz CisrKyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9yZXNvdXJjZXMvZmxleGJveC5qcwpAQCAt NiwzMSArNiwzNSBAQCBmdW5jdGlvbiBpbnNlcnRBZnRlcihub2RlVG9BZGQsIHJlZmVyZW5jZU5v ZGUpCiAgICAgICAgIHJlZmVyZW5jZU5vZGUucGFyZW50Tm9kZS5hcHBlbmRDaGlsZChub2RlVG9B ZGQpOwogfQogCitmdW5jdGlvbiBjaGVja0V4cGVjdGVkVmFsdWVzKG5vZGUsIGZhaWx1cmVzKQor eworICAgIHZhciBleHBlY3RlZFdpZHRoID0gbm9kZS5nZXRBdHRyaWJ1dGUgJiYgbm9kZS5nZXRB dHRyaWJ1dGUoImRhdGEtZXhwZWN0ZWQtd2lkdGgiKTsKKyAgICBpZiAobm9kZS5vZmZzZXRXaWR0 aCAmJiBleHBlY3RlZFdpZHRoKSB7CisgICAgICAgIGlmIChub2RlLm9mZnNldFdpZHRoICE9IHBh cnNlSW50KGV4cGVjdGVkV2lkdGgpKQorICAgICAgICAgICAgZmFpbHVyZXMucHVzaCgiRXhwZWN0 ZWQgIiArIGV4cGVjdGVkV2lkdGggKyAiIGZvciB3aWR0aCwgYnV0IGdvdCAiICsgbm9kZS5vZmZz ZXRXaWR0aCArICIuICIpOworICAgIH0KKworICAgIHZhciBleHBlY3RlZE9mZnNldCA9IG5vZGUu Z2V0QXR0cmlidXRlICYmIG5vZGUuZ2V0QXR0cmlidXRlKCJkYXRhLW9mZnNldC14Iik7CisgICAg aWYgKG5vZGUub2Zmc2V0TGVmdCAmJiBleHBlY3RlZE9mZnNldCkgeworICAgICAgICBpZiAobm9k ZS5vZmZzZXRMZWZ0ICE9IHBhcnNlSW50KGV4cGVjdGVkT2Zmc2V0KSkKKyAgICAgICAgICAgIGZh aWx1cmVzLnB1c2goIkV4cGVjdGVkICIgKyBleHBlY3RlZE9mZnNldCArICIgZm9yIG9mZnNldExl ZnQsIGJ1dCBnb3QgIiArIG5vZGUub2Zmc2V0TGVmdCArICIuICIpOworICAgIH0KK30KKwogZnVu Y3Rpb24gY2hlY2tIb3Jpem9udGFsQm94ZW4oKQogewogICAgIHZhciBmbGV4Ym94ZW4gPSBkb2N1 bWVudC5nZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCJob3Jpem9udGFsLWJveCIpOwogICAgIEFycmF5 LnByb3RvdHlwZS5mb3JFYWNoLmNhbGwoZmxleGJveGVuLCBmdW5jdGlvbihmbGV4Ym94KSB7Ci0g ICAgICB2YXIgZmFpbHVyZXMgPSAiIjsKKyAgICAgIHZhciBmYWlsdXJlcyA9IFtdOworICAgICAg Y2hlY2tFeHBlY3RlZFZhbHVlcyhmbGV4Ym94LCBmYWlsdXJlcyk7CisKICAgICAgIHZhciBjaGls ZCA9IGZsZXhib3guZmlyc3RDaGlsZDsKICAgICAgIHdoaWxlIChjaGlsZCkgewotICAgICAgICAg IHZhciBleHBlY3RlZFdpZHRoID0gY2hpbGQuZ2V0QXR0cmlidXRlICYmIGNoaWxkLmdldEF0dHJp YnV0ZSgiZGF0YS1leHBlY3RlZC13aWR0aCIpOwotICAgICAgICAgIGlmIChjaGlsZC5vZmZzZXRX aWR0aCAmJiBleHBlY3RlZFdpZHRoKSB7Ci0gICAgICAgICAgICAgIGlmIChjaGlsZC5vZmZzZXRX aWR0aCAhPSBwYXJzZUludChleHBlY3RlZFdpZHRoKSkgewotICAgICAgICAgICAgICAgICAgZmFp bHVyZXMgKz0gIkV4cGVjdGVkICIgKyBleHBlY3RlZFdpZHRoICsgIiBmb3Igd2lkdGgsIGJ1dCBn b3QgIiArIGNoaWxkLm9mZnNldFdpZHRoICsgIi4gIjsKLSAgICAgICAgICAgICAgfQotICAgICAg ICAgIH0KLQotICAgICAgICAgIHZhciBleHBlY3RlZE9mZnNldCA9IGNoaWxkLmdldEF0dHJpYnV0 ZSAmJiBjaGlsZC5nZXRBdHRyaWJ1dGUoImRhdGEtb2Zmc2V0LXgiKTsKLSAgICAgICAgICBpZiAo Y2hpbGQub2Zmc2V0TGVmdCAmJiBleHBlY3RlZE9mZnNldCkgewotICAgICAgICAgICAgICBpZiAo Y2hpbGQub2Zmc2V0TGVmdCAhPSBwYXJzZUludChleHBlY3RlZE9mZnNldCkpIHsKLSAgICAgICAg ICAgICAgICAgIGZhaWx1cmVzICs9ICJFeHBlY3RlZCAiICsgZXhwZWN0ZWRPZmZzZXQgKyAiIGZv ciBvZmZzZXRMZWZ0LCBidXQgZ290ICIgKyBjaGlsZC5vZmZzZXRMZWZ0ICsgIi4gIjsKLSAgICAg ICAgICAgICAgfQotICAgICAgICAgIH0KLQorICAgICAgICAgIGNoZWNrRXhwZWN0ZWRWYWx1ZXMo Y2hpbGQsIGZhaWx1cmVzKTsKICAgICAgICAgICBjaGlsZCA9IGNoaWxkLm5leHRTaWJsaW5nOwog ICAgICAgfQogCiAgICAgICBpbnNlcnRBZnRlcihkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJwIiks IGZsZXhib3gpOwotICAgICAgaW5zZXJ0QWZ0ZXIoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZmFp bHVyZXMgPyBmYWlsdXJlcyA6ICJQQVNTIiksIGZsZXhib3gpOworICAgICAgaW5zZXJ0QWZ0ZXIo ZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZmFpbHVyZXMubGVuZ3RoID8gZmFpbHVyZXMuam9pbign PGJyPicpIDogIlBBU1MiKSwgZmxleGJveCk7CiAgICAgfSk7CiB9Cg==