67234 2011-08-30 14:40:22 -0700 REGRESSION(r93902): Can't open external links on gmail 2011-09-01 06:43:44 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 rniwa alice.barraclough alice.barraclough andersca ap aroben sam verseau_o4 oldest_to_newest 459218 0 rniwa 2011-08-30 14:40:22 -0700 Reproduction steps: 1. Go to gmail.com 2. Open some message that contains an external hyperlink 3. Open it while pressing the command key Expected result: The destination is opened in new tab Actual result: I get an alert with message "Grrr! A popup blocker may be preventing the application from opening the page. If you have a popup blocker, try disabling it to open the window." 459222 1 rniwa 2011-08-30 14:43:04 -0700 Oops, this bug doesn't reproduce on released version of Safari 5.1. Only on ToT. 459308 2 rniwa 2011-08-30 16:25:33 -0700 r92990: good r93707: good r93849: good r93903: bad r93948: bad 459709 3 ap 2011-08-31 10:31:44 -0700 Further bisected to r93900-r93903, meaning that it's <http://trac.webkit.org/changeset/93902> (bug 66823). 459711 4 ap 2011-08-31 10:34:50 -0700 My steps to reproduce: 1. Open a webkit-changes list message in GMail. 2. Click or Cmd-click on revision number. Expected results: changeset opens in a new window or tab. Actual results: a "Grrr!" alert. 459713 5 ap 2011-08-31 10:35:06 -0700 <rdar://problem/10053636> 459715 6 rniwa 2011-08-31 10:37:00 -0700 This might be also related to nightly not auto-installing new binaries. 459757 7 alice.barraclough 2011-08-31 11:19:59 -0700 looking now. 459832 8 alice.barraclough 2011-08-31 12:42:41 -0700 the window isn't created because sendSync returns false. Looking further, sendSync does send the message okay, but it's having trouble decoding the reply. CoreIPC::ArgumentDecoder::markInvalid() at /Volumes/Data/Source/OpenSource/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:48 CoreIPC::ArgumentDecoder::alignBufferPosition(unsigned int, unsigned long) () CoreIPC::ArgumentDecoder::decodeUInt64 at /Volumes/Data/Source/OpenSource/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.cpp:156 CoreIPC::ArgumentDecoder::decode<unsigned long long> at /Volumes/Data/Source/OpenSource/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:136 CoreIPC::Arguments1<unsigned long long&>::decode at /Volumes/Data/Source/OpenSource/Source/WebKit2/Platform/CoreIPC/Arguments.h:77 CoreIPC::Arguments2<unsigned long long&, WebKit::WebPageCreationParameters&>::decode at /Volumes/Data/Source/OpenSource/Source/WebKit2/Platform/CoreIPC/Arguments.h:115 CoreIPC::ArgumentCoder<CoreIPC::Arguments2<unsigned long long&, WebKit::WebPageCreationParameters&> >::decode at /Volumes/Data/Source/OpenSource/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44 CoreIPC::ArgumentDecoder::decode<CoreIPC::Arguments2<unsigned long long&, WebKit::WebPageCreationParameters&> > at /Volumes/Data/Source/OpenSource/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:89 CoreIPC::Connection::sendSync<Messages::WebPageProxy::CreateNewPage> at /Volumes/Data/Source/OpenSource/Source/WebKit2/Platform/CoreIPC/Connection.h:386 WebKit::WebChromeClient::createWindow at /Volumes/Data/Source/OpenSource/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:167 459931 9 105828 andersca 2011-08-31 14:34:54 -0700 Created attachment 105828 Patch 459939 10 105828 ap 2011-08-31 14:41:33 -0700 Comment on attachment 105828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105828&action=review This bug couldn't happen on Windows, could it? > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:521 > + // FIXME: Move this to ArgumentCodersCFMac.mm and change this file back to be C++ Is there a reason why this cannot be done right away? Leaving ArgumentCodersCF.cpp in Objective C++ mode seems unfortunate. > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:525 > + result = reinterpret_cast<CFURLRef>([NSURL URLWithString:@""]); Would be nice to avoid leaving an autoreleased object behind - NSURL has initWithString:. 460031 11 andersca 2011-08-31 16:14:48 -0700 (In reply to comment #10) > (From update of attachment 105828 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=105828&action=review > > This bug couldn't happen on Windows, could it? > Not sure... > > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:521 > > + // FIXME: Move this to ArgumentCodersCFMac.mm and change this file back to be C++ > > Is there a reason why this cannot be done right away? Leaving ArgumentCodersCF.cpp in Objective C++ mode seems unfortunate. I wanted to get this fix landed as soon as possible. > > > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:525 > > + result = reinterpret_cast<CFURLRef>([NSURL URLWithString:@""]); > > Would be nice to avoid leaving an autoreleased object behind - NSURL has initWithString:. I couldn't find an elegant way to do that given that we want to call adoptNS on a RetainPtr<CFURLRef>. 460032 12 andersca 2011-08-31 16:15:23 -0700 Committed r94246: <http://trac.webkit.org/changeset/94246> 460240 13 ap 2011-08-31 23:00:10 -0700 *** Bug 67333 has been marked as a duplicate of this bug. *** 460414 14 aroben 2011-09-01 06:43:44 -0700 Is it possible to write a test for this? 105828 2011-08-31 14:34:54 -0700 2011-08-31 14:41:33 -0700 Patch bug-67234-20110831143453.patch text/plain 3774 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MjM0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMzEgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHI5Mzkw Mik6IENhbid0IG9wZW4gZXh0ZXJuYWwgbGlua3Mgb24gZ21haWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3MjM0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8xMDA1MzYzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNoYXJlZC9jZi9Bcmd1bWVudENvZGVyc0NGLmNwcDoKKyAgICAgICAgKENvcmVJ UEM6OmRlY29kZSk6CisgICAgICAgIElmIHdlIGVuY291bnRlciBhbiBlbXB0eSBVUkwgc3RyaW5n LCBjcmVhdGUgYW4gZW1wdHkgdXJsIGJ5IHVzaW5nIE5TVVJMLCBqdXN0CisgICAgICAgIGxpa2Ug d2UgZG8gaW4gV2ViQ29yZSB3aGVuIGNvbnZlcnRpbmcgYW4gZW1wdHkgS1VSTCB0byBhbiBOU1VS TC4KKworICAgICAgICAqIFdlYktpdDIueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoKKyAgICAg ICAgQ29tcGlsZSBBcmd1bWVudENvZGVyc0NGLmNwcCBhcyBPYmplY3RpdmUtQysrIGZvciBub3cu CisKIDIwMTEtMDgtMzAgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzE1MApJbmRleDogU291 cmNlL1dlYktpdDIvU2hhcmVkL2NmL0FyZ3VtZW50Q29kZXJzQ0YuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9jZi9Bcmd1bWVudENvZGVyc0NGLmNwcAkocmV2aXNpb24g OTQyMjYpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2YvQXJndW1lbnRDb2RlcnNDRi5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDEwIEBACiAjaW5jbHVkZSAiRGF0YVJlZmVyZW5j ZS5oIgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAorI2lmIFBMQVRGT1JNKE1BQykKKyNpbXBv cnQgPEZvdW5kYXRpb24vRm91bmRhdGlvbi5oPgorI2VuZGlmCisKIG5hbWVzcGFjZSBDb3JlSVBD IHsKIAogQ0ZUeXBlUmVmIHRva2VuTnVsbFR5cGVSZWYoKQpAQCAtNTEzLDYgKzUxNywxNiBAQCBi b29sIGRlY29kZShBcmd1bWVudERlY29kZXIqIGRlY29kZXIsIFJlCiAgICAgaWYgKCFkZWNvZGUo ZGVjb2Rlciwgc3RyaW5nKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisjaWYgUExBVEZPUk0o TUFDKQorICAgIC8vIEZJWE1FOiBNb3ZlIHRoaXMgdG8gQXJndW1lbnRDb2RlcnNDRk1hYy5tbSBh bmQgY2hhbmdlIHRoaXMgZmlsZSBiYWNrIHRvIGJlIEMrKworICAgIC8vIGluc3RlYWQgb2YgT2Jq ZWN0aXZlLUMrKy4KKyAgICBpZiAoIUNGU3RyaW5nR2V0TGVuZ3RoKHN0cmluZy5nZXQoKSkpIHsK KyAgICAgICAgLy8gQ0ZVUkwgY2FuJ3QgaG9sZCBhbiBlbXB0eSBVUkwsIHVubGlrZSBOU1VSTC4K KyAgICAgICAgcmVzdWx0ID0gcmVpbnRlcnByZXRfY2FzdDxDRlVSTFJlZj4oW05TVVJMIFVSTFdp dGhTdHJpbmc6QCIiXSk7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyNlbmRpZgorICAg ICAgICAgICAgICAgICAgICAKICAgICBDRlVSTFJlZiB1cmwgPSBDRlVSTENyZWF0ZVdpdGhTdHJp bmcoMCwgc3RyaW5nLmdldCgpLCBiYXNlVVJMLmdldCgpKTsKICAgICBpZiAoIXVybCkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViS2l0Mi54Y29kZXByb2ov cHJvamVjdC5wYnhwcm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYktpdDIueGNv ZGVwcm9qL3Byb2plY3QucGJ4cHJvagkocmV2aXNpb24gOTQyMjYpCisrKyBTb3VyY2UvV2ViS2l0 Mi9XZWJLaXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTEx MDksNyArMTEwOSw3IEBACiAJCTFBQUYwNjEyMTJCMDExMzEwMDhFNDlFMiAvKiBQREZWaWV3Q29u dHJvbGxlci5oICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7 IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBQREZWaWV3Q29udHJv bGxlci5oOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQkxQUFGMDYxMzEyQjAxMTMxMDA4 RTQ5RTIgLyogUERGVmlld0NvbnRyb2xsZXIubW0gKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5j ZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5v YmpjcHA7IHBhdGggPSBQREZWaWV3Q29udHJvbGxlci5tbTsgc291cmNlVHJlZSA9ICI8Z3JvdXA+ IjsgfTsKIAkJMUFBRjBDNDgxMkIxNjMzNDAwOEU0OUUyIC8qIEFyZ3VtZW50Q29kZXJzQ0YuaCAq LyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25G aWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gQXJndW1lbnRDb2RlcnNDRi5oOyBzb3Vy Y2VUcmVlID0gIjxncm91cD4iOyB9OwotCQkxQUFGMEM0OTEyQjE2MzM0MDA4RTQ5RTIgLyogQXJn dW1lbnRDb2RlcnNDRi5jcHAgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29k aW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5jcHA7IHBhdGggPSBB cmd1bWVudENvZGVyc0NGLmNwcDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKKwkJMUFBRjBD NDkxMkIxNjMzNDAwOEU0OUUyIC8qIEFyZ3VtZW50Q29kZXJzQ0YuY3BwICovID0ge2lzYSA9IFBC WEZpbGVSZWZlcmVuY2U7IGV4cGxpY2l0RmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5vYmpjcHA7 IGZpbGVFbmNvZGluZyA9IDQ7IHBhdGggPSBBcmd1bWVudENvZGVyc0NGLmNwcDsgc291cmNlVHJl ZSA9ICI8Z3JvdXA+IjsgfTsKIAkJMUFCN0Q0QzgxMjg4QUFBNzAwQ0ZEMDhDIC8qIERvd25sb2Fk UHJveHkuaCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBs YXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gRG93bmxvYWRQcm94eS5o OyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQkxQUI3RDRDOTEyODhBQUE3MDBDRkQwOEMg LyogRG93bmxvYWRQcm94eS5jcHAgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVu Y29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5jcHA7IHBhdGgg PSBEb3dubG9hZFByb3h5LmNwcDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJMUFCN0Q1 RTkxMjg4QjhDMDAwQ0ZEMDhDIC8qIERvd25sb2FkUHJveHkubWVzc2FnZXMuaW4gKi8gPSB7aXNh ID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUg PSB0ZXh0OyBwYXRoID0gRG93bmxvYWRQcm94eS5tZXNzYWdlcy5pbjsgc291cmNlVHJlZSA9ICI8 Z3JvdXA+IjsgfTsK