67233 2011-08-30 14:37:28 -0700 Setting value on a select element to a non existing option value should clear selection 2012-01-12 14:57:51 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED http://www.whatwg.org/specs/web-apps/current-work/#dom-select-value InRadar P2 Normal --- 1 arv jonlee ap ian jonlee rafaelw webkit-bug-importer webkit.review.bot oldest_to_newest 459212 0 arv 2011-08-30 14:37:28 -0700 Given: <select> <option value="a">A</option> <option value="b">B</option> </select> <script> var sel = document.querySelector('select'); sel.value = 'x' assert(sel.selectedIndex === -1) </script> The spec says: "On setting, the value attribute must set the selectedness of all the option elements in the list of options to false, and then the first option element in the list of options, in tree order, whose value is equal to the given new value, if any, must have its selectedness set to true." This means that we should unselect all and then select first option that matches the value. 460057 1 ap 2011-08-31 16:32:29 -0700 This fails in WebKit and in Firefox, so sounds like a mistake in the spec. 460112 2 rafaelw 2011-08-31 17:32:27 -0700 IE9 follows the spec. FWIW (probably not much), the spec seems like the right (desirable) behavior to me. 460118 3 webkit-bug-importer 2011-08-31 17:38:11 -0700 <rdar://problem/10057159> 460249 4 ap 2011-08-31 23:16:15 -0700 WebKit/Gecko behavior doesn't seem unnatural or confusing to me. Why base the spec on a minority engine behavior? Is there known Web compatibility impact? 528987 5 120984 jonlee 2012-01-03 13:14:01 -0800 Created attachment 120984 Patch 528991 6 webkit.review.bot 2012-01-03 13:17:01 -0800 Attachment 120984 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource Index mismatch: 3a7674dadd24ecd6a1b023eba203ecf2ed62fc59 != edb861612940a3244431d239dacdbc36317b627c rereading e1e2538cff7d320c2b7cc22c0b75c9369ce9cdb2 A LayoutTests/svg/custom/webkit-transform-crash.html A LayoutTests/svg/custom/webkit-transform-crash-expected.txt M LayoutTests/ChangeLog M Source/WebCore/ChangeLog M Source/WebCore/svg/SVGStyledTransformableElement.cpp 103950 = 8282a1d85ad097ce4064a5896912bdb211b115e6 already exists! Why are we refetching it? at /usr/lib/git-core/git-svn line 5210 Died at Tools/Scripts/update-webkit line 158. If any of these errors are false positives, please file a bug against check-webkit-style. 529003 7 ap 2012-01-03 13:33:28 -0800 I'm still not sure why we want to change this. 533248 8 120984 darin 2012-01-10 11:44:24 -0800 Comment on attachment 120984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120984&action=review > Source/WebCore/html/HTMLSelectElement.cpp:257 > + // Setting the value clears the selectedness of all options. > + setSelectedIndex(-1); Does calling setSelectedIndex twice have any additional effect? For example, do we get additional change events? To word this another way, why isn’t this call in the return statement and then again at the end of the function? 533351 9 120984 jonlee 2012-01-10 13:52:12 -0800 Comment on attachment 120984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120984&action=review >> Source/WebCore/html/HTMLSelectElement.cpp:257 >> + setSelectedIndex(-1); > > Does calling setSelectedIndex twice have any additional effect? For example, do we get additional change events? > > To word this another way, why isn’t this call in the return statement and then again at the end of the function? In this case there should be no extra change event calls, but I like your approach, since that guarantees just one setSelectedIndex() call for any given case. I will do this instead. 535189 10 jonlee 2012-01-12 14:42:52 -0800 Without this patch there'd be inconsistency between value and selectedIndex, since both are supposed to clear the selectedness of all options first. Also, when <select> has no selection, value returns ''. I'd expect that setting value to '' would remove any existing selection. Moreover, Alexey and I did some additional testing and found that IE7 and IE8 seem to also follow the spec. So, any sites in which WK behavior would has different from IE's probably will have implemented a separate code path, further preventing any potential breaks in existing web sites. It seems low risk to make this behavior follow the spec, so I will land the patch with Darin's suggested changes. 535200 11 jonlee 2012-01-12 14:57:51 -0800 Committed r104864: http://trac.webkit.org/changeset/104864 120984 2012-01-03 13:14:01 -0800 2012-01-10 13:52:12 -0800 Patch bug-67233-20120103131512.patch text/plain 5774 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQzMWU3NTU1M2EwNWQx YjBlNzAxY2Q4ODY4MDRmOTBmNDc1ZDg0Zi4uZWY0N2IyZmQyZDVhZWUwNjI5N2ZiNzJkYzkyYTFk NWY0YjM3ODQwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTAzICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBTZXR0aW5nIHZhbHVlIG9uIGEgc2Vs ZWN0IGVsZW1lbnQgdG8gYSBub24gZXhpc3Rpbmcgb3B0aW9uIHZhbHVlIHNob3VsZCBjbGVhciBz ZWxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY3MjMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDA1NzE1OT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL3NlbGVj dC9zZXR0aW5nLXRvLWludmFsaWQtdmFsdWUuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MU2Vs ZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6c2V0 VmFsdWUpOiBDbGVhciB0aGUgc2VsZWN0aW9uIGZpcnN0LCBhbmQgZml4CisgICAgICAgIHNlbnRl bmNlIHN0eWxlIG9mIGEgbGF0ZXIgY29tbWVudC4KKwogMjAxMi0wMS0wMyAgS2VudGFybyBIYXJh ICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUmViYXNlbGlu ZWQgcnVuLWJpbmRpbmdzLXRlc3RzIHJlc3VsdHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNl bGVjdEVsZW1lbnQuY3BwCmluZGV4IDk1NDIxZjMwYjhhNmExN2I0N2NmYmRhZjc1MDE2NTQ3ZDAz NWVkM2UuLjc2MjIyMDIxNzU5NTIwZDdlNjZkYjJmNmI3NmI5ZjFkYWE0NDEwOGYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCkBAIC0yNTMsMTAgKzI1MywxMyBA QCBTdHJpbmcgSFRNTFNlbGVjdEVsZW1lbnQ6OnZhbHVlKCkgY29uc3QKIAogdm9pZCBIVE1MU2Vs ZWN0RWxlbWVudDo6c2V0VmFsdWUoY29uc3QgU3RyaW5nICZ2YWx1ZSkKIHsKKyAgICAvLyBTZXR0 aW5nIHRoZSB2YWx1ZSBjbGVhcnMgdGhlIHNlbGVjdGVkbmVzcyBvZiBhbGwgb3B0aW9ucy4KKyAg ICBzZXRTZWxlY3RlZEluZGV4KC0xKTsKKwogICAgIGlmICh2YWx1ZS5pc051bGwoKSkKICAgICAg ICAgcmV0dXJuOwotICAgIC8vIGZpbmQgdGhlIG9wdGlvbiB3aXRoIHZhbHVlKCkgbWF0Y2hpbmcg dGhlIGdpdmVuIHBhcmFtZXRlcgotICAgIC8vIGFuZCBtYWtlIGl0IHRoZSBjdXJyZW50IHNlbGVj dGlvbi4KKworICAgIC8vIEZpbmQgdGhlIG9wdGlvbiB3aXRoIHZhbHVlKCkgbWF0Y2hpbmcgdGhl IGdpdmVuIHBhcmFtZXRlciBhbmQgbWFrZSBpdCB0aGUgY3VycmVudCBzZWxlY3Rpb24uCiAgICAg Y29uc3QgVmVjdG9yPEhUTUxFbGVtZW50Kj4mIGl0ZW1zID0gbGlzdEl0ZW1zKCk7CiAgICAgdW5z aWduZWQgb3B0aW9uSW5kZXggPSAwOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBpdGVt cy5zaXplKCk7IGkrKykgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUzMjNjNmE0ZjZjOTk4YTgzYzZmYjllZDE2MWQ1MzVk MGU1OTdkN2EuLjY2NzI0ZTg5MzZlNTQxY2NlYzE5ODE3MGEyZTY2YzRlOTNiYWI3MTQgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNyBAQAorMjAxMi0wMS0wMyAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+ CisKKyAgICAgICAgU2V0dGluZyB2YWx1ZSBvbiBhIHNlbGVjdCBlbGVtZW50IHRvIGEgbm9uIGV4 aXN0aW5nIG9wdGlvbiB2YWx1ZSBzaG91bGQgY2xlYXIgc2VsZWN0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzIzMworICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTAwNTcxNTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTmV3IHRlc3RzIGNoZWNrIHRvIHNlZSB0aGF0IHNldHRpbmcgdGhlIHZhbHVl IG9mIGEgc2VsZWN0IGVsZW1lbnQgY2xlYXJzIHRoZQorICAgICAgICBzZWxlY3Rpb24sIGV2ZW4g aWYgdGhlIHZhbHVlIGlzIGludmFsaWQsIG51bGwsIG9yIHVuZGVmaW5lZC4KKworICAgICAgICAq IGZhc3QvZm9ybXMvc2VsZWN0L3NldHRpbmctdG8taW52YWxpZC12YWx1ZS1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvc2VsZWN0L3NldHRpbmctdG8taW52YWxpZC12 YWx1ZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wMS0wMyAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5t ZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBnZXRDb21wdXRlZFN0eWxlIGZvciBvdXRs aW5lIGlzIG5vdCBpbXBsZW1lbnRlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvc2VsZWN0L3NldHRpbmctdG8taW52YWxpZC12YWx1ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC9zZXR0aW5nLXRvLWludmFsaWQtdmFsdWUtZXhwZWN0ZWQu dHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLmQ3ODljODZhYzFmZjE1YTg5MWY4OWQzYTc0NTk3MDM1ZWJlMjYwNjYK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC9zZXR0aW5n LXRvLWludmFsaWQtdmFsdWUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjQgQEAKKyAKK2h0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzIzMyAtIFNldHRpbmcgdGhlIHZh bHVlIG9mIGEgc2VsZWN0IHRvIGFuIGludmFsaWQgdmFsdWUgc2hvdWxkIHVuc2V0IHRoZSBzZWxl Y3Rpb24uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCistLSBNZW51IGxpc3Qgc2Vs ZWN0OgorU2V0dGluZyB0aGUgdmFsdWUgdG8gYW4gaW52YWxpZCB2YWx1ZToKK1BBU1Mgc2VsLnNl bGVjdGVkSW5kZXggaXMgLTEKK1NldHRpbmcgdGhlIHZhbHVlIHRvIG51bGw6CitQQVNTIHNlbC5z ZWxlY3RlZEluZGV4IGlzIC0xCitTZXR0aW5nIHRoZSB2YWx1ZSB0byB1bmRlZmluZWQ6CitQQVNT IHNlbC5zZWxlY3RlZEluZGV4IGlzIC0xCistLSBMaXN0IGJveCBzZWxlY3Q6CitTZXR0aW5nIHRo ZSB2YWx1ZSB0byBhbiBpbnZhbGlkIHZhbHVlOgorUEFTUyBzZWwuc2VsZWN0ZWRJbmRleCBpcyAt MQorU2V0dGluZyB0aGUgdmFsdWUgdG8gbnVsbDoKK1BBU1Mgc2VsLnNlbGVjdGVkSW5kZXggaXMg LTEKK1NldHRpbmcgdGhlIHZhbHVlIHRvIHVuZGVmaW5lZDoKK1BBU1Mgc2VsLnNlbGVjdGVkSW5k ZXggaXMgLTEKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVU RQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC9zZXR0aW5nLXRv LWludmFsaWQtdmFsdWUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VsZWN0L3NldHRp bmctdG8taW52YWxpZC12YWx1ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE2OWYwYmI3OTUzN2MwNGFiM2E3 ZTdlNGZiZjM4MTZmNjMyYTFlOGYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL3NlbGVjdC9zZXR0aW5nLXRvLWludmFsaWQtdmFsdWUuaHRtbApAQCAtMCwwICsxLDYy IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v Li4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgor PGJvZHk+Cis8c2VsZWN0IGlkPSJ0aGVTZWxlY3QiPgorICAgIDxvcHRpb24gdmFsdWU9ImEiPkE8 L29wdGlvbj4KKyAgICA8b3B0aW9uIHZhbHVlPSJiIj5CPC9vcHRpb24+Cis8L3NlbGVjdD4KKzxz ZWxlY3QgaWQ9InRoZU11bHRpcGxlU2VsZWN0IiBtdWx0aXBsZT4KKyAgICA8b3B0aW9uIHZhbHVl PSJhIj5BPC9vcHRpb24+CisgICAgPG9wdGlvbiB2YWx1ZT0iYiI+Qjwvb3B0aW9uPgorICAgIDxv cHRpb24gdmFsdWU9ImMiPkM8L29wdGlvbj4KKyAgICA8b3B0aW9uIHZhbHVlPSJkIj5EPC9vcHRp b24+Cis8L3NlbGVjdD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorZGVz Y3JpcHRpb24oImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzIzMyAt IFNldHRpbmcgdGhlIHZhbHVlIG9mIGEgc2VsZWN0IHRvIGFuIGludmFsaWQgdmFsdWUgc2hvdWxk IHVuc2V0IHRoZSBzZWxlY3Rpb24uIik7CisKK2Z1bmN0aW9uIHJlc2V0U2luZ2xlU2VsZWN0KCkg eworICAgIHNlbC52YWx1ZSA9ICdhJzsKKyAgICBzaG91bGRCZSgic2VsLnNlbGVjdGVkSW5kZXgi LCAiMCIsIHRydWUpOworfQorCitmdW5jdGlvbiByZXNldE11bHRpcGxlU2VsZWN0KCkgeworICAg IHNlbC5pdGVtKDEpLnNlbGVjdGVkID0gdHJ1ZTsKKyAgICBzZWwuaXRlbSgzKS5zZWxlY3RlZCA9 IHRydWU7Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3RzT25TZWxlY3QocmVzZXRTZWxlY3QpIHsKKyAg ICBkZWJ1ZygiU2V0dGluZyB0aGUgdmFsdWUgdG8gYW4gaW52YWxpZCB2YWx1ZToiKTsKKyAgICBy ZXNldFNlbGVjdChzZWwpOworICAgIHNlbC52YWx1ZSA9ICd4JzsKKyAgICBzaG91bGRCZSgic2Vs LnNlbGVjdGVkSW5kZXgiLCAiLTEiKTsKKworICAgIGRlYnVnKCJTZXR0aW5nIHRoZSB2YWx1ZSB0 byBudWxsOiIpOworICAgIHJlc2V0U2VsZWN0KHNlbCk7CisgICAgc2VsLnZhbHVlID0gbnVsbDsK KyAgICBzaG91bGRCZSgic2VsLnNlbGVjdGVkSW5kZXgiLCAiLTEiKTsKKworICAgIGRlYnVnKCJT ZXR0aW5nIHRoZSB2YWx1ZSB0byB1bmRlZmluZWQ6Iik7CisgICAgcmVzZXRTZWxlY3Qoc2VsKTsK KyAgICBzZWwudmFsdWUgPSB1bmRlZmluZWQ7CisgICAgc2hvdWxkQmUoInNlbC5zZWxlY3RlZElu ZGV4IiwgIi0xIik7Cit9CisKK2RlYnVnKCItLSBNZW51IGxpc3Qgc2VsZWN0OiIpOworc2VsID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRoZVNlbGVjdCIpOworcnVuVGVzdHNPblNlbGVjdChy ZXNldFNpbmdsZVNlbGVjdCk7CisKK2RlYnVnKCItLSBMaXN0IGJveCBzZWxlY3Q6Iik7CitzZWwg PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGhlTXVsdGlwbGVTZWxlY3QiKTsKK3J1blRlc3Rz T25TZWxlY3QocmVzZXRNdWx0aXBsZVNlbGVjdCk7CisKK3N1Y2Nlc3NmdWxseVBhcnNlZCA9IHRy dWU7Cis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGlu ZSBhdCBlbmQgb2YgZmlsZQo=