67227 2011-08-30 13:52:27 -0700 CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else 2011-10-26 00:41:12 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 aroben andersca andersca bdakin rniwa sullivan webkit-bug-importer oldest_to_newest 459165 0 aroben 2011-08-30 13:52:27 -0700 CG plug-ins are always given a context with a scale factor of 1 to draw into, even when the device scale factor is something else. This results in plug-ins looking blurry on higher scale factor displays. We should scale the context to match the device scale factor before handing it off to the plug-in for drawing. 459167 1 webkit-bug-importer 2011-08-30 13:53:02 -0700 <rdar://problem/10048319> 490506 2 112436 andersca 2011-10-25 17:56:17 -0700 Created attachment 112436 Patch 490507 3 andersca 2011-10-25 17:59:14 -0700 Committed r98416: <http://trac.webkit.org/changeset/98416> 490613 4 rniwa 2011-10-26 00:01:47 -0700 GTK build fixes attempted in http://trac.webkit.org/changeset/98435 and http://trac.webkit.org/changeset/98437. 490625 5 rniwa 2011-10-26 00:41:12 -0700 GTK build fixed in http://trac.webkit.org/changeset/98438. 112436 2011-10-25 17:56:17 -0700 2011-10-25 17:57:34 -0700 Patch bug-67227-20111025175620.patch text/plain 6351 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogOTg0MTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1YTNmMjRiOGQ5NDZlMjBl NDE5N2U3ZTkyYmUxYTRkYWNkYzg4Zjg0Li4yYTRlMDgzZWMwN2U0MDkxOTQ1NGM3ZjFkNjcwMjFm ZjgwZmUyZWIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcgQEAKIDIwMTEtMTAtMjUgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBDRyBwbHVnLWlucyBh cmUgYWx3YXlzIGdpdmVuIGEgY29udGV4dCB3aXRoIGEgc2NhbGUgZmFjdG9yIG9mIDEsIGV2ZW4g d2hlbiB0aGUgZGV2aWNlIHNjYWxlIGZhY3RvciBpcyBzb21ldGhpbmcgZWxzZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcyMjcKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzEwMDQ4MzE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Db250cm9sbGVyUHJveHk6OnBhaW50KToKKyAgICAg ICAgQXBwbHkgdGhlIHNjYWxlIGZhY3RvciB3aGVuIHBhaW50aW5nLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2lu UHJveHk6OnBhaW50KToKKyAgICAgICAgQXBwbHkgdGhlIHNjYWxlIGZhY3RvciB3aGVuIHBhaW50 aW5nLgorCisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb3h5OjpnZW9tZXRyeURpZENoYW5nZSk6 CisgICAgICAgIE1ha2Ugc3VyZSB0byBhcHBseSB0aGUgY29udGVudHMgc2NhbGUgZmFjdG9yIHRv IHRoZSBiYWNraW5nIHN0b3JlIHNpemUuCisKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJveHk6 OnVwZGF0ZSk6CisgICAgICAgIEFwcGx5IHRoZSBzY2FsZSBmYWN0b3IgKHdoZW4gcGFpbnRpbmcp LgorCisyMDExLTEwLTI1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisK ICAgICAgICAgUGx1Zy1pbnMgaGF2ZSBubyB3YXkgdG8gZmluZCBvdXQgd2hlbiB0aGUgZGV2aWNl IHNjYWxlIGZhY3RvciBjaGFuZ2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NzIyNgogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTAwNDgyNzY+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQ cm94eS5jcHAKaW5kZXggYzRhYTQxNTZiOGRlMDY2ODdkZWMyMWRjNjZjMWFjZGMwYzA1MjNkYy4u NWZhMTE3NDdmMGU3NWY5N2ExYzhkODVkY2FjM2FjY2FkNTEzMGQzMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmNwcApA QCAtMTYzLDYgKzE2MywxMCBAQCB2b2lkIFBsdWdpbkNvbnRyb2xsZXJQcm94eTo6cGFpbnQoKQog ICAgIC8vIENyZWF0ZSBhIGdyYXBoaWNzIGNvbnRleHQuCiAgICAgT3duUHRyPEdyYXBoaWNzQ29u dGV4dD4gZ3JhcGhpY3NDb250ZXh0ID0gbV9iYWNraW5nU3RvcmUtPmNyZWF0ZUdyYXBoaWNzQ29u dGV4dCgpOwogCisgICAgLy8gRklYTUU6IFdlIHNob3VsZCByZWFsbHkgY2FsbCBhcHBseURldmlj ZVNjYWxlRmFjdG9yIGluc3RlYWQgb2Ygc2NhbGUsIGJ1dCB0aGF0IGVuZHMgdXAgY2FsbGluZyBp bnRvIFdLU0kKKyAgICAvLyB3aGljaCB3ZSBjdXJyZW50bHkgZG9uJ3QgaGF2ZSBpbml0aWF0ZWQg aW4gdGhlIHBsdWctaW4gcHJvY2Vzcy4KKyAgICBncmFwaGljc0NvbnRleHQtPnNjYWxlKEZsb2F0 U2l6ZShtX2NvbnRlbnRzU2NhbGVGYWN0b3IsIG1fY29udGVudHNTY2FsZUZhY3RvcikpOworCiAg ICAgZ3JhcGhpY3NDb250ZXh0LT50cmFuc2xhdGUoLW1fZnJhbWVSZWN0LngoKSwgLW1fZnJhbWVS ZWN0LnkoKSk7CiAKICAgICBpZiAobV9wbHVnaW4tPmlzVHJhbnNwYXJlbnQoKSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm94eS5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuY3BwCmluZGV4IDI4 ZTY5MGVkNjM3NWY0N2ExOWM0MTAxMThkMDliZDRlY2M4NzY0YzAuLmQzODAxNGI4MTM5NTBmY2Ew ZTM2NzE1ZGE1NDJjZWNiOTdhNTBhODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5LmNwcApAQCAtMTM1LDE0ICsxMzUsMTcgQEAgdm9pZCBQ bHVnaW5Qcm94eTo6cGFpbnQoR3JhcGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGNvbnN0 IEludFJlY3QmIGRpcnR5UmUKICAgICBpZiAoIW5lZWRzQmFja2luZ1N0b3JlKCkgfHwgIW1fYmFj a2luZ1N0b3JlKQogICAgICAgICByZXR1cm47CiAKKyAgICBmbG9hdCBjb250ZW50c1NjYWxlRmFj dG9yID0gY29udHJvbGxlcigpLT5jb250ZW50c1NjYWxlRmFjdG9yKCk7CisKICAgICBpZiAoIW1f cGx1Z2luQmFja2luZ1N0b3JlQ29udGFpbnNWYWxpZERhdGEpIHsKICAgICAgICAgbV9jb25uZWN0 aW9uLT5jb25uZWN0aW9uKCktPnNlbmRTeW5jKE1lc3NhZ2VzOjpQbHVnaW5Db250cm9sbGVyUHJv eHk6OlBhaW50RW50aXJlUGx1Z2luKCksIE1lc3NhZ2VzOjpQbHVnaW5Db250cm9sbGVyUHJveHk6 OlBhaW50RW50aXJlUGx1Z2luOjpSZXBseSgpLCBtX3BsdWdpbkluc3RhbmNlSUQpOwogICAgIAog ICAgICAgICAvLyBCbGl0IHRoZSBwbHVnLWluIGJhY2tpbmcgc3RvcmUgaW50byBvdXIgb3duIGJh Y2tpbmcgc3RvcmUuCiAgICAgICAgIE93blB0cjxXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ+IGdy YXBoaWNzQ29udGV4dCA9IG1fYmFja2luZ1N0b3JlLT5jcmVhdGVHcmFwaGljc0NvbnRleHQoKTsK KyAgICAgICAgZ3JhcGhpY3NDb250ZXh0LT5hcHBseURldmljZVNjYWxlRmFjdG9yKGNvbnRlbnRz U2NhbGVGYWN0b3IpOwogICAgICAgICBncmFwaGljc0NvbnRleHQtPnNldENvbXBvc2l0ZU9wZXJh dGlvbihDb21wb3NpdGVDb3B5KTsKIAotICAgICAgICBtX3BsdWdpbkJhY2tpbmdTdG9yZS0+cGFp bnQoKmdyYXBoaWNzQ29udGV4dCwgSW50UG9pbnQoKSwgSW50UmVjdCgwLCAwLCBtX2ZyYW1lUmVj dC53aWR0aCgpLCBtX2ZyYW1lUmVjdC5oZWlnaHQoKSkpOworICAgICAgICBtX3BsdWdpbkJhY2tp bmdTdG9yZS0+cGFpbnQoKmdyYXBoaWNzQ29udGV4dCwgY29udGVudHNTY2FsZUZhY3RvciwgSW50 UG9pbnQoKSwgSW50UmVjdCgwLCAwLCBtX2ZyYW1lUmVjdC53aWR0aCgpLCBtX2ZyYW1lUmVjdC5o ZWlnaHQoKSkpOwogCiAgICAgICAgIG1fcGx1Z2luQmFja2luZ1N0b3JlQ29udGFpbnNWYWxpZERh dGEgPSB0cnVlOwogICAgIH0KQEAgLTE1MCw3ICsxNTMsNyBAQCB2b2lkIFBsdWdpblByb3h5Ojpw YWludChHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCwgY29uc3QgSW50UmVjdCYgZGly dHlSZQogICAgIEludFJlY3QgZGlydHlSZWN0SW5QbHVnaW5Db29yZGluYXRlcyA9IGRpcnR5UmVj dDsKICAgICBkaXJ0eVJlY3RJblBsdWdpbkNvb3JkaW5hdGVzLm1vdmUoLW1fZnJhbWVSZWN0Lngo KSwgLW1fZnJhbWVSZWN0LnkoKSk7CiAKLSAgICBtX2JhY2tpbmdTdG9yZS0+cGFpbnQoKmdyYXBo aWNzQ29udGV4dCwgZGlydHlSZWN0LmxvY2F0aW9uKCksIGRpcnR5UmVjdEluUGx1Z2luQ29vcmRp bmF0ZXMpOworICAgIG1fYmFja2luZ1N0b3JlLT5wYWludCgqZ3JhcGhpY3NDb250ZXh0LCBjb250 ZW50c1NjYWxlRmFjdG9yLCBkaXJ0eVJlY3QubG9jYXRpb24oKSwgZGlydHlSZWN0SW5QbHVnaW5D b29yZGluYXRlcyk7CiAKICAgICBpZiAobV93YWl0aW5nRm9yUGFpbnRJblJlc3BvbnNlVG9VcGRh dGUpIHsKICAgICAgICAgbV93YWl0aW5nRm9yUGFpbnRJblJlc3BvbnNlVG9VcGRhdGUgPSBmYWxz ZTsKQEAgLTE4OCwxMiArMTkxLDE1IEBAIHZvaWQgUGx1Z2luUHJveHk6Omdlb21ldHJ5RGlkQ2hh bmdlKCkKICAgICB9CiAKICAgICBib29sIGRpZFVwZGF0ZUJhY2tpbmdTdG9yZSA9IGZhbHNlOwor ICAgIEludFNpemUgYmFja2luZ1N0b3JlU2l6ZSA9IG1fZnJhbWVSZWN0LnNpemUoKTsKKyAgICBi YWNraW5nU3RvcmVTaXplLnNjYWxlKGNvbnRlbnRzU2NhbGVGYWN0b3IpOworCiAgICAgaWYgKCFt X2JhY2tpbmdTdG9yZSkgewotICAgICAgICBtX2JhY2tpbmdTdG9yZSA9IFNoYXJlYWJsZUJpdG1h cDo6Y3JlYXRlKG1fZnJhbWVSZWN0LnNpemUoKSwgU2hhcmVhYmxlQml0bWFwOjpTdXBwb3J0c0Fs cGhhKTsKKyAgICAgICAgbV9iYWNraW5nU3RvcmUgPSBTaGFyZWFibGVCaXRtYXA6OmNyZWF0ZShi YWNraW5nU3RvcmVTaXplLCBTaGFyZWFibGVCaXRtYXA6OlN1cHBvcnRzQWxwaGEpOwogICAgICAg ICBkaWRVcGRhdGVCYWNraW5nU3RvcmUgPSB0cnVlOwotICAgIH0gZWxzZSBpZiAobV9mcmFtZVJl Y3Quc2l6ZSgpICE9IG1fYmFja2luZ1N0b3JlLT5zaXplKCkpIHsKKyAgICB9IGVsc2UgaWYgKGJh Y2tpbmdTdG9yZVNpemUgIT0gbV9iYWNraW5nU3RvcmUtPnNpemUoKSkgewogICAgICAgICAvLyBU aGUgYmFja2luZyBzdG9yZSBhbHJlYWR5IGV4aXN0cywganVzdCByZXNpemUgaXQuCi0gICAgICAg IGlmICghbV9iYWNraW5nU3RvcmUtPnJlc2l6ZShtX2ZyYW1lUmVjdC5zaXplKCkpKQorICAgICAg ICBpZiAoIW1fYmFja2luZ1N0b3JlLT5yZXNpemUoYmFja2luZ1N0b3JlU2l6ZSkpCiAgICAgICAg ICAgICByZXR1cm47CiAKICAgICAgICAgZGlkVXBkYXRlQmFja2luZ1N0b3JlID0gdHJ1ZTsKQEAg LTIwMyw3ICsyMDksNyBAQCB2b2lkIFBsdWdpblByb3h5OjpnZW9tZXRyeURpZENoYW5nZSgpCiAK ICAgICBpZiAoZGlkVXBkYXRlQmFja2luZ1N0b3JlKSB7CiAgICAgICAgIC8vIENyZWF0ZSBhIG5l dyBwbHVnLWluIGJhY2tpbmcgc3RvcmUuCi0gICAgICAgIG1fcGx1Z2luQmFja2luZ1N0b3JlID0g U2hhcmVhYmxlQml0bWFwOjpjcmVhdGVTaGFyZWFibGUobV9mcmFtZVJlY3Quc2l6ZSgpLCBTaGFy ZWFibGVCaXRtYXA6OlN1cHBvcnRzQWxwaGEpOworICAgICAgICBtX3BsdWdpbkJhY2tpbmdTdG9y ZSA9IFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRlU2hhcmVhYmxlKGJhY2tpbmdTdG9yZVNpemUsIFNo YXJlYWJsZUJpdG1hcDo6U3VwcG9ydHNBbHBoYSk7CiAgICAgICAgIGlmICghbV9wbHVnaW5CYWNr aW5nU3RvcmUpCiAgICAgICAgICAgICByZXR1cm47CiAKQEAgLTUyNCwxMCArNTMwLDEzIEBAIHZv aWQgUGx1Z2luUHJveHk6OnVwZGF0ZShjb25zdCBJbnRSZWN0JiBwYWludGVkUmVjdCkKICAgICBw YWludGVkUmVjdFBsdWdpbkNvb3JkaW5hdGVzLm1vdmUoLW1fZnJhbWVSZWN0LngoKSwgLW1fZnJh bWVSZWN0LnkoKSk7CiAKICAgICBpZiAobV9iYWNraW5nU3RvcmUpIHsKKyAgICAgICAgZmxvYXQg Y29udGVudHNTY2FsZUZhY3RvciA9IGNvbnRyb2xsZXIoKS0+Y29udGVudHNTY2FsZUZhY3Rvcigp OworCiAgICAgICAgIC8vIEJsaXQgdGhlIHBsdWctaW4gYmFja2luZyBzdG9yZSBpbnRvIG91ciBv d24gYmFja2luZyBzdG9yZS4KICAgICAgICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dD4gZ3JhcGhp Y3NDb250ZXh0ID0gbV9iYWNraW5nU3RvcmUtPmNyZWF0ZUdyYXBoaWNzQ29udGV4dCgpOworICAg ICAgICBncmFwaGljc0NvbnRleHQtPmFwcGx5RGV2aWNlU2NhbGVGYWN0b3IoY29udGVudHNTY2Fs ZUZhY3Rvcik7CiAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+c2V0Q29tcG9zaXRlT3BlcmF0aW9u KENvbXBvc2l0ZUNvcHkpOwotICAgICAgICBtX3BsdWdpbkJhY2tpbmdTdG9yZS0+cGFpbnQoKmdy YXBoaWNzQ29udGV4dCwgcGFpbnRlZFJlY3RQbHVnaW5Db29yZGluYXRlcy5sb2NhdGlvbigpLCAK KyAgICAgICAgbV9wbHVnaW5CYWNraW5nU3RvcmUtPnBhaW50KCpncmFwaGljc0NvbnRleHQsIGNv bnRlbnRzU2NhbGVGYWN0b3IsIHBhaW50ZWRSZWN0UGx1Z2luQ29vcmRpbmF0ZXMubG9jYXRpb24o KSwgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWludGVkUmVjdFBsdWdp bkNvb3JkaW5hdGVzKTsKICAgICB9CiAK