67223 2011-08-30 12:57:38 -0700 shouldBeEqualToString should encode special characters 2011-08-31 18:21:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arv arv darin webkit.review.bot oldest_to_newest 459110 0 arv 2011-08-30 12:57:38 -0700 shouldBeEqualToString should encode special characters 459114 1 105676 arv 2011-08-30 13:00:51 -0700 Created attachment 105676 Patch 459965 2 ap 2011-08-31 15:03:02 -0700 This patch has no rationale. Why? 459968 3 ap 2011-08-31 15:03:28 -0700 *** Bug 67222 has been marked as a duplicate of this bug. *** 459980 4 arv 2011-08-31 15:21:03 -0700 I was looking at the code and found the NOOP replace; b.replace(/"/g, "\"") does nothing. My initial plan was to just to remove the call to replace but after seeing that other places does encode the string correctly I was convinced that the encoding is needed. 460054 5 105676 darin 2011-08-31 16:31:28 -0700 Comment on attachment 105676 Patch Does this change affect any test results? 460070 6 arv 2011-08-31 16:47:11 -0700 (In reply to comment #5) > (From update of attachment 105676 [details]) > Does this change affect any test results? No, no tests depends on these at the moment. I ran into the issue because I wanted to use shouldBeEqualToString in some new tests. 460134 7 105676 webkit.review.bot 2011-08-31 18:21:29 -0700 Comment on attachment 105676 Patch Clearing flags on attachment: 105676 Committed r94260: <http://trac.webkit.org/changeset/94260> 460135 8 webkit.review.bot 2011-08-31 18:21:33 -0700 All reviewed patches have been landed. Closing bug. 105676 2011-08-30 13:00:51 -0700 2011-08-31 18:21:29 -0700 Patch bug-67223-20110830130050.patch text/plain 2183 arv U3VidmVyc2lvbiBSZXZpc2lvbjogOTQwOTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1NDQzNjQ5ZTUzNTE4Yjg2ZTNjMjY3 NDEzNTU0MWE4Mzc0NDBkZTE3Li5lNWMzOTc1ZTFiYWZiZDA3MjhjZjJiNDUxMzQ4ZWU4ZjZmYjg3 YmQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMzAgIEVyaWsgQXJ2aWRzc29uICA8 YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcgc2hvdWxk IGVuY29kZSBzcGVjaWFsIGNoYXJhY3RlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY3MjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmYXN0L2pzL3Jlc291cmNlcy9zdGFuZGFsb25lLXByZS5qczoK KyAgICAgICAgKHNob3VsZEJlRXF1YWxUb1N0cmluZyk6IEVuY29kZSBcLCAiLCBcbiwgXHIKKyAg ICAgICAgKiBodHRwL3Rlc3RzL2Nvb2tpZXMvcmVzb3VyY2VzL2Nvb2tpZXMtdGVzdC1wcmUuanM6 CisgICAgICAgIChzaG91bGRCZUVxdWFsVG9TdHJpbmcpOiBFbmNvZGUgXCwgIiwgXG4sIFxyCisK IDIwMTEtMDgtMzAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xMDAwMjE0MD4gOUEzMDk6IFRleHQgZ2V0cyBjbGlwcGVkIGluIGJvb2sg YmVjYXVzZSBvZiBvdmVyZmxvdzphdXRvCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2pz L3Jlc291cmNlcy9zdGFuZGFsb25lLXByZS5qcyBiL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3Vy Y2VzL3N0YW5kYWxvbmUtcHJlLmpzCmluZGV4IGI4MGMzY2I5YTE4YmMzZDkxN2RiNjJjMjQ2MDg5 MzA1MjVlNjNiOTguLjFhYTRhZDQzYmYzY2QyNDZjNDE3ZTJhNjcyNDQyZGNkOTA4YTQ4YjUgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL3N0YW5kYWxvbmUtcHJlLmpz CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL3N0YW5kYWxvbmUtcHJlLmpzCkBA IC05NCw3ICs5NCw3IEBAIGZ1bmN0aW9uIHNob3VsZEJlTnVsbChfYSkgeyBzaG91bGRCZShfYSwg Im51bGwiKTsgfQogCiBmdW5jdGlvbiBzaG91bGRCZUVxdWFsVG9TdHJpbmcoYSwgYikKIHsKLSAg dmFyIHVuZXZhbGVkU3RyaW5nID0gJyInICsgYi5yZXBsYWNlKC8iL2csICJcIiIpICsgJyInOwor ICB2YXIgdW5ldmFsZWRTdHJpbmcgPSAnIicgKyBiLnJlcGxhY2UoL1xcL2csICJcXFxcIikucmVw bGFjZSgvIi9nLCAiXCIiKS5yZXBsYWNlKC9cbi9nLCAiXFxuIikucmVwbGFjZSgvXHIvZywgIlxc ciIpICsgJyInOwogICBzaG91bGRCZShhLCB1bmV2YWxlZFN0cmluZyk7CiB9CiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvY29va2llcy10ZXN0 LXByZS5qcyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvY29va2ll cy10ZXN0LXByZS5qcwppbmRleCA4MGIwZmYxZDBmM2E4ODI1MTYxMzNhODFiNzQwNWY5NzM5ZWI2 NWZiLi40MjVkYzhkOGJjY2RiM2QzNzA5NzA3NjQwYjMxNjA3YTg3NDU0N2IzIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2Nvb2tpZXMvcmVzb3VyY2VzL2Nvb2tpZXMtdGVzdC1w cmUuanMKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb29raWVzL3Jlc291cmNlcy9jb29r aWVzLXRlc3QtcHJlLmpzCkBAIC0xMDIsNyArMTAyLDcgQEAgZnVuY3Rpb24gc2hvdWxkQmVOdWxs KF9hKSB7IHNob3VsZEJlKF9hLCAibnVsbCIpOyB9CiAKIGZ1bmN0aW9uIHNob3VsZEJlRXF1YWxU b1N0cmluZyhhLCBiKQogewotICAgIHZhciB1bmV2YWxlZFN0cmluZyA9ICciJyArIGIucmVwbGFj ZSgvIi9nLCAiXCIiKSArICciJzsKKyAgICB2YXIgdW5ldmFsZWRTdHJpbmcgPSAnIicgKyBiLnJl cGxhY2UoL1xcL2csICJcXFxcIikucmVwbGFjZSgvIi9nLCAiXCIiKS5yZXBsYWNlKC9cbi9nLCAi XFxuIikucmVwbGFjZSgvXHIvZywgIlxcciIpICsgJyInOwogICAgIHNob3VsZEJlKGEsIHVuZXZh bGVkU3RyaW5nKTsKIH0KIAo=