67198 2011-08-30 05:44:43 -0700 Web Inspector: console view does a style recalculation per each addMessage call 2011-08-31 05:12:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 458861 0 loislo 2011-08-30 05:44:43 -0700 it is bad from the performance point of view. 458862 1 105620 loislo 2011-08-30 05:48:05 -0700 Created attachment 105620 [patch] initial version 458863 2 105620 vsevik 2011-08-30 05:55:31 -0700 Comment on attachment 105620 [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=105620&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:286 > + if (!this._isScrollIntoViewScheduled() && ((msg instanceof WebInspector.ConsoleCommandResult) || this.messagesElement.isScrolledToBottom())) this._scrollIntoViewTimer is already checked in _scheduleScrollIntoView(), isn't it? 458866 3 105620 loislo 2011-08-30 06:00:25 -0700 Comment on attachment 105620 [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=105620&action=review >> Source/WebCore/inspector/front-end/ConsoleView.js:286 >> + if (!this._isScrollIntoViewScheduled() && ((msg instanceof WebInspector.ConsoleCommandResult) || this.messagesElement.isScrolledToBottom())) > > this._scrollIntoViewTimer is already checked in _scheduleScrollIntoView(), isn't it? the problem is in this.messagesElement.isScrolledToBottom call. This call is forcing style recalculation. In the old code we do style recalculation even if we already scheduled the scroll action. 458874 4 105620 yurys 2011-08-30 06:44:21 -0700 Comment on attachment 105620 [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=105620&action=review >>> Source/WebCore/inspector/front-end/ConsoleView.js:286 >>> + if (!this._isScrollIntoViewScheduled() && ((msg instanceof WebInspector.ConsoleCommandResult) || this.messagesElement.isScrolledToBottom())) >> >> this._scrollIntoViewTimer is already checked in _scheduleScrollIntoView(), isn't it? > > the problem is in this.messagesElement.isScrolledToBottom call. This call is forcing style recalculation. > In the old code we do style recalculation even if we already scheduled the scroll action. isScrolledToBottom() should be called *before* the new message has been added. 458914 5 105632 loislo 2011-08-30 08:20:00 -0700 Created attachment 105632 [patch] second iteration 459563 6 105632 loislo 2011-08-31 05:12:51 -0700 Comment on attachment 105632 [patch] second iteration Clearing flags on attachment: 105632 Committed r94178: <http://trac.webkit.org/changeset/94178> 459564 7 loislo 2011-08-31 05:12:58 -0700 All reviewed patches have been landed. Closing bug. 105620 2011-08-30 05:48:05 -0700 2011-08-30 08:20:00 -0700 [patch] initial version patch text/plain 2230 loislo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YTYyN2E2Li4xNGIyOTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDgtMzAgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNvbnNvbGUgdmlldyBkb2VzIGEgc3R5bGUgcmVjYWxj dWxhdGlvbiBwZXIgZWFjaCBhZGRNZXNzYWdlIGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzE5OAorCisgICAgICAgIEl0IGlzIGJhZCBmcm9t IHRoZSBwZXJmb3JtYW5jZSBwb2ludCBvZiB2aWV3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmll dy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUuX2lzU2Ny b2xsSW50b1ZpZXdTY2hlZHVsZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3 LnByb3RvdHlwZS5fYXBwZW5kQ29uc29sZU1lc3NhZ2UpOgorCiAyMDExLTA4LTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIGxhc3RDaGFuZ2VXYXNVc2VyRWRp dCBjb250aW51ZXMgdG8gcmV0dXJuIHRydWUgd2hlbiBpbm5lclRleHQgb3IgdGV4dENvbnRlbnQg aXMgbW9kaWZpZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nv bnNvbGVWaWV3LmpzCmluZGV4IDMyN2NhNjcuLjQxOGIxMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwpAQCAtMjQxLDYgKzI0MSwx MSBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlz LnRvZ2dsZUNvbnNvbGVCdXR0b24udGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNob3cg Y29uc29sZS4iKTsKICAgICB9LAogCisgICAgX2lzU2Nyb2xsSW50b1ZpZXdTY2hlZHVsZWQ6IGZ1 bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHJldHVybiAhIXRoaXMuX3Njcm9sbEludG9WaWV3VGlt ZXI7CisgICAgfSwKKwogICAgIF9zY2hlZHVsZVNjcm9sbEludG9WaWV3OiBmdW5jdGlvbigpCiAg ICAgewogICAgICAgICBpZiAodGhpcy5fc2Nyb2xsSW50b1ZpZXdUaW1lcikKQEAgLTI2MSw4ICsy NjYsNiBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogCiAgICAgX2Fw cGVuZENvbnNvbGVNZXNzYWdlOiBmdW5jdGlvbihtc2cpCiAgICAgewotICAgICAgICB2YXIgc2hv dWxkU2Nyb2xsVG9MYXN0TWVzc2FnZSA9IHRoaXMubWVzc2FnZXNFbGVtZW50LmlzU2Nyb2xsZWRU b0JvdHRvbSgpOwotCiAgICAgICAgIHRoaXMubWVzc2FnZXMucHVzaChtc2cpOwogCiAgICAgICAg IGlmIChtc2cudHlwZSA9PT0gV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlLk1lc3NhZ2VUeXBl LkVuZEdyb3VwKSB7CkBAIC0yODAsNyArMjgzLDcgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogCiAgICAgICAgIC8vIEFsd2F5cyBzY3JvbGwgd2hl biBjb21tYW5kIHJlc3VsdCBhcnJpdmVzLgotICAgICAgICBpZiAoc2hvdWxkU2Nyb2xsVG9MYXN0 TWVzc2FnZSB8fCAobXNnIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkNvbnNvbGVDb21tYW5kUmVz dWx0KSkKKyAgICAgICAgaWYgKCF0aGlzLl9pc1Njcm9sbEludG9WaWV3U2NoZWR1bGVkKCkgJiYg KChtc2cgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuQ29uc29sZUNvbW1hbmRSZXN1bHQpIHx8IHRo aXMubWVzc2FnZXNFbGVtZW50LmlzU2Nyb2xsZWRUb0JvdHRvbSgpKSkKICAgICAgICAgICAgIHRo aXMuX3NjaGVkdWxlU2Nyb2xsSW50b1ZpZXcoKTsKIAogICAgICAgICB0aGlzLmRpc3BhdGNoRXZl bnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcuRXZlbnRzLkVudHJ5QWRkZWQs IG1zZyk7Cg== 105632 2011-08-30 08:20:00 -0700 2011-08-31 05:12:51 -0700 [patch] second iteration patch text/plain 2412 loislo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YTYyN2E2Li4xNGIyOTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDgtMzAgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNvbnNvbGUgdmlldyBkb2VzIGEgc3R5bGUgcmVjYWxj dWxhdGlvbiBwZXIgZWFjaCBhZGRNZXNzYWdlIGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzE5OAorCisgICAgICAgIEl0IGlzIGJhZCBmcm9t IHRoZSBwZXJmb3JtYW5jZSBwb2ludCBvZiB2aWV3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmll dy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUuX2lzU2Ny b2xsSW50b1ZpZXdTY2hlZHVsZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3 LnByb3RvdHlwZS5fYXBwZW5kQ29uc29sZU1lc3NhZ2UpOgorCiAyMDExLTA4LTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIGxhc3RDaGFuZ2VXYXNVc2VyRWRp dCBjb250aW51ZXMgdG8gcmV0dXJuIHRydWUgd2hlbiBpbm5lclRleHQgb3IgdGV4dENvbnRlbnQg aXMgbW9kaWZpZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nv bnNvbGVWaWV3LmpzCmluZGV4IDMyN2NhNjcuLmQzODRkZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwpAQCAtMjQxLDYgKzI0MSwx MSBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlz LnRvZ2dsZUNvbnNvbGVCdXR0b24udGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNob3cg Y29uc29sZS4iKTsKICAgICB9LAogCisgICAgX2lzU2Nyb2xsSW50b1ZpZXdTY2hlZHVsZWQ6IGZ1 bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHJldHVybiAhIXRoaXMuX3Njcm9sbEludG9WaWV3VGlt ZXI7CisgICAgfSwKKwogICAgIF9zY2hlZHVsZVNjcm9sbEludG9WaWV3OiBmdW5jdGlvbigpCiAg ICAgewogICAgICAgICBpZiAodGhpcy5fc2Nyb2xsSW50b1ZpZXdUaW1lcikKQEAgLTI2MSw3ICsy NjYsMTAgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgIF9h cHBlbmRDb25zb2xlTWVzc2FnZTogZnVuY3Rpb24obXNnKQogICAgIHsKLSAgICAgICAgdmFyIHNo b3VsZFNjcm9sbFRvTGFzdE1lc3NhZ2UgPSB0aGlzLm1lc3NhZ2VzRWxlbWVudC5pc1Njcm9sbGVk VG9Cb3R0b20oKTsKKyAgICAgICAgLy8gdGhpcy5tZXNzYWdlc0VsZW1lbnQuaXNTY3JvbGxlZFRv Qm90dG9tKCkgaXMgZm9yY2luZyBzdHlsZSByZWNhbGN1bGF0aW9uLgorICAgICAgICAvLyBXZSBq dXN0IHNraXAgaXQgaWYgdGhlIHNjcm9sbCBhY3Rpb24gaGFzIGJlZW4gc2NoZWR1bGVkLgorICAg ICAgICBpZiAoIXRoaXMuX2lzU2Nyb2xsSW50b1ZpZXdTY2hlZHVsZWQoKSAmJiAoKG1zZyBpbnN0 YW5jZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlQ29tbWFuZFJlc3VsdCkgfHwgdGhpcy5tZXNzYWdl c0VsZW1lbnQuaXNTY3JvbGxlZFRvQm90dG9tKCkpKQorICAgICAgICAgICAgdGhpcy5fc2NoZWR1 bGVTY3JvbGxJbnRvVmlldygpOwogCiAgICAgICAgIHRoaXMubWVzc2FnZXMucHVzaChtc2cpOwog CkBAIC0yNzksMTAgKzI4Nyw2IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICB0aGlzLmN1cnJlbnRHcm91cC5hZGRNZXNzYWdlKG1zZyk7CiAgICAg ICAgIH0KIAotICAgICAgICAvLyBBbHdheXMgc2Nyb2xsIHdoZW4gY29tbWFuZCByZXN1bHQgYXJy aXZlcy4KLSAgICAgICAgaWYgKHNob3VsZFNjcm9sbFRvTGFzdE1lc3NhZ2UgfHwgKG1zZyBpbnN0 YW5jZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlQ29tbWFuZFJlc3VsdCkpCi0gICAgICAgICAgICB0 aGlzLl9zY2hlZHVsZVNjcm9sbEludG9WaWV3KCk7Ci0KICAgICAgICAgdGhpcy5kaXNwYXRjaEV2 ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LkV2ZW50cy5FbnRyeUFkZGVk LCBtc2cpOwogICAgIH0sCiAK