67194 2011-08-30 03:44:45 -0700 [stylechecker] complains about NULL usage in some gst_structure_ calls 2011-09-06 09:27:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 458824 0 pnormand 2011-08-30 03:44:45 -0700 Very similar to Bug 39740. The involved calls are: gst_structure_set gst_structure_get gst_structure_remove_fields gst_structure_new gst_structure_id_new gst_structure_id_set gst_structure_id_get 458825 1 105609 pnormand 2011-08-30 03:48:15 -0700 Created attachment 105609 proposed patch 459475 2 pnormand 2011-08-30 23:55:02 -0700 Committed r94153: <http://trac.webkit.org/changeset/94153> 462589 3 105609 mrobinson 2011-09-06 09:27:52 -0700 Comment on attachment 105609 proposed patch Clearing flag on committed patch. 105609 2011-08-30 03:48:15 -0700 2011-09-06 09:27:52 -0700 proposed patch proposed-patch.patch text/plain 3537 pnormand RnJvbSAyOWZkYzI2OTdiZDI5OWZlYWYzMjU3YTVjYWIwODgyNDdkMTc5ODdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDMwIEF1ZyAyMDExIDEyOjQ3OjQ3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKwogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkgICAgICAgfCAgIDEyICsrKysrKysrKysrCiAuLi4vd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5ICAgICAgICB8ICAgMjEgKysrKysr KysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgMCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggNzljZDYyNi4uNjMyODA4OSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTA4LTMwICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbc3R5bGVjaGVja2VyXSBj b21wbGFpbnMgYWJvdXQgTlVMTCB1c2FnZSBpbiBzb21lIGdzdF9zdHJ1Y3R1cmVfIGNhbGxzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzE5NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHdhcm4g YWJvdXQgTlVMTCBpbiBzb21lIGdzdF9zdHJ1Y3R1cmVfIGNhbGxzLiAwIGNhbid0IGJlCisgICAg ICAgIHVzZWQgZm9yIHRoZXNlLCBhIHByb3BlciBzZW50aW5lbCBpcyByZXF1aXJlZC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorCiAyMDEx LTA4LTI5ICBUb20gWmFrcmFqc2VrICA8dG9tekBjb2RlYXVyb3JhLm9yZz4KIAogICAgICAgICBz aGVyaWZmYm90ICJ1c2FnZSIgaGVscCBzdGF0ZW1lbnRzIGFyZSB3cm9uZwpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCAyNWRiZjVhLi5mNTk1MTE0 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAt MjM4MSw2ICsyMzgxLDE4IEBAIGRlZiBjaGVja19mb3JfbnVsbChjbGVhbl9saW5lcywgbGluZV9u dW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKToKICAgICBpZiBzZWFyY2gocidcYmdzdF9cdytfbWFu eVxiJywgbGluZSk6CiAgICAgICAgIHJldHVybgogCisgICAgIyBEb24ndCB3YXJuIGFib3V0IE5V TEwgdXNhZ2UgaW4gc29tZSBnc3Rfc3RydWN0dXJlXyooKS4gU2VlIEJ1ZyA2NzE5NC4KKyAgICBp ZiBzZWFyY2gocidcYmdzdF9zdHJ1Y3R1cmVfW3NnXWV0XGInLCBsaW5lKToKKyAgICAgICAgcmV0 dXJuCisgICAgaWYgc2VhcmNoKHInXGJnc3Rfc3RydWN0dXJlX3JlbW92ZV9maWVsZHNcYicsIGxp bmUpOgorICAgICAgICByZXR1cm4KKyAgICBpZiBzZWFyY2gocidcYmdzdF9zdHJ1Y3R1cmVfbmV3 XGInLCBsaW5lKToKKyAgICAgICAgcmV0dXJuCisgICAgaWYgc2VhcmNoKHInXGJnc3Rfc3RydWN0 dXJlX2lkX25ld1xiJywgbGluZSk6CisgICAgICAgIHJldHVybgorICAgIGlmIHNlYXJjaChyJ1xi Z3N0X3N0cnVjdHVyZV9pZF9bc2ddZXRcYicsIGxpbmUpOgorICAgICAgICByZXR1cm4KKwogICAg ICMgRG9uJ3Qgd2FybiBhYm91dCBOVUxMIHVzYWdlIGluIGdfc3Rye2pvaW4sY29uY2F0fSgpLiBT ZWUgQnVnIDM0ODM0CiAgICAgaWYgc2VhcmNoKHInXGJnX3N0cihqb2lufGNvbmNhdClcYicsIGxp bmUpOgogICAgICAgICByZXR1cm4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggM2E4ZDI0ZS4uM2Q5OGJmZSAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRl c3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkKQEAgLTQwOTIsNiArNDA5MiwyNyBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3Bw U3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAnZ3N0X2VsZW1lbnRfdW5saW5rX21hbnkoZm9v LCBiYXIsIGJvbywgTlVMTCk7JywKICAgICAgICAgICAgICcnKQogICAgICAgICBzZWxmLmFzc2Vy dF9saW50KAorICAgICAgICAgICAgJ2dzdF9zdHJ1Y3R1cmVfZ2V0KGZvbywgInZhbHVlIiwgR19U WVBFX0lOVCwgJnZhbHVlLCBOVUxMKTsnLAorICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYu YXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnZ3N0X3N0cnVjdHVyZV9zZXQoZm9vLCAidmFsdWUi LCBHX1RZUEVfSU5ULCB2YWx1ZSwgTlVMTCk7JywKKyAgICAgICAgICAgICcnKQorICAgICAgICBz ZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2dzdF9zdHJ1Y3R1cmVfcmVtb3ZlX2ZpZWxk cyhmb28sICJ2YWx1ZSIsICJiYXIiLCBOVUxMKTsnLAorICAgICAgICAgICAgJycpCisgICAgICAg IHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnZ3N0X3N0cnVjdHVyZV9uZXcoImZvbyIs ICJ2YWx1ZSIsIEdfVFlQRV9JTlQsIHZhbHVlLCBOVUxMKTsnLAorICAgICAgICAgICAgJycpCisg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnZ3N0X3N0cnVjdHVyZV9pZF9u ZXcoRk9PLCBWQUxVRSwgR19UWVBFX0lOVCwgdmFsdWUsIE5VTEwpOycsCisgICAgICAgICAgICAn JykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICdnc3Rfc3RydWN0dXJl X2lkX3NldChGT08sIFZBTFVFLCBHX1RZUEVfSU5ULCB2YWx1ZSwgTlVMTCk7JywKKyAgICAgICAg ICAgICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2dzdF9zdHJ1 Y3R1cmVfaWRfZ2V0KEZPTywgVkFMVUUsIEdfVFlQRV9JTlQsICZ2YWx1ZSwgTlVMTCk7JywKKyAg ICAgICAgICAgICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KAogICAgICAgICAgICAgJ2dj aGFyKiByZXN1bHQgPSBnX3N0cmNvbmNhdCgicGFydDEiLCAicGFydDIiLCAicGFydDMiLCBOVUxM KTsnLAogICAgICAgICAgICAgJycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCi0tIAoxLjcu NS40