67193 2011-08-30 03:39:44 -0700 Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading 2011-08-30 08:27:55 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 458823 0 vsevik 2011-08-30 03:39:44 -0700 Chromium crash report: http://code.google.com/p/chromium/issues/detail?id=93469 458835 1 105613 vsevik 2011-08-30 04:29:37 -0700 Created attachment 105613 Patch 458873 2 105613 yurys 2011-08-30 06:41:53 -0700 Comment on attachment 105613 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105613&action=review > Source/WebCore/inspector/InspectorResourceAgent.cpp:294 > + if (!loader || !loader->frame()) All this check should be in if (m_resourcesData->resourceType(requestId) == InspectorPageAgent::DocumentResource), shouldn't them? 458887 3 105624 vsevik 2011-08-30 07:26:30 -0700 Created attachment 105624 Patch 458917 4 vsevik 2011-08-30 08:27:55 -0700 Committed r94078: <http://trac.webkit.org/changeset/94078> 105613 2011-08-30 04:29:37 -0700 2011-08-30 07:26:22 -0700 Patch bug-67193-20110830152934.patch text/plain 2082 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTQwNjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZTM5ZmViNzg4N2VhZDJi NjAwZjIzMjI0NWVkNWJiYjNkZGZiMjQ4Li5iYWVmMTM0NGViMzc1YjUyNjA4YTBkMzM1OTZkNzY4 YWI0NDFiYmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMzAgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogSW5zcGVjdGVkIHBhZ2Ugc29tZXRpbWVzIGNyYXNoZXMgaW4gSW5zcGVjdG9yUmVzb3VyY2VB Z2VudDo6ZGlkRmFpbExvYWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY3MTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JSZXNvdXJjZUFnZW50OjpkaWRGYWlsTG9hZGluZyk6CisK IDIwMTEtMDgtMjkgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV0dXJuIHZhbHVlIG9mIHdpbmRvdy5vbmVycm9yIGhhcyBpbnZlcnRlZCBzZW1hbnRp Y3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJj ZUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZUFn ZW50LmNwcAppbmRleCBjNzZkMDU0YTRkYjcwODczZDUyOTk5OTUxMjUxOTI3YjU0NmQ5MWVhLi4w MTZlZGFhMDM3ZGIyY2QzODdmODQ5NjRmOWE0NzNmMzA1ZWI2YTk4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwCkBAIC0yOTEs OSArMjkxLDE2IEBAIHZvaWQgSW5zcGVjdG9yUmVzb3VyY2VBZ2VudDo6ZGlkRmluaXNoTG9hZGlu Zyh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIERvY3VtZW50CiAKIHZvaWQgSW5zcGVjdG9yUmVz b3VyY2VBZ2VudDo6ZGlkRmFpbExvYWRpbmcodW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBEb2N1 bWVudExvYWRlciogbG9hZGVyLCBjb25zdCBSZXNvdXJjZUVycm9yJiBlcnJvcikKIHsKKyAgICBp ZiAoIWxvYWRlciB8fCAhbG9hZGVyLT5mcmFtZSgpKQorICAgICAgICByZXR1cm47CisgICAgRnJh bWUqIGZyYW1lID0gbG9hZGVyLT5mcmFtZSgpOworICAgIGlmICghZnJhbWUtPmxvYWRlcigpLT5k b2N1bWVudExvYWRlcigpIHx8ICFmcmFtZS0+ZG9jdW1lbnQoKSkKKyAgICAgICAgcmV0dXJuOwor CiAgICAgU3RyaW5nIHJlcXVlc3RJZCA9IElkZW50aWZpZXJzRmFjdG9yeTo6cmVxdWVzdElkKGlk ZW50aWZpZXIpOworCiAgICAgaWYgKG1fcmVzb3VyY2VzRGF0YS0+cmVzb3VyY2VUeXBlKHJlcXVl c3RJZCkgPT0gSW5zcGVjdG9yUGFnZUFnZW50OjpEb2N1bWVudFJlc291cmNlKQotICAgICAgICBt X3Jlc291cmNlc0RhdGEtPmFkZFJlc291cmNlU2hhcmVkQnVmZmVyKHJlcXVlc3RJZCwgbG9hZGVy LT5mcmFtZUxvYWRlcigpLT5kb2N1bWVudExvYWRlcigpLT5tYWluUmVzb3VyY2VEYXRhKCksIGxv YWRlci0+ZnJhbWUoKS0+ZG9jdW1lbnQoKS0+aW5wdXRFbmNvZGluZygpKTsKKyAgICAgICAgbV9y ZXNvdXJjZXNEYXRhLT5hZGRSZXNvdXJjZVNoYXJlZEJ1ZmZlcihyZXF1ZXN0SWQsIGZyYW1lLT5s b2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKS0+bWFpblJlc291cmNlRGF0YSgpLCBmcmFtZS0+ZG9j dW1lbnQoKS0+aW5wdXRFbmNvZGluZygpKTsKIAogICAgIG1fZnJvbnRlbmQtPmxvYWRpbmdGYWls ZWQocmVxdWVzdElkLCBjdXJyZW50VGltZSgpLCBlcnJvci5sb2NhbGl6ZWREZXNjcmlwdGlvbigp LCBlcnJvci5pc0NhbmNlbGxhdGlvbigpKTsKIH0K 105624 2011-08-30 07:26:30 -0700 2011-08-30 08:18:48 -0700 Patch bug-67193-20110830182628.patch text/plain 2156 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTQwNzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0NjdiNTBmZGUzMTBhZWQw M2Q0MTRlZDFjNGRlNDVmNTg1Y2YyZWM4Li43NDkwZGM4M2VmYjQzOTcxZjJjMmVhOWRmZWQzOTA2 ODVhN2Q2ZmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMzAgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogSW5zcGVjdGVkIHBhZ2Ugc29tZXRpbWVzIGNyYXNoZXMgaW4gSW5zcGVjdG9yUmVzb3VyY2VB Z2VudDo6ZGlkRmFpbExvYWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY3MTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JSZXNvdXJjZUFnZW50OjpkaWRGYWlsTG9hZGluZyk6CisK IDIwMTEtMDgtMzAgIEFkZW1hciBkZSBTb3V6YSBSZWlzIEpyLiAgPGFkZW1hci5yZWlzQG9wZW5i b3NzYS5vcmc+CiAKICAgICAgICAgW1F0XSBEbyBub3QgdW5jb25kaXRpb25hbGx5IHVzZSBwa2ct Y29uZmlnIGluIC5wcm8gZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcAppbmRleCBjNzZkMDU0YTRkYjcwODczZDUyOTk5OTUx MjUxOTI3YjU0NmQ5MWVhLi5mNDU5NzUwZTgzZWRlMWJkNDc0ZDYyNjY2NTIwNjkyNTViNDcyYTA4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VB Z2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNl QWdlbnQuY3BwCkBAIC0yOTIsOCArMjkyLDEyIEBAIHZvaWQgSW5zcGVjdG9yUmVzb3VyY2VBZ2Vu dDo6ZGlkRmluaXNoTG9hZGluZyh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIERvY3VtZW50CiB2 b2lkIEluc3BlY3RvclJlc291cmNlQWdlbnQ6OmRpZEZhaWxMb2FkaW5nKHVuc2lnbmVkIGxvbmcg aWRlbnRpZmllciwgRG9jdW1lbnRMb2FkZXIqIGxvYWRlciwgY29uc3QgUmVzb3VyY2VFcnJvciYg ZXJyb3IpCiB7CiAgICAgU3RyaW5nIHJlcXVlc3RJZCA9IElkZW50aWZpZXJzRmFjdG9yeTo6cmVx dWVzdElkKGlkZW50aWZpZXIpOwotICAgIGlmIChtX3Jlc291cmNlc0RhdGEtPnJlc291cmNlVHlw ZShyZXF1ZXN0SWQpID09IEluc3BlY3RvclBhZ2VBZ2VudDo6RG9jdW1lbnRSZXNvdXJjZSkKLSAg ICAgICAgbV9yZXNvdXJjZXNEYXRhLT5hZGRSZXNvdXJjZVNoYXJlZEJ1ZmZlcihyZXF1ZXN0SWQs IGxvYWRlci0+ZnJhbWVMb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKS0+bWFpblJlc291cmNlRGF0 YSgpLCBsb2FkZXItPmZyYW1lKCktPmRvY3VtZW50KCktPmlucHV0RW5jb2RpbmcoKSk7CisKKyAg ICBpZiAobV9yZXNvdXJjZXNEYXRhLT5yZXNvdXJjZVR5cGUocmVxdWVzdElkKSA9PSBJbnNwZWN0 b3JQYWdlQWdlbnQ6OkRvY3VtZW50UmVzb3VyY2UpIHsKKyAgICAgICAgRnJhbWUqIGZyYW1lID0g bG9hZGVyID8gbG9hZGVyLT5mcmFtZSgpIDogMDsKKyAgICAgICAgaWYgKGZyYW1lICYmIGZyYW1l LT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKSAmJiBmcmFtZS0+ZG9jdW1lbnQoKSkKKyAgICAg ICAgICAgIG1fcmVzb3VyY2VzRGF0YS0+YWRkUmVzb3VyY2VTaGFyZWRCdWZmZXIocmVxdWVzdElk LCBmcmFtZS0+bG9hZGVyKCktPmRvY3VtZW50TG9hZGVyKCktPm1haW5SZXNvdXJjZURhdGEoKSwg ZnJhbWUtPmRvY3VtZW50KCktPmlucHV0RW5jb2RpbmcoKSk7CisgICAgfQogCiAgICAgbV9mcm9u dGVuZC0+bG9hZGluZ0ZhaWxlZChyZXF1ZXN0SWQsIGN1cnJlbnRUaW1lKCksIGVycm9yLmxvY2Fs aXplZERlc2NyaXB0aW9uKCksIGVycm9yLmlzQ2FuY2VsbGF0aW9uKCkpOwogfQo=