67183 2011-08-30 01:54:34 -0700 lastChangeWasUserEdit continues to return true when innerText or textContent is modified 2011-08-30 04:22:37 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa adele ap darin dglazkov morrita sam tkent webkit.review.bot oldest_to_newest 458773 0 rniwa 2011-08-30 01:54:34 -0700 Two test cases in fast/forms/textfield-lastchange-was-useredit.html fail because lastChangeWasUserEdit isn't set to false when innerText or textContent of textarea element is modified. We should fix this. 458782 1 105599 rniwa 2011-08-30 02:01:20 -0700 Created attachment 105599 Patch 458819 2 105599 tkent 2011-08-30 03:21:09 -0700 Comment on attachment 105599 Patch ok 458833 3 105599 webkit.review.bot 2011-08-30 04:22:31 -0700 Comment on attachment 105599 Patch Clearing flags on attachment: 105599 Committed r94068: <http://trac.webkit.org/changeset/94068> 458834 4 webkit.review.bot 2011-08-30 04:22:37 -0700 All reviewed patches have been landed. Closing bug. 105599 2011-08-30 02:01:20 -0700 2011-08-30 04:22:31 -0700 Patch bug-67183-20110830020118.patch text/plain 7114 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MDU5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDgtMzAgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgbGFzdENoYW5nZVdhc1VzZXJFZGl0 IGNvbnRpbnVlcyB0byByZXR1cm4gdHJ1ZSB3aGVuIGlubmVyVGV4dCBvciB0ZXh0Q29udGVudCBp cyBtb2RpZmllZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjcxODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlZCB0aGUgYnVnIGJ5IGNhbGxpbmcgc2V0TGFzdENoYW5nZVdhc05vdFVzZXJFZGl0IGlu IEhUTUxUZXh0QXJlYUVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZC4KKworICAgICAgICBBbHNvIGdv dCByaWQgb2YgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnN1YnRyZWVIYXNDaGFuZ2VkIGJl Y2F1c2UgaXQgd2FzIGEgbmVlZGxlc3MgaW5kaXJlY3Rpb24uCisKKyAgICAgICAgKiBodG1sL0hU TUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6 c3VidHJlZUhhc0NoYW5nZWQpOiBObyBsb25nZXIgY2FsbHMgSFRNTFRleHRGb3JtQ29udHJvbEVs ZW1lbnQ6OnN1YnRyZWVIYXNDaGFuZ2VkLgorICAgICAgICAqIGh0bWwvSFRNTFRleHRBcmVhRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50OjpjaGlsZHJl bkNoYW5nZWQpOiBDYWxscyBzZXRMYXN0Q2hhbmdlV2FzTm90VXNlckVkaXQuCisgICAgICAgIChX ZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50OjpzdWJ0cmVlSGFzQ2hhbmdlZCk6IE5vIGxvbmdl ciBjYWxscyBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6c3VidHJlZUhhc0NoYW5nZWQuCisg ICAgICAgICogaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6 IE1lcmdlZCBzdWJ0cmVlSGFzQ2hhbmdlZC4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0Rm9y bUNvbnRyb2xFbGVtZW50OjpzZXRJbm5lclRleHRWYWx1ZSk6IE5vIGxvbmdlciBzZXQgbV9sYXN0 Q2hhbmdlV2FzVXNlckVkaXQgdG8gZmFsc2UKKyAgICAgICAgc2luY2UgdGhpcyBpcyBub3cgZG9u ZSB3aGVuIHJlbmRlcmVycyBhcmUgc2V0IGRpcnR5LgorICAgICAgICAqIGh0bWwvSFRNTFRleHRG b3JtQ29udHJvbEVsZW1lbnQuaDogTWFkZSBzdWJ0cmVlSGFzQ2hhbmdlZCBhIHB1cmUgdmlydHVh bCBmdW5jdGlvbi4KKwogMjAxMS0wOC0yOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBUb3VjaCBJbnRlcm5hbHMuY3BwIGluIGFuIGF0dGVtcHQgdG8gZml4IEdU SysgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJ KHJldmlzaW9uIDk0MDU5KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjE2LDggKzYxNiw2IEBAIHZvaWQgSFRNTElucHV0RWxl bWVudDo6c3VidHJlZUhhc0NoYW5nZWQKICAgICBBU1NFUlQocmVuZGVyZXIoKSk7CiAgICAgUmVu ZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lKiByZW5kZXJUZXh0Q29udHJvbCA9IHRvUmVuZGVyVGV4 dENvbnRyb2xTaW5nbGVMaW5lKHJlbmRlcmVyKCkpOwogCi0gICAgSFRNTFRleHRGb3JtQ29udHJv bEVsZW1lbnQ6OnN1YnRyZWVIYXNDaGFuZ2VkKCk7Ci0KICAgICBib29sIHdhc0NoYW5nZWQgPSB3 YXNDaGFuZ2VkU2luY2VMYXN0Rm9ybUNvbnRyb2xDaGFuZ2VFdmVudCgpOwogICAgIHNldENoYW5n ZWRTaW5jZUxhc3RGb3JtQ29udHJvbENoYW5nZUV2ZW50KHRydWUpOwogCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAJKHJldmlzaW9uIDk0MDU5KQor KysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcAkod29ya2luZyBj b3B5KQpAQCAtOTgsNiArOTgsNyBAQCB2b2lkIEhUTUxUZXh0QXJlYUVsZW1lbnQ6OnJlc3RvcmVG b3JtQ29uCiAKIHZvaWQgSFRNTFRleHRBcmVhRWxlbWVudDo6Y2hpbGRyZW5DaGFuZ2VkKGJvb2wg Y2hhbmdlZEJ5UGFyc2VyLCBOb2RlKiBiZWZvcmVDaGFuZ2UsIE5vZGUqIGFmdGVyQ2hhbmdlLCBp bnQgY2hpbGRDb3VudERlbHRhKQogeworICAgIHNldExhc3RDaGFuZ2VXYXNOb3RVc2VyRWRpdCgp OwogICAgIGlmICghbV9pc0RpcnR5KQogICAgICAgICBzZXROb25EaXJ0eVZhbHVlKGRlZmF1bHRW YWx1ZSgpKTsKICAgICBIVE1MRWxlbWVudDo6Y2hpbGRyZW5DaGFuZ2VkKGNoYW5nZWRCeVBhcnNl ciwgYmVmb3JlQ2hhbmdlLCBhZnRlckNoYW5nZSwgY2hpbGRDb3VudERlbHRhKTsKQEAgLTIzMCw4 ICsyMzEsNiBAQCB2b2lkIEhUTUxUZXh0QXJlYUVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhCiAKIHZv aWQgSFRNTFRleHRBcmVhRWxlbWVudDo6c3VidHJlZUhhc0NoYW5nZWQoKQogewotICAgIEhUTUxU ZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpzdWJ0cmVlSGFzQ2hhbmdlZCgpOwotCiAgICAgc2V0Q2hh bmdlZFNpbmNlTGFzdEZvcm1Db250cm9sQ2hhbmdlRXZlbnQodHJ1ZSk7CiAgICAgc2V0Rm9ybUNv bnRyb2xWYWx1ZU1hdGNoZXNSZW5kZXJlcihmYWxzZSk7CiAgICAgc2V0TmVlZHNWYWxpZGl0eUNo ZWNrKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVt ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNv bnRyb2xFbGVtZW50LmNwcAkocmV2aXNpb24gOTQwNTkpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODksNiAr ODksNyBAQCB2b2lkIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpkaXNwYXRjCiB2b2lkIEhU TUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVu dCkKIHsKICAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkud2Via2l0RWRpdGFi bGVDb250ZW50Q2hhbmdlZEV2ZW50ICYmIHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+aXNUZXh0 Q29udHJvbCgpKSB7CisgICAgICAgIG1fbGFzdENoYW5nZVdhc1VzZXJFZGl0ID0gdHJ1ZTsKICAg ICAgICAgc3VidHJlZUhhc0NoYW5nZWQoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTEw MywxMSArMTA0LDYgQEAgdm9pZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6Zm9yd2FyZAog ICAgIGlubmVyVGV4dEVsZW1lbnQoKS0+ZGVmYXVsdEV2ZW50SGFuZGxlcihldmVudCk7CiB9CiAK LXZvaWQgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnN1YnRyZWVIYXNDaGFuZ2VkKCkKLXsK LSAgICBtX2xhc3RDaGFuZ2VXYXNVc2VyRWRpdCA9IHRydWU7Ci19Ci0KIFN0cmluZyBIVE1MVGV4 dEZvcm1Db250cm9sRWxlbWVudDo6c3RyaXBwZWRQbGFjZWhvbGRlcigpIGNvbnN0CiB7CiAgICAg Ly8gQWNjb3JkaW5nIHRvIHRoZSBIVE1MNSBzcGVjaWZpY2F0aW9uLCB3ZSBuZWVkIHRvIHJlbW92 ZSBDUiBhbmQgTEYgZnJvbQpAQCAtNDc1LDkgKzQ3MSw2IEBAIHZvaWQgSFRNTFRleHRGb3JtQ29u dHJvbEVsZW1lbnQ6OnNldElubmUKICAgICAgICAgICAgIGlubmVyVGV4dEVsZW1lbnQoKS0+YXBw ZW5kQ2hpbGQoSFRNTEJSRWxlbWVudDo6Y3JlYXRlKGRvY3VtZW50KCkpLCBlYyk7CiAgICAgICAg ICAgICBBU1NFUlQoIWVjKTsKICAgICAgICAgfQotCi0gICAgICAgIC8vIFdlIHNldCBtX2xhc3RD aGFuZ2VXYXNVc2VyRWRpdCB0byBmYWxzZSBzaW5jZSB0aGlzIGNoYW5nZSB3YXMgbm90IGV4cGxp Y2l0bHkgbWFkZSBieSB0aGUgdXNlciAoc2F5LCB2aWEgdHlwaW5nIG9uIHRoZSBrZXlib2FyZCks IHNlZSA8cmRhcjovL3Byb2JsZW0vNTM1OTkyMT4uCi0gICAgICAgIG1fbGFzdENoYW5nZVdhc1Vz ZXJFZGl0ID0gZmFsc2U7CiAgICAgfQogCiAgICAgc2V0Rm9ybUNvbnRyb2xWYWx1ZU1hdGNoZXNS ZW5kZXJlcih0cnVlKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3JtQ29u dHJvbEVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0 Rm9ybUNvbnRyb2xFbGVtZW50LmgJKHJldmlzaW9uIDk0MDU5KQorKysgU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC05Nyw3 ICs5Nyw3IEBAIHByb3RlY3RlZDoKICAgICBib29sIGhhc0NhY2hlZFNlbGVjdGlvbigpIGNvbnN0 IHsgcmV0dXJuIG1fY2FjaGVkU2VsZWN0aW9uU3RhcnQgPj0gMDsgfQogCiAgICAgdmlydHVhbCB2 b2lkIGRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqKTsKLSAgICB2aXJ0dWFsIHZvaWQgc3VidHJl ZUhhc0NoYW5nZWQoKTsKKyAgICB2aXJ0dWFsIHZvaWQgc3VidHJlZUhhc0NoYW5nZWQoKSA9IDA7 CiAKICAgICB2b2lkIHNldExhc3RDaGFuZ2VXYXNOb3RVc2VyRWRpdCgpIHsgbV9sYXN0Q2hhbmdl V2FzVXNlckVkaXQgPSBmYWxzZTsgfQogcHJpdmF0ZToKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MDU5 KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDgtMzAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgbGFzdENoYW5nZVdhc1VzZXJFZGl0IGNvbnRpbnVlcyB0byByZXR1cm4gdHJ1ZSB3aGVuIGlu bmVyVGV4dCBvciB0ZXh0Q29udGVudCBpcyBtb2RpZmllZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcxODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUd28gdGVzdCBjYXNlcyBub3cgcGFzcy4KKworICAg ICAgICAqIGZhc3QvZm9ybXMvdGV4dGZpZWxkLWxhc3RjaGFuZ2Utd2FzLXVzZXJlZGl0LWV4cGVj dGVkLnR4dDoKKwogMjAxMS0wOC0zMCAgVGFrYXNoaSBUb3lvc2hpbWEgIDx0b3lvc2hpbUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW1dlYlNvY2tldF0gUHJldmVudCB1bm5lY2Vzc2FyeSBweXdl YnNvY2tldCB3YXJuaW5ncyBvbiBsYXlvdXQgdGVzdHMuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL3RleHRmaWVsZC1sYXN0Y2hhbmdlLXdhcy11c2VyZWRpdC1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0ZmllbGQtbGFzdGNoYW5nZS13 YXMtdXNlcmVkaXQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5NDA1OSkKKysrIExheW91dFRlc3Rz L2Zhc3QvZm9ybXMvdGV4dGZpZWxkLWxhc3RjaGFuZ2Utd2FzLXVzZXJlZGl0LWV4cGVjdGVkLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtMTksOSArMTksOSBAQCBQQVNTIHRleHRGaWVsZC52YWx1ZSA9 ICJXZWJLaXQiOyBpbnRlcm5hCiBQQVNTIHRleHRGaWVsZC5zdHlsZS5kaXNwbGF5ID0gbnVsbDsg aW50ZXJuYWxzLndhc0xhc3RDaGFuZ2VVc2VyRWRpdCh0ZXh0RmllbGQpIGlzIGZhbHNlCiBQQVNT IGRvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiLCBmYWxzZSwgbnVsbCk7IGludGVybmFs cy53YXNMYXN0Q2hhbmdlVXNlckVkaXQodGV4dEZpZWxkKSBpcyBmYWxzZQogUEFTUyBkb2N1bWVu dC5leGVjQ29tbWFuZCgiRGVsZXRlIiwgZmFsc2UsIG51bGwpOyBpbnRlcm5hbHMud2FzTGFzdENo YW5nZVVzZXJFZGl0KHRleHRGaWVsZCkgaXMgdHJ1ZQotRkFJTCB0ZXh0RmllbGQudGV4dENvbnRl bnQgPSAiaGVsbG9cbndvcmxkIjsgaW50ZXJuYWxzLndhc0xhc3RDaGFuZ2VVc2VyRWRpdCh0ZXh0 RmllbGQpIHNob3VsZCBiZSBmYWxzZS4gV2FzIHRydWUuCitQQVNTIHRleHRGaWVsZC50ZXh0Q29u dGVudCA9ICJoZWxsb1xud29ybGQiOyBpbnRlcm5hbHMud2FzTGFzdENoYW5nZVVzZXJFZGl0KHRl eHRGaWVsZCkgaXMgZmFsc2UKIFBBU1MgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydFRleHQi LCBmYWxzZSwgIlxuV2ViS2l0IHJvY2tzIik7IGludGVybmFscy53YXNMYXN0Q2hhbmdlVXNlckVk aXQodGV4dEZpZWxkKSBpcyB0cnVlCi1GQUlMIHRleHRGaWVsZC5pbm5lclRleHQgPSAiIFdlYktp dCAiOyBpbnRlcm5hbHMud2FzTGFzdENoYW5nZVVzZXJFZGl0KHRleHRGaWVsZCkgc2hvdWxkIGJl IGZhbHNlLiBXYXMgdHJ1ZS4KK1BBU1MgdGV4dEZpZWxkLmlubmVyVGV4dCA9ICIgV2ViS2l0ICI7 IGludGVybmFscy53YXNMYXN0Q2hhbmdlVXNlckVkaXQodGV4dEZpZWxkKSBpcyBmYWxzZQogUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCg==