67169 2011-08-29 17:01:45 -0700 [chromium] DumpRenderTree should be explicit about its dependency on GoogleURL 2011-08-30 12:25:21 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fishd fishd webkit.review.bot oldest_to_newest 458575 0 fishd 2011-08-29 17:01:45 -0700 [chromium] DumpRenderTree should be explicit about its dependency on GoogleURL DumpRenderTree uses GoogleURL code directly, and it should be explicit about that instead of picking up this dependency transitively, which only works for the static build. This is needed to support the "component" build of DumpRenderTree, in which the various Chromium dependencies are built as separate DLLs. 458577 1 105548 fishd 2011-08-29 17:03:11 -0700 Created attachment 105548 v1 patch 458770 2 105548 webkit.review.bot 2011-08-30 01:44:47 -0700 Comment on attachment 105548 v1 patch Rejecting attachment 105548 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: Updating working directory Processing patch 105548 from bug 67169. ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9558538 459085 3 fishd 2011-08-30 12:25:21 -0700 Landed as http://trac.webkit.org/changeset/94096 with fixed up reviewer line. 105548 2011-08-29 17:03:11 -0700 2011-08-30 01:44:47 -0700 v1 patch drt_1.txt text/plain 1637 fishd SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5NDAzMykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDgtMjkgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbY2hyb21pdW1dIER1bXBSZW5kZXJUcmVlIHNob3VsZCBiZSBleHBsaWNpdCBhYm91dCBp dHMgZGVwZW5kZW5jeSBvbgorICAgICAgICBHb29nbGVVUkwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3MTY5CisKKyAgICAgICAgRHVtcFJlbmRlclRy ZWUgdXNlcyBHb29nbGVVUkwgY29kZSBkaXJlY3RseSwgYW5kIGl0IHNob3VsZCBiZSBleHBsaWNp dAorICAgICAgICBhYm91dCB0aGF0IGluc3RlYWQgb2YgcGlja2luZyB1cCB0aGlzIGRlcGVuZGVu Y3kgdHJhbnNpdGl2ZWx5LCB3aGljaAorICAgICAgICBvbmx5IHdvcmtzIGZvciB0aGUgc3RhdGlj IGJ1aWxkLgorCisgICAgICAgIFRoaXMgaXMgbmVlZGVkIHRvIHN1cHBvcnQgdGhlICJjb21wb25l bnQiIGJ1aWxkIG9mIER1bXBSZW5kZXJUcmVlLCBpbgorICAgICAgICB3aGljaCB0aGUgdmFyaW91 cyBDaHJvbWl1bSBkZXBlbmRlbmNpZXMgYXJlIGJ1aWx0IGFzIHNlcGFyYXRlIERMTHMuCisKKyAg ICAgICAgKiBXZWJLaXQuZ3lwOgorCiAyMDExLTA4LTI5ICBHcmVnIEJpbGxvY2sgIDxnYmlsbG9j a0Bnb29nbGUuY29tPgogCiAgICAgICAgIFtDaHJvbWl1bV0gQWRkIGFiaWxpdHkgdG8gZG8gc3Rh dGljIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSBkZXNlcmlhbGl6YXRpb24KSW5kZXg6IFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2No cm9taXVtL1dlYktpdC5neXAJKHJldmlzaW9uIDk0MDMzKQorKysgU291cmNlL1dlYktpdC9jaHJv bWl1bS9XZWJLaXQuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC05ODYsNiArOTg2LDcgQEAKICAgICAg ICAgICAgICAgICAnY29weV9UZXN0TmV0c2NhcGVQbHVnSW4nLAogICAgICAgICAgICAgICAgICd3 ZWJraXQnLAogICAgICAgICAgICAgICAgICcuLi8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0 Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwOnd0Zl9jb25maWcnLAorICAgICAgICAgICAgICAg ICc8KGNocm9taXVtX3NyY19kaXIpL2J1aWxkL3RlbXBfZ3lwL2dvb2dsZXVybC5neXA6Z29vZ2xl dXJsJywKICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9p Y3UvaWN1Lmd5cDppY3V1YycsCiAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikv dGhpcmRfcGFydHkvbWVzYS9tZXNhLmd5cDpvc21lc2EnLAogICAgICAgICAgICAgICAgICc8KGNo cm9taXVtX3NyY19kaXIpL3Y4L3Rvb2xzL2d5cC92OC5neXA6djgnLAo=