67168 2011-08-29 16:55:26 -0700 Remove webcore_bindings (including DerivedSources##.cpp) from the critical path 2011-08-31 14:12:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67291 1 tony tony abarth apavlov dglazkov webkit.review.bot oldest_to_newest 458571 0 tony 2011-08-29 16:55:26 -0700 Remove webcore_bindings (including DerivedSources##.cpp) from the critical path 458574 1 105547 tony 2011-08-29 17:01:43 -0700 Created attachment 105547 Patch 458962 2 tony 2011-08-30 09:34:36 -0700 Committed r94082: <http://trac.webkit.org/changeset/94082> 459631 3 apavlov 2011-08-31 07:54:19 -0700 This change breaks trunk Chromium Mac builders on a WebKit roll (strangely, it does not affect the canaries). I attempted a fix but it was not enough. I guess all the source-generating dependencies should be moved from webcore_bindings into webcore_remaining (like my attempt you can see at http://trac.webkit.org/changeset/94176/trunk/Source/WebCore/WebCore.gyp/WebCore.gyp). The second time, it seems, the "injected_script_source"-generated files were missing. Unfortunately, I could not afford another cycle to leave the Chromium trunk more than 1 day and 100+ revisions of WebKit behind, so I rolled out this change. 459733 4 105793 tony 2011-08-31 10:53:48 -0700 Created attachment 105793 Patch 459735 5 tony 2011-08-31 10:55:47 -0700 Take 2 of the patch: I added debugger_script_source, injected_script_source, and inspector_protocol_sources as dependencies of webcore_prerequisites because they also generate files that we try to compile. I manually verified on a mac that a clobber build without this change fails and a clobber build with this change succeeds. 459912 6 105793 webkit.review.bot 2011-08-31 14:11:53 -0700 Comment on attachment 105793 Patch Clearing flags on attachment: 105793 Committed r94232: <http://trac.webkit.org/changeset/94232> 459913 7 webkit.review.bot 2011-08-31 14:12:00 -0700 All reviewed patches have been landed. Closing bug. 105547 2011-08-29 17:01:43 -0700 2011-08-31 10:53:44 -0700 Patch bug-67168-20110829170041.patch text/plain 2745 tony U3VidmVyc2lvbiBSZXZpc2lvbjogOTQwMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YzhlODMxMDQ0ZWYzYjNk OThjOGRkZmZmZTE5M2I1MTc4OTBmNDc4Li5iYjFlMzQwNjY2MDc1MDllNWI3ZjBmODIzZWIwNjFk MTcxOGY1MzgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDgtMjkgIFRvbnkg Q2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgd2ViY29yZV9iaW5k aW5ncyAoaW5jbHVkaW5nIERlcml2ZWRTb3VyY2VzIyMuY3BwKSBmcm9tIHRoZSBjcml0aWNhbCBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzE2 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmNv cmVfYmluZGluZ3Nfc291cmNlcyBnZW5lcmF0ZXMgdmFyaW91cyBmaWxlcyAoZS5nLiwgQ1NTUHJv cGVydHlOYW1lcywKKyAgICAgICAgRGVyaXZlZFNvdXJjZXMsIEhUTUxOYW1lcywgZXRjKS4gIHdl YmNvcmVfYmluZGluZ3MgZGVwZW5kcyBvbiB3ZWJjb3JlX2JpbmRpbmdzX3NvdXJjZXMKKyAgICAg ICAgYW5kIGNvbXBpbGVzIHRoZXNlIGZpbGVzLiAgUHJldmlvdXNseSwgdGhlIG90aGVyIHdlYmNv cmUgbGlicyAod2ViY29yZV9zdmcsCisgICAgICAgIHdlYmNvcmVfaHRtbCwgd2ViY29yZV9yZW1h aW5pbmcsIGV0YykgZGVwZW5kZWQgb24gd2ViY29yZV9iaW5kaW5ncy4gIFRoaXMgY2hhbmdlcyB0 aGUKKyAgICAgICAgZGVwZW5kZW5jeSBvbiB3ZWJvY3JlX2JpbmRpbmdzX3NvdXJjZXMgc28gdGhl IGJ1aWxkIGNhbiBwYXJhbGxlbGl6ZSB0aGUgY29tcGlsZSBvZgorICAgICAgICB3ZWJjb3JlX2Jp bmRpbmdzIGFuZCB0aGUgb3RoZXIgd2ViY29yZV8qIGxpYnMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBqdXN0IGNoYW5naW5nIHRoZSBidWlsZCBkZXBlbmRlbmNpZXMuICBNYW51YWxseSBjb3B5 IG92ZXIgdGhlCisgICAgICAgIGluY2x1ZGUgZGlycyB0aGF0IHdlIHVzZWQgdG8gZ2V0IGZyb20g d2ViY29yZV9iaW5kaW5ncycgZGlyZWN0X2RlcGVuZGVudF9zZXR0aW5ncy4KKworICAgICAgICAq IFdlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwOgorCiAyMDExLTA4LTI5ICBKb2huIEJhdW1hbiAgPGpi YXVtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNwZWVkIHVwIHRleEltYWdlIGZyb20gQkdS QQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9T b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCAxYTRjMDY5NDFjMmJm MDQ4MTQ2YTM2OGJkZDgxYTYxY2I4YTI1MGFiLi4xNjI0MGRjMzA0OTFkMjdmYmQ5NTgzZTk5YjE5 MGQwNjcxMWJkZDZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJD b3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAt MTA0NSw3ICsxMDQ1LDcgQEAKICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJjb3JlX3ByZXJlcXVp c2l0ZXMnLAogICAgICAgJ3R5cGUnOiAnbm9uZScsCiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwot ICAgICAgICAnd2ViY29yZV9iaW5kaW5ncycsCisgICAgICAgICd3ZWJjb3JlX2JpbmRpbmdzX3Nv dXJjZXMnLAogICAgICAgICAnLi4vLi4vVGhpcmRQYXJ0eS9nbHUvZ2x1Lmd5cDpsaWJ0ZXNzJywK ICAgICAgICAgJy4uLy4uL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2Ny aXB0Q29yZS5neXA6eWFycicsCiAgICAgICAgICcuLi8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2Ny aXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwOnd0ZicsCkBAIC0xMDYzLDcgKzEwNjMsNiBA QAogICAgICAgICAnPChsaWJqcGVnX2d5cF9wYXRoKTpsaWJqcGVnJywKICAgICAgIF0sCiAgICAg ICAnZXhwb3J0X2RlcGVuZGVudF9zZXR0aW5ncyc6IFsKLSAgICAgICAgJ3dlYmNvcmVfYmluZGlu Z3MnLAogICAgICAgICAnLi4vLi4vSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0ph dmFTY3JpcHRDb3JlLmd5cDp5YXJyJywKICAgICAgICAgJy4uLy4uL0phdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXA6d3RmJywKICAgICAgICAgJzwoY2hy b21pdW1fc3JjX2RpcikvYnVpbGQvdGVtcF9neXAvZ29vZ2xldXJsLmd5cDpnb29nbGV1cmwnLApA QCAtMTA5MSw2ICsxMDkwLDggQEAKICAgICAgICAgICAnPEAod2ViY29yZV9pbmNsdWRlX2RpcnMp JywKICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9ncHUnLAogICAgICAgICAgICc8KGNo cm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2FuZ2xlL2luY2x1ZGUvR0xTTEFORycsCisgICAg ICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdCcsCisgICAgICAgICAgJzwo U0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC9iaW5kaW5ncycsCiAgICAgICAgIF0sCiAg ICAgICAgICdtYWNfZnJhbWV3b3JrX2RpcnMnOiBbCiAgICAgICAgICAgJyQoU0RLUk9PVCkvU3lz dGVtL0xpYnJhcnkvRnJhbWV3b3Jrcy9BcHBsaWNhdGlvblNlcnZpY2VzLmZyYW1ld29yay9GcmFt ZXdvcmtzJywK 105793 2011-08-31 10:53:48 -0700 2011-08-31 14:11:53 -0700 Patch bug-67168-20110831105347.patch text/plain 2984 tony U3VidmVyc2lvbiBSZXZpc2lvbjogOTQxOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNzJmMDM4MDI2MjM1ZTYw NWRjNjk0YmE5ZDdhNzlmYzU2MWVlM2YxLi41MjYyOTkyYTI5NjQ3NmQ2MzE1NTJjYzU0M2FlNGY0 ZWU3NmYxNjQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDgtMzEgIFRvbnkg Q2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgd2ViY29yZV9iaW5k aW5ncyAoaW5jbHVkaW5nIERlcml2ZWRTb3VyY2VzIyMuY3BwKSBmcm9tIHRoZSBjcml0aWNhbCBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzE2 OAorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCisKKyAgICAgICAgd2ViY29yZV9i aW5kaW5nc19zb3VyY2VzLCBkZWJ1Z2dlcl9zY3JpcHRfc291cmNlLCBpbmplY3RlZF9zY3JpcHRf c291cmNlLCBhbmQKKyAgICAgICAgaW5zcGVjdG9yX3Byb3RvY29sX3NvdXJjZXMgZ2VuZXJhdGVz IHZhcmlvdXMgZmlsZXMgKGUuZy4sIENTU1Byb3BlcnR5TmFtZXMsCisgICAgICAgIERlcml2ZWRT b3VyY2VzLCBIVE1MTmFtZXMsIGV0YykuICB3ZWJjb3JlX2JpbmRpbmdzIGRlcGVuZHMgb24gKl9z b3VyY2VzIGFuZCBjb21waWxlcworICAgICAgICB0aGVzZSBmaWxlcy4gIFByZXZpb3VzbHksIHRo ZSBvdGhlciB3ZWJjb3JlIGxpYnMgKHdlYmNvcmVfc3ZnLCB3ZWJjb3JlX2h0bWwsCisgICAgICAg IHdlYmNvcmVfcmVtYWluaW5nLCBldGMpIGRlcGVuZGVkIG9uIHdlYmNvcmVfYmluZGluZ3MuICBU aGlzIG1vdmVzIHRoZSAqX3NvdXJjZXMKKyAgICAgICAgZGVwZW5kZW5jaWVzIGZyb20gd2ViY29y ZV9iaW5kaW5ncyB0byB0aGUgb3RoZXIgd2ViY29yZSBsaWJzIHNvIHRoZSBidWlsZCBjYW4KKyAg ICAgICAgcGFyYWxsZWxpemUgdGhlIGNvbXBpbGUgb2Ygd2ViY29yZV9iaW5kaW5ncyBhbmQgdGhl IG90aGVyIHdlYmNvcmVfKiBsaWJzLgorCisgICAgICAgIEFsc28gY29weSBvdmVyIHRoZSBpbmNs dWRlIGRpcnMgdGhhdCB3ZSB1c2VkIHRvIGdldCBmcm9tIHdlYmNvcmVfYmluZGluZ3MnCisgICAg ICAgIGRpcmVjdF9kZXBlbmRlbnRfc2V0dGluZ3MuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBq dXN0IGNoYW5naW5nIHRoZSBidWlsZCBkZXBlbmRlbmNpZXMuCisKKyAgICAgICAgKiBXZWJDb3Jl Lmd5cC9XZWJDb3JlLmd5cDoKKwogMjAxMS0wOC0zMSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJs c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCBIVE1MTWVkaWFFbGVtZW50IGJlaGF2 aW9yIHJlc3RyaWN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAv V2ViQ29yZS5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRl eCAwNGU1OGM0NzkwMmY1NDA3YjdlNmQyYThhNGZkYmQwM2Y3ODNjNjJjLi44YWJkYjhkMzFiYTk5 NTA0MTk4ZGRlZjczNDUzYjBhMmRjNzlkNjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9X ZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9X ZWJDb3JlLmd5cApAQCAtMTA0NSw3ICsxMDQ1LDEwIEBACiAgICAgICAndGFyZ2V0X25hbWUnOiAn d2ViY29yZV9wcmVyZXF1aXNpdGVzJywKICAgICAgICd0eXBlJzogJ25vbmUnLAogICAgICAgJ2Rl cGVuZGVuY2llcyc6IFsKLSAgICAgICAgJ3dlYmNvcmVfYmluZGluZ3MnLAorICAgICAgICAnZGVi dWdnZXJfc2NyaXB0X3NvdXJjZScsCisgICAgICAgICdpbmplY3RlZF9zY3JpcHRfc291cmNlJywK KyAgICAgICAgJ2luc3BlY3Rvcl9wcm90b2NvbF9zb3VyY2VzJywKKyAgICAgICAgJ3dlYmNvcmVf YmluZGluZ3Nfc291cmNlcycsCiAgICAgICAgICcuLi8uLi9UaGlyZFBhcnR5L2dsdS9nbHUuZ3lw OmxpYnRlc3MnLAogICAgICAgICAnLi4vLi4vSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUu Z3lwL0phdmFTY3JpcHRDb3JlLmd5cDp5YXJyJywKICAgICAgICAgJy4uLy4uL0phdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXA6d3RmJywKQEAgLTEwNjMs NyArMTA2Niw2IEBACiAgICAgICAgICc8KGxpYmpwZWdfZ3lwX3BhdGgpOmxpYmpwZWcnLAogICAg ICAgXSwKICAgICAgICdleHBvcnRfZGVwZW5kZW50X3NldHRpbmdzJzogWwotICAgICAgICAnd2Vi Y29yZV9iaW5kaW5ncycsCiAgICAgICAgICcuLi8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0 Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwOnlhcnInLAogICAgICAgICAnLi4vLi4vSmF2YVNj cmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDp3dGYnLAogICAg ICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9idWlsZC90ZW1wX2d5cC9nb29nbGV1cmwuZ3lwOmdv b2dsZXVybCcsCkBAIC0xMDkxLDYgKzEwOTMsOCBAQAogICAgICAgICAgICc8QCh3ZWJjb3JlX2lu Y2x1ZGVfZGlycyknLAogICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL2dwdScsCiAgICAg ICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvYW5nbGUvaW5jbHVkZS9HTFNM QU5HJywKKyAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0JywKKyAg ICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L2JpbmRpbmdzJywKICAg ICAgICAgXSwKICAgICAgICAgJ21hY19mcmFtZXdvcmtfZGlycyc6IFsKICAgICAgICAgICAnJChT REtST09UKS9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtzL0FwcGxpY2F0aW9uU2VydmljZXMuZnJh bWV3b3JrL0ZyYW1ld29ya3MnLAo=