67159 2011-08-29 15:41:07 -0700 [Qt] QTouchWebView url property test missing 2011-08-29 16:47:40 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gopal.1.raghavan webkit-unassigned webkit.review.bot oldest_to_newest 458500 0 gopal.1.raghavan 2011-08-29 15:41:07 -0700 Need property test for url in QTouchWebView. Very similar to https://bugs.webkit.org/show_bug.cgi?id=67155 458504 1 105534 gopal.1.raghavan 2011-08-29 15:44:32 -0700 Created attachment 105534 url property test for TouchWebView Just realized we need a similar test as 67155 for QTouchWebView. 458505 2 gopal.1.raghavan 2011-08-29 15:45:12 -0700 ********* Start testing of tst_QTouchWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QTouchWebView::initTestCase() PASS : tst_QTouchWebView::accessPage() PASS : tst_QTouchWebView::navigationActionsStatusAtStartup() PASS : tst_QTouchWebView::cleanupTestCase() Totals: 4 passed, 0 failed, 0 skipped ********* Finished testing of tst_QTouchWebView ********* ********* Start testing of tst_QDesktopWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QDesktopWebView::initTestCase() PASS : tst_QDesktopWebView::navigationActionsStatusAtStartup() QWARN : tst_QDesktopWebView::stopActionEnabledAfterLoadStarted() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : tst_QDesktopWebView::stopActionEnabledAfterLoadStarted() PASS : tst_QDesktopWebView::cleanupTestCase() Totals: 4 passed, 0 failed, 0 skipped ********* Finished testing of tst_QDesktopWebView ********* ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : DesktopWebViewNavigationPolicyForUrl::initTestCase() QWARN : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() QObject::startTimer: timers cannot be started from another thread PASS : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::test_usePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase() PASS : DesktopWebViewProperties::initTestCase() PASS : DesktopWebViewProperties::test_title() PASS : DesktopWebViewProperties::cleanupTestCase() PASS : TouchWebViewProperties::initTestCase() QWARN : TouchWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewProperties::test_title() PASS : TouchWebViewProperties::test_url() PASS : TouchWebViewProperties::cleanupTestCase() Totals: 11 passed, 0 failed, 0 skipped ********* Finished testing of qmltests ********* ********************************************************************** ** TOTALS: 31 passed, 0 failed, 0 skipped ** ********************************************************************** 458507 3 105534 noam 2011-08-29 15:47:23 -0700 Comment on attachment 105534 url property test for TouchWebView LGTM 458565 4 105534 webkit.review.bot 2011-08-29 16:47:36 -0700 Comment on attachment 105534 url property test for TouchWebView Clearing flags on attachment: 105534 Committed r94033: <http://trac.webkit.org/changeset/94033> 458566 5 webkit.review.bot 2011-08-29 16:47:40 -0700 All reviewed patches have been landed. Closing bug. 105534 2011-08-29 15:44:32 -0700 2011-08-29 16:47:36 -0700 url property test for TouchWebView 67159.patch text/plain 1526 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MDIwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMjkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKworICAgICAgICBbUXRdIFFU b3VjaFdlYlZpZXcgdXJsIHByb3BlcnR5IHRlc3QgbWlzc2luZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcxNTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBxbWwgdGVzdCBjYXNlIHRvIGNoZWNr IHVybCBwcm9wZXJ0eSBvZiBRVG91Y2hXZWJWaWV3LiBTaW5jZSB1cmwgaXMgYSByZWFkb25seSBw cm9wZXJ0eSwgd2UgbWFrZSBzdXJlIHRoYXQgaXQncyBzZXQgYWZ0ZXIgbG9hZCgpIGlzIGNhbGxl ZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvVG91Y2hXZWJW aWV3L3RzdF9wcm9wZXJ0aWVzLnFtbDoKKwogMjAxMS0wOC0yOSAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjkzOTg3LCByOTM5OTIsIHI5Mzk5NSwgcjkzOTk4LCBhbmQKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvVG91Y2hXZWJWaWV3L3RzdF9wcm9w ZXJ0aWVzLnFtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3Rlc3RzL3FtbHRlc3RzL1RvdWNoV2ViVmlldy90c3RfcHJvcGVydGllcy5xbWwJKHJldmlzaW9u IDkzOTg4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9Ub3VjaFdlYlZpZXcvdHN0X3Byb3BlcnRpZXMucW1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMCw1 ICsyMCwxNCBAQCBUb3VjaFdlYlZpZXcgewogICAgICAgICAgICAgc3B5LndhaXQoKQogICAgICAg ICAgICAgY29tcGFyZSh3ZWJWaWV3LnBhZ2UudGl0bGUsICJUZXN0IHBhZ2UgMSIpCiAgICAgICAg IH0KKworICAgICAgICBmdW5jdGlvbiB0ZXN0X3VybCgpIHsKKyAgICAgICAgICAgIGNvbXBhcmUo c3B5LmNvdW50LCAxKQorICAgICAgICAgICAgdmFyIHRlc3RVcmwgPSBRdC5yZXNvbHZlZFVybCgi Li4vY29tbW9uL3Rlc3QxLmh0bWwiKQorICAgICAgICAgICAgd2ViVmlldy5wYWdlLmxvYWQodGVz dFVybCkKKyAgICAgICAgICAgIHNweS53YWl0KCkKKyAgICAgICAgICAgIGNvbXBhcmUod2ViVmll dy5wYWdlLnVybCwgdGVzdFVybCkKKyAgICAgICAgfQorCiAgICAgfQogfQo=